Commit graph

74 commits

Author SHA1 Message Date
Shane Hughes
003bd7527b Bug 1899757 - Allow targeting the trigger tab for feature callouts. a=RyanVM
Also add a global `browserIsSelected` context property for all triggers,
so you can entirely avoid showing a message if the triggering browser
was in the background. You can use the selector and the context property
together or separately.

Context targeting:
`browserIsSelected`

Background tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%`

Current tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%[visuallyselected]`

Child of tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab% .tab-icon-image`

Original Revision: https://phabricator.services.mozilla.com/D212494

Differential Revision: https://phabricator.services.mozilla.com/D213921
2024-06-17 21:10:29 +00:00
Shane Hughes
6295d1777c Bug 1893671 - Add Fx113 facebook container experiment message in CFRMessageProvider. r=omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D208941
2024-05-02 20:54:51 +00:00
Punam Dahiya
22cf8fcf66 Bug 1775847 - Fix intermittent milestone message and accessibility cfr test failure r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D208761
2024-04-26 16:38:10 +00:00
Barret Rennie
677b4036a4 Bug 1883673 - Remove majorRelease2022 Nimbus feature r=aminomancer,omc-reviewers,win-reviewers,gstoll,pbz,firefox-desktop-core-reviewers
This feature is no longer intended for experimentation and some of the things
it controls are no longer in product.

Differential Revision: https://phabricator.services.mozilla.com/D204514
2024-04-24 20:15:19 +00:00
gravyant
c7fdfabf96 Bug 1869065 - Re-visit some of the element property names used in moz-message-bar. r=hjones,reusable-components-reviewers,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D207897
2024-04-23 21:27:46 +00:00
Nipun Shukla
d043179aa7 Bug 1888263 - Disable Firefox launch on login for MSIX builds r=nrishel,settings-reviewers,mconley,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D207595
2024-04-23 14:08:52 +00:00
Iulian Moraru
7b76404e84 Backed out changeset 89b76affef99 (bug 1883673) for causing multiple bc failures. CLOSED TREE 2024-04-22 22:12:59 +03:00
Barret Rennie
ceaa247170 Bug 1883673 - Remove majorRelease2022 Nimbus feature r=aminomancer,omc-reviewers,win-reviewers,gstoll,pbz,firefox-desktop-core-reviewers
This feature is no longer intended for experimentation and some of the things
it controls are no longer in product.

Differential Revision: https://phabricator.services.mozilla.com/D204514
2024-04-22 17:57:31 +00:00
dschomburg
e63de59f5c Bug 1853818 - Remove toolkit/branding/accounts.ftl file r=flod,fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mconley,aminomancer,mak,sgalich,nsharpley,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D190612
2024-04-22 16:24:30 +00:00
Emily McMinn
86cbf9ecdd Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose
Differential Revision: https://phabricator.services.mozilla.com/D205344
2024-03-28 16:26:14 +00:00
Punam Dahiya
87c4dca929 Bug 1859302 - NimbusRolloutMessageProvider should be listed as a generated file r=omc-reviewers,aminomancer
Patch invokes `import-rollouts` script that import Nimbus Rollout messages into NimbusRolloutMessageProvider.sys.mjs when running test using ` ./mach npm run test --prefix browser/components/asrouter`

Differential Revision: https://phabricator.services.mozilla.com/D205777
2024-03-27 22:12:31 +00:00
Emily McMinn
079ff41016 Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201867
2024-03-21 22:05:28 +00:00
Mark Banner
23a339fc7c Bug 1885723 - Fix more jsm references in browser/. r=Gijs,credential-management-reviewers,omc-reviewers,aminomancer,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D204843
2024-03-19 22:08:29 +00:00
Mark Banner
1bb7ccda05 Bug 1881816 - Rename ActorConstants.sys.mjs to ActorConstants.mjs. r=amy,omc-reviewers,aminomancer
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203401
2024-03-19 17:01:38 +00:00
Mark Banner
f4ce4f5c95 Bug 1885041 - Expand disallowing JSM based imports via ESLint to everything except for devtools. r=arai,omc-reviewers,aminomancer,zombie
Differential Revision: https://phabricator.services.mozilla.com/D204441
2024-03-13 17:38:28 +00:00
Shane Hughes
d5888b2c7b Bug 1775847 - Fix Glean timeout in browser_asrouter_cfr.js. r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D202078
2024-03-07 19:03:28 +00:00
Dave Townsend
1fe4db4a69 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-03 09:09:08 +00:00
Punam Dahiya
ef18155aa8 Bug 1879638 - Update Old references to asrouter and aboutwelcome files r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D203330
2024-03-02 02:36:24 +00:00
Natalia Csoregi
96b1b25a39 Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
2024-03-01 18:25:05 +02:00
Dave Townsend
c7318b4cf2 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-01 15:20:17 +00:00
Iulian Moraru
97fd2dad96 Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
2024-03-01 12:58:03 +02:00
Dave Townsend
f4705b2208 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-01 10:10:08 +00:00
Shane Hughes
f197e62f41 Bug 1881106 - Move ModalOverlay.test.jsx to newtab directory. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D202255
2024-02-27 18:52:20 +00:00
Mark Banner
c1641790d9 Bug 1881817 - Move all asrouter/content-src/*.js files which are modules to use .mjs extensions. r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D202622
2024-02-24 10:00:59 +00:00
Nick Alexander
2814902b49 Bug 1868676 - Part 1: Allow snapshots of multiple contexts. r=barret,omc-reviewers,aminomancer
`ASRouterTargeting` does _not_ include the experiment details that
supply `activeExperiments`, `activeRollouts`, etc.  Those are combined
from additional contexts.  This patch makes it easy to do that
combination.

N.b.: the use of `Proxy` instances makes iteration tricky, so we avoid
it entirely.

Differential Revision: https://phabricator.services.mozilla.com/D200124
2024-02-14 21:31:19 +00:00
Shane Hughes
a53c204f88 Bug 1877995 - Move feature callout dismiss button so the tab order makes more sense. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D200714
2024-02-13 23:26:16 +00:00
Mike Conley
24da9bffd2 Bug 1878731 - Convert ASRouter to an ESM. r=emcminn,pip-reviewers,fxview-reviewers,omc-reviewers,sfoster,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D201138
2024-02-12 18:49:38 +00:00
Mike Conley
5ab28b68b9 Bug 1878731 - Convert ASRouterPreferences to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201134
2024-02-12 18:49:37 +00:00
Mike Conley
3e82da1fda Bug 1878731 - Convert ASRouterTargeting to an ESM. r=emcminn,application-update-reviewers,omc-reviewers,bytesized
Differential Revision: https://phabricator.services.mozilla.com/D201133
2024-02-12 18:49:37 +00:00
Mike Conley
78b1c85ec9 Bug 1878731 - Convert ASRouterTriggerListeners to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201129
2024-02-12 18:49:36 +00:00
Mike Conley
24defeb8da Bug 1878731 - Convert ASRouterDefaultConfig to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201128
2024-02-12 18:49:36 +00:00
Mike Conley
3a56bf9f14 Bug 1878731 - Convert ASRouterParentProcessMessageHandler to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201127
2024-02-12 18:49:36 +00:00
Mike Conley
3b42177c8a Bug 1878731 - Convert CFRPageActions to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201126
2024-02-12 18:49:35 +00:00
Mike Conley
7ede6945db Bug 1878731 - Convert OnboardingMessageProvider to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201125
2024-02-12 18:49:35 +00:00
Mike Conley
34e17ab7c2 Bug 1878731 - Convert ToolbarPanelHub to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201124
2024-02-12 18:49:34 +00:00
Mike Conley
3624c8f09d Bug 1878731 - Convert ToolbarBadgeHub to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201123
2024-02-12 18:49:34 +00:00
Mike Conley
6a92b4c33b Bug 1878281 - Stub out NEWTAB_MESSAGE_REQUEST handling for legacy privileged addons. r=mkaply,omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D201094
2024-02-09 21:29:46 +00:00
Mark Banner
9f0e2f03d2 Bug 1878556 - Remove unused asrouter/content-src/template-utils.js. r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200591
2024-02-07 08:55:33 +00:00
Mark Banner
8bf1bcba31 Bug 1878556 - Move addUtmParams.js to aboutwelcome and rename to .mjs. r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200590
2024-02-07 08:55:32 +00:00
Cristian Tuns
77f2a39423 Backed out 11 changesets (bug 1878554, bug 1878553, bug 1878556) for causing node failures in aboutwelcome CLOSED TREE
Backed out changeset 425f70fa7e5a (bug 1878556)
Backed out changeset 2ab3a28f5c04 (bug 1878556)
Backed out changeset fb2e02682c8c (bug 1878556)
Backed out changeset 2fc5e630568e (bug 1878554)
Backed out changeset 78839d5841b4 (bug 1878554)
Backed out changeset e0ab31d2de1b (bug 1878554)
Backed out changeset 4eb59e4ebafa (bug 1878554)
Backed out changeset ab1e077d3f84 (bug 1878554)
Backed out changeset ef999f293e3e (bug 1878553)
Backed out changeset cf49920cb1ad (bug 1878553)
Backed out changeset 95f0fce63726 (bug 1878553)
2024-02-07 01:26:39 -05:00
Mark Banner
08f5bfa51f Bug 1878556 - Remove unused asrouter/content-src/template-utils.js. r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200591
2024-02-06 22:32:55 +00:00
Mark Banner
c0760d5e24 Bug 1878556 - Move addUtmParams.js to aboutwelcome and rename to .mjs. r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200590
2024-02-06 22:32:54 +00:00
Mike Conley
c8b2bacff2 Bug 1877196 - Move FeatureCallout modules and styles to browser/components/asrouter. r=fxview-reviewers,omc-reviewers,sclements,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D200514
2024-02-05 22:03:16 +00:00
Mike Conley
c65fe995c1 Bug 1877196 - Move ActorConstants.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
We import the ActorConstants into the ASRouter unit-entry.js script because
ASRouterChild.sys.mjs loads ActorConstants.sys.mjs, and the ResourceUriPlugin
that does the rewriting for the Karma tests doesn't understand how to do
remapping outside of the newtab folder.

So instead of trying to hack that capability into ResourceUriPlugin, we
just import the ActorConstants into the Karma global scope.

Differential Revision: https://phabricator.services.mozilla.com/D200087
2024-02-05 22:03:15 +00:00
Mike Conley
b2be69f52d Bug 1877196 - Move browser_asrouter tests to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200086
2024-02-05 22:03:15 +00:00
Mike Conley
2e68c0b11a Bug 1877196 - Move InflightAssetsMessageProvider.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200085
2024-02-05 22:03:15 +00:00
Mike Conley
fb2ce4bd02 Bug 1877196 - Move MomentsPageHub.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200083
2024-02-05 22:03:14 +00:00
Mike Conley
88baec62ec Bug 1877196 - Move ToolbarPanelHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200082
2024-02-05 22:03:13 +00:00
Mike Conley
682fee1d69 Bug 1877196 - Move ToolbarBadgeHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200081
2024-02-05 22:03:13 +00:00
Mike Conley
9a333aee03 Bug 1868838 - Add missing xpcshell.toml file for browser/components/asrouter. r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D199003
2024-01-29 18:52:30 +00:00