Commit graph

107 commits

Author SHA1 Message Date
Ksenia Berezina
883f596167 Bug 1900435 - Add extra_labels back to the mobile reporter; r=twisniewski,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D212510
2024-06-04 15:54:53 +00:00
Dave Townsend
a9a51bf046 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D203005
2024-03-19 09:36:35 +00:00
Mark Banner
4f1d29d324 Bug 1883371 - Enable ESLint rule no-console on production code. r=mossop,webcompat-reviewers,devtools-reviewers,omc-reviewers,twisniewski,nchevobbe,aminomancer
Allow for console.error, console.warn and console.createInstance, but fail for everything else.

Differential Revision: https://phabricator.services.mozilla.com/D203456
2024-03-05 16:56:57 +00:00
Thomas Wisniewski
dd33e85ad8 Bug 1881803 - convert Report Site Issue extension to event pages; r=robwu,webcompat-reviewers,ksenia
Differential Revision: https://phabricator.services.mozilla.com/D202602
2024-03-04 15:15:01 +00:00
Mark Banner
b4dc975e82 Bug 1880535 - Enable ESLint rule no-unused-private-class-members. r=Gijs,webdriver-reviewers,webcompat-reviewers,extension-reviewers,application-update-reviewers,devtools-reviewers,translations-reviewers,bytesized,twisniewski,jhirsch,robwu,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D202002
2024-02-20 22:09:21 +00:00
Mark Banner
8e8cc1684d Bug 1879811 - Avoid re-enabling ESLint rules when they are already enabled by ESLint's recommended configuration, or mozilla-central's one. r=Gijs,webcompat-reviewers,extension-reviewers,devtools-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D201361
2024-02-12 18:46:28 +00:00
Gijs Kruitbosch
96fbfbdfb0 Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements
Differential Revision: https://phabricator.services.mozilla.com/D198974
2024-01-24 17:03:13 +00:00
Thomas Wisniewski
a6562d5849 Bug 1852340 - part 2: Simplify the fallback Report Site Issue feature to not have redundant actors and experimental APIs; r=webcompat-reviewers,ksenia
Depends on D190647

Differential Revision: https://phabricator.services.mozilla.com/D190648
2023-11-20 01:50:36 +00:00
Cristian Tuns
c76093316c Backed out 3 changesets (bug 1852340) for causing frequent mochitest failures in docshell/test/chrome/ CLOSED TREE
Backed out changeset 61875987e62c (bug 1852340)
Backed out changeset 05320d6c0441 (bug 1852340)
Backed out changeset 411374d444d1 (bug 1852340)
2023-11-19 11:46:26 -05:00
Thomas Wisniewski
566e56744f Bug 1852340 - part 2: Simplify the fallback Report Site Issue feature to not have redundant actors and experimental APIs; r=webcompat-reviewers,ksenia
Depends on D190647

Differential Revision: https://phabricator.services.mozilla.com/D190648
2023-11-19 15:34:41 +00:00
Natalia Csoregi
42acdc9cd5 Backed out 3 changesets (bug 1852340) for causing failures due to reportBrokenSite.ftl. CLOSED TREE
Backed out changeset 86f9e01f70d6 (bug 1852340)
Backed out changeset 0049d0494b17 (bug 1852340)
Backed out changeset 7851355d5c95 (bug 1852340)
2023-11-19 10:50:25 +02:00
Thomas Wisniewski
a42e6b7954 Bug 1852340 - part 2: Simplify the fallback Report Site Issue feature to not have redundant actors and experimental APIs; r=webcompat-reviewers,ksenia
Depends on D190647

Differential Revision: https://phabricator.services.mozilla.com/D190648
2023-11-19 07:31:32 +00:00
Benjamin VanderSloot
7292a59797 Bug 1850955 - Add current GPC setting to webcompat reports - r=timhuang,twisniewski,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189659
2023-10-10 15:24:21 +00:00
Sylvestre Ledru
4c29c24344 Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D189896
2023-10-03 09:22:18 +00:00
Masatoshi Kimura
bcd7d268c4 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D189696
2023-10-02 19:00:07 +00:00
Noemi Erli
26e0b0be0a Backed out 3 changesets (bug 1856187, bug 1856100, bug 1856104) for causing newtab failures
Backed out changeset db28784a1734 (bug 1856187)
Backed out changeset bd11e14dca63 (bug 1856104)
Backed out changeset 2741311b6055 (bug 1856100)
2023-10-02 21:16:25 +03:00
Masatoshi Kimura
7ad48d61dd Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D189696
2023-10-02 17:36:27 +00:00
Markus Stange
a26dbc5487 Bug 1611626 - Remove gfx.webrender.blob-images. r=nical,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D188489
2023-09-25 23:36:26 +00:00
Tom Marble
d596ebea8e Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D188427
2023-09-21 22:47:07 +00:00
Gregory Pappas
8a35d5cf5f Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184623
2023-08-01 23:01:02 +00:00
Gregory Pappas
76facf7cd2 Bug 1842345 - Remove gfx.webrender.enabled pref r=jrmuizel,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D183071
2023-07-13 04:17:40 +00:00
Mark Banner
0b2d2afdea Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin
Differential Revision: https://phabricator.services.mozilla.com/D181159
2023-07-12 13:38:34 +00:00
Gregory Pappas
2f76844f75 Bug 1842470 - Remove unused image.mem.shared pref r=CanadaHonk,webcompat-reviewers,twisniewski
Since bug 1729051 this pref doesn't actually do anything

Differential Revision: https://phabricator.services.mozilla.com/D183091
2023-07-09 17:25:34 +00:00
Rob Wu
3c0c3a2676 Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski
This patch was generated as follows:

Run:
`./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager`
In the output there are linter/prettifier errors due to unused
XPCOMUtils or separate importESModule calls. These have been fixed
manually and verified with `./mach lint --outgoing`.

The `esmify` script also inserts many unwanted newlines around imports
that are broken on two lines due to length. Due to the number of these,
I fixed them programatically.

1. Create patch from the changes so far.
2. From the patch, delete all lines that consist of "+" (i.e. added blank line).
3. Reset the working dir and apply the revised patch.
4. Verify that the diff between step 1 and 3 looks reasonable.
5. Verify that this patch as a whole looks reasonable.

Commands:

```
git diff > rename.diff
:%g/^+$/d
git commit -va -m WIP-rename
git revert HEAD
git apply --recount rename.diff
git diff HEAD^  # and verify that the removed lines are ok.
git commit -va  # one last review to verify correctness of whole patch.
git rebase -i HEAD~3  # drop the WIP + reverted commit, pick only the last.
```

`git apply` has the `--recount` option to force it to ignore mismatches
in line counts, which happens because we deleted added lines (^+$)
without fixing up the line counts in the file headers.

Differential Revision: https://phabricator.services.mozilla.com/D179874
2023-06-04 13:44:45 +00:00
Saira Abdulla
9691ab4a5f Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 15:27:03 +00:00
Iulian Moraru
90b739a400 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
2023-05-31 17:28:16 +03:00
Saira Abdulla
2e8db5969a Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
Ksenia Berezina
f78e5a33f6 Bug 1833916 - Add additional data/prefs passed from "Report site issue" to webcompat.com r=webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D178462
2023-05-24 19:22:26 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Mark Banner
c2dd8e3266 Bug 1829618 - Enable Prettier on json files (automatic fixes). r=perftest-reviewers,webcompat-reviewers,extension-reviewers,andi,desktop-theme-reviewers,pip-reviewers,devtools-reviewers,sync-reviewers,mossop,denschub,dao,sparky,robwu,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D176336
2023-05-09 16:14:51 +00:00
anwar
a7126d2057 Bug 1830075 - Put all mochitests under browser/extensions, browser/modules and browser/tools into alphabetical order. r=mconley,webcompat-reviewers,credential-management-reviewers,twisniewski,dimi
Differential Revision: https://phabricator.services.mozilla.com/D176839
2023-05-02 20:26:16 +00:00
Mark Banner
36ab6611df Bug 1824173 - Enable ESLint configuration valid-jsdocs across the tree, disabling for currently failing locations. r=mossop,webcompat-reviewers,extension-reviewers,credential-management-reviewers,denschub,dimi,robwu
Depends on D173450

Differential Revision: https://phabricator.services.mozilla.com/D173451
2023-03-24 19:35:25 +00:00
William Durand
6cbcad5461 Bug 1797777 - Use browser_specific_settings instead of applications in extension manifests. r=rpl,twisniewski,markh,webcompat-reviewers,credential-management-reviewers,dimi
Differential Revision: https://phabricator.services.mozilla.com/D167018
2023-01-18 15:57:30 +00:00
Mark Banner
2a9627f119 Bug 1810877 - Automatically replace Cu.reportError with console.error (browser/extensions/report-site-issue/). r=webcompat-reviewers,twisniewski
Depends on D167095

Differential Revision: https://phabricator.services.mozilla.com/D167096
2023-01-18 08:24:40 +00:00
trickypr
a914e03ff7 Bug 1510561 - Part 12: Apply plugin:mozilla/valid-jsdoc to browser/extensions/report-site-issue. r=webcompat-reviewers,twisniewski
Depends on D161386

Differential Revision: https://phabricator.services.mozilla.com/D161387
2022-11-07 12:33:29 +00:00
Andrew Osmond
77b6b3ccc7 Bug 1794722 - Part 3. Remove all uses of GfxInfo::GetWebRenderEnabled. r=jrmuizel,webcompat-reviewers,twisniewski
This is always true.

Differential Revision: https://phabricator.services.mozilla.com/D160122
2022-10-28 12:36:06 +00:00
Cristian Tuns
1303ee58d8 Backed out 3 changesets (bug 1794722) for causing multiple failures on RemoteProcessMonitor CLOSED TREE
Backed out changeset 0217af5b1aa6 (bug 1794722)
Backed out changeset d7805be9dfb3 (bug 1794722)
Backed out changeset 0093f071f1a5 (bug 1794722)
2022-10-27 20:52:36 -04:00
Andrew Osmond
f8dc716e8d Bug 1794722 - Part 3. Remove all uses of GfxInfo::GetWebRenderEnabled. r=jrmuizel,webcompat-reviewers,twisniewski
This is always true.

Differential Revision: https://phabricator.services.mozilla.com/D160122
2022-10-28 00:08:04 +00:00
Mark Banner
7428be4a86 Bug 1782008 - Remove now unnecessary .eslintrc.js files. r=webcompat-reviewers,extension-reviewers,media-playback-reviewers,pip-reviewers,denschub,rpl,alwu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D152736
2022-08-03 11:16:20 +00:00
Mark Banner
58566a1db9 Bug 1777268 - Support structuredClone in the system global by default. r=webcompat-reviewers,twisniewski,kmag
Differential Revision: https://phabricator.services.mozilla.com/D152196
2022-07-26 20:13:52 +00:00
Tooru Fujisawa
f3a8c52c53 Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Mark Banner
f81acc0ab7 Bug 1646183 - Use ESLint rule reject-importGlobalProperties to reject all imports in system modules. r=arai,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D150354
2022-06-29 22:37:58 +00:00
Thomas Wisniewski
64865cfb7a Bug 1775402 - disable the report-site-issues tests until we can determine why they intermittently fail in bz1775526; r=ksenia,webcompat-reviewers DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D150269
2022-06-24 16:44:20 +00:00
Thomas Wisniewski
db8b4655a3 Bug 1775126 - fix a structured-cloning failure in the webcompat report-site-issue feature, and update and re-enable some of its tests; r=denschub,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D149847
2022-06-22 03:27:54 +00:00
criss
5d561f14dc Backed out changeset d0771d3e5261 (bug 1775126) for causing mochitest failures on browser_report_site_issue.js. CLOSED TREE 2022-06-21 22:25:58 +03:00
Thomas Wisniewski
4f70108602 Bug 1775126 - fix a structured-cloning failure in the webcompat report-site-issue feature, and update and re-enable its tests; r=denschub,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D149847
2022-06-21 12:36:18 +00:00
raquelvargas
0aadb60b82 Bug 1738229 - Stop using the second argument to ChromeUtils.import in various files in browser. r=Standard8,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D129842
2021-11-02 17:21:07 +00:00
Sam Foster
b61fcc9780 Bug 1708018 - Use toolkit's lightbulb icon for the report-site-issue extension. r=webcompat-reviewers,denschub
Differential Revision: https://phabricator.services.mozilla.com/D117581
2021-06-24 21:59:33 +00:00
Harry Twyford
7e9451d277 Bug 1707756 - Part 2 - Update lightbulb icon. r=sfoster,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D113531
2021-04-30 20:24:33 +00:00
Cosmin Sabou
61b6535e33 Backed out 2 changesets (bug 1707756) for causing build bustages. CLOSED TREE
Backed out changeset ddfb12358dcd (bug 1707756)
Backed out changeset be804f37dfe3 (bug 1707756)
2021-04-29 19:05:09 +03:00