Commit graph

3541 commits

Author SHA1 Message Date
Kagami Sascha Rosylight
aa2b46d4e7 Bug 1905928 - Part 3: Add glean telemetry entries a=RyanVM
Each provider has different fallback behavior:
* Windows/macOS: Fallback only on error
* Gpsd/Portal: Fallback only on timeout
* Geoclue: Fallback on both

To meet all the behaviors MLSFallback got FallbackReason/ShutdownReason and report via Glean based on that.

Original Revision: https://phabricator.services.mozilla.com/D216085

Differential Revision: https://phabricator.services.mozilla.com/D216942
2024-07-19 13:37:04 +00:00
Emilio Cobos Álvarez
6364cf7159 Bug 1905717 - Add a timeout for geoclue -> GLS fallback. r=saschanaz a=RyanVM
Use 10s which feels it should be enough for geoclue to provide a
reasonable location, without feeling too slow for users.

Still if geoclue eventually gives us a proper location we'd update it
properly and stop the network fallback so this seems reasonable.

I made some naming tweaks for consistency but otherwise it should be
reasonably straight-forward.

Differential Revision: https://phabricator.services.mozilla.com/D215491
2024-07-02 16:24:43 +00:00
Ray Kraesig
fce1a86177 Bug 1895375 - [4/4] Propagate ipc::LaunchErrors to callers r=ipc-reviewers,nika
* Adjust UtilityProcess{Host,Manager} to propagate ipc::LaunchErrors for
  their clients, or to create new ones where none previously existed.

* Adjust the various clients of the above to to handle the additional
  information -- mostly by adding the additional failure-location data
  to log messages.

* Fix an unrelated bug wherein the return type of `LaunchProcess` was
  declared as exclusive, despite being cached and reused.

In particular, filedialog::Error objects should now contain -- and report
to telemetry without further adjustment -- the actual error code from
`ipc::LaunchError`s.

(Reporting the original failure location as well will occur in bug
1884221.)

Differential Revision: https://phabricator.services.mozilla.com/D209715
2024-05-30 17:52:09 +00:00
Dave Townsend
6a99b2e0d4 Bug 1864896: Autofix unused function arguments (dom). r=emilio,media-playback-reviewers,dom-storage-reviewers,padenot,janv
Differential Revision: https://phabricator.services.mozilla.com/D202962
2024-03-04 15:44:59 +00:00
Peter Van der Beken
2b747df80a Bug 1640839 - Add some helpers for enums to calculate the size and use it in EnumeratedArray. r=glandium,jgilbert,media-playback-reviewers,padenot
Differential Revision: https://phabricator.services.mozilla.com/D201334
2024-03-02 07:50:19 +00:00
Peter Van der Beken
9c8d00b7fb Bug 1640839 - Move size template parameter for EnumeratedArray to the end. r=glandium,jgilbert,media-playback-reviewers,credential-management-reviewers,padenot,dimi
This will allow us to provide a default value for the size when some enum
helper traits are defined.

Differential Revision: https://phabricator.services.mozilla.com/D201333
2024-03-02 07:50:19 +00:00
Natalia Csoregi
8c2521e9d5 Backed out 13 changesets (bug 1640839) for causing bustage on Element.cpp CLOSED TREE
Backed out changeset 179ceb82c9e5 (bug 1640839)
Backed out changeset 73f498a821f0 (bug 1640839)
Backed out changeset dc2d3d0e0365 (bug 1640839)
Backed out changeset ddc989ac0509 (bug 1640839)
Backed out changeset e595bb3feea8 (bug 1640839)
Backed out changeset c85aca04e27f (bug 1640839)
Backed out changeset 98e8e3a4047a (bug 1640839)
Backed out changeset 59ef180517db (bug 1640839)
Backed out changeset af2f5e293662 (bug 1640839)
Backed out changeset 89aa6d9dc598 (bug 1640839)
Backed out changeset 67b722a722f9 (bug 1640839)
Backed out changeset 24a9665c6ced (bug 1640839)
Backed out changeset d93f199385e9 (bug 1640839)
2024-03-01 18:23:08 +02:00
Peter Van der Beken
f295b0c979 Bug 1640839 - Add some helpers for enums to calculate the size and use it in EnumeratedArray. r=glandium,jgilbert,media-playback-reviewers,padenot
Differential Revision: https://phabricator.services.mozilla.com/D201334
2024-03-01 14:31:09 +00:00
Peter Van der Beken
8d1c9ad39c Bug 1640839 - Move size template parameter for EnumeratedArray to the end. r=glandium,jgilbert,media-playback-reviewers,credential-management-reviewers,padenot,dimi
This will allow us to provide a default value for the size when some enum
helper traits are defined.

Differential Revision: https://phabricator.services.mozilla.com/D201333
2024-03-01 14:31:09 +00:00
Stanca Serban
5993e595e1 Backed out changeset a03f0155519c (bug 1870426) for causing mochitests failures in test_ioutils_read_write.html. CLOSED TREE 2024-02-26 18:18:34 +02:00
Barret Rennie
98851e0029 Bug 1870426 - Don't allow backupFile to be a directory in IOUtils::Write* r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196656
2024-02-26 15:54:18 +00:00
Barret Rennie
2a938f84cb Bug 1869371 - Chain errors from nested calls in IOUtils r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196655
2024-02-23 18:25:32 +00:00
Barret Rennie
8cf29a0217 Bug 1869371 - Include nsresult error code when reporting IOUtils errors r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196654
2024-02-23 18:25:32 +00:00
Barret Rennie
5185561d96 Bug 1869371 - Move IOUtils::ReadSync option errors to frontend r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196653
2024-02-23 18:25:31 +00:00
Barret Rennie
071db74ad4 Bug 1869371 - Improve error messages when rejecting IOUtils promises early r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196652
2024-02-23 18:25:31 +00:00
Barret Rennie
51007ab7a0 Bug 1869371 - Improve error messages in IOUtils frontend r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196651
2024-02-23 18:25:31 +00:00
Barret Rennie
ba92fe9023 Bug 1869371 - Make message mandatory for IOUtils::IOError r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196650
2024-02-23 18:25:30 +00:00
Barret Rennie
ea37027806 Bug 1869371 - Replace MOZ_TRY in IOUtils with IOUTILS_TRY_WITH_CONTEXT r=nika
Using plain MOZ_TRY will result in a generic error message being used in
RejectJSPromise.

Differential Revision: https://phabricator.services.mozilla.com/D196649
2024-02-23 18:25:30 +00:00
Butkovits Atila
70401bd1d7 Backed out 8 changesets (bug 1869371) for causing failures at test_sqlite.js. CLOSED TREE
Backed out changeset 391786e96304 (bug 1869371)
Backed out changeset b92684d03373 (bug 1869371)
Backed out changeset 9c7998c36e23 (bug 1869371)
Backed out changeset 1ed5e90100b9 (bug 1869371)
Backed out changeset d37cbe376973 (bug 1869371)
Backed out changeset 753da5215de8 (bug 1869371)
Backed out changeset 124b34895745 (bug 1869371)
Backed out changeset 988b51eb124f (bug 1869371)
2024-02-22 00:04:02 +02:00
Barret Rennie
f0e51159ae Bug 1869371 - Chain errors from nested calls in IOUtils r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196655
2024-02-21 19:33:45 +00:00
Barret Rennie
8154d58fff Bug 1869371 - Include nsresult error code when reporting IOUtils errors r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196654
2024-02-21 19:33:45 +00:00
Barret Rennie
ca6567f0fa Bug 1869371 - Move IOUtils::ReadSync option errors to frontend r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196653
2024-02-21 19:33:45 +00:00
Barret Rennie
47071a738f Bug 1869371 - Improve error messages when rejecting IOUtils promises early r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196652
2024-02-21 19:33:44 +00:00
Barret Rennie
b7596666f5 Bug 1869371 - Improve error messages in IOUtils frontend r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196651
2024-02-21 19:33:44 +00:00
Barret Rennie
ea9a97b2d0 Bug 1869371 - Make message mandatory for IOUtils::IOError r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196650
2024-02-21 19:33:43 +00:00
Barret Rennie
a6cf318b15 Bug 1869371 - Replace MOZ_TRY in IOUtils with IOUTILS_TRY_WITH_CONTEXT r=nika
Using plain MOZ_TRY will result in a generic error message being used in
RejectJSPromise.

Differential Revision: https://phabricator.services.mozilla.com/D196649
2024-02-21 19:33:43 +00:00
Cristian Tuns
a988a4d5f9 Backed out 7 changesets (bug 1869371) for causing xpcshell failures in /test_telemetry.js CLOSED TREE
Backed out changeset 1a5a7790c117 (bug 1869371)
Backed out changeset b1e169c2ffb2 (bug 1869371)
Backed out changeset ab8c2d6a01ba (bug 1869371)
Backed out changeset 4f2ac5fe4356 (bug 1869371)
Backed out changeset b2211ce1cbcc (bug 1869371)
Backed out changeset 51827faf0339 (bug 1869371)
Backed out changeset 673ddb6bc4b3 (bug 1869371)
2024-02-07 01:56:15 -05:00
Barret Rennie
5c6e5f6d11 Bug 1869371 - Chain errors from nested calls in IOUtils r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196655
2024-02-07 03:24:50 +00:00
Barret Rennie
d8931fe781 Bug 1869371 - Include nsresult error code when reporting IOUtils errors r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196654
2024-02-07 03:24:49 +00:00
Barret Rennie
fcfe19e4c2 Bug 1869371 - Move IOUtils::ReadSync option errors to frontend r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196653
2024-02-07 03:24:49 +00:00
Barret Rennie
d9ab3a1f97 Bug 1869371 - Improve error messages when rejecting IOUtils promises early r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196652
2024-02-07 03:24:49 +00:00
Barret Rennie
7966f97c8b Bug 1869371 - Improve error messages in IOUtils frontend r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196651
2024-02-07 03:24:48 +00:00
Barret Rennie
25fb0438c8 Bug 1869371 - Make message mandatory for IOUtils::IOError r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196650
2024-02-07 03:24:48 +00:00
Barret Rennie
b52ddc96cb Bug 1869371 - Replace MOZ_TRY in IOUtils with IOUTILS_TRY_WITH_CONTEXT r=nika
Using plain MOZ_TRY will result in a generic error message being used in
RejectJSPromise.

Differential Revision: https://phabricator.services.mozilla.com/D196649
2024-02-07 03:24:47 +00:00
Narcis Beleuzu
01e306d45d Backed out 7 changesets (bug 1869371) for bustages on IOUtils.cpp . CLOSED TREE
Backed out changeset f83467c82917 (bug 1869371)
Backed out changeset bbaca6589c02 (bug 1869371)
Backed out changeset 564d342cdb12 (bug 1869371)
Backed out changeset c90d1df73804 (bug 1869371)
Backed out changeset bd7c84d9e914 (bug 1869371)
Backed out changeset c549b0479a3b (bug 1869371)
Backed out changeset ff455712e871 (bug 1869371)
2024-02-06 18:46:07 +02:00
Barret Rennie
e8f32c5fab Bug 1869371 - Chain errors from nested calls in IOUtils r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196655
2024-02-06 16:04:49 +00:00
Barret Rennie
496717582c Bug 1869371 - Include nsresult error code when reporting IOUtils errors r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196654
2024-02-06 16:04:49 +00:00
Barret Rennie
2d5cf0502d Bug 1869371 - Move IOUtils::ReadSync option errors to frontend r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196653
2024-02-06 16:04:48 +00:00
Barret Rennie
f11fbfc097 Bug 1869371 - Improve error messages when rejecting IOUtils promises early r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196652
2024-02-06 16:04:48 +00:00
Barret Rennie
373259b667 Bug 1869371 - Improve error messages in IOUtils frontend r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196651
2024-02-06 16:04:47 +00:00
Barret Rennie
4f8caf902a Bug 1869371 - Make message mandatory for IOUtils::IOError r=nika
Differential Revision: https://phabricator.services.mozilla.com/D196650
2024-02-06 16:04:47 +00:00
Barret Rennie
6b01abf2b4 Bug 1869371 - Replace MOZ_TRY in IOUtils with IOUTILS_TRY_WITH_CONTEXT r=nika
Using plain MOZ_TRY will result in a generic error message being used in
RejectJSPromise.

Differential Revision: https://phabricator.services.mozilla.com/D196649
2024-02-06 16:04:47 +00:00
Barret Rennie
b5a3288cbc Bug 1871110 - Remove sha1 support from IOUtils::ComputeHexDigest r=xpcom-reviewers,mccr8,extension-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D196995
2024-02-01 21:50:06 +00:00
Nika Layzell
ad9bb1e2c4 Bug 1867360 - Require toplevel protocols to specify which processes they expect to be bound in, r=decoder,ipc-reviewers,necko-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,aosmond,rkraesig,mccr8,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D195485
2024-01-18 23:07:18 +00:00
Natalia Csoregi
b2289eef93 Backed out changeset 9c4ce17422de (bug 1867360) for causing crashes on PRemoteQuotaObjectChild. CLOSED TREE 2024-01-08 23:18:19 +02:00
Nika Layzell
c4aa6e4813 Bug 1867360 - Require toplevel protocols to specify which processes they expect to be bound in, r=decoder,ipc-reviewers,necko-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,aosmond,rkraesig,mccr8,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D195485
2024-01-08 19:48:23 +00:00
Cristian Tuns
287183f7e3 Backed out changeset b2d838cca6bd (bug 1871110) for causing xpcshell failures in test_system_update_checkSizeHash.js CLOSED TREE 2023-12-21 18:20:48 -05:00
Barret Rennie
81ca0c8611 Bug 1871110 - Remove sha1 support from IOUtils::ComputeHexDigest r=xpcom-reviewers,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D196995
2023-12-21 19:49:08 +00:00
Cristian Tuns
398245395b Backed out changeset 1130670445e4 (bug 1871110) for causing mochitest failures in /test_ioutils_compute_hex_digest.html CLOSED TREE 2023-12-21 13:00:04 -05:00
Barret Rennie
2759388716 Bug 1871110 - Remove sha1 support from IOUtils::ComputeHexDigest r=xpcom-reviewers,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D196995
2023-12-21 16:50:41 +00:00