Commit graph

21 commits

Author SHA1 Message Date
Matt Howell
ba8e2a22b0 Bug 1324617 - Allow any of multiple installations to be set as the Windows default browser; r=jimm,rstrong
Previously each new installation of any Firefox channel in any location would
just overwrite the Windows registry keys which register us as a candidate for
the default browser setting and for all of our potential file and protocol associations.

This meant that only the most recent installation (across all channels) was ever
selectable in those settings.

It also meant that creating a new installation when one was already present
tripped Windows 10's shenanigans alarm, because it saw the registration for an
existing application getting clobbered by a new one and couldn't tell that they
were really the same application.

The response to that alarm going off is to reset the default browser to Edge,
and maybe or maybe not generate a system notification about that. This is the
cause of bug 1324617. Obviously we would like to prevent that outcome.

So with this commit we generate new registration entries for each installation,
by adding a hash of the install path to the relevant identifiers.

MozReview-Commit-ID: Fz1xDtittMi

--HG--
extra : rebase_source : e0bc19e4abc1b32133f56458daf625527ce188b0
2017-01-09 08:14:00 -08:00
Sebastian Hengst
f3c9a45af9 Backed out changeset 5b0aa267bc53 (bug 1324617) for Windows build bustage (warning in CityHash.h). r=backout on a CLOSED TREE 2017-01-30 23:20:01 +01:00
Matt Howell
b50dd65754 Bug 1324617 - Allow any of multiple installations to be set as the Windows default browser; r=jimm,rstrong
Previously each new installation of any Firefox channel in any location would
just overwrite the Windows registry keys which register us as a candidate for
the default browser setting and for all of our potential file and protocol associations.

This meant that only the most recent installation (across all channels) was ever
selectable in those settings.

It also meant that creating a new installation when one was already present
tripped Windows 10's shenanigans alarm, because it saw the registration for an
existing application getting clobbered by a new one and couldn't tell that they
were really the same application.

The response to that alarm going off is to reset the default browser to Edge,
and maybe or maybe not generate a system notification about that. This is the
cause of bug 1324617. Obviously we would like to prevent that outcome.

So with this commit we generate new registration entries for each installation,
by adding a hash of the install path to the relevant identifiers.

MozReview-Commit-ID: Fz1xDtittMi

--HG--
extra : rebase_source : 3b3523c108502aebd08fd4912c3ab50baf3c0359
2017-01-09 08:14:00 -08:00
Tom Tromey
5538d692d3 Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
This removes the unnecessary setting of c-basic-offset from all
python-mode files.

This was automatically generated using

    perl -pi -e 's/; *c-basic-offset: *[0-9]+//'

... on the affected files.

The bulk of these files are moz.build files but there a few others as
well.

MozReview-Commit-ID: 2pPf3DEiZqx

--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
Chris Peterson
8a9e2d2bd4 Bug 1272513 - Part 2: Remove redundant -Wshadow CXXFLAGS from moz.build files. r=glandium 2016-05-14 00:54:55 -07:00
Mike Hommey
0a771514a8 Bug 1256988 - Replace tests on MOZ_WIDGET_GTK with tests on MOZ_WIDGET_TOOLKIT containing gtk. r=chmanchester
But only do that for the AC_SUBST. The AC_DEFINE is still useful.
2016-03-17 06:49:44 +09:00
Jared Wein
b82fbe3699 Bug 1238712 - Move duplicated shell-service code to a shared JSM. r=gijs
--HG--
extra : commitid : 5Dm73Qky4vC
extra : rebase_source : 081f9eb19df15bcde305e87dbacea64cfe488249
2016-01-15 12:35:15 -05:00
Chris Peterson
71920a9550 Bug 1207030 - Enable -Wshadow flag in more directories that have no -Wshadow warnings. r=glandium 2015-09-22 21:39:03 -07:00
Nicholas Nethercote
f44287005f Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.

--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
Sebastian Hengst
bb17128a40 Bug 1139427 - Define file-based metadata in /browser/components. r=gavin
Add bugzilla components as metadata to moz.build files for easier bugfiling into the correct component. More information:

https://gecko.readthedocs.org/en/latest/build/buildsystem/mozbuild-symbols.html#bug-component
2015-03-08 20:43:22 +01:00
Chris Peterson
249ac81315 Bug 1110031 - Part 1: Mark more directories as FAIL_ON_WARNINGS. r=gps 2014-12-10 22:56:31 -08:00
Nathan Froyd
12c76f15f7 Bug 1042878 - part 2 - move MOZ_CAIRO_CFLAGS et al additions to C*FLAGS into moz.build; r=glandium 2014-07-24 11:55:33 -04:00
Birunthan Mohanathas
a8756989dc Bug 1038458 - Part 7: Flatten browser/components/shell/{public,src}/ directories. r=mak
--HG--
rename : browser/components/shell/src/Makefile.in => browser/components/shell/Makefile.in
rename : browser/components/shell/src/nsGNOMEShellService.cpp => browser/components/shell/nsGNOMEShellService.cpp
rename : browser/components/shell/src/nsGNOMEShellService.h => browser/components/shell/nsGNOMEShellService.h
rename : browser/components/shell/public/nsIMacShellService.idl => browser/components/shell/nsIMacShellService.idl
rename : browser/components/shell/public/nsIShellService.idl => browser/components/shell/nsIShellService.idl
rename : browser/components/shell/public/nsIWindowsShellService.idl => browser/components/shell/nsIWindowsShellService.idl
rename : browser/components/shell/src/nsMacShellService.cpp => browser/components/shell/nsMacShellService.cpp
rename : browser/components/shell/src/nsMacShellService.h => browser/components/shell/nsMacShellService.h
rename : browser/components/shell/src/nsSetDefaultBrowser.js => browser/components/shell/nsSetDefaultBrowser.js
rename : browser/components/shell/src/nsSetDefaultBrowser.manifest => browser/components/shell/nsSetDefaultBrowser.manifest
rename : browser/components/shell/src/nsShellService.h => browser/components/shell/nsShellService.h
rename : browser/components/shell/src/nsWindowsShellService.cpp => browser/components/shell/nsWindowsShellService.cpp
rename : browser/components/shell/src/nsWindowsShellService.h => browser/components/shell/nsWindowsShellService.h
2014-07-26 09:32:14 -07:00
Gregory Szorc
e396fc159d Bug 774572 - Part 2: Define JAR_MANIFESTS in moz.build files; r=glandium
Every directory with a jar.mn now has JAR_MANIFESTS defined in its
moz.build file.

We also removed the may_skip special consideration of jar.mn files
because this information is now available during tier traversal by the
reader courtesy of the variables being present in moz.build files.

--HG--
extra : rebase_source : 21049b15e6bd9cf65b0805ccaccc4ba5aae93c98
extra : amend_source : 0b1ea866d725beef92d37c6f6d475369ac002e19
2013-12-10 16:18:11 +09:00
Gijs Kruitbosch
3905b31a92 Bug 924463 - clean up browser/components moz.build/test manifest, r=gps 2013-10-18 14:55:19 +02:00
Phil Ringnalda
42269c15ff Back out e9f46c81c28e (bug 924463) on suspicion of being the One True cause of mass browser-chrome orange
CLOSED TREE
2013-10-18 18:54:22 -07:00
Gijs Kruitbosch
fd78ae11da Bug 924463 - clean up browser/components moz.build/test manifest, r=gps 2013-10-18 14:55:19 +02:00
Kyle Machulis
72a717a860 Bug 855465 - Add emacs python mode comments to moz.build files; r=gps 2013-04-01 11:36:59 -07:00
Kyle Machulis
43628a7867 Backout for changeset 03452b187c14 (Bug 855465) due to bustage on a CLOSED TREE; r=qdot 2013-03-29 15:12:58 -07:00
Kyle Machulis
334c0800cf Bug 855465 - Add emacs python mode comments to moz.build files; r=gps
--HG--
extra : rebase_source : 004a756492323e1a049586e85b3be5037159df20
2013-03-29 13:56:18 -07:00
Gregory Szorc
1b27561fa4 Bug 784841 - Part 18d: Convert /browser; r=gavin f=Ms2ger 2013-02-25 12:47:18 -08:00