Commit graph

146 commits

Author SHA1 Message Date
Shawn Huang
bea755a58f Bug 1341272 - Set readyState to DONE during synchronous XMLHttpRequest failure, r=baku 2017-03-27 15:21:57 +08:00
David Major
dc67bfc9a3 Bug 1344629 - Part 6: Rewrite unnecessary uses of nsLiteralString. r=dbaron
There's an antipattern where nsLiteralString is used as an unnecessary intermediary in converting from CharT* to CharT*,
e.g. CallAFunctionThatTakesACharPointer(NS_LITERAL_CSTRING("foo").get());
or
NS_NAMED_LITERAL_STRING(foo, "abc");
CallAFunctionThatTakesACharPointer(foo.get());

This patch rewrites the callsites that can be trivially changed to use char*/char16_t*.

I'd somewhat like to remove nsTLiteralString::get() altogether, but in code that's less straightforward than these examples, get() is useful enough to keep.

MozReview-Commit-ID: Kh1rUziVllo

--HG--
extra : rebase_source : c21a65694d6e1c42fd88f73632f7ac8f38d005ae
2017-03-14 15:26:27 +13:00
Iris Hsiao
5cece96e1c Backed out 12 changesets (bug 1344629) for stylo build bustage
Backed out changeset cf4273d3ac30 (bug 1344629)
Backed out changeset a96390e044e0 (bug 1344629)
Backed out changeset d9b330f9bc24 (bug 1344629)
Backed out changeset 2b460fe020af (bug 1344629)
Backed out changeset 0ada91b0452e (bug 1344629)
Backed out changeset 083304fcd6bd (bug 1344629)
Backed out changeset 53d7d1ce2c97 (bug 1344629)
Backed out changeset 55eee7078ae4 (bug 1344629)
Backed out changeset 7d3c06b3eca9 (bug 1344629)
Backed out changeset e5df14c3db61 (bug 1344629)
Backed out changeset 636095ff2815 (bug 1344629)
Backed out changeset 0be052ad24c1 (bug 1344629)
2017-03-14 11:52:24 +08:00
David Major
40f4821701 Bug 1344629 - Part 6: Rewrite unnecessary uses of nsLiteralString. r=dbaron
There's an antipattern where nsLiteralString is used as an unnecessary intermediary in converting from CharT* to CharT*,
e.g. CallAFunctionThatTakesACharPointer(NS_LITERAL_CSTRING("foo").get());
or
NS_NAMED_LITERAL_STRING(foo, "abc");
CallAFunctionThatTakesACharPointer(foo.get());

This patch rewrites the callsites that can be trivially changed to use char*/char16_t*.

I'd somewhat like to remove nsTLiteralString::get() altogether, but in code that's less straightforward than these examples, get() is useful enough to keep.

MozReview-Commit-ID: Kh1rUziVllo

--HG--
extra : rebase_source : c21a65694d6e1c42fd88f73632f7ac8f38d005ae
2017-03-14 15:26:27 +13:00
Wei-Cheng Pan
510ba75c20 Bug 1310127 - Part 17: Use MOZ_MUST_USE in netwerk/protocol/http r=smaug
MozReview-Commit-ID: 5gvVZtsa3yS

--HG--
extra : rebase_source : 5e1ab2fc06ae58f18abb8909ac93f9512abbe220
2016-12-20 11:49:32 +08:00
Patrick McManus
0a3349e548 Bug 1344374 - remove now-meaningless nsIRequest::INHIBIT_PIPELINE r=hurley 2017-03-03 16:46:53 -05:00
Jessica Jong
cf17189117 Bug 1340086 - Remove uses of AnimationsPaused() since it is always false after bug 1316330. r=mrbkap 2017-02-22 01:00:00 -05:00
Andrew McCreight
55021b6577 Bug 1336811 - Clear mWaitingForOnStopRequest in CloseRequest. r=smaug
Otherwise, if a tab is closed when we have a request pending, we'll
end up leaking the page forever, due to CC optimizations.

MozReview-Commit-ID: E5NC0jxWCur

--HG--
extra : rebase_source : ac9b068dbf7166daf90d4143a190e7caa03aa88e
2017-02-17 11:22:45 -08:00
Andrea Marchesini
3043646e52 Bug 1339871 - Splitting dom/file/File.{h,cpp}, r=smaug
--HG--
rename : dom/file/File.cpp => dom/file/BaseBlobImpl.cpp
rename : dom/file/File.h => dom/file/BaseBlobImpl.h
rename : dom/file/File.cpp => dom/file/Blob.cpp
rename : dom/file/File.h => dom/file/Blob.h
rename : dom/file/File.cpp => dom/file/BlobImpl.cpp
rename : dom/file/File.h => dom/file/BlobImpl.h
rename : dom/file/File.cpp => dom/file/EmptyBlobImpl.cpp
rename : dom/file/File.h => dom/file/EmptyBlobImpl.h
rename : dom/file/File.cpp => dom/file/FileBlobImpl.cpp
rename : dom/file/File.h => dom/file/FileBlobImpl.h
rename : dom/file/File.cpp => dom/file/MemoryBlobImpl.cpp
rename : dom/file/File.h => dom/file/MemoryBlobImpl.h
rename : dom/file/File.cpp => dom/file/StreamBlobImpl.cpp
rename : dom/file/File.h => dom/file/StreamBlobImpl.h
rename : dom/file/File.h => dom/file/StringBlobImpl.h
rename : dom/file/File.h => dom/file/TemporaryBlobImpl.h
2017-02-16 18:26:38 +01:00
Bill McCloskey
0cda76d680 Bug 1339289 - Give names to a lot of common timers (r=ehsan)
MozReview-Commit-ID: IMsv5bkyjBL
2017-02-15 12:30:01 -08:00
Andrea Marchesini
614673153f Bug 1328470 - XMLHttpRequest should reset timers when send() is executed again, r=smaug 2017-02-10 15:05:06 +01:00
Carsten "Tomcat" Book
ffe70d35b2 Merge mozilla-central to mozilla-inbound 2017-02-09 11:38:08 +01:00
Andrea Marchesini
6bce17f8b4 Bug 1337746 - XHR should cancel the nsIChannel with an error code and not with NS_OK, r=smaug 2017-02-09 10:47:43 +01:00
Tim Huang
756cf900c9 Bug 1336802 - Part 2: Updating the whole code base to make sure nsILoadInfo get null check. r=smaug
--HG--
extra : rebase_source : 22149fd540fd02119afe9fe5c9a815d01cf959c1
2017-02-07 11:49:34 +08:00
Andrea Marchesini
788b5eca61 Bug 1337016 - XHR should create a Blob in the parent process when run from a file:// URL, r=smaug 2017-02-08 14:34:42 +01:00
Jessica Jong
ed17f6c827 Bug 1316330 - Cancel delayed keypress events if last keydown was canceled. r=smaug
--HG--
extra : histedit_source : 7d2215d9c049b01b883e194e0efd0e61845223a3%2C135d6e6cef429efc19bba2c03a0f73fc6441d3a1
2017-02-03 05:16:00 -05:00
Andrea Marchesini
cbcc3bb043 Bug 1335365 - Add telemetry to see if we can remove moz-only XHR.reponseType, r=me CLOSED TREE 2017-01-31 18:06:14 +01:00
Andrea Marchesini
d4efdb7c26 Bug 1335365 - Add telemetry to see if we can remove moz-only XHR.reponseType, r=smaug, data-review=bsmedberg 2017-01-31 17:34:08 +01:00
Boris Zbarsky
334f1106d6 Bug 1333540. Common up the skippability implementations that are basically copy/pastes of the DOMEventTargetHelper one. r=smaug 2017-01-24 20:40:11 -05:00
Boris Zbarsky
28dabea2ec Bug 1332322 part 3. Rename nsWrapperCache::IsBlackAndDoesNotNeedTracing to nsWrapperCache::HasKnownLiveWrapperAndDoesNotNeedTracing. r=mccr8 2017-01-24 20:39:37 -05:00
Boris Zbarsky
cce1668e68 Bug 1332322 part 2. Rename nsWrapperCache::IsBlack to nsWrapperCache::HasKnownLiveWrapper. r=mccr8 2017-01-24 20:38:58 -05:00
Boris Zbarsky
b39cdf67a8 Bug 1332322 part 1. Add an nsWrapperCache function to mark the wrapper as 'live' for GC purposes. r=mccr8 2017-01-24 20:33:54 -05:00
Andrea Marchesini
20247bbf3f Bug 1329298 - Part 1 - Unify body extraction in Fetch/Beacon/XHR, r=smaug 2017-01-24 12:13:31 +01:00
Boris Zbarsky
ffe339f775 Bug 1330759 part 4. Change XMLHttpRequest's responseText getter to take a DOMString, not an nsAString. r=froydnj 2017-01-18 22:20:15 -05:00
Andrea Marchesini
359ae91eac Bug 1328653 - Merging all the various *OriginAttributes to just one, r=huseby 2017-01-12 17:38:48 +01:00
Thomas Wisniewski
c6aea6cc68 Bug 1329365 - Follow-up adding 201, 202, and 205 to the list of response codes which suppress XML parsing errors. r=bz 2017-01-06 23:23:56 -05:00
Thomas Nguyen
0aaea58b69 Bug 1304623 - Create a pref to control the default referrer policy - part 3. r=bkelly
MozReview-Commit-ID: 1A6IHPeNYBQ
2017-01-05 11:29:56 +08:00
Kris Maglione
d823573e34 Bug 1325158: Part 1 - Don't return error result from OnRedirectVerifyCallback. r=ehsan
MozReview-Commit-ID: Hb3I0U8kxdz

--HG--
extra : rebase_source : 447f2e11e9e3f59f984de56689681780d85b7bd3
2016-12-24 18:24:41 -08:00
Ehsan Akhgari
d67534c9f0 Bug 1320201 - When an XHR is made with an expanded principal, use the expanded principal for CORS security checks; r=bzbarsky
We should only ensure that the resulting document doesn't end up
inheriting the expanded principal.
2016-12-15 16:49:35 -05:00
Thomas Wisniewski
54ad3187aa Bug 1319744 - Ensure that progress events and corresponding LOADING readystatechanges fire as per spec. r=baku 2016-12-13 15:23:01 -05:00
Bill McCloskey
2d57ca5e03 Bug 1318506 - Label XHR timer runnables with DocGroup (r=bkelly)
MozReview-Commit-ID: LYB8LFuVs1w
2016-12-01 15:00:13 -08:00
Sebastian Hengst
4d3b3e1658 Backed out changeset 6a0c2912650a (bug 1318506) 2016-12-01 13:35:27 +01:00
Bill McCloskey
4ab3a33831 Bug 1318506 - Label XHR timer runnables with DocGroup (r=bkelly)
MozReview-Commit-ID: LYB8LFuVs1w
2016-11-30 18:01:59 -08:00
Thomas Wisniewski
d1cae84099 Bug 1311798 - Align XMLHttpRequest.abort() with the spec. r=baku
--HG--
extra : rebase_source : 29002a6d139a08b706e54dfa4c32163632455e67
2016-11-21 01:30:00 -05:00
Sebastian Hengst
0718e6147b Backed out changeset 3421c306d8cf (bug 1311798) for failing event-readystatechange-loaded.htm and unexpected passes. r=backout 2016-11-20 21:39:59 +01:00
Thomas Wisniewski
fcc3c463e9 Bug 1311798 - Align XMLHttpRequest.abort() with the spec. r=baku
--HG--
extra : rebase_source : a0b4f89c41fbb15fa7f7acd69b993d14f709863a
2016-11-20 09:32:00 -05:00
Thomas Nguyen
b169621e2e Bug 1264792 - Update request'referrer policy when redirect.r=bkelly,dragana.
MozReview-Commit-ID: 3V6W0fuRomZ

--HG--
extra : rebase_source : 4b708f9646ea42ef40c60ba0b7a86e14edf621e3
2016-11-14 15:15:32 +08:00
Shawn Huang
71456ae11e Bug 1308341 - Don't fire the progress event if the length is 0, r=baku 2016-11-08 17:45:36 +08:00
Ben Kelly
0983850a63 Bug 1303167 P6 Rename new suspend and freeze methods to final names. r=smaug 2016-10-26 10:20:16 -07:00
Ben Kelly
bf0ca72f77 Bug 1303167 P2 Use new window suspend and freeze methods. r=smaug
* * *
Bug 1303167 P2 interdiff 0001 Review feedback
2016-10-26 10:20:15 -07:00
Jon Coppeard
556585c65f Bug 1297558 - Remove explicit calls to Expose*ToActiveJS r=mccr8 2016-10-18 17:58:19 +01:00
Andrea Marchesini
9215b7b957 Bug 1307122 - Introducing a timeout for sync XHR when unload events are dispatched, r=smaug 2016-10-16 08:46:10 +02:00
Andrea Marchesini
68662fa565 Bug 1308073 - Remove app:// specific special cases in XHR, r=ehsan 2016-10-11 19:00:55 +02:00
Andrea Marchesini
9d453d6ef0 Bug 1306235 - XHR should set lengthComputable only if total value is set, r==smaug 2016-10-06 16:13:08 +02:00
Phil Ringnalda
6a7decdac1 Backed out changeset cf588a950083 (bug 1306235) for failures in at least test_xhr_progressevents.html and test_blobconstructor.html
MozReview-Commit-ID: HJlw9w1quhu
2016-10-03 23:30:44 -07:00
Andrea Marchesini
6e5e949e82 Bug 1306235 - XHR should set lengthComputable only if total value is set, r=wisniewskit, r=smaug 2016-10-04 07:31:26 +02:00
Andrea Marchesini
c69e585e9c Bug 1202006 - Memory Blob to Temporary File - part 4 - Temporary File, r=smaug 2016-09-29 07:12:56 +02:00
Andrea Marchesini
e089417459 Bug 1202006 - Memory Blob to Temporary File - part 3 - BlobSet and MutableBlobStorage for XHR, r=smaug 2016-09-29 07:12:37 +02:00
Andrea Marchesini
5ab2cd6e5c Bug 1202006 - Memory Blob to Temporary File - part 1 - MutableBlobStorage for XHR, r=smaug
--HG--
rename : dom/base/BlobSet.cpp => dom/base/MutableBlobStorage.cpp
rename : dom/base/BlobSet.h => dom/base/MutableBlobStorage.h
2016-09-29 07:12:00 +02:00
Thomas Wisniewski
c190891418 Bug 1303121 - Do not fire one last progress event on XHR errors, to match a spec change. r=annevk
--HG--
extra : rebase_source : 9a59934cfe8fc7f2ee8ef7788813f97e2355ce2a
2016-09-28 13:05:32 -04:00