Commit graph

144 commits

Author SHA1 Message Date
Drew Willcoxon
d07b49ff57 Bug 1292573 - Broken keyboard interaction with the subview in the Downloads Panel. r=Paolo
MozReview-Commit-ID: 3jiqzlzLuWM

--HG--
extra : rebase_source : 46560a17b66d8ddff04795422a7c9a1a3bf6471a
2016-08-26 09:59:11 -07:00
Drew Willcoxon
1a22b3ba23 Bug 1292566 - The "open" button in the subview for uncommon and potentially unwanted downloads should not ask for confirmation. r=Paolo
MozReview-Commit-ID: AVDyaQSbriX

--HG--
extra : rebase_source : 1e151511068dc708e27f60216b6b055a90d72ef9
2016-08-24 17:56:44 -07:00
Sean Lee
ab824e0228 Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel., r=Paolo
MozReview-Commit-ID: ArmPPgLABtA

--HG--
extra : rebase_source : 8a15572df32954306b8484dbe3bf7be0c077b88e
2016-08-22 18:44:24 +08:00
Sean Lee
9b70990ee3 Bug 1269962 - Implement a popup menu for showing a submenu in Downloads Panel Footer., r=Paolo
MozReview-Commit-ID: 7K1W15039W8

--HG--
extra : rebase_source : 01b66909876cb22ea8442d037ebd8b8f3f5748ec
2016-07-13 13:39:00 +08:00
Drew Willcoxon
a21a61d78d Bug 1287914 - Buttons in sliding panel overlay are not clickable. r=jaws
MozReview-Commit-ID: 91yoPxiMIy8
2016-07-28 11:51:53 -07:00
Drew Willcoxon
01dbcb42ca Bug 1280709 - Downloads panel's "Show All Downloads" menu item is no longer clickable below its text label. r=gijs
MozReview-Commit-ID: HgTiDObq2JU

--HG--
extra : rebase_source : 546203ad5f899d66eab70dd7b86cd2a90c124978
2016-07-25 12:25:52 -07:00
Drew Willcoxon
05d0f2d0ee Bug 1252509 - Use a sliding panel overlay from the downloads panel to display the available actions. r=jaws
MozReview-Commit-ID: FhRlxcPeWu3
2016-06-10 22:08:59 -07:00
Paolo Amadini
f13e54ad79 Bug 1265387 - The default action for uncommon downloads should open the file directly. r=past
MozReview-Commit-ID: GrZev8J5MRN

--HG--
extra : rebase_source : 4f30d59be56c51801f42f9222a35dc86def9c819
2016-04-20 15:44:38 +01:00
Paolo Amadini
e0a1fb4878 Bug 1198181 - Part 5 - Change the unblock dialog actions based on the verdict. r=past
MozReview-Commit-ID: 3NkvpI9EqpB

--HG--
extra : rebase_source : 029bde9cc35128aea9c2fd61ab1d42b27ad78822
2016-04-20 11:16:00 +01:00
Paolo Amadini
916f990002 Bug 1198181 - Part 2 - Unify the code that updates the state of download items. r=jaws
MozReview-Commit-ID: KptYcAGbMG2

--HG--
extra : rebase_source : dadc1863d877de730107b12ff063c8695cf8c90d
2016-04-15 15:37:22 +01:00
Paolo Amadini
44ddde4b6e Bug 1254100 - Part 2 - Downloads blocked by Application Reputation should provide information about the verdict. r=mak
MozReview-Commit-ID: FYH5Tdtbzn

--HG--
extra : rebase_source : a59e79ac247d5f6d039d25f6ee6aea6cf2b5dbe6
2016-03-16 14:29:23 +00:00
Paolo Amadini
0fec3e127c Bug 1117145 - Part 5 - Share the implementation of some of the download item commands. r=jaws
MozReview-Commit-ID: La6km3izidY

--HG--
extra : rebase_source : 6cbd26296b0943e347fd71b263ce2a4dacb9115c
2016-02-14 17:28:12 +00:00
Paolo Amadini
f5f432c4df Bug 1117145 - Part 4 - Unify how commands are handled in the Downloads Panel and the Library. r=jaws
MozReview-Commit-ID: 2Irgwu5YI72

--HG--
extra : rebase_source : d1da32b41a36f383cc76039934ae022742a29840
2016-02-29 15:50:57 +00:00
Paolo Amadini
42971bb248 Bug 1117145 - Part 2 - Unify DownloadsViewItem and DownloadsViewItemController. r=jaws
MozReview-Commit-ID: 8qcV5Y7t1hM

--HG--
extra : rebase_source : a49dff2db7f5c89f1fa2851416cf122b1fb484c0
2016-02-10 14:54:24 +00:00
Dave Townsend
2438882fb4 Bug 1229224: Fix linting for some browser files that tests depend on. r=felipe
--HG--
extra : commitid : 63xJ7CuQ3vP
extra : rebase_source : 5bb977edee31a299d13ef82acdebb9fe6808f8fa
2015-12-17 15:19:00 -08:00
Carsten "Tomcat" Book
08997000eb Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00
Sebastian Hengst
cdcff6d0a7 Backed out changeset c6b267589d0d (bug 1202902) for Mulet Reftest, W3C Platform Test and other failures. r=backout a=backout on a CLOSED TREE 2015-10-07 13:36:26 +02:00
Shu-yu Guo
52e365bb7b Bug 1202902 - Fix the world. (r=ato for marionette, rs=Mossop for rest) 2015-10-06 14:00:30 -07:00
Tooru Fujisawa
e3e8c7540e Bug 1207491 - Part 6: Remove use of expression closure from browser/components/downloads/. r=Gijs
--HG--
extra : commitid : 8BIIBSCXIf9
extra : rebase_source : cca677e0c83e99cca719f5b6f794060fa0144205
2015-09-23 18:36:20 +09:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Nazim Can Altinova
5483bf7f34 Bug 1198235 - abuse of bind(this) with add/removeEventListener in downloads.js. r=mak 2015-08-31 14:04:00 +02:00
Birunthan Mohanathas
3ffa8d565d Bug 1166840 - Remove unused document argument in uses of nsIClipboardHelper.copyString. r=ehsan 2015-05-21 21:49:30 +01:00
Bill McCloskey
2cbf53b22f Bug 1145394 - Remove exec bit on js files (r=fabrice,gavin) 2015-03-20 11:57:38 -07:00
Jared Wein
2d7032360c Bug 1137909 - part 2: context menuitem to unblock downloads and an X button to confirm the blocked download. r=paolo
--HG--
extra : rebase_source : 5c72469031f9d452c9fc4b579c8e4cb2a7099f88
2015-03-05 12:25:45 -05:00
Paolo Amadini
7de2b29a33 Bug 1137996 - Can't drag items from downloads panel. r=mak 2015-03-03 10:23:12 +00:00
Marco Bonardo
448c1ef44d Bug 1135348 - Fix about:downloads by adding missing XPCOMUtils imports. r=paolo 2015-02-26 19:06:15 +01:00
Paolo Amadini
cd4b3c7397 Bug 1129896 - Part 2 of 2 - Convert the shared front-end code to a JavaScript code module. r=mak
--HG--
rename : browser/components/downloads/content/downloadsViewCommon.js => browser/components/downloads/DownloadsViewUI.jsm
2015-02-16 18:49:56 +00:00
Paolo Amadini
6e91f09568 Bug 1127867 - Use the new back-end property to get the size of downloads asynchronously. r=mak 2015-02-16 18:49:52 +00:00
Paolo Amadini
69d94e3fbd Bug 1117141 - Part 2 of 2 - Refactor notifications and remove the DownloadsDataItem object. r=mak 2015-02-16 18:49:51 +00:00
Paolo Amadini
797528c9fe Bug 1117141 - Part 1 of 2 - Bypass all the DownloadsDataItem properties. r=mak 2015-02-16 18:49:49 +00:00
Paolo Amadini
91501caee2 Bug 1117139 - Move code controlling the "download.xml" binding to a common place. r=mak 2015-02-16 18:49:47 +00:00
Paolo Amadini
1f1b323a7d Bug 1116176 - Create DownloadsHistoryDataItem and HistoryDownload objects. r=mak 2015-02-16 18:49:46 +00:00
Paolo Amadini
63cb33d173 Bug 1115983 - Keep only minimal state information in the DataItem. r=mak 2015-02-16 18:49:44 +00:00
Paolo Amadini
a541c7a926 Bug 1115379 - Streamline DownloadsViewItemController construction and remove now unneeded identifiers. r=mak 2015-01-14 17:30:27 +00:00
Paolo Amadini
d5519cad10 Bug 1115369 - Use notifications instead of getViewItem for DownloadsView. r=mak 2015-01-14 17:30:27 +00:00
Paolo Amadini
d4c5c8ca0b Bug 1115364 - Downloads Panel code style refresh. r=jaws 2014-12-29 12:35:27 +00:00
Ed Morley
18a50dd690 Bug 577266 - Correct another handful of incorrect spellings 2014-08-13 09:04:36 +01:00
Jim Blandy
7e20285e70 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Masayuki Nakano
a183cc5385 Bug 969247 part.1 Remove or replace DOM_VK_ENTER and NS_VK_ENTER users r=smaug 2014-02-15 09:57:39 +09:00
Marco Bonardo
3a79e9b75a Bug 945707 - Pausing a download fails when done after a retry. r=paolo 2014-01-29 17:00:17 -05:00
Matthew Noorenberghe
be474fa47a Merge mozilla-central to UX 2013-11-05 01:04:20 -08:00
Paolo Amadini
147dff90bb Bug 899110 - Remove the code to switch between different back-ends from the Downloads Panel. r=enn 2013-11-04 19:21:13 +01:00
Gijs Kruitbosch
aeaa73f245 Merge m-c to UX 2013-09-18 10:31:05 +02:00
Paolo Amadini
d201131137 Bug 910236 - The Downloads Panel shows one extra download for the number in "+ X other downloads". r=enn 2013-09-17 19:37:00 +02:00
Gijs Kruitbosch
1ea72c3a1a Merge mozilla-central and ux 2013-09-10 16:46:22 +02:00
Neil Deakin
c3c6d3fde3 Bug 907062, resolve the promise if the popup is already open so that the test doesn't occasionally fail, r=paolo 2013-09-09 20:13:58 -04:00
Gijs Kruitbosch
27fc510686 Merge m-c to ux 2013-08-20 10:49:07 +02:00
Paolo Amadini
3e8d68c340 Bug 906314 - Allow using the JavaScript API instead of nsIDownloadManager when removing finished downloads. r=enn 2013-08-19 17:18:25 +02:00
Mike Conley
2402dc3ea1 Bug 885452 - Remove retrieveToolbarIconsizesFromTheme now that we only support one icon size. r=jaws. 2013-06-28 17:04:50 -04:00
Paolo Amadini
fedd338868 Bug 832672 - Downloads Panel gives no indication or feedback on missing files. r=mak ui-r=shorlander 2013-04-24 02:19:49 +02:00
Marco Bonardo
0e69d13800 Bug 851519 - Keyboard commands may executed on the wrong download in the panel
r=Mano
2013-04-17 16:16:09 +02:00
Asaf Romano
3b829dd6ba Bug 842553 - Double clicking an in-progress download in the Library opens its containing folder. r=mak 2013-03-06 11:43:28 +02:00
Christian Sonne
371159a109 Bug 816254 - Add logging to Downloads Panel r=mak 2013-02-15 17:34:18 -08:00
Owen Coutts
390fe1595a Bug 808054 - Don't anchor the Downloads Panel to the tabs toolbar. r=mconley 2013-01-23 18:08:15 -05:00
Mike Conley
13653a16e1 Bug 819428 - Re-jig keyboard navigation for the Downloads Panel. r=mak. 2013-01-14 12:59:40 -05:00
Asaf Romano
a5af73a11c Bug 828243 - Cleanup wasDone, wasInProgress and endTime usage. r=mak 2013-01-09 14:45:08 +02:00
Marco Bonardo
a18c0101df Bug 822689 - Nothing happens when clicking on a compete download in the Downloads Panel.
r=mconley
2012-12-18 18:02:03 +01:00
Mike Conley
f4ac3e2509 Bug 817006 - "Remove from List" option in the Downloads Panel should be clarified as "Remove from History". r=mak. 2012-12-14 12:51:52 -05:00
Asaf Romano
26944959a9 Relanding Bug 675902 - New Downloads view for Places Library. r=mak. Test fix contributed by Mike Conley (r=me). The new view is still disabled. 2012-12-17 07:38:53 +00:00
Boris Zbarsky
9c8dded539 Back out bug 675902 (rev 627a842914d0) from CLOSED TREE because it fails browser-chrome tests. 2012-12-14 16:48:49 -05:00
Boris Zbarsky
d3e8d43ce8 Back out bug 817006 (rev 0852e5efadac) because it depends on a patch I'm about to back out for test failures. 2012-12-14 16:46:51 -05:00
Mike Conley
7ec731ed6c Bug 817006 - "Remove from List" option in the Downloads Panel should be clarified as "Remove from History". r=mak. 2012-12-14 12:51:52 -05:00
Asaf Romano
7a4f22fecb Bug 675902 - Implement the new Downloads view for the places Library window; r=mak 2012-12-14 12:32:20 -05:00
Ehsan Akhgari
e511b0e504 Bug 801232 - Add support for the downloads panel in per-window private browsing builds; r=mak 2012-12-05 22:31:26 -05:00
Ehsan Akhgari
e248c72e5e Backed out changeset ea20935fa19d (bug 801232) because of leaks 2012-12-06 15:52:30 -05:00
Ehsan Akhgari
08fe432eb6 Bug 801232 - Add support for the downloads panel in per-window private browsing builds; r=mak 2012-12-05 22:31:26 -05:00
Ehsan Akhgari
bf3f7c8da2 Backed out changeset 31d5dca2a3b4 (bug 801232) because of leaks 2012-12-06 14:01:35 -05:00
Ehsan Akhgari
9360dba19d Bug 801232 - Add support for the downloads panel in per-window private browsing builds; r=mak 2012-12-05 22:31:26 -05:00
Mike Conley
bfacfd2dab Bug 814961 - Hide the summary in the Downloads Panel if there are no hidden downloads in progress or paused. r=mak. 2012-12-05 12:12:00 -05:00
Mike Conley
68a44ae3b3 Bug 815941 - Remove the usages of nsIDownload.id and nsIDownloadManager.getDownload from the downloads panel code. Code started by ehsan. feedback=paolo, r=mak. 2012-11-30 22:37:48 -05:00
Mike Conley
9c09856253 Bug 815273 - Don't force focus the Downloads Panel "Show all downloads" button when opening the panel. r=mak. 2012-11-28 11:10:57 -05:00
Mike Conley
07911c72d9 Bug 809852 - Allow cycling through the "Show all downloads" and summary footers in the Downloads Panel using the arrow keys. r=mak. 2012-11-22 14:38:38 -05:00
Mike Conley
9108fa7ad5 Bug 808277 - Show the progress of downloads that are not visible in the Downloads Panel in a summary. r=mak. 2012-11-16 16:19:45 -05:00
Ryan VanderMeulen
2006509e4a Backed out changesets c2ea3fb28c45 (bug 812343), 68e26307643e (bug 812345), 15eaadc2cd9a (bug 811076), and 5a98a1662e64 (bug 808277) for mochitest-1 failures.
CLOSED TREE
2012-11-16 17:57:44 -05:00
Mike Conley
25eb07c6c1 Bug 808277 - Show the progress of downloads that are not visible in the Downloads Panel in a summary. r=mak. 2012-11-16 16:19:45 -05:00
Mike Conley
22fef0fa74 Bug 766654 - Allow pasting of a URL into the Downloads Panel to initiate a download. r=mak. 2012-11-13 14:46:56 -05:00
Mike Conley
9cfdc25e3c Bug 759397 - Remove per-item download rate clutter from Downloads Panel. r=mak. 2012-11-06 13:21:50 -05:00
Mike Conley
4b77f24cd4 Bug 807709 - Downloads Panel does not always close when handing off operations to the OS. r=mak. 2012-11-06 13:21:50 -05:00
Mike Conley
581b505894 Bug 786662 - Open Containing Folder in context menu for Download Panel item is always disabled after pause. r=mak. 2012-10-31 10:07:44 -04:00
Jan Horak
0945a39988 Bug 567377 - Support drag and drop for Linux. r=mak77 2012-10-25 17:43:24 -04:00
Mike Conley
b61f1894a8 Bug 773267 - The Downloads Panel flickers at the top left of the screen before anchoring to the Downloads button. r=mak77, f=paolo. 2012-10-09 13:45:51 -04:00
Paolo Amadini
c9b3789953 Bug 748160 - Update the Downloads command to open the Downloads view instead of the Downloads Panel. r=mak 2012-08-25 11:37:55 +02:00
Paolo Amadini
bdb0c7be1c Bug 747903 - Limit the number of items in the Downloads Panel. r=mano 2012-08-25 11:37:55 +02:00
Paolo Amadini
28104186ba Bug 760607 - Update the Downloads Panel visual design. r=mak 2012-08-25 11:37:55 +02:00
Ehsan Akhgari
f4b598bf08 Bug 722872 - Part 1: Add nsITransferable::Init(nsILoadContext*), enforce that it's called in debug builds, and add nsIDOMDocument* arguments to nsIClipboardHelper methods; r=roc
This patch does the following:

* It adds nsITransferable::Init(nsILoadContext*).  The load context
  might be null, which means that the transferable is non-private, but
  if it's non-null, we extract the boolean value for the privacy mode
  and store it in the transferable.
* It adds checks in debug builds to make sure that Init is always
  called, in form of fatal assertions.
* It adds nsIDOMDocument* agruments to nsIClipboardHelper methods which
  represent the document that the string is coming from.
  nsIClipboardHelper implementation internally gets the nsILoadContext
  from that and passes it on to the transferable upon creation.  The
  reason that I did this was that nsIClipboardHelper is supposed to be a
  high-level helper, and in most of its call sites, we have easy access
  to a document object.
* It modifies all of the call sites of the above interfaces according to
  this change.
* It adds a GetLoadContext helper to nsIDocument to help with changing
  the call sites.
2012-04-16 22:14:01 -04:00
Dão Gottwald
0d8fc08142 Bug 767813 - Set the consumeoutsideclicks attribute on panels instead of calling popupBoxObject.setConsumeRollupEvent. r=enndeakin 2012-06-24 22:30:59 +02:00
Ryan VanderMeulen
84292006a9 Backout e8a507a0a1a8 (bug 767813) due to mochitest-browser-chrome orange. 2012-06-24 16:27:20 -04:00
Dão Gottwald
907d3a4738 Bug 767813 - Set the consumeoutsideclicks attribute on panels instead of calling popupBoxObject.setConsumeRollupEvent. r=enndeakin 2012-06-24 19:44:04 +02:00
Ryan VanderMeulen
d2dae13c09 Backout 70e3a2c8c6b4 (Bug 767133) due to mochitest-other orange. 2012-06-22 18:12:54 -04:00
Dão Gottwald
bdeaa55387 Bug 767133 - Add slide-in animation for arrow panels. r=enndeakin ui-r=shorlander
--HG--
extra : rebase_source : ab38e90e42a6bf45c4152b4960db8f4a8ba14ec0
2012-06-22 22:13:21 +02:00
Paolo Amadini
695359ee3c Bug 746787 - Ensure the browser window is not minimized when opening the Downloads panel. r=mak 2012-04-27 15:05:04 +02:00
Paolo Amadini
9180b309a7 Bug 726444 - Implement the Downloads Panel. r=mak ui-r=limi
Includes: Bug 697679 - By Javi Rueda <leofigueres@yahoo.com>.
2012-04-17 13:35:09 +02:00
Ed Morley
f6653e490a Backout ba7da6256b23 (bug 726444) for talos regressions; a=mak 2012-03-11 23:38:53 +00:00
Paolo Amadini
749f7c69ab Bug 726444 - Implement the Downloads Panel. r=mak ui-r=limi
Includes: Bug 697679 - By Javi Rueda <leofigueres@yahoo.com>.
2012-03-10 15:00:45 +01:00