Commit graph

1 commit

Author SHA1 Message Date
Gijs Kruitbosch
5169d79e96 Bug 1518500 - ensure we don't end up without a flexible space if moving items directly to toolbars, r=dao
Before this patch, we change aDraggedItemId somewhat late in the _applyDrop method -
significantly, we do this after the aTargetNode == areaCustomizationTarget check. So
we end up bailing out before adjusting aDraggedItemId, and we add the specific dummy
item from the palette into the toolbar, rather than adding a new spring to the
toolbar, and leaving the existing palette item alone.

Simply moving this adjustment to aDraggedItemId earlier into the method is sufficient
to fix the issue at hand.

Differential Revision: https://phabricator.services.mozilla.com/D62948

--HG--
extra : moz-landing-system : lando
2020-02-17 15:43:32 +00:00