Commit graph

245 commits

Author SHA1 Message Date
Gijs Kruitbosch
cd50b177a7 Bug 1711523 - remove private proton tracking flags in frontend modules, r=mak,emalysz,desktop-theme-reviewers,harry
Differential Revision: https://phabricator.services.mozilla.com/D116009
2021-05-28 19:33:38 +00:00
Bernard Igiri
ca8345555c Bug 1705500 - Added word wrap to send tab to another device menu r=mconley
Modified toolbaritem for the send tab to another device menu item to wrap text and align icon at the top of the button.

Differential Revision: https://phabricator.services.mozilla.com/D115657
2021-05-21 16:30:21 +00:00
Mike Conley
4ad0c866de Bug 1703494 - Use CSS box for FxA CTA item to avoid need for descriptionHeightWorkaround. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D114770
2021-05-10 23:49:55 +00:00
Gijs Kruitbosch
1ea987eb07 Bug 1704483 - improve a11y labeling of disconnected/errored account item in the hamburger menu, r=morgan
The full text is split into 2 labels, one describing state and one containing the e-mail address.
To sighted users, both are visible. When this happens, let's use aria-labelledby to ensure both
labels are associated with the button control, so that both are read by screenreaders.

In the signed in and signed out state, the label is already correct (and either doesn't include
an email address, or doesn't include anything *but* the email address).

Note that in non-proton, the only label (both visible and otherwise) is the
state (the e-mail is not shown/used).

Differential Revision: https://phabricator.services.mozilla.com/D113657
2021-04-28 18:27:47 +00:00
Mark Striemer
da9122c7bc Bug 1701544 - Show Sent! confirmation when sending a tab to a device r=harry,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D113047
2021-04-22 17:59:10 +00:00
Emma Malysz
b32b6f3de8 Bug 1706460: update fxa disconnected string r=mhowell,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D112838
2021-04-21 16:40:13 +00:00
Vijay Budhram
6ebff066e9 Bug 1701529 - Remove unused FxA toolbar menu items r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D111303
2021-04-09 19:08:03 +00:00
Harry Twyford
5e9bbf7a17 Bug 1703838 - Stop triggering a ConfirmationHint when a tab is sent to a device. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D111327
2021-04-09 07:46:31 +00:00
Molly Howell
dd708f55d8 Bug 1703239 - Expose the accounts error messages in the app menu to screen readers. r=emalysz
The Proton app menu version of the accounts button doesn't need the button
label attribute for display purposes, but if the attribute isn't updated when
an error happens, then accessibility tools only ever see the "Sign in" text.

Differential Revision: https://phabricator.services.mozilla.com/D111183
2021-04-08 16:56:20 +00:00
Emma Malysz
fb284a526f Bug 1702461, set fxa submenu header correctly when opening the panel r=mconley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D110633
2021-04-02 15:27:01 +00:00
Emma Malysz
caad0a1fe9 Bug 1698062: set app menu width and ensure text can wrap r=fluent-reviewers,mconley,flod
Differential Revision: https://phabricator.services.mozilla.com/D110461
2021-04-01 14:58:05 +00:00
Francesco Lodolo (:flod)
e258e49a03 Bug 1700638 - Remove Sync brand from Sync dialogs and sidebar, App menu and FxA menu, r=mconley,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D110013
2021-03-30 14:30:55 +00:00
Emma Malysz
e5104deb98 Bug 1700993, adjust app menu fxa button for different states. r=fluent-reviewers,flod,markh
This patch:
-displays the correct fxa button in the app menu when
unverified or disconnected
-shows the "sign out" button in the fxa panel for the above states
-introduces a new string for a disconnected state
-strengthens our test coverage for the proton fxa panel

Differential Revision: https://phabricator.services.mozilla.com/D109802
2021-03-29 15:05:23 +00:00
Emma Malysz
5916067531 Bug 1700431: take syncing state into account when setting datal10nid for sync now buttons r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D109540
2021-03-24 17:02:29 +00:00
Emma Malysz
9a844ca5d2 Bug 1697659, remove chevron from fxa sign in button r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D109109
2021-03-22 15:03:43 +00:00
Molly Howell
ce9daf2f2a Bug 1695792 - Update copy for accounts error notifications. r=mconley,fluent-reviewers
Also take the opportunity to convert these two strings to Fluent,
since we're changing the text here anyway.

Differential Revision: https://phabricator.services.mozilla.com/D108530
2021-03-18 21:45:09 +00:00
Sam Foster
6ba985b5a8 Bug 1690567 - Hide some sync context menu items when not signed in. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D104746
2021-03-17 04:22:50 +00:00
Emma Malysz
36ce22cdc5 Bug 1698492, dynamically set data-l10n-id attribute for sync now buttons when panel views are showing r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D108506
2021-03-16 20:24:29 +00:00
Emma Malysz
e3585b8a9e Bug 1698024, reintroduce 'Send to All Devices' and 'Manage Devices' buttons in app menu and context menu r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D108231
2021-03-15 17:42:59 +00:00
Cosmin Sabou
521bcd8985 Backed out changeset 59f02c384ab7 (bug 1698024) for bc failures on browser_page_action_menu.js. CLOSED TREE 2021-03-15 18:29:36 +02:00
Emma Malysz
a6a1bc2839 Bug 1698024, reintroduce 'Send to All Devices' and 'Manage Devices' buttons in app menu and context menu r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D108231
2021-03-15 14:58:16 +00:00
Doug Thayer
fc47f797f9 Bug 1693052 - Update fxa signout dialog r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D108225
2021-03-13 03:05:17 +00:00
Emma Malysz
6e4c1b1588 Bug 1694678: update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality

Differential Revision: https://phabricator.services.mozilla.com/D106651
2021-03-12 21:41:46 +00:00
Neil Deakin
0a6f2c6e96 Bug 1691860, move code that hides separators in the content area context menu into a single place that just hides duplicates, r=Gijs,robwu
Differential Revision: https://phabricator.services.mozilla.com/D104615
2021-03-04 00:16:16 +00:00
Csoregi Natalia
f8043879e3 Backed out changeset 44ff4cb38ce1 (bug 1694678) for failures on browser_sync.js. CLOSED TREE 2021-03-03 09:56:35 +02:00
Emma Malysz
bfd4f5a6d1 Bug 1694678: update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality

Differential Revision: https://phabricator.services.mozilla.com/D106651
2021-03-03 06:52:10 +00:00
Mihai Alexandru Michis
1c9566c96e Backed out changeset 7692908f97e7 (bug 1694678) for causing bc failures in browser_sync.js
CLOSED TREE
2021-03-02 19:56:17 +02:00
Emma Malysz
4d02027b4d Bug 1694678: update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality

Differential Revision: https://phabricator.services.mozilla.com/D106651
2021-03-02 16:02:35 +00:00
Emma Malysz
0df0408e17 Bug 1695697, update show more button label in remote tabs panels r=mconley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D106804
2021-03-01 18:39:22 +00:00
Emma Malysz
417b5880d4 Bug 1695264, display sync settings in fxa panel only when more than 1 device is connected r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D106654
2021-03-01 16:04:17 +00:00
Butkovits Atila
8ed8707b3d Backed out changeset 962540b712f9 (bug 1694678) for causing failure at browser_sync.js. CLOSED TREE 2021-02-27 05:05:08 +02:00
Emma Malysz
cc6a25c9cc Bug 1694678: update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality

Differential Revision: https://phabricator.services.mozilla.com/D106651
2021-02-27 01:16:40 +00:00
Mike Conley
0d520cb3fb Bug 1693851 - Fix browser_sync.js tests when Proton AppMenu is enabled. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D106380
2021-02-25 23:43:07 +00:00
Micah Tigley
78b48e4781 Bug 1690569 - Replace sync's isSendableURI checks with BrowserUtils.isShareableURL. r=markh
Depends on D104558

Differential Revision: https://phabricator.services.mozilla.com/D105640
2021-02-25 02:51:04 +00:00
Emma Malysz
fc2ffae60a Bug 1694650, update fxa avatar when proton is enable r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D106320
2021-02-24 21:28:33 +00:00
Mike Conley
344a56022e Bug 1693177 - Apply Proton stylings to Firefox Accounts menu and surroundings. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D105697
2021-02-24 03:01:51 +00:00
Dorel Luca
df1d85fc90 Backed out 2 changesets (bug 1688960, bug 1693177) for Browser-chrome failures in browser/base/content/test/sync/browser_sync.js. CLOSED TREE
Backed out changeset 13e08408add0 (bug 1693177)
Backed out changeset a34474998cd6 (bug 1688960)
2021-02-24 03:36:21 +02:00
Mike Conley
348076c2de Bug 1693177 - Apply Proton stylings to Firefox Accounts menu and surroundings. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D105697
2021-02-23 23:16:12 +00:00
Emma Malysz
38dfb59850 Bug 1690131: create proton-specific fxa menu r=mconley,markh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D104937
2021-02-23 15:37:12 +00:00
james
16060f0cc4 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 23:33:51 +00:00
Narcis Beleuzu
ed6880e281 Backed out changeset b3fcb4fcea64 (bug 1691274) for bc failures on browser_pointerlock_warning.js . CLOSED TREE 2021-02-13 21:46:51 +02:00
james
8069ab6165 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 18:11:18 +00:00
Emma Malysz
0b31b064f0 Bug 1662183, hide fxa button from main menu when identity.fxaccounts.enabled is false r=Gijs,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D88946
2020-09-08 14:44:19 +00:00
Razvan Maries
83f4507fd3 Backed out changeset c0e35053e222 (bug 1662183) for perma failures on browser_contextmenu_sendtab.js. CLOSED TREE 2020-09-02 09:45:59 +03:00
Emma Malysz
97bb860597 Bug 1662183, hide fxa button from main menu when identity.fxaccounts.enabled is false r=Gijs,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D88946
2020-09-02 04:18:01 +00:00
Edouard Oger
6fe4fd09b5 Bug 1661475 - Add a "Manage devices" item to the Send Tab menu. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D88420
2020-08-27 21:50:46 +00:00
lougeniac64
16418eddeb Bug 1657463 - Allow users to delete their data when signing out r=markh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D86065
2020-08-19 04:55:51 +00:00
Emma Malysz
3123c7867e Bug 1634030: lazify main app menu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D84014
2020-08-10 17:09:55 +00:00
Butkovits Atila
996e816c65 Backed out changeset e71e10688704 (bug 1634030) for failure at browser_shim_disable_devtools.js CLOSED TREE 2020-08-08 03:46:14 +03:00
Emma Malysz
77f8ca0ed1 Bug 1634030: lazify main app menu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D84014
2020-08-07 22:02:32 +00:00