Commit graph

3592 commits

Author SHA1 Message Date
Silke Hofmann
4650ab077c Bug 1481470 - Stop using xlink:href in SVG in browser/. r=nhnt11,desktop-theme-reviewers,harry
Differential Revision: https://phabricator.services.mozilla.com/D117204
2021-06-13 19:01:19 +00:00
Butkovits Atila
a4246aecb0 Backed out changeset c99bb7d3308e (bug 1699794) for causing Mochitest failures in browser_anti_clickjacking.js. CLOSED TREE 2021-06-12 02:41:21 +03:00
owlishDeveloper
001ef39fb7 Bug 1699794 - [2.0] Add address autocomplete tests r=geckoview-reviewers,agi
Depends on D109139

Differential Revision: https://phabricator.services.mozilla.com/D109137
2021-06-11 21:41:09 +00:00
Ed Lee
9930a18c9b Bug 1633883 - TelemetryTestUtils.assertScalar assumes Number (so behaves odd for boolean, strings) r=chutten
Split assertScalar to assertScalarUnset to allow the former to plain check the value including strings, false and 0.

Differential Revision: https://phabricator.services.mozilla.com/D117457
2021-06-11 21:06:26 +00:00
Kajal Sah
4cadce4f26 Bug 1710635 - Adds capture visible view port using Save visible. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D116405
2021-06-09 17:45:27 +00:00
Thomas Wisniewski
6cd599c6fa Bug 1714407 - fix a regression caused by bug 1714407 where SmartBlock does not always properly inform the anti-tracking UI when users opt into allowing specific content; r=pbz,ksenia,webcompat-reviewers
Three changes here:
- fix the experimental API to check for the "allow" case first, then the "replace" signal
- update the JSON config for the two opt-in shims so they know to also mark the relevant requests as allowed, not just replaced/shimmed
- remove a pointless (unused) unblocksOnOptIn line

Differential Revision: https://phabricator.services.mozilla.com/D116756
2021-06-03 19:18:25 +00:00
Sam Foster
76d166f883 Bug 1682634 - Add a mochitest-chrome test for the screenshot flow and result dimensions. r=emalysz
* Some helpers and a basic test for full page and visible page screenshots, using the clipboard to examine the result
* The visible page test's assertions are marked todo, as we don't actually get the expected image dimensions currently. This is possibly bug 1711101?

Differential Revision: https://phabricator.services.mozilla.com/D99854
2021-06-03 05:30:30 +00:00
Brindusan Cristian
57be0e57c8 Backed out changeset 64e8532c9a0b (bug 1682634) for causing bc failures in browser_screenshots_dimensions.js. CLOSED TREE 2021-06-03 03:14:56 +03:00
Sam Foster
e1641e46b7 Bug 1682634 - Add a mochitest-chrome test for the screenshot flow and result dimensions. r=emalysz
* Some helpers and a basic test for full page and visible page screenshots, using the clipboard to examine the result
* The visible page test's assertions are marked todo, as we don't actually get the expected image dimensions currently. This is possibly bug 1711101?

Differential Revision: https://phabricator.services.mozilla.com/D99854
2021-06-02 22:52:04 +00:00
Thomas Wisniewski
b97066dd63 Bug 1714180 - fix a logic flaw in SmartBlock which makes it more permissive than necessary; r=denschub,webcompat-reviewers
The bug in question is that if a user opts into allowing one tracker on a given
site for the session, new visits to that site will allow others trackers as
well, not just the expected one.

While we're here, we also improve the web console messages to show the same
"allowing X due to opt in" message on new visits as well, not just the original
one where the user initially opted-in for that shim.

We might as well also land bug 1712959 into m-c, rather than waiting for the
next webcompat release cycle.

Differential Revision: https://phabricator.services.mozilla.com/D116642
2021-06-02 20:10:52 +00:00
Andrew Halberstadt
f84d5f3016 Bug 1694824 - [ci] Annotate browser-chrome manifests for new fission failures, r=jmaher,extension-reviewers,preferences-reviewers,zombie
Differential Revision: https://phabricator.services.mozilla.com/D116276
2021-06-02 19:22:25 +00:00
Neil Deakin
a096495c54 Bug 1600059, remove some usages of waitForCondition in formautofill tests and replace with waitForMutationCondition and waiting for popup event notifications in the child process to see if this fixes the intermittent failures, r=mak
This is the same issue as bug 1701078.

Differential Revision: https://phabricator.services.mozilla.com/D112979
2021-06-02 13:45:10 +00:00
Neil Deakin
d9f00505dd Bug 1600059, browser_autocomplete_footer.js doesn't account for collapsed items, causing it to fail when run twice or in sequence with certain other tests, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D112978
2021-06-02 13:45:10 +00:00
Thomas Wisniewski
011dbf08d8 Bug 1713635 - Work around a lack of support for the properties parameter of browser.tabs.onUpdated in GeckoView, so the webcompat addon starts up properly there; r=denschub,webcompat-reviewers
Also put try/catch blocks around the startup sections of the various sub-components, to limit the damage if one of them throws while failing to start

Differential Revision: https://phabricator.services.mozilla.com/D116402
2021-05-31 18:06:48 +00:00
Andre Natal
760b23419b Bug 1710546 - Firefox Translations integration r=mossop,mixedpuppy,mhoye
Bundle Firefox Translation as a builtin pref'd off addon in Nightly only

Differential Revision: https://phabricator.services.mozilla.com/D114810
2021-05-28 18:38:59 +00:00
Butkovits Atila
57a0cf8d59 Backed out changeset f6aae19033a0 (bug 1710546) for causing Bug 1713225. CLOSED TREE 2021-05-28 05:56:23 +03:00
Andre Natal
7cd7fe0c60 Bug 1710546 - Firefox Translations integration r=mossop,mixedpuppy,mhoye
Bundle Firefox Translation as a builtin pref'd off addon in Nightly only

Differential Revision: https://phabricator.services.mozilla.com/D114810
2021-05-27 17:56:02 +00:00
Thomas Wisniewski
e82d19336e Bug 1707797 - Ship v23.0.0 of webcompat system addon; r=ksenia,webcompat-reviewers
This roll-up includes the following fixes:
- Bug 1711082 - Add an intervention for m.aliexpress.com
- Bug 1712807 - Add an override for www.dealnews.com
- Bug 1712833 - Add an intervention for buskocchi.desuca.co.jp
- Bug 1712843 - Add an intervention for snaptik.app
- Bug 1712626 - Change CSS intervention for livescience.com
- Bug 1710993 - Remove Intervention for dev.to
- Bug 1710997 - Remove Intervention for slack.com
- Bug 1711003 - Remove Intervention for store.hp.com

Differential Revision: https://phabricator.services.mozilla.com/D116123
2021-05-27 14:34:29 +00:00
Thomas Wisniewski
7092f57bf9 Bug 1712562 - fix a perf regression on Facebook by simplifying some code in SmartBlock; r=webcompat-reviewers,denschub
This patch improves the experimental trackingProtection add-on API used by SmartBlock:
- has callers specify both which MatchPatterns to shim, and which to merely allow.
- this simplifies the related code and makes it easier to read its intent.
- this also entirely removes the need for the _ensureOptInRequestAllowedOnTab listener,
  which was causing the performance regression.

Differential Revision: https://phabricator.services.mozilla.com/D116051
2021-05-27 06:19:32 +00:00
Iulian Moraru
35bfe2ddf2 Backed out changeset c7e7bba07257 (bug 1710546) for causing bc failures on browser_all_files_referenced.js. CLOSED TREE 2021-05-27 01:11:00 +03:00
Andre Natal
cfd82965b8 Bug 1710546 - Firefox Translations integration r=mossop,mixedpuppy,mhoye
Bundle Firefox Translation as a builtin pref'd off addon in Nightly only

Differential Revision: https://phabricator.services.mozilla.com/D114810
2021-05-26 21:25:50 +00:00
Thomas Wisniewski
153e428fc6 Bug 1711361 - Have SmartBlock's Eluminate shim to treat the cmTagQueue as a no-op; r=robwu,webcompat-reviewers,ksenia
Sites appear to only ever call the cm* functions using cmTagQueue, so since
we are shimming them all as no-ops, it's safer to ignore the queue entirely.

Differential Revision: https://phabricator.services.mozilla.com/D115709
2021-05-21 20:11:54 +00:00
Thomas Wisniewski
4073372272 Bug 1709449 - Changes to the Facebook SmartBlock shim to bring it in line with phase 2 SmartBlock expectations, including relevant SmartBlock engine changes; r=denschub,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D115261
2021-05-20 16:48:52 +00:00
Emma Malysz
724d5b2206 Bug 1699410: factor in zoom value when taking a screenshot r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D109093
2021-05-13 19:07:51 +00:00
Thomas Wisniewski
7cb351d3a0 Bug 1707795 - adjust the webcompat fix to disable overscroll effects on Excel spreadsheets; r=denschub,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D114775
2021-05-10 20:33:22 +00:00
Thomas Wisniewski
8a6000b33e Bug 1707795 - add a webcompat fix to disable overscroll effects on Excel spreadsheets; r=denschub,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D114550
2021-05-07 10:06:04 +00:00
Shane Caraveo
7d11b0aa66 Bug 1687762 fix deprecated extension api use r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D111966
2021-04-30 20:31:40 +00:00
Harry Twyford
7e9451d277 Bug 1707756 - Part 2 - Update lightbulb icon. r=sfoster,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D113531
2021-04-30 20:24:33 +00:00
Cosmin Sabou
61b6535e33 Backed out 2 changesets (bug 1707756) for causing build bustages. CLOSED TREE
Backed out changeset ddfb12358dcd (bug 1707756)
Backed out changeset be804f37dfe3 (bug 1707756)
2021-04-29 19:05:09 +03:00
Harry Twyford
8a7d75009f Bug 1707756 - Part 2 - Update lightbulb icon. r=sfoster,webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D113531
2021-04-29 15:42:24 +00:00
Brindusan Cristian
5b5adab338 Bug 1705751 - Fix eslint failure in main.js. a=lint-fix CLOSED TREE 2021-04-29 01:07:09 +03:00
Falguni Islam
728a6f9073 Bug 1705751: fix Remove Buildsettings Code from Screenshots r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D112415
2021-04-28 21:44:00 +00:00
Falguni Islam
959874613b Bug 1667887: fix Remove Dead Code in HighContrastCheck in the Screenshots UI r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D112263
2021-04-28 21:41:31 +00:00
Cosmin Sabou
e3f5ad16b5 Backed out 2 changesets (bug 1600059) for bc failures on browser_autocomplete_footer.js. CLOSED TREE
Backed out changeset 6e03b1a45863 (bug 1600059)
Backed out changeset 9a742ac1be88 (bug 1600059)
2021-04-26 23:24:18 +03:00
Neil Deakin
513e659b72 Bug 1600059, remove some usages of waitForCondition in formautofill tests and replace with waitForMutationCondition and waiting for popup event notifications in the child process to see if this fixes the intermittent failures, r=mak
This is the same issue as bug 1701078.

Differential Revision: https://phabricator.services.mozilla.com/D112979
2021-04-26 15:29:36 +00:00
Neil Deakin
dd27439769 Bug 1600059, browser_autocomplete_footer.js doesn't account for collapsed items, causing it to fail when run twice or in sequence with certain other tests, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D112978
2021-04-26 15:29:36 +00:00
anshukaira
05262dc7a2 Bug 1706436 Remove unused icons for screenshot. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D112994
2021-04-21 18:42:57 +00:00
Falguni Islam
794b4f8785 Bug 1705747: fixing Removed DeviceId code from screenshots r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D112957
2021-04-21 18:02:13 +00:00
oneminch
6a9dcf098b Bug 1705749 - Remove save code from screenshots. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D112879
2021-04-21 17:26:06 +00:00
Kajal Sah
3cde3cb7c5 Bug 1705744 - Removes myshots from screenshots. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D112418
2021-04-20 20:22:42 +00:00
Kajal Sah
d08ef1b5e6 Bug 1702557 - Fixes lint errors in browser/extensions/screenshots/build/shot.js. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D112156
2021-04-16 15:03:58 +00:00
Ksenia Berezina
7ef318fa51 Bug 1702011 - Ship v22.0.0 of webcompat system addon r=webcompat-reviewers,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D112297
2021-04-15 23:35:27 +00:00
Thomas Wisniewski
17884fe1e4 Bug 1705452 - correctly pass in the set of hosts for which the user has opted in to bypassing shims, so that we may call allow or replace on channels appropriately; r=pbz,webcompat-reviewers,denschub
Differential Revision: https://phabricator.services.mozilla.com/D112215
2021-04-15 17:22:48 +00:00
Falguni Islam
ca7abe651a Bug 1635068: fix removed dead pref extensions.screenshots.upload-disabled and unused function isUploadDisabled() r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D112010
2021-04-14 18:49:08 +00:00
Thomas Wisniewski
eb9eff46ab Bug 1705111 - Fix shimmed opt-in video playback on nhl.com; r=denschub,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D112051
2021-04-14 16:08:20 +00:00
Paul Zuehlcke
522131845a Bug 1699668 - Tests for shim warning. r=webcompat-reviewers,johannh,denschub
Differential Revision: https://phabricator.services.mozilla.com/D109718
2021-04-13 16:11:21 +00:00
Paul Zuehlcke
2a67780e4a Bug 1661330 - Webcompat: Call channel.allow for allowing tracking resources on user opt-in. r=denschub,webcompat-reviewers
Original patch by :twisniewski

Differential Revision: https://phabricator.services.mozilla.com/D104697
2021-04-13 16:11:20 +00:00
Thomas Wisniewski
5cff0ed8dc Bug 1703830 - Add ability to gate SmartBlock shims by specific platform+release branch; r=denschub,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D111697
2021-04-12 17:38:34 +00:00
Eugen Sawin
a35b4fa14b Bug 1691821 - [3.2] Adjust form autofill extension tests to work with the shared component. r=zbraniecki,dimi,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D110273
2021-04-12 17:33:18 +00:00
Eugen Sawin
ea394ebcbc Bug 1691821 - [2.7] Extend the form autofill component to support GeckoView. r=erik,zbraniecki,dimi,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D108059
2021-04-12 17:33:18 +00:00