Commit graph

286 commits

Author SHA1 Message Date
Makoto Kato
c20f1137cb Bug 1624562 - Remove Fennec theme files. r=geckoview-reviewers,agi
Now, Fennec theme files (mobile/android/themes/core) are unused and
GV's files are in mobile/android/themes/geckoview.

So we can remove Fennec theme files.

Differential Revision: https://phabricator.services.mozilla.com/D100755
2021-01-05 20:14:15 +00:00
Itiel
847ef41e9d Bug 1668884 - Replace -moz-Field/-moz-FieldText with Field/FieldText in toolkit/ r=dao
Depends on D92335

Differential Revision: https://phabricator.services.mozilla.com/D92336
2020-10-05 11:13:54 +00:00
Andrew McCreight
6e19e07fe0 Bug 1662850 - Remove address-space segments from diffs. r=njn
These segment counts vary as memory usage vary, which makes diffs a lot
noisier. It would be slicker to diff the number of segments, but that
would require some changes to the way we do diffs.

Differential Revision: https://phabricator.services.mozilla.com/D89199
2020-09-07 00:10:09 +00:00
Andrew McCreight
4e95b07530 Bug 1653671 - Add aMinimizeMemoryUsage argument to dumpMemoryReportsToNamedFile(). r=froydnj
This functionality already exists, so it is just a matter of threading
an extra bool around. This patch should not actually change the behavior
anywhere.

The goal of this is to consider using it for AWSY. Currently AWSY
asks every process to minimize memory usage at once, but with
this option the minimization will be batched along with the memory
reports, which should make it less likely to overwhelm the system
when there are a lot of content processes.

Differential Revision: https://phabricator.services.mozilla.com/D87475
2020-08-21 17:11:03 +00:00
Sonia Singla
5f5c9fd7f2 Bug 1659267 - Remove usages of -moz-user-select across the Firefox codebase. r=emilio,marionette-reviewers,geckoview-reviewers,preferences-reviewers,whimboo,agi
Differential Revision: https://phabricator.services.mozilla.com/D87499
2020-08-18 23:37:51 +00:00
Andrew McCreight
3c8ea64fcc Bug 1650151 - Merge webIsolated processes when diffing with non-Fission memory reports. r=njn
Fission processes show up in about:memory as webIsolated=<URL>. This is
great when comparing two reports from a single session, to precisely
see how the memory usage of a particular process has changed, but it
makes it harder to compare to a non-Fission memory report. For instance,
when loading a news page with many ad iframes, what was a single process
without Fission enabled will be split across more than a dozen processes.

This patch fixes this by making it so that if exactly one memory report
being diffed contains a webIsolated process, then webIsolated processes
will be treated like regular web processes.

Differential Revision: https://phabricator.services.mozilla.com/D85608
2020-08-14 05:38:34 +00:00
Andrew McCreight
8046f2166b Bug 1649867 - Remove window IDs from event-counts in diffs. r=njn
Differential Revision: https://phabricator.services.mozilla.com/D81900
2020-07-02 16:23:53 +00:00
Nicholas Nethercote
4f86d45835 Bug 1628033 - Add pid to the main process in about:memory. r=erahm
In the tests we now explicitly use "Main Process" (or similar) for the process
name in various places to avoid having to filter out a PID.

Also in `test_aboutmemory[34].xhtml`, the main process entries now appear
first, as they should, because the sorting code now looks for a "Main Process"
prefix, rather than an exact match.

Depends on D72995

Differential Revision: https://phabricator.services.mozilla.com/D73164
2020-04-30 21:20:23 +00:00
Nicholas Nethercote
f25403924e Bug 1626804 - Clarify about:memory's explicit description. r=erahm
This commit clarifies that only some OS-level allocations are covered; the old
wording made it sound like they all were.

It also moves the allocator-level allocations first in the list, because
they're more common.

Depends on D43842

Differential Revision: https://phabricator.services.mozilla.com/D69287

--HG--
extra : moz-landing-system : lando
2020-04-02 00:58:45 +00:00
Bogdan Tara
f7039a4704 Backed out changeset 1fa5a2877746 (bug 1609825) for aboutmemory related failures CLOSED TREE
--HG--
rename : toolkit/components/aboutmemory/content/aboutMemory.html => toolkit/components/aboutmemory/content/aboutMemory.xhtml
2020-03-10 15:54:27 +02:00
eghitta
eb16450714 Bug 1609825 - Make about:memory and HTML file.r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D66183

--HG--
rename : toolkit/components/aboutmemory/content/aboutMemory.xhtml => toolkit/components/aboutmemory/content/aboutMemory.html
extra : moz-landing-system : lando
2020-03-10 12:42:26 +00:00
Christoph Kerschbaumer
30285b4a58 Bug 1499354: Add object-src 'none' to the CSP of all about: pages. r=freddyb
Differential Revision: https://phabricator.services.mozilla.com/D46950

--HG--
extra : moz-landing-system : lando
2019-09-26 16:22:41 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Matthew Noorenberghe
4a0c3a4b17 Bug 1568371 - Make h1 headings sticky on about:memory. r=njn
The arrows to jump to the next file aren't sticky but they wouldn't have been visible before this patch so I still think it's an incremental improvement.

Differential Revision: https://phabricator.services.mozilla.com/D39121

--HG--
extra : moz-landing-system : lando
2019-07-24 01:50:09 +00:00
Jonathan Kew
5e1a0f81de Bug 1563722 - Prefer DejaVu or Liberation fonts over Fira for treelines in about:memory, to minimize overlap issues. r=njn
Differential Revision: https://phabricator.services.mozilla.com/D37725

--HG--
extra : moz-landing-system : lando
2019-07-11 21:42:31 +00:00
Victor Porof
815b9d372b Bug 1561435 - Fix linting errors for toolkit/, r=standard8
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35955

--HG--
extra : source : e6571d8ed75be94bdcdef8fbd0d977bfa92f3a34
extra : intermediate-source : 1351521a4bb3f78be45cf6bf6df90b4c75a959c4
2019-06-25 23:43:58 +02:00
Victor Porof
4a06c925ac Bug 1561435 - Format toolkit/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36052

--HG--
extra : source : b5be5b4f4b47c256e28a29f665dc754f6407ee7f
2019-07-05 11:14:05 +02:00
Nicholas Nethercote
2ba5d9c1c7 Bug 1561153 - Fix problems with box-drawing chars in about:memory. r=jfkthame
In Japanese (and Chinese?) locales the box-drawing chars may be twice the width
of ASCII chars, which messes up about:memory's layout. By explicitly specifying
the language and font-family, we increase the chance that single-width
box-drawing chars are used.

Differential Revision: https://phabricator.services.mozilla.com/D36287

--HG--
extra : moz-landing-system : lando
2019-07-01 01:07:52 +00:00
Nicholas Nethercote
48fb92c3c5 Bug 1556268 - Remove aboutCompartments.xhtml. r=mccr8
about:compartments hasn't resolved for a long time.

Differential Revision: https://phabricator.services.mozilla.com/D33431

--HG--
extra : moz-landing-system : lando
2019-06-02 23:05:01 +00:00
Christoph Kerschbaumer
0fb869ec4c Bug 1496386: Apply Meta CSP to System Privileged about:memory.
Differential Revision: https://phabricator.services.mozilla.com/D33594

--HG--
extra : moz-landing-system : lando
2019-06-04 04:57:57 +00:00
Brian Grinstead
08992fb8e8 Bug 1546501 - Remove unnecessary type attributes (i.e. [type="application/javascript"]) on non-test script tags r=mossop
This is an autogenerated commit, generated with https://bug1546501.bmoattachments.org/attachment.cgi?id=9060222

Differential Revision: https://phabricator.services.mozilla.com/D28559

--HG--
extra : moz-landing-system : lando
2019-04-24 19:43:57 +00:00
Ian Moody
57b82dd9be Bug 1544284 - toolkit/ automated ESLint no-throw-literal fixes. r=Standard8
Result of running:
$ mach eslint -funix toolkit/ | sed -Ee 's/:.+//' - | xargs sed -E \
    -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
    -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
    -e 's/throw \(/throw new Error(/g' -i

...and then reverting a couple of places where comments were touched,
as well as changes to toolkit/components/ctypes/tests/unit/test_jsctypes.js
that required expectation changes to
toolkit/components/ctypes/tests/chrome/test_ctypes.xul

Differential Revision: https://phabricator.services.mozilla.com/D27448

--HG--
extra : moz-landing-system : lando
2019-04-16 19:30:27 +00:00
Arpit
cca238563d Bug 1051846 - Add a <title> to about:checkerboard and about:memory, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D23751

--HG--
extra : moz-landing-system : lando
2019-03-18 10:49:13 +00:00
Jonathan Kingston
f6680698bd Bug 1525319 - Removing context from OnDataAvailable r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20881

--HG--
extra : moz-landing-system : lando
2019-02-27 23:42:27 +00:00
Dorel Luca
4a4dcd57fa Backed out 4 changesets (bug 1525319) for Android failures in dom/base/test/test_progress_events_for_gzip_data.html
Backed out changeset b73f033efb41 (bug 1525319)
Backed out changeset 1d318d5c6b98 (bug 1525319)
Backed out changeset 6d73418988d4 (bug 1525319)
Backed out changeset 84ca79bd2dc3 (bug 1525319)
2019-02-25 04:06:11 +02:00
Jonathan Kingston
63ab2bd8aa Bug 1525319 - Removing context from OnDataAvailable r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20881

--HG--
extra : moz-landing-system : lando
2019-02-24 20:27:55 +00:00
Jonathan Kingston
3421b8fcff Bug 1520868 - Replacing AsyncOpen2 with AsyncOpen always r=valentin
Replacing js and text occurences of asyncOpen2
Replacing open2 with open

Differential Revision: https://phabricator.services.mozilla.com/D16885

--HG--
rename : layout/style/test/test_asyncopen2.html => layout/style/test/test_asyncopen.html
extra : moz-landing-system : lando
2019-02-12 16:08:25 +00:00
Myk Melez
25349d2601 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526

--HG--
extra : moz-landing-system : lando
2019-01-30 17:26:25 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Jeff Walden
718bf761d4 Bug 1518263 - Use Intl.NumberFormat objects to format numbers in about:memory rather than hand-rolling formatting code or using toLocaleString that will create a fresh formatter object every time it's called. r=heycam 2019-01-07 12:05:55 -08:00
Cameron McCormack
9635af505d Bug 1517175 - Part 2: Add about:memory filter r=njn
Depends on D15628

Differential Revision: https://phabricator.services.mozilla.com/D15629

--HG--
extra : moz-landing-system : lando
2019-01-07 03:04:46 +00:00
Cameron McCormack
81b8379a06 Bug 1517175 - Part 1: Omit "Other Measurements" section when empty r=njn
Differential Revision: https://phabricator.services.mozilla.com/D15628

--HG--
extra : moz-landing-system : lando
2019-01-07 03:04:44 +00:00
Cameron McCormack
af0862d439 Bug 1516831 - Add a process index to about:memory r=njn
Differential Revision: https://phabricator.services.mozilla.com/D15495

--HG--
extra : moz-landing-system : lando
2019-01-07 03:06:27 +00:00
Cameron McCormack
3ce3dcbe16 Bug 1517354 - Improve about:memory performance by not using toLocaleString r=njn
Differential Revision: https://phabricator.services.mozilla.com/D15627

--HG--
extra : moz-landing-system : lando
2019-01-07 02:50:05 +00:00
Eric Rahm
b9e275de1e Bug 1476371 - Normalize thread names in about:memory diffs. r=njn
This normalizes thread IDs (tid) to use the form 'tid=NNN'. It also
normalizes threadpool numbers, for example 'Foo #1 (tid=1234)' is
mapped to 'Foo #N (tid=NNN)'.

--HG--
extra : source : 2590832f34408f2ece66fb5d6a688d141d1df5bd
extra : amend_source : 4b2d4114fb94e871583e2c6461414aa6ba7d2dd7
2018-10-30 17:17:15 -07:00
Narcis Beleuzu
63a39ee873 Backed out changeset 2590832f3440 (bug 1476371) for Linting opt failrue on aboutMemory.js. CLOSED TREE 2018-10-31 21:08:22 +02:00
Eric Rahm
5817ebf336 Bug 1476371 - Normalize thread names in about:memory diffs. r=njn
This normalizes thread IDs (tid) to use the form 'tid=NNN'. It also
normalizes threadpool numbers, for example 'Foo #1 (tid=1234)' is
mapped to 'Foo #N (tid=NNN)'.

--HG--
extra : rebase_source : a476da4dd81a1a34ae12170da1008a98005adf62
2018-10-30 17:17:15 -07:00
Nicholas Nethercote
15dc34f5e1 Bug 1499906 (attempt 2) - Use template literals where suitable. r=erahm
--HG--
extra : rebase_source : 2b22e5875f4881d93f7dcab32f38f54dd52b3eef
2018-10-19 15:11:43 +11:00
Nicholas Nethercote
10d9fc7170 Bug 1499906 (attempt 2) - Put some parameters in aFoo form. erahm
--HG--
extra : rebase_source : 3fd1b18909b24ace1a76031ff46931fbb2d574d9
2018-10-19 15:11:41 +11:00
Nicholas Nethercote
2fc8cc6806 Bug 1499906 (attempt 2) - Use String.prototype.padStart(). r=erahm
--HG--
extra : rebase_source : 33797e2b53f0dece8b7684a5ff203b8bc31c5571
2018-10-19 15:11:39 +11:00
Nicholas Nethercote
49c8d5a3ea Bug 1499906 (attempt 2) - Use toLocaleString(). r=erahm
--HG--
extra : rebase_source : f00fdff317ac9964eb71743ba4407d4d580b4565
2018-10-19 15:11:36 +11:00
Nicholas Nethercote
535292ae85 Bug 1499906 (attempt 2) - Change var to let. r=erahm
--HG--
extra : rebase_source : e11be23b19088eb9b6179e236acc0f3eed40671c
2018-10-19 15:09:46 +11:00
Nicholas Nethercote
291b2825be Bug 1499906 (attempt 2) - Use for..of loops where possible. r=erahm
--HG--
extra : rebase_source : 24441f0e916f17e623d24dacbc650989231bef17
2018-10-19 15:09:46 +11:00
Nicholas Nethercote
4504f6da92 Bug 1499906 (attempt 2) - Improve treeline handling. r=erahm.
--HG--
extra : rebase_source : 58eb1bbd658cf268fdff8da4f5e17a8603610e07
2018-10-19 15:09:46 +11:00
Nicholas Nethercote
d6b23c42da Bug 1499906 (attempt 2) - Use non-ASCII chars directly in the code. r=erahm
--HG--
extra : rebase_source : 13aa1cace50aa109d397e54e82503454cb525a6e
2018-10-19 15:09:41 +11:00
Noemi Erli
7ace7a0df2 Backed out 8 changesets (bug 1499906) for ES Lint failure in builds/worker/checkouts/gecko/toolkit/components/aboutmemory/content/aboutMemory.js
Backed out changeset 81ed2232fb09 (bug 1499906)
Backed out changeset a4e7eb7be03c (bug 1499906)
Backed out changeset eeea7ba794c3 (bug 1499906)
Backed out changeset 9819dbed2d88 (bug 1499906)
Backed out changeset 97348d7aa09e (bug 1499906)
Backed out changeset 075198910378 (bug 1499906)
Backed out changeset 14cef5ef3dc4 (bug 1499906)
Backed out changeset 9d2fa6237585 (bug 1499906)
2018-10-19 06:00:48 +03:00
Nicholas Nethercote
63cb243205 Bug 1499906 - Use template literals where suitable. r=erahm
--HG--
extra : rebase_source : d5bc0fb14584077e5aa3dfda4f9aa4d770d60972
2018-10-19 11:27:37 +11:00
Nicholas Nethercote
c18a4882ef Bug 1499906 - Put some parameters in aFoo form. erahm
--HG--
extra : rebase_source : 5e815dd97ec90aff24670dbb005031cef903bbb5
2018-10-19 11:27:34 +11:00
Nicholas Nethercote
fcf04335f0 Bug 1499906 - Use String.prototype.padStart(). r=erahm
This lets us remove pad().

--HG--
extra : rebase_source : 1fec9bae018fd9a8dece94f5e5f851068a5305e0
2018-10-19 11:27:30 +11:00
Nicholas Nethercote
352b12fba0 Bug 1499906 - Use toLocaleString(). r=erahm
This replaces a bunch of code that inserted separators by hand.

For now I've kept the output mostly the same by forcing the locale to en-US.
But at least now we could consider localizing the output.

The places where the output is different, it's more consistent with the new
code. E.g. printing "-05.55%" (which matches "05.55%") instead of "-5.55%".

--HG--
extra : rebase_source : 7c7161e5ab07e55e514020070bdfa4a774644a53
2018-10-19 11:19:32 +11:00