Daniel Holbert
5b30ebbe89
Bug 1713912 followup: drop trailing blank space. (no review, whitespace-only) DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D117555
2021-06-11 18:05:45 +00:00
Daniel Holbert
d888a478ae
Bug 1713912: Remove skip-if-fission annotations for tests browser_modal_print.js and browser_print_in_container.js. r=emilio
...
In the former case (for browser_modal_print.js), the test-failures seem to just
be bug 1700803, a known intermittent that's not asan/fission-specific (though
it might be worse with fission -- we can keep an eye on failure rates to see).
In the latter case (for browser_print_in_container.js), it looks like the test
has some known intermittent timeouts on slow configurations, and it's had some
observed timeouts on **non-fission** Linux-ASAN runs. So it seems likely that
our Linux+ASAN+fission annotation there was accidentally too-specific, and
fission probably wasn't a relevant subcondition there. Therefore, this patch
is just removing fission from that condition, so the test will now be skipped on
Linux ASAN testruns in general.
Differential Revision: https://phabricator.services.mozilla.com/D117363
2021-06-11 17:32:03 +00:00
Daniel Holbert
0abd4dea7a
Bug 1715656: Add <meta charset="utf-8"> tag to all helper HTML files in toolkit/components/printing/tests/, to avoid log-spam for undeclared encoding. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D117371
2021-06-10 00:11:40 +00:00
Andrew Halberstadt
f84d5f3016
Bug 1694824 - [ci] Annotate browser-chrome manifests for new fission failures, r=jmaher,extension-reviewers,preferences-reviewers,zombie
...
Differential Revision: https://phabricator.services.mozilla.com/D116276
2021-06-02 19:22:25 +00:00
Sam Foster
3ae623a5c4
Bug 1711791 - Output stringified settings in debug log, and resolved printer details. r=dholbert
...
Differential Revision: https://phabricator.services.mozilla.com/D115428
2021-05-21 17:59:32 +00:00
Michelle Goossens
6af282754f
Bug 1711498 - Remove checks for protonAppMenuEnabled or protonToolbarEnabled smart pref getters from tests r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D115651
2021-05-21 15:51:13 +00:00
Geoff Lankow
2b549b87c7
Bug 1711805 - Extract uses of gBrowser in PrintUtils in a way that can be easily overridden. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D115433
2021-05-19 10:45:01 +00:00
Emilio Cobos Álvarez
d973da3734
Bug 1710887 - Make modal state handling in window.print() more reliable. r=smaug
...
If afterprint removes the window we're printing, we'd call
LeaveModalState() without a top window, and never leave the modal state.
Differential Revision: https://phabricator.services.mozilla.com/D115007
2021-05-12 19:26:20 +00:00
Mark Striemer
3110ac3ec8
Bug 1706155 - Set hover states for HCM common.css r=desktop-theme-reviewers,dao,morgan,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D113872
2021-05-10 16:31:27 +00:00
Andreea Pavel
ea6620b07c
Backed out changeset 8757d112fc04 (bug 1706155) for bc failures at browser_parsable_css.js on a CLOSED TREE
2021-05-08 03:19:31 +03:00
Mark Striemer
0480fc9ec0
Bug 1706155 - Set hover states for HCM common.css r=desktop-theme-reviewers,dao,morgan,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D113872
2021-05-07 23:24:59 +00:00
Andreea Pavel
d27a810ad2
Backed out changeset 8a02c8fa7821 (bug 1706155) for failing browser_parsable_css.js on a CLOSED TREE
2021-05-08 00:50:40 +03:00
Mark Striemer
8ee31eee8c
Bug 1706155 - Set hover states for HCM common.css r=desktop-theme-reviewers,dao,morgan,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D113872
2021-05-07 20:46:03 +00:00
Emilio Cobos Álvarez
7fb4c21e4a
Bug 1705348 - printToFile should only be true for the PDF printer. r=emalysz
...
There are users with broken prefs (old bugs that are fixed perhaps?),
but anyhow there's no sensible reason to set printToFile to true for
users printing from the print dialog.
We were working around it for the PDF printer but there's no reason we
shouldn't do it for other printers.
Differential Revision: https://phabricator.services.mozilla.com/D113821
2021-05-06 12:02:18 +00:00
Sam Foster
781b048414
Bug 1708588 - Add page-portrait.svg and page-landscape.svg to shared toolkit icons; use these from the print UI, and instead of document.svg. r=harry,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D113896
2021-04-30 17:11:23 +00:00
Emma Malysz
d2b69538dd
Bug 1675965, do not store file name in preference value for save to pdf printers r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D113413
2021-04-29 17:42:54 +00:00
Butkovits Atila
a9b9f287ea
Bug 1679403 - disable browser_preview_print_simplify_non_article.js on Linux_64 for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D113609
2021-04-28 02:01:52 +00:00
Mike Conley
c0f33ff43d
Bug 1705849 - Update toolbar icon fill colours for system/light/dark themes to remove opacity and match Proton spec. r=harry
...
Differential Revision: https://phabricator.services.mozilla.com/D112820
2021-04-26 16:55:12 +00:00
Cosmin Sabou
6143c3b834
Backed out changeset a08a2e0aee43 (bug 1705849) for causing Bug 1707357. a=backout
2021-04-24 18:52:22 +03:00
Emma Malysz
0895bb2111
Bug 1685352, adjust print modal to match proton styles r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D113031
2021-04-22 18:39:09 +00:00
Mike Conley
5adce32a77
Bug 1705849 - Update toolbar icon fill colours for system/light/dark themes to remove opacity and match Proton spec. r=harry,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D112820
2021-04-22 15:29:51 +00:00
Emilio Cobos Álvarez
1f4e023df8
Bug 1705757 - Fix my previous patch, d'oh.
...
MANUAL PUSH: Minor fixup in a CLOSED TREE
2021-04-17 22:35:45 +02:00
Emilio Cobos Álvarez
1d16b51ec4
Bug 1705757 - Restore _doPrint to fix mochitest which replaces it.
...
MANUAL PUSH: orange fix CLOSED TREE
2021-04-17 21:58:53 +02:00
Emilio Cobos Álvarez
81f0dc222e
Bug 1705757 - Add a test for this. r=nika
...
There was none, of course :(
Depends on D112413
Differential Revision: https://phabricator.services.mozilla.com/D112414
2021-04-17 18:41:12 +00:00
Emilio Cobos Álvarez
d14a43f487
Bug 1705757 - Make printing a single frame choose the right process for the preview frame. r=nika
...
We were using the top BrowsingContextGroup id in this case, which is
obviously wrong. Also make the API take a BrowsingContext directly,
rather than passing outerwindowids around.
Differential Revision: https://phabricator.services.mozilla.com/D112413
2021-04-17 18:41:11 +00:00
Emilio Cobos Álvarez
9afefdd884
Bug 1705757 - Move FrameLoader.print to BrowsingContext.print. r=nika,remote-protocol-reviewers,marionette-reviewers,extension-reviewers,zombie
...
This makes it trivial to choose the right BrowserParent to print a
browsing context, by removing the OuterWindowID / FrameLoader
indirections.
Differential Revision: https://phabricator.services.mozilla.com/D112412
2021-04-17 18:41:11 +00:00
Emilio Cobos Álvarez
b42ccb7de0
Bug 1705509 - Hide -moz-outline-radius behind a pref. r=mstange
...
This property does nothing since bug 315209 got implemented.
Every single user that I checked was doing the same math by hand, so
hooray for good defaults :-)
Differential Revision: https://phabricator.services.mozilla.com/D112253
2021-04-16 01:01:45 +00:00
Mike Conley
79f423f697
Bug 1699889 - Update toolkit/themes/shared/icons icons. r=sfoster,desktop-theme-reviewers,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D111698
2021-04-15 12:01:46 +00:00
Markus Stange
689a5fe4f5
Bug 1704569 - Don't synthesize events on menus in toolkit/components/printing/tests/browser_print_context_menu.js. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D111776
2021-04-13 16:22:20 +00:00
Emilio Cobos Álvarez
5d28fe67d1
Bug 1702867 - Static print documents do have a browsing context and are loaded as data. r=smaug
...
Document::CrossOriginIsolated() was assuming this wasn't possible,
so when you print from an isolated page from a different site, then we
end up with the wrong docgroup.
Differential Revision: https://phabricator.services.mozilla.com/D110988
2021-04-06 19:29:49 +00:00
Emilio Cobos Álvarez
b5f0b0642f
Bug 1697836 - Add an automated test for this bug. r=emalysz
...
Differential Revision: https://phabricator.services.mozilla.com/D110035
2021-03-29 23:33:35 +00:00
Mark Striemer
81479b1262
Bug 1699250 - Use proton dark theme in-content r=jaws
...
This also fixes up various about pages.
Differential Revision: https://phabricator.services.mozilla.com/D108800
2021-03-28 18:33:05 +00:00
Butkovits Atila
71d46d5a75
Backed out 2 changesets (bug 1690333, bug 1699250) for causing failures on test_bug509732.xhtml. CLOSED TREE
...
Backed out changeset dcba2814dbc4 (bug 1690333)
Backed out changeset ae3a0e6dde00 (bug 1699250)
2021-03-28 21:16:58 +03:00
Mark Striemer
5c54a9a003
Bug 1699250 - Use proton dark theme in-content r=jaws
...
This also fixes up various about pages.
Differential Revision: https://phabricator.services.mozilla.com/D108800
2021-03-28 17:02:20 +00:00
Bogdan Tara
3b463ca0d1
Backed out changeset 421e6e333309 (bug 1699250) for browser_html_discover_view_clientid.js mochitest failures
...
DONTBUILD
2021-03-28 02:37:33 +02:00
Mark Striemer
3d91b0c5fb
Bug 1699250 - Use proton dark theme in-content r=jaws
...
This also fixes up various about pages.
Differential Revision: https://phabricator.services.mozilla.com/D108800
2021-03-27 23:31:07 +00:00
Cosmin Sabou
4618d0a607
Backed out 2 changesets (bug 1690333, bug 1699250) for mochitest failures on test_notificationbox.xhtml.
...
Backed out changeset d6780d34ca05 (bug 1690333)
Backed out changeset 50cc5db86f1e (bug 1699250)
2021-03-27 23:58:04 +02:00
Mark Striemer
d4b82a8583
Bug 1699250 - Use proton dark theme in-content r=jaws
...
This also fixes up various about pages.
Differential Revision: https://phabricator.services.mozilla.com/D108800
2021-03-27 21:02:50 +00:00
Emilio Cobos Álvarez
06b663afd4
Bug 1697836 - Avoid throwing when asking for a selection. r=emalysz
...
Selection may be null if the page got hidden in e.g., the afterprint
event listener or somewhere else.
Add a try catch for good measure, assuming there's no selection is
always safe.
I'll try to get an automated test-case for this working, though it might
be tricky.
Depends on D109714
Differential Revision: https://phabricator.services.mozilla.com/D109715
2021-03-27 10:22:55 +00:00
Emilio Cobos Álvarez
188f91724f
Bug 1697836 - Improve error handling when failing to window.print(). r=emalysz
...
Ensure we report the error to the web console, and that the print
browser gets removed, as that is what will exit the modal state in the
page that's printing.
Differential Revision: https://phabricator.services.mozilla.com/D109714
2021-03-27 10:22:54 +00:00
Tim Nguyen
02d57f66a3
Bug 1698355 - Consolidate in-content focus outline styles. r=Itiel
...
Differential Revision: https://phabricator.services.mozilla.com/D108584
2021-03-18 23:22:07 +00:00
Butkovits Atila
59c50bbeb3
Backed out changeset 529ca682d2ff (bug 1698355) for causing failures at browser_parsable_css.js.
2021-03-19 01:01:48 +02:00
Tim Nguyen
1953bc5d33
Bug 1698355 - Consolidate in-content focus outline styles. r=Itiel
...
Differential Revision: https://phabricator.services.mozilla.com/D108584
2021-03-18 22:13:51 +00:00
Florian Quèze
b6e4723024
Bug 1697588 - avoid leaking about:blank windows in browser_modal_print.js by waiting a bit before closing the dialog, r=emalysz.
...
Depends on D108020
Differential Revision: https://phabricator.services.mozilla.com/D108021
2021-03-17 17:39:34 +00:00
Emilio Cobos Álvarez
e65533e909
Bug 1698821 - Simplify native-appearance-disabling for number spinners. r=dholbert
...
The root cause of this bug is that we're now accidentally using the
native theme for the spinners because GetNumberControlFrameForSpinButton
broke with my changes.
These pseudos are not exposed to content, and there's just one user of
this pseudo-class (the print.css one).
So just disable native appearance explicitly and remove that check.
Differential Revision: https://phabricator.services.mozilla.com/D108653
2021-03-16 21:53:20 +00:00
Sam Foster
72d4c476b1
Bug 1682162 - Use the paperSizeUnit to display and handle mm/inch custom margin values. r=emalysz,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D104291
2021-03-13 00:27:53 +00:00
Tom Schuster
73302badda
Bug 1695622 - Gracefully handle missing paper when trying to getMarginPresets. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D107708
2021-03-12 17:53:55 +00:00
Tom Schuster
5f997c8d2b
Bug 1694844 - In nsPrinterListCUPS::SystemDefaultPrinterName return NS_OK even without working CUPS. r=emilio
...
The other nsPrinterListCUPS methods already handle !InitOkay() without returning an error or rejecting
the promise.
Differential Revision: https://phabricator.services.mozilla.com/D107210
2021-03-04 16:03:30 +00:00
Emilio Cobos Álvarez
915f02d25c
Bug 1694951 - Remove printing.trigger telemetry. r=jwatt,marionette-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D106465
2021-03-01 11:36:43 +00:00
Mike Conley
d1abcdce20
Bug 1693851 - Fix some variety of tests so that they pass with and without Proton AppMenu enabled. r=emalysz
...
Differential Revision: https://phabricator.services.mozilla.com/D106381
2021-02-25 23:43:08 +00:00