John Underwood
8ab22cf0e7
Bug 1326910 - wait for a loadend event before using the width and height of the Page Info media preview, r=florian.
2017-06-02 22:08:21 +02:00
Florian Queze
f935ddc4b3
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
Florian Queze
37ff4fc7cc
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699
Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout
2017-04-14 23:39:22 +02:00
Sebastian Hengst
738d097aae
Backed out changeset 55f3df15eaa6 (bug 1356569)
2017-04-14 23:39:17 +02:00
Florian Queze
3c564a2b02
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
Florian Queze
95d4d20c17
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
Mark Banner
1087fc1884
Bug 1352969 - Fix various ESLint no-undef issues in browser/base (no-undef is not enabled yet). r=mossop
...
MozReview-Commit-ID: BuTyJAfUoWR
--HG--
extra : rebase_source : 482bdc039362347f35aec9fd15e07a143dccb860
2017-02-22 17:02:59 +00:00
Zibi Braniecki
3d91da8726
Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
...
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.
This allows us to remove a lot of calls for the app locale.
The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.
MozReview-Commit-ID: DzmFEUvMq3N
--HG--
extra : rebase_source : 513ed31d995864939aa893e73c81ffdf591a6617
2017-03-14 16:09:54 -07:00
Sebastian Hengst
0a04f3b9e2
Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout
2017-03-22 18:20:26 +01:00
Zibi Braniecki
c2cd68a689
Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
...
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.
This allows us to remove a lot of calls for the app locale.
The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.
MozReview-Commit-ID: DzmFEUvMq3N
--HG--
extra : rebase_source : 13fa4c397ba4c79303a2cd76684b5b8c4bd17331
2017-03-14 16:09:54 -07:00
Florian Quèze
9d62681259
Bug 1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild), r=jaws.
2017-03-08 10:17:52 +01:00
Jared Wein
43bac26d30
Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
...
MozReview-Commit-ID: 6tv0Z06CO4a
--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Florian Quèze
028a82f682
Bug 1329182 - remove trailing newURI null parameters in browser/, r=jaws.
2017-01-09 20:27:25 +01:00
Jared Wein
9141469edf
Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
...
MozReview-Commit-ID: FuVu8skcqOe
--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 7E7LPorrEje
--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c
Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
...
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 8WoGr8i6oCR
--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Jared Wein
3718f00db1
Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop
2016-11-15 22:58:30 -05:00
Dave Townsend
8de07a19a0
Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
...
MozReview-Commit-ID: 2ZvTiZDHchz
--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Phil Ringnalda
c9fdc270b6
Merge m-c to autoland
...
--HG--
rename : dom/media/webaudio/compiledtest/TestAudioEventTimeline.cpp => dom/media/webaudio/gtest/TestAudioEventTimeline.cpp
2016-11-03 20:02:24 -07:00
Jared Wein
17ee4aac47
Bug 1315013 - part 2, remove unnecessary slash-star comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
...
MozReview-Commit-ID: LpP0OeyjqX9
--HG--
extra : rebase_source : 3bee2f5e8df7059609085e6b466849af5117b9df
2016-11-03 15:02:07 -04:00
Deepjyoti Mondal
03da3ee9bf
Bug 1215856 - "":" should not be selected or copied in Title field". r=dtownsend
2016-09-20 09:30:00 +02:00
Mark Banner
09ab00a94f
Bug 1313998 - Turn on no-unused-vars for local variable scopes in browser/base/content. r=mossop
...
MozReview-Commit-ID: IyFGBotfd11
--HG--
extra : rebase_source : aa43e5aea9e7fd7223fc59e941ecdc067abdb48f
2016-10-31 10:33:38 +00:00
Jared Wein
5040f17e00
Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
...
MozReview-Commit-ID: 7Gx90a5y8t6
--HG--
extra : rebase_source : 9c8a6b15c19982d720b0163fbbf19d465da786fe
2016-10-24 13:14:19 -04:00
Jonathan Kew
fd8ad61437
Bug 1301655 - pt 1 - Replace use of nsIScriptableDateFormat with standard JS date formatting in pageInfo.js. r=gandalf
2016-10-28 12:04:06 +01:00
Jared Wein
e6276ea7f5
Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
...
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Jared Wein
fd84c776c7
Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
...
MozReview-Commit-ID: EMjJ3yWt9Wt
--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00
Jared Wein
871ed4e3ba
Bug 1291855 - Enable the no-else-return rule for eslint. r=Felipe,kmag,mossop
...
MozReview-Commit-ID: DYOmE6xwMJh
--HG--
extra : rebase_source : bc81b68ea5599fd1815dc34dac7106eef7044483
2016-08-03 18:54:59 -04:00
David Keeler
100044aea9
bug 803330 - fix row count assertion failure in page info dialog r=florian
...
When calling rowCountChanged on an nsITreeBoxObject, the implementation assumes
that the row count has actually changed. pageInfoTreeView violated this
assumption in addRows by first calling rowCountChanged and then updating its row
count. This patch fixes the issue by using the power of decomposition. That is,
there's already a perfectly fine function called 'addRow' that can be called
once for each row being added.
MozReview-Commit-ID: HP6LkP4ICLf
--HG--
extra : rebase_source : 574afa9a8bdaf6eea027144de96c55a2a24ea241
2016-07-14 17:21:14 -07:00
Mike Conley
aabda2cf0f
Bug 1241892 - Make Page Info work for sidebar browser. r=florian
...
The modifications that were made in bug 1238180 assumed that
gBrowser.selectedBrowser from the opening window context would
be defined. This is true in normal browser tabs, but not so much
in the sidebar browser. This patch makes it so that callers can
supply a browser to override the assumption.
MozReview-Commit-ID: FKSyl7WUu1V
--HG--
extra : rebase_source : 54e163dc79c349fe84da4b9b3bab7f6462d82217
2016-07-04 15:42:45 -04:00
Dave Huseby
b815db526b
Bug 1233885 - fix up docInfo and permission manager to use default user context. r=sicking
...
(HEAD -> oa, refs/patches/oa/Bug_1233885)
fix up docInfo and permission manager to use default user context
2016-03-26 15:07:00 +01:00
Dave Townsend
4bf4f02ce7
Bug 1257246: Update browser for eslint 2. r=felipe
...
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.
MozReview-Commit-ID: DEskVIjiKDM
--HG--
extra : rebase_source : 07ba1d14655f5d761624b105ef025ec88323d4d5
extra : histedit_source : 9e5ab54ce1b1a5ee1f0fb143f8d1450522455e3b
2016-04-05 11:33:33 -07:00
Mike Conley
ec59745657
Bug 1255773 - Account for multiple media elements per node for Page Info. r=florian
...
MozReview-Commit-ID: GwzIYVsLgue
--HG--
extra : rebase_source : 6fc4d9317487dd311a3f0b2602d7c704b2fc0b2b
2016-04-05 12:39:24 -04:00
Dave Townsend
a9fc7f9380
Bug 1245649: Turn on no-irregular-whitespace and no-mixed-spaces-and-tabs. r=jaws
...
--HG--
extra : commitid : AHmjTpVmCOP
extra : rebase_source : 0034d884816464bff4677afbe96c52fa9dca9072
2016-02-03 18:09:49 -08:00
George Wright
3996b5e615
Bug 1237025 - Stop using CPOWs for View Image Info context menu r=mconley
2016-01-19 19:21:49 -05:00
Masatoshi Kimura
262636dacf
Bug 1211243 - Do not swallow exceptions if the URI is not an instance of a standard URL. r=florian
2016-01-22 07:29:35 +09:00
Masatoshi Kimura
b15598ec83
Bug 1207168 - Fix internalSave() arguments in pageInfo.js. r=florian
2016-01-22 07:29:35 +09:00
Felipe Gomes
bddd338cd7
Bug 1231728 - Fixes some code to follow eslint rules. r=mak
...
--HG--
extra : commitid : 2pB0pOqsHVW
2015-12-10 14:38:30 -05:00
Mike Conley
ba12fbbe72
Bug 1180991 - Send up natural dimensions of background images loaded in content for Page Info. r=florian
...
--HG--
extra : commitid : 3WG0R3DrZ5K
extra : rebase_source : 9bd7c6c33b8de5342138c8c66c04ebac8c355477
extra : amend_source : 79a786a900756692614126e536135616adc719b0
2015-10-05 15:22:38 -04:00
Nikhil Gupta
938582f5e1
Bug 1175877 - Removed Cu and used Components.util directly r=Mak
...
--HG--
extra : amend_source : 7ef589f4cfab4f0f464e8935e37eeb495203b274
2015-10-08 11:30:16 +05:30
Carsten "Tomcat" Book
08997000eb
Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
...
Backed out changeset 647025383676 (bug 1202902 )
Backed out changeset d70c7fe532c6 (bug 1202902 )
2015-10-07 14:03:21 +02:00
Carsten "Tomcat" Book
e7ef778c9d
Backed out 1 changesets (bug 1202902) for causing merge conflicts to mozilla-central
...
Backed out changeset cfc1820361f5 (bug 1202902 )
--HG--
extra : rebase_source : 5d3db72337754bc7ab0ed0c30b2896100411ff92
2015-10-07 12:13:45 +02:00
Shu-yu Guo
d06b6030f6
Bug 1202902 - Scripted fix the world.
2015-10-06 14:00:31 -07:00
Jimmy Wang
a627185642
Bug 1175794 - Use task with setTimeout and send messages to continuously update PageInfo Media tab. r=florian
2015-08-13 05:12:02 -04:00
Jimmy Wang
fa2afab424
Bug 1175794 - Rename and cleanup pageinfo code. r=florian
2015-08-13 03:37:02 -04:00
Jimmy Wang
df7dcddd7e
Bug 1040947 - Opening page info from a remote tab is sluggish. r=florian
2015-07-08 17:18:38 -04:00
Michael Layzell
1a566f38c0
Bug 1173523 - Part 9: Update pageinfo to use the new API for nsIPermission, r=florian
2015-07-16 14:49:37 -04:00
Wes Kocher
ff2f0d32cf
Backed out 24 changesets (bug 1173523, bug 1172080, bug 817007, bug 1165263) for android reftest bustage CLOSED TREE
...
Backed out changeset 84fe04b2e7d1 (bug 1172080)
Backed out changeset 0ff004760a1f (bug 1172080)
Backed out changeset af147585ad55 (bug 1165263)
Backed out changeset c3af8ebb6db0 (bug 1165263)
Backed out changeset cd3f33a888fe (bug 1165263)
Backed out changeset e5db39044a1e (bug 1165263)
Backed out changeset c01c9ed77061 (bug 1165263)
Backed out changeset fb723aaa4267 (bug 1165263)
Backed out changeset f754e52e74dc (bug 1165263)
Backed out changeset c6bda3a0afd6 (bug 817007)
Backed out changeset bfa100253349 (bug 817007)
Backed out changeset b787b3f9aadc (bug 1173523)
Backed out changeset 4a0676b73f77 (bug 1173523)
Backed out changeset 82034a4560c5 (bug 1173523)
Backed out changeset 4bdb91114c7a (bug 1173523)
Backed out changeset 72406261eccc (bug 1173523)
Backed out changeset 541b6faf7196 (bug 1173523)
Backed out changeset 1caac4569616 (bug 1173523)
Backed out changeset 0d4f9f9e1b4e (bug 1173523)
Backed out changeset 2d5661eb966c (bug 1173523)
Backed out changeset 89833c0bb0cd (bug 1173523)
Backed out changeset ea64d70eacfe (bug 1173523)
Backed out changeset a8e4f1c0c445 (bug 1173523)
Backed out changeset cf498d466b85 (bug 1173523)
2015-07-14 14:00:32 -07:00
Michael Layzell
9038774873
Bug 1173523 - Part 9: Update pageinfo to use the new API for nsIPermission, r=florian
2015-07-14 15:06:24 -04:00