Gijs Kruitbosch
9f3268689a
Bug 1370986 - disable panelmultiview in the overflow panel off-nightly for 55, r=mikedeboer
...
This #ifdefs out the multiview for non-photon-theme, and checks for it being
present in various bits of JS that interact with it. As a result, this will
'fix' the issues in this bug and in bug 1370967 for 55 as it moves off
Nightly. bug 1370967 will still need fixing in the photonpanelmultiview /
webextensions.
MozReview-Commit-ID: 6x4HmyvxeRP
--HG--
extra : rebase_source : cdab2fab97795def95b6f4c70c61cfcb1c3ac2f9
2017-06-08 16:38:36 +01:00
Sebastian Hengst
87ac370a16
Backed out changeset 71da3a25b572 (bug 1370986) for timing out in browser_photon_customization_context_menus.js. r=backout
2017-06-09 21:19:50 +02:00
Gijs Kruitbosch
cacf8fbbd8
Bug 1370986 - switch to photonpanelmultiview for photon, disable off-nightly, r=mikedeboer
...
This #ifdefs out the multiview for non-photon-theme, and checks for it being
present in various bits of JS that interact with it. As a result, this will
'fix' the issues in this bug and in bug 1370967 for 55 as it moves off
Nightly. By switching to the photonpanelmultiview, we get proper anchoring
and slightly improved styling (bug 1354086 covers the rest of that), even
where this code *is* enabled. bug 1370967 will still need fixing in
the photonpanelmultiview / webextensions.
MozReview-Commit-ID: 6x4HmyvxeRP
--HG--
extra : rebase_source : 11503543ab1945f82dc2ba902c32dd6092ebbe80
2017-06-08 16:38:36 +01:00
Mike Taylor
4b10337a50
Bug 1368920. Part 4 - Enable Report Site Issue button for DevEdition and Nightly builds only. r=Gijs
...
MozReview-Commit-ID: Fu1oGBulbLT
--HG--
extra : rebase_source : 987965cd033c682f7c1023225b74541729eda53c
2017-06-06 15:50:53 -05:00
Gijs Kruitbosch
b9c12b59fb
Bug 1367012 - update edit UI visibility checks for photon, r=mikedeboer
...
This ensures we update edit UI visibility state when opening/closing the
overflow panel, as well as ensuring we do so if/when the edit controls
get over/underflowed. It then updates the test to ensure we correctly
check the overflow panel, both for overflown items and for items
put there by the user when photon is enabled.
MozReview-Commit-ID: AjRH8wz5Pla
--HG--
extra : rebase_source : 706063645062f52333d5491907ea9ba857bcabe7
2017-06-08 11:17:55 +01:00
Paolo Amadini
9e788278c4
Bug 694291 - Add a preference mirroring the presence of the search widget in the navigation toolbar. r=past
...
MozReview-Commit-ID: 9UmowyRTTMK
--HG--
extra : rebase_source : 15a2a48e3dae3447e18d65b5f329501717d6a1fe
2017-06-02 16:36:18 +01:00
Mike Taylor
f4d49f16ca
Bug 1341438. Part 1 - Enable Report Site Issue for DevEdition + Nightly. r=Gijs
...
MozReview-Commit-ID: 7yH39YDmL6V
--HG--
extra : rebase_source : 6ccd82d23d434bde0eba095fbb4ce59d8abe2e3a
2017-04-04 17:40:50 -05:00
Gijs Kruitbosch
693fc8a6f8
Bug 1365294 - swap position of the fixed overflow list, r=mikedeboer
...
MozReview-Commit-ID: 9LlTxRLuOkx
--HG--
extra : rebase_source : bc97a85cf5e2f1f8bc10cc5e5e8883875490c2de
2017-05-17 15:05:36 +01:00
Gijs
dec20c821e
Bug 1354094 - show the overflow button when there are items in the permanent overflow menu, r=mikedeboer
...
This also disables the menu button and overflow button correctly in
customize mode, and fixes an issues where the overflow button state
would stay 'open' when closing the panel by clicking the button
a second time.
MozReview-Commit-ID: BNTkE6zvv9Q
--HG--
extra : rebase_source : caa6ca5376c0b0e6c5d3190ffaed0b34e5292fb4
2017-05-10 12:36:05 -04:00
Gijs Kruitbosch
b2a18e6463
Bug 1354082 - part 2: make overflow panel show up in customize mode and make dragging work correctly, r=mikedeboer
...
This reuses the logic we have for toolbar dragging and uses it for the photon panel (ie overflow panel)
to do vertical space-making animations.
It explicitly doesn't address the styling or permanently showing the overflow button (for which we have other bugs on file).
MozReview-Commit-ID: 4qrWC0H30xi
--HG--
extra : rebase_source : 57c413620aff496069b8cf371b8980a1fa432d72
extra : histedit_source : 60f65f3cb81ba0c64553bdac4dc502a6a704be90
2017-05-05 19:26:55 +01:00
Gijs Kruitbosch
9631be649d
Bug 1354082 - part 1: make toggling the photon structure pref at runtime not break the panels, r=mikedeboer
...
This is unfortunate, but in order to keep automated tests working when we flip the pref,
it would be nice to be able to flip the pref at runtime and have things Just Work. This
tries to make that happen. We can remove most of this code post-Photon.
MozReview-Commit-ID: 8zbgCGJautO
--HG--
extra : rebase_source : 2b6df54d24d35294cc547be0b7abe5396ddec6b6
extra : histedit_source : a9b4654bbddc10a933f83a08f34d809a58b80ad9
2017-05-05 19:25:37 +01:00
Julian Descottes
3953540654
Bug 1183962 - stop installing webide button in menu or navbar automatically;r=jryans
...
MozReview-Commit-ID: CACgml3Xijf
--HG--
extra : rebase_source : 6fc322700f3d2113c813f2a33c09abc3ba865405
2017-05-02 22:56:40 +02:00
Gijs Kruitbosch
9941e89ec3
Bug 1354079 - add sticky / permanent part to overflow panel, r=mikedeboer
...
MozReview-Commit-ID: 7wv43JWLx8Q
--HG--
extra : rebase_source : d8532f3b6d15baea124480cab2f55d4944417b27
2017-04-22 10:41:03 +01:00
Florian Queze
4b1556a5f2
Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws.
2017-04-27 00:25:45 +02:00
Gijs Kruitbosch
6e172a32c1
Bug 1354071 - make sure context menu continues to work correctly, r=mikedeboer
...
MozReview-Commit-ID: DZiwogYyDBv
--HG--
extra : rebase_source : ea3a2f6914b02738c02878e75717d3d02548d0d7
2017-04-19 11:21:12 +01:00
Gijs Kruitbosch
0d9f28833b
Bug 1354071 - use a panelmultiview for the overflow panel, r=mikedeboer
...
MozReview-Commit-ID: ERZuwC6eYQf
--HG--
extra : rebase_source : bb000fcd948897ff0694de8943223651e1e061ca
2017-04-18 12:16:47 +01:00
Florian Queze
37ff4fc7cc
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699
Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout
2017-04-14 23:39:22 +02:00
Florian Queze
95d4d20c17
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
Gijs Kruitbosch
29bf378255
Bug 1341562 - fix CustomizableUI's overflow insertion to not break if buttons aren't where we expect them, r=jaws
...
MozReview-Commit-ID: Fs9IYC4bvL9
--HG--
extra : rebase_source : af948f85e4675b0e83abbe6e554646b13603111a
2017-03-22 19:50:53 +00:00
Florian Quèze
7f1b926f29
Bug 1344711 - hand cleanup of cases that were ignored by the script to remove try blocks around get*Pref calls, r=jaws.
...
--HG--
extra : rebase_source : 4da1e10b87ac37de19e0ca6f79996e8a12492db9
2017-03-07 15:29:48 +01:00
Florian Quèze
cd762cc83c
Bug 1344711 - script-generated patch to remove try blocks around get*Pref calls, r=jaws.
...
--HG--
extra : rebase_source : c6e20e6e79b0ca5de751c52712d96cbea9432d26
2017-03-07 15:29:48 +01:00
Florian Quèze
0e0865f4fc
Bug 1331599 - script-generated patch to replace removeEventListener calls with the once option when possible, r=jaws.
2017-01-25 07:01:52 +01:00
Gijs Kruitbosch
a18ca4322b
Backed out changeset b3761531b00b (bug 1306561) for perma-oranging a lot of tests once 53 merges to aurora, rs=bustage,me,etc.
...
MozReview-Commit-ID: 9m4g9aqYPW8
2017-01-22 00:24:47 +00:00
Mike Taylor
8660be2ede
Bug 1324062. Part 1 - Add a "Report Site Issue" button to the panel menu for NIGHTLY_BUILDs. r=Gijs
...
MozReview-Commit-ID: 74T8uRuqpyf
--HG--
extra : rebase_source : a047d01a70df5f0689c251698fc00c3f89a236ae
2017-01-17 14:27:03 -06:00
Wes Kocher
333d007681
Backed out 3 changesets (bug 1324062) for frequent Win7VM bc2 failures a=backout
...
Backed out changeset d01f82be01f1 (bug 1324062)
Backed out changeset 054cfcf60c75 (bug 1324062)
Backed out changeset 1658b20cb69c (bug 1324062)
MozReview-Commit-ID: LTl7fJ8zrp9
2017-01-20 11:53:36 -08:00
Mike Taylor
85464e788f
Bug 1324062. Part 1 - Add a "Report Site Issue" button to the panel menu for NIGHTLY_BUILDs. r=Gijs
...
MozReview-Commit-ID: 74T8uRuqpyf
--HG--
extra : rebase_source : a047d01a70df5f0689c251698fc00c3f89a236ae
2017-01-17 14:27:03 -06:00
Jared Wein
43bac26d30
Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
...
MozReview-Commit-ID: 6tv0Z06CO4a
--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Florian Quèze
85611a7b6d
Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
...
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Phil Ringnalda
e8e3e64e68
Backed out 2 changesets (bug 1324062) for unexpected file access errors in webcompat-reporter@mozilla.org.xpi on Win7 PGO xperf
...
Backed out changeset 1df935d51464 (bug 1324062)
Backed out changeset 028db619f166 (bug 1324062)
2017-01-12 07:34:18 -08:00
Mike Taylor
ed942c578e
Bug 1324062. Part 1 - Add a "Report Site Issue" button to the panel menu for NIGHTLY_BUILDs. r=Gijs
...
MozReview-Commit-ID: 74T8uRuqpyf
--HG--
extra : rebase_source : ae70816913cbd1510db02a47d7834248396ba78c
2016-12-28 13:31:22 -06:00
Dão Gottwald
8fb88d18f2
Bug 1306561 - Make the Restore Default button take into account that the devedition theme is the default in devedition builds. r=jaws
...
MozReview-Commit-ID: 3gIOZuaXOO1
--HG--
extra : rebase_source : d8daee4cf735b4860e4dd305e7b8374a965764fb
2017-01-11 13:31:37 +01:00
Dão Gottwald
900b14556f
Bug 1330001 - Remove browser code behind Windows XP and Vista version checks. r=jaws
2017-01-11 10:54:16 +01:00
Jared Wein
9141469edf
Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
...
MozReview-Commit-ID: FuVu8skcqOe
--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 7E7LPorrEje
--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c
Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
...
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 8WoGr8i6oCR
--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Dão Gottwald
84b8909f1f
Bug 1318276 - Clean up CustomizableUIInternal.addShortcut. r=jaws
2016-11-17 17:18:07 +01:00
Jared Wein
3718f00db1
Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop
2016-11-15 22:58:30 -05:00
Dave Townsend
8de07a19a0
Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
...
MozReview-Commit-ID: 2ZvTiZDHchz
--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Dave Townsend
0a2c8f9b78
Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
...
MozReview-Commit-ID: HBpjT2uHJaZ
--HG--
extra : rebase_source : 78fe71a1d673a1c698520a9c82c6f35959614f8f
2016-11-10 14:48:04 -08:00
Mark Banner
a41b5adcb0
Bug 1314918 - Fix most of the remaining no-unused-vars issues for local scope in browser/. r=mossop
...
MozReview-Commit-ID: LdoXLniNeT7
--HG--
extra : rebase_source : d2418b8cfab0a399d0dfb5a96ea50c62fac63e70
2016-11-03 11:51:48 +00:00
Jared Wein
5040f17e00
Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
...
MozReview-Commit-ID: 7Gx90a5y8t6
--HG--
extra : rebase_source : 9c8a6b15c19982d720b0163fbbf19d465da786fe
2016-10-24 13:14:19 -04:00
Wes Kocher
431cc3777c
Merge m-c to inbound a=merge
2016-08-19 18:39:52 -07:00
Kris Maglione
c732d51ec4
Bug 1259093: Part 1 - Allow async initialization from ViewShowing events. r=Gijs
...
This changes the `detail` of the ViewShowing events in an incompatible way.
There were only a few places it was used in mozilla-central, which I fixed. I
searched add-ons in DXR and didn't find any that used the `detail` member of
this event, but I had to resort to a random sampling, so it's possible that
some do exist.
MozReview-Commit-ID: CYzGw6KH7uI
***
amend-0
MozReview-Commit-ID: EZfo1k7YhSx
--HG--
extra : rebase_source : 28255d2f3b780043a9853a43c0fa4028d3128d66
2016-08-16 18:46:56 -07:00
Katie Broida[:ktbee]
07f2d654fe
Bug 1171746 - Ensure tab-specific panels close when you switch the tab. r=jaws
...
--HG--
extra : amend_source : 8c8bd60be44132befa37a50422086d9ffdae3cbe
2016-08-19 07:27:00 -04:00
Jared Wein
e6276ea7f5
Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
...
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Jared Wein
d3e296107e
Bug 1294621 - Enable the no-lonely-if rule for eslint. r=gijs
...
MozReview-Commit-ID: 8izEqc8IyCu
2016-08-12 11:50:35 -04:00
Sumit Tiwari
8d27110b79
Bug 1290698 - Replace Iterator() with Object.{values, entries}; r=mossop
...
MozReview-Commit-ID: DEoVeqEZWpd
--HG--
extra : rebase_source : 53b3a2be2cd5bfc444ce6047c44f20bb176e2337
2016-08-07 21:58:24 -04:00
Jared Wein
fd84c776c7
Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
...
MozReview-Commit-ID: EMjJ3yWt9Wt
--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00