mirrors/gecko-dev
1
0
Fork 1
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-11-12 14:20:14 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
541200 commits 621 branches 98 tags 6.6 GiB
Commit graph

52 commits

Author SHA1 Message Date
gasolin
40422612bd Bug 1361286 - add in-page messages support for Automigration module; r=Gijs 
MozReview-Commit-ID: I4xK2PkuHp3

--HG--
extra : rebase_source : 4e307d616ebe237c225ea131f9993c4df34d13ac
 2017-05-24 16:56:00 +08:00
Sebastian Hengst
b01db289d2 Backed out changeset 2612892f2785 (bug 1361286) for typos in its strings. r=backout 2017-05-27 10:27:02 +02:00
gasolin
9dbb25e1ad Bug 1361286 - add in-page messages support for Automigration module; r=Gijs 
MozReview-Commit-ID: I4xK2PkuHp3

--HG--
extra : rebase_source : e29603a260163534dfcc83bf2886994688aa97e1
 2017-05-24 16:56:00 +08:00
Mark Banner
4fb45e5b8c Bug 1365412 - Clean up various ESLint global definitions in browser/. r=mossop 
MozReview-Commit-ID: JqAm9x1XGCM

--HG--
extra : rebase_source : e9215288195f1fe683832db53d87dbe77c697b4c
 2017-05-16 22:22:42 +01:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Zibi Braniecki
3d91da8726 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike 
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N

--HG--
extra : rebase_source : 513ed31d995864939aa893e73c81ffdf591a6617
 2017-03-14 16:09:54 -07:00
Sebastian Hengst
0a04f3b9e2 Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout 2017-03-22 18:20:26 +01:00
Zibi Braniecki
c2cd68a689 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike 
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N

--HG--
extra : rebase_source : 13fa4c397ba4c79303a2cd76684b5b8c4bd17331
 2017-03-14 16:09:54 -07:00
Gijs Kruitbosch
c87ff7ce1d Bug 1335442 - update wording of automigration notification bar and add tests, r=jaws 
MozReview-Commit-ID: EkuOQmRjqOF

--HG--
extra : rebase_source : 6e3818fe8f0e739ba01852f4e152950ed880aea3
 2017-02-03 14:04:40 +00:00
Gijs Kruitbosch
48f9baa59d Bug 1335442 - deal correctly with not importing anything, r=jaws 
MozReview-Commit-ID: 3WZCxXV48Ms

--HG--
extra : rebase_source : f4ac27b2d9e26b8d9330e7b4839ccd05286c1098
 2017-02-03 14:04:23 +00:00
Gijs Kruitbosch
9b3d8d687b Bug 1335349 - add survey link option to 'undo' for automigration, r=Dolske 
MozReview-Commit-ID: BGsxAdsTu7X

--HG--
extra : rebase_source : 02dc08207387bef370e7d7926346d0c9124cd931
 2017-01-31 12:32:27 +01:00
Gijs Kruitbosch
b6dca22dac Bug 1333233 - part 2: add telemetry for the time it takes to do individual undo operations, r=bsmedberg,Dolske 
MozReview-Commit-ID: Lf7roH3EswB

--HG--
extra : rebase_source : 679b0c32b960aff809e1650e6f2cd1e32a5a935f
 2017-01-26 17:00:00 +00:00
Gijs Kruitbosch
569e10b1e0 Bug 1333233 - part 1: add telemetry for error counts from undo operations, r=bsmedberg,Dolske 
MozReview-Commit-ID: EdelbiibVWi

--HG--
extra : rebase_source : 21d376c84c66e7dc6ff3ae05f1c0a8826ad68d82
 2017-01-26 15:54:41 +00:00
Gijs Kruitbosch
d527f98427 Bug 1331800 - catch errors from history removals and don't block undo on them, r=Dolske 
MozReview-Commit-ID: JhWAs6rvBnW

--HG--
extra : rebase_source : 55afb05588c8e9a4734f0a4172ad5b7c1f1e2b23
 2017-01-18 18:07:47 +00:00
Gijs Kruitbosch
8079695555 Bug 1331888 - immediately remove (and don't reshow) notification bars once user chooses to undo, r=dao 
The automated test verifies that we remove the notification bars immediately.
Unfortunately, I couldn't think of a way to verify we won't allow reshowing the notification bar while an undo is ongoing,
because for that to happen I'd need to get one to show while an undo is ongoing, which isn't reliably possible in an
automated test.

MozReview-Commit-ID: EYHNIPEaOOo

--HG--
extra : rebase_source : 00177261942c757fdd41b3b54a9da002217d8c53
 2017-01-18 11:07:47 +00:00
Gijs Kruitbosch
a5d7653858 Bug 1330384 - force a refresh of the new tab page after automigration undo, r=jaws 
MozReview-Commit-ID: KoqbAgPkcLC

--HG--
extra : rebase_source : b5745aa5e9812dcb6fcc671b1884ca7ebfaab995
 2017-01-12 16:00:27 +00:00
Gijs Kruitbosch
66df3660b9 Bug 1322730 - display undo migration message on about:newtab, r=Dolske 
MozReview-Commit-ID: 8nIGdD9XyFH

--HG--
extra : rebase_source : edb3034962fb0f29e7bd245974096b6609718313
 2017-01-04 19:05:50 +00:00
Sebastian Hengst
e5329fbf68 Backed out changeset 9647d2c82af4 (bug 1322730) for eslint failures. r=backout 2017-01-04 20:05:06 +01:00
Gijs Kruitbosch
71aae2ba87 Bug 1322730 - display undo migration message on about:newtab, r=Dolske 
MozReview-Commit-ID: 8nIGdD9XyFH

--HG--
extra : rebase_source : 82e1ca0b02602a69510da54de9a329289b5d57ce
 2016-12-15 16:54:36 +00:00
Gijs Kruitbosch
33b498ac62 Bug 1285577 - part 4: save, use and delete implementations for import undo state, r=mak 
MozReview-Commit-ID: FVy2MMpvV65

--HG--
extra : rebase_source : e330deab2d1e2601fb9c435f3c6a5ae1d5d5cfc4
 2016-12-20 22:49:05 +00:00
Gijs Kruitbosch
70e962988d Bug 1285577 - part 3: keep track of added visits in an import and allow removing them, r=mak 
MozReview-Commit-ID: 7HCA7cKhws4

--HG--
extra : rebase_source : 711f3575093b84bf6dfb18e7750f49c58858ebbc
 2016-11-30 11:56:25 +00:00
Gijs Kruitbosch
f9853bee1e Bug 1285577 - part 2: keep track of added logins in an import and allow removing them, r=MattN 
MozReview-Commit-ID: JZbOkmZ7ZZG

--HG--
extra : rebase_source : fc36e4a137e6eef890091fb46e5f149a3cc1c46f
 2016-11-30 11:50:38 +00:00
Gijs Kruitbosch
fb5973dfbc Bug 1285577 - part 1: keep track of added bookmarks in an import and allow removing them, r=mak 
MozReview-Commit-ID: 8pKlBmDVX5X

--HG--
extra : rebase_source : 88a07f15e920d570576d0220f541f156f6da86f9
 2016-11-30 11:48:03 +00:00
Sebastian Hengst
e36b2e502c Backed out changeset 12aa73f4a982 (bug 1285577) 2016-12-20 22:54:35 +01:00
Sebastian Hengst
7ed2722b24 Backed out changeset 78a3cd5bf313 (bug 1285577) 2016-12-20 22:54:31 +01:00
Sebastian Hengst
d87d8e6640 Backed out changeset 10388e609fe3 (bug 1285577) 2016-12-20 22:54:26 +01:00
Sebastian Hengst
35be83c7bc Backed out changeset 1ffe78f2ab5a (bug 1285577) 2016-12-20 22:53:48 +01:00
Gijs Kruitbosch
cb7ec389a9 Bug 1285577 - part 4: save, use and delete implementations for import undo state, r=mak 
MozReview-Commit-ID: FVy2MMpvV65

--HG--
extra : rebase_source : 5187ce09771d6288ad864a44d1f3fd86ec60ce22
 2016-12-19 21:56:20 +00:00
Gijs Kruitbosch
75e4193f12 Bug 1285577 - part 3: keep track of added visits in an import and allow removing them, r=mak 
MozReview-Commit-ID: 7HCA7cKhws4

--HG--
extra : rebase_source : 16091dde8d36cb05d794a4a32341f57d470242be
 2016-11-30 11:56:25 +00:00
Gijs Kruitbosch
7ae04355c1 Bug 1285577 - part 2: keep track of added logins in an import and allow removing them, r=MattN 
MozReview-Commit-ID: JZbOkmZ7ZZG

--HG--
extra : rebase_source : c6f10003226c22404a31b1c33a5c4bef654fed4a
 2016-11-30 11:50:38 +00:00
Gijs Kruitbosch
d50600d402 Bug 1285577 - part 1: keep track of added bookmarks in an import and allow removing them, r=mak 
MozReview-Commit-ID: 8pKlBmDVX5X

--HG--
extra : rebase_source : 0673ea396eff2cfbcc656b7f89cd50ac850e13dc
 2016-11-30 11:48:03 +00:00
Gijs Kruitbosch
46cf9c683d Bug 1319816 - fix default browser determination on Windows 7 and below in the automigration case, r=jaws 
As noted on the bug, because we call getMigratorKeyForDefaultBrowser() multiple times,
its value no longer reflects the (deleted) registry key for subsequent calls.

While we can fix this for the automigrate case by just passing the default we determined a few
lines earlier (and that seems worth doing to avoid busywork), there are 2 small problems
with this:

1) if the default browser has no data, `migratorKey` won't be set, and so we'll call the same
method again anyway, and the message reported in the error console will be that we can't
migrate from Firefox, when the real problem is that we can't migrate from the original
default browser.

2) there are other callers besides AutoMigrate. Specifically, migration.js also calls this
method.

To deal with these, I've fixed getMigratorKeyForDefaultBrowser() to return the same
registry-based value for its lifetime if we hit the 'the default is firefox, go look for an
earlier default' case.

I've verified that either the s/aMigratorKey/migratorKey/ or the change to
getMigratorKeyForDefaultBrowser() are sufficient to make this work properly in the
automigration case.

While I was here, I also updated one of the error messages to be more explicit.

MozReview-Commit-ID: GeUNTfScMMB

--HG--
extra : rebase_source : 09b4b5fef85c4668bc0931de2c8cf3d1a32e2b42
 2016-11-23 16:06:00 +00:00
Gijs Kruitbosch
7db44ac908 Bug 1309617 - add telemetry indicating when we show the 'would you like to undo automigration' notification, r=bsmedberg,Dolske 
MozReview-Commit-ID: 7RdDyn9dQNq

--HG--
extra : rebase_source : 56015307bfc2fee6759426184d011a58205e845b
 2016-10-19 23:10:46 +01:00
Gijs Kruitbosch
8d23ab9355 Bug 1311043 - make eslint much more strict in browser/components/migration/, and fix issues, r=mikedeboer 
MozReview-Commit-ID: RXO68w3Kv3

--HG--
extra : rebase_source : b25a1976f2be89f12c2ad14e649270bacd17d174
 2016-10-18 16:03:06 +01:00
Gijs Kruitbosch
dc76ec0d07 Bug 1307382 - fix sync case for automigration undo telemetry, r=markh 
MozReview-Commit-ID: GcJw83YnhN6

--HG--
extra : rebase_source : d1ac085a62bf81e92441b9e24f3f682d1295b6dd
 2016-10-04 10:44:28 +01:00
Gijs Kruitbosch
b30d0cb67b Bug 1299445 - use distribution.ini directly to check if automigration is enabled, r=mkaply 
MozReview-Commit-ID: DINI8rnyMfe

--HG--
extra : rebase_source : b215ff2344417c844ffa9f73ed61de0fadf82998
 2016-08-31 14:58:23 +01:00
Gijs Kruitbosch
40188f3de6 Bug 1297479 - create a pref to turn off UI to undo automatic migration for use by funnelcake builds, r=Dolske 
MozReview-Commit-ID: JZQuhMxxrXU

--HG--
extra : rebase_source : f796b9504e10aa0e19a57ea312ebe337dcdb1e1d
 2016-08-23 19:30:32 +01:00
Gijs Kruitbosch
ad09f51c7d Bug 1289906 - part 2: add more generic telemetry for undo reasons, r=bsmedberg,markh 
MozReview-Commit-ID: 1wwLdY2iumV

--HG--
extra : rebase_source : 82c3edba7d04e3574e6480c16d24cfd6d63afa29
 2016-08-20 14:15:12 +01:00
Gijs Kruitbosch
53b0c89309 Bug 1289906 - part 1: use an observer to know when the user signs into sync after an undo, r=markh 
MozReview-Commit-ID: BPjUVvYdsRG

--HG--
extra : rebase_source : 96b7d88b1774afbbd605ab7e561b766af1431f53
 2016-08-22 12:39:39 +01:00
Gijs Kruitbosch
7116496e95 Bug 1289231 - part 2: remove notification after it's been displayed for 3 days, r=dolske 
MozReview-Commit-ID: CFARPDu3FnI

--HG--
extra : rebase_source : f740e99b8169f35cfa64812d6465eb31375530ae
 2016-07-26 13:14:44 +01:00
Gijs Kruitbosch
8b7f8ba630 Bug 1289231 - show 'undo' notification bar, r=dolske 
MozReview-Commit-ID: 1qy7GUSaowb

--HG--
extra : rebase_source : b9b302a0cd99fbf665958b6d4844af831e296287
 2016-08-20 12:15:02 +01:00
Gijs Kruitbosch
c99c0d5e93 Bug 1289229 - disable automigration undo if people create/change bookmarks/logins, r=mak 
MozReview-Commit-ID: DAoNV9H71Yv

--HG--
extra : rebase_source : b75fce027c28a98566523f54427b7f965e79ad52
 2016-07-26 12:48:37 +01:00
Carsten "Tomcat" Book
eec8b2656e Merge mozilla-central to autoland 2016-07-02 11:16:11 +02:00
Gijs Kruitbosch
d71d400a4a Bug 1283565 - add telemetry to determine whether undo works and how often it's unavailable due to sync, r=dolske,data-r=bsmedberg 
MozReview-Commit-ID: LwFrwbEQLtV

--HG--
extra : transplant_source : %151E%E3%5E%C0%1C%EB%3D%13%99%10%BC%C7%0C%F4%21%EEL%E8
 2016-06-30 19:02:46 +01:00
Gijs Kruitbosch
0423031f08 Bug 1283267 - save start time of automigration when we save the finished time, to ensure both actually get written to prefs, r=Dolske 
MozReview-Commit-ID: J4foRyWlJTv

--HG--
extra : rebase_source : b0c75e8a66468d063ddfd6cf21bdc0085072d64e
 2016-06-29 20:59:23 +01:00
Gijs Kruitbosch
51c24100f1 Bug 1281602 - rework automigration telemetry to use an enumerated histogram, r=bsmedberg,dolske 
MozReview-Commit-ID: 37XarohGgMN

--HG--
extra : rebase_source : 34134ccfb413eae7d25c811008a8dc647dbbeba4
extra : amend_source : 4d04fc59349673c7f6540fd9468b0d78409262ca
 2016-06-23 10:02:59 +01:00
Gijs Kruitbosch
a580940405 Bug 1271799 - implement undo functionality in automigration code, r=mak 
MozReview-Commit-ID: 28yvZyVimOx

--HG--
extra : rebase_source : 216da87f46d1bb7cde17507431b04b8bbc3367c3
 2016-06-20 12:12:28 +01:00