Commit graph

59 commits

Author SHA1 Message Date
Andrea Marchesini
e7eda19b3d Bug 1369323 - Get rid of nsScriptSecurityManager::GetNoAppCodebasePrincipal, r=bholley 2017-06-02 11:05:28 +02:00
Gijs Kruitbosch
04fd5e2765 Bug 1354155 - fix pocket button's checks for whether it is the mainview in a panelmultiview, r=mikedeboer
MozReview-Commit-ID: 6kLNAtOmCjn

--HG--
extra : rebase_source : a1428cab9a46cfac52162c3544dcf11761f4b87c
2017-05-30 16:29:45 +01:00
Honza Bambas
d6d727a69e backout of f9abb9c83452 (bug 1319111) for crashes, r=bz 2017-05-13 13:55:11 +02:00
Wes Kocher
0a1e1fe23b Backed out changeset 95ff98f1c2e5 (bug 1319111) for talos failures a=backout
MozReview-Commit-ID: Gs09moFm5rQ
2017-05-12 18:24:42 -07:00
Honza Bambas
70f62bdec1 backout of f9abb9c83452 (bug 1319111) for crashes, r=bz 2017-05-12 22:13:49 +02:00
Honza Bambas
a1b64b4694 Bug 1319111 - Expose URI to make security check against on LoadInfo (no LOAD_REPLACE flag). r=bz 2017-01-27 19:10:01 +01:00
Jared Wein
a54eda04ca Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx

--HG--
extra : rebase_source : 61d2aa91bf9474af3d72a5dea41b25dca442c1b7
2017-03-21 14:29:43 -04:00
Zibi Braniecki
3d91da8726 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N

--HG--
extra : rebase_source : 513ed31d995864939aa893e73c81ffdf591a6617
2017-03-14 16:09:54 -07:00
Sebastian Hengst
0a04f3b9e2 Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout 2017-03-22 18:20:26 +01:00
Zibi Braniecki
c2cd68a689 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N

--HG--
extra : rebase_source : 13fa4c397ba4c79303a2cd76684b5b8c4bd17331
2017-03-14 16:09:54 -07:00
Florian Quèze
9c4d40bb54 Bug 1345294 - script generated patch (+ some hand cleanup) to replace {get,set}ComplexValue for nsISupportsString by {get,set}StringPref, r=Mossop. 2017-03-16 19:26:01 +01:00
Mark Banner
09889d3184 Bug 1343519 - Change the ESLint rule 'import-browserjs-globals' to be an environment (mozilla/browser-window) to better describe the purpose of it. r=mossop
MozReview-Commit-ID: FTDV8BcMGeF

--HG--
rename : tools/lint/eslint/eslint-plugin-mozilla/lib/rules/import-browserjs-globals.js => tools/lint/eslint/eslint-plugin-mozilla/lib/environments/browser-window.js
extra : rebase_source : f0e89f2ce3cfdf343213f66a007f74a80a785c19
2017-03-01 21:29:52 +00:00
Mark Banner
e5c2479848 Bug 1336070 - Enable eslint no-undef for browser/, apart from components/ and base/content/. r=mossop
MozReview-Commit-ID: CJtpm8zlLxa

--HG--
extra : rebase_source : c6a834d5aaba0f84f5e147333085883de1a118e8
2017-02-02 09:08:42 +00:00
Mark Banner
1034b3750f Bug 1336070 - Fix no-undef issues in the pocket code. r=mixedpuppy
MozReview-Commit-ID: F5brmleBkca

--HG--
extra : rebase_source : 9c2f3cff6d3d6143b82d9d01f8cc9d8e1cbc4e3e
2017-02-02 12:08:56 +00:00
Florian Quèze
bdc1ffa608 Bug 1334831 - script-generated patch to use .remove() instead of .parentNode.removeChild, r=jaws. 2017-01-30 08:10:22 +01:00
Jared Wein
43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Florian Quèze
85611a7b6d Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Pawan Sasanka
18fcf9d31b Bug 1319849 - Remove unused browser/extensions/pocket/content/panels/img/signup_or@*x.png images, r=florian. 2017-01-12 20:36:16 +05:30
Florian Quèze
028a82f682 Bug 1329182 - remove trailing newURI null parameters in browser/, r=jaws. 2017-01-09 20:27:25 +01:00
Jared Wein
b33bfba51a Bug 1329017 - Enable the no-useless-return rule for eslint and use eslint --fix to autofix the errors. r=standard8
MozReview-Commit-ID: 2MhpvzUDgtK

--HG--
extra : rebase_source : 1df2b81badfe556928f6424c8990e4b3fde7056f
2017-01-06 12:09:28 -05:00
Jared Wein
9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Gijs Kruitbosch
88746d57d7 Bug 1320039, r=kmag,wladimir
MozReview-Commit-ID: Fsj4bG5e2gT

--HG--
extra : rebase_source : c0c3f41c945e041ebee0b1c0ca10066d43c356d5
2016-11-24 11:21:05 +00:00
Gijs Kruitbosch
b4d82c6ebc Bug 1320057, r=kmag
MozReview-Commit-ID: GlM44da7hYL

--HG--
extra : rebase_source : 8abbaade1361f87544baf41f92c42f4587dabeb4
2016-11-24 13:09:58 +00:00
Jared Wein
3718f00db1 Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Dave Townsend
8de07a19a0 Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz

--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Dave Townsend
0a2c8f9b78 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ

--HG--
extra : rebase_source : 78fe71a1d673a1c698520a9c82c6f35959614f8f
2016-11-10 14:48:04 -08:00
Mark Banner
7b8c358ec7 Bug 1315615 - Fix no-unused-vars issues in the Pocket extension. r=jaws
MozReview-Commit-ID: 4L8XCRo1PWe

--HG--
extra : rebase_source : a6019e4dfb361e91c976c01cc2273277587cb76a
2016-11-07 08:57:40 +00:00
Michael Kaply
1d801ff09b Bug 1309027 - Adjust test weight for Pocket towards non login version. r=Gijs 2016-10-11 14:45:30 -05:00
Shane Caraveo
fa891d5de4 Bug 1304151 add finished locales and a couple minor bug fixes, r=flod,Gijs
MozReview-Commit-ID: eyeDj5nxXE

--HG--
extra : rebase_source : b8cdc45622c9ffb15d9952db04829c7b9005f9f3
2016-09-28 23:29:52 -07:00
Shane Caraveo
caf8a7af28 Bug 1304142 pocket a/b test updates, r=Gijs
MozReview-Commit-ID: ChBRc81QQ7Y

--HG--
extra : rebase_source : 56c0a97d4cd56e9a9f2b6307b23d4a1f3e0f31d1
2016-09-20 16:06:37 -07:00
Thomas Wisniewski
2b28c5e2a9 Bug 1069012 - Unprefix ::placeholder pseudo-element. r=bz 2016-09-07 19:38:38 -04:00
Mark Banner
f39cd14a1c Bug 1291641 - Make the Pocket system add-on as e10s compatible. r=mixedpuppy
Move the about: handler registration into the content process, and set the flag on the add-on.

MozReview-Commit-ID: Ken10jJH9o8

--HG--
extra : rebase_source : 1b23f082718d1cfd89e89fa37f84af1fc69c2f85
2016-08-18 13:59:59 +01:00
Jared Wein
e6276ea7f5 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Jared Wein
d3e296107e Bug 1294621 - Enable the no-lonely-if rule for eslint. r=gijs
MozReview-Commit-ID: 8izEqc8IyCu
2016-08-12 11:50:35 -04:00
Jared Wein
fd84c776c7 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt

--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00
Jared Wein
169d66a3ed Bug 1292035 - Enable the space-before-blocks rule for eslint. This patch was generated using 'eslint --fix'. r=markh
MozReview-Commit-ID: 2XVoU05YvES

--HG--
extra : rebase_source : e7ed2d094c21b59dd59476b8930b75da2e6d6980
2016-08-04 03:20:25 -04:00
Jared Wein
871ed4e3ba Bug 1291855 - Enable the no-else-return rule for eslint. r=Felipe,kmag,mossop
MozReview-Commit-ID: DYOmE6xwMJh

--HG--
extra : rebase_source : bc81b68ea5599fd1815dc34dac7106eef7044483
2016-08-03 18:54:59 -04:00
Michael Kaply
93020fda4e Bug 1287476 - Clear panel handlers to avoid double page. r=Gijs 2016-07-18 12:12:01 -05:00
Pushpankar
c6670d980f Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao
--HG--
extra : rebase_source : 72d50e73baf595840a2aade57ae782e4c40d4c27
2016-07-16 10:20:04 +02:00
Michael Kaply
81750bc647 Bug 1276054 - Uplift pocket changes from partner. r=gijs
--HG--
extra : rebase_source : 3a8e112fe65af8c9fd6c9e255dd8a6594266ebb1
extra : amend_source : 441e8723b08372f3f497fb4df703f3606501a66e
2016-07-05 09:34:30 -05:00
Ryan VanderMeulen
3b8f6019c4 Backed out changeset 0b20196061d7 (bug 1276054) for browser_UITour_pocket.js failures. 2016-06-24 15:41:09 -04:00
Michael Kaply
2adb8a0678 Bug 1276054 - Uplift pocket changes from partner. r=gijs
--HG--
extra : rebase_source : 43336ecc47d8039488d032ede5003957acf9cbdd
extra : amend_source : e17d84c2951b9a002ee2fee330ddbe8d504270b8
2016-06-23 10:48:39 -05:00
Tim Huang
8ec727cd19 Bug 1267910 - Part 2: Update all existing functions of add() and getCookiesFromHost() to make them origin attributes aware. r=jdm, r=mratcliffe
--HG--
extra : rebase_source : 288c9cab8340c5cc06861d4f2c7ee43ae4de608e
2016-05-25 11:54:21 +08:00
Wes Kocher
2596f34110 Backed out 3 changesets (bug 1267910) for reports of it breaking session restore a=backout
Backed out changeset 5962f8e6d030 (bug 1267910)
Backed out changeset f8afc5cf9e0e (bug 1267910)
Backed out changeset cc202e0ac0dd (bug 1267910)
2016-05-20 21:15:17 -07:00
Tim Huang
ad550d017f Bug 1267910 - Part 2: Update all existing functions of add() and getCookiesFromHost() to make them origin attributes aware. r=jdm, r=mratcliffe
--HG--
extra : rebase_source : 3d8b306dfa83363c01c4db5d018c55fddf6d1595
2016-05-18 20:42:00 -04:00
Shane Caraveo
c75f47993f Bug 1261375 fix load handling in pocket panel, r=gijs 2016-05-04 09:19:10 -07:00
Shane Caraveo
a148305200 Bug 1261376 fix typeof check in pocket code, r=jaws 2016-04-25 11:34:22 -07:00