mirrors/gecko-dev
1
0
Fork 1
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-11-12 22:28:59 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
936853 commits 621 branches 98 tags 6.6 GiB
Commit graph

65 commits

Author SHA1 Message Date
Stanca Serban
b34c7866fc Backed out 2 changesets (bug 1926582, bug 1926394) for causing mochitests failures in browser_preserveTabPipIconOverlay.js. CLOSED TREE 
Backed out changeset 851d64f4461e (bug 1926582)
Backed out changeset 79c92abcd174 (bug 1926394)
 2024-10-23 19:41:00 +03:00
Dão Gottwald
d93431fb57 Bug 1926582 - Rename things related to moving multiselected tabs together to avoid confusion with tab groups. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D226640
 2024-10-23 14:26:43 +00:00
Dão Gottwald
dca2603d55 Bug 1926359 - Add tab group line to dragged tabs when dragging into a group. r=dwalker,tabbrowser-reviewers 
Ideally the line should cover the whole group, but I don't know that we can do this given our use of display:contents. If someone has ideas we can file a followup on that. As it stands the line will extend under dragged tabs themselves, but left or right from those there can be gaps in the line.

Differential Revision: https://phabricator.services.mozilla.com/D226634
 2024-10-23 14:21:34 +00:00
Tooru Fujisawa
9440a839ce Bug 1923593 - Ignore the active tab when handling drag and drop for the tab list. r=mak,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D225723
 2024-10-23 07:24:39 +00:00
Dão Gottwald
88d5563a41 Bug 1926058 - groupDropIndex is an index within all tabs, so use it on this.allTabs to get the tab we're looking for. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D226360
 2024-10-21 19:18:01 +00:00
Dão Gottwald
4750c05946 Bug 1925842 - Rename _numPinnedTabs to pinnedTabCount. r=tabbrowser-reviewers,jswinarton,dwalker 
Also move getDuplicateTabsToClose and getAllDuplicateTabsToClose away from essentials at the top, closer to related methods.

Differential Revision: https://phabricator.services.mozilla.com/D226279
 2024-10-21 14:35:06 +00:00
Dão Gottwald
6eecbf9e4e Bug 1925843 - Make sure groupDropIndex is in bounds. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D226250
 2024-10-21 14:15:39 +00:00
Dão Gottwald
d39af4daab Bug 1908438 - Drag and drop support for creating a group. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D225799
 2024-10-18 17:59:44 +00:00
Dão Gottwald
d2165b3a37 Bug 1924129 - When moving tabs, calculate the distance tabs need to shift by looking at the first and last moving tab rather than multiplying the size of one tab by the number of moving tabs. r=tabbrowser-reviewers,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D225365
 2024-10-15 05:54:18 +00:00
Dão Gottwald
c3c13fc1ea Bug 1924041 - Stop setting the "hashiddentabs" attribute. r=tabbrowser-reviewers,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D225325
 2024-10-11 14:25:14 +00:00
Dão Gottwald
827c481bb3 Bug 1923635 - Various MozTabbrowserTabs cleanup. r=dwalker,tabbrowser-reviewers 
Did this while working on drag-and-drop code.

Differential Revision: https://phabricator.services.mozilla.com/D225062
 2024-10-09 14:46:09 +00:00
Nikki Sharpley
0610b3748d Bug 1921761 - Compute maxTabsPerRow dynamically r=sidebar-reviewers,tabbrowser-reviewers,sfoster,dao 
Since the tabs size and padding has been updated, the max number of tabs
per row is no longer 6. There is also a plan to make the number of tabs per
row dynamic based on an adjustable sidebar main width. Additionally, There
is a proposed patch to pack pinned tabs when expanded - Bug 1921081. Hence,
this patch aims to make the `maxTabsPerRow` variable dynamic too.

Differential Revision: https://phabricator.services.mozilla.com/D224315
 2024-10-08 18:31:28 +00:00
Gregory Pappas
286d8afd8b Bug 1921762 - Fix horizontal tabstrip drop animation r=tabbrowser-reviewers,nsharpley,dao 
Differential Revision: https://phabricator.services.mozilla.com/D224157
 2024-10-01 13:52:39 +00:00
Gijs Kruitbosch
c9eba88f1f Bug 1920319 - add dedicated keypress handler for new tab buttons, r=tabbrowser-reviewers,dao 
Right now, tabbrowser relies on browser-toolbarKeyNav.js for keyboard access to these buttons on macOS.
There's also toolkit handling for space, but not enter, in https://searchfox.org/mozilla-central/rev/9fe73403523732f57cd82d30590ecc272fb0b165/toolkit/content/widgets/button.js#27-34 .
In vertical tabs mode, browser-toolbarKeyNav does not help us as the buttons aren't in the toolbox.
On Nightly, the containers-related code in https://searchfox.org/mozilla-central/rev/9fe73403523732f57cd82d30590ecc272fb0b165/browser/components/tabbrowser/content/tabs.js#1422-1428
adds the buttons to gClickAndHoldListeners, which have their own keypress handling. This happens whenever
containers are enabled. Those are not enabled by default on non-nightly, and so we end up missing a keypress
handler in vertical tabs mode on non-Nightly on macOS.

This is all a big mess and we should probably figure out a better solution. But given this needs beta uplift,
the expedient solution seems to be a dedicated listener and making sure that only 1 listener is invoked.

Differential Revision: https://phabricator.services.mozilla.com/D224094
 2024-09-30 13:15:28 +00:00
Dão Gottwald
595c8a4069 Bug 1920922 - Update hidden tab checks to account for tabs in collapsed groups. r=tabbrowser-reviewers,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D223469
 2024-09-26 04:18:45 +00:00
Jeremy Swinarton
da27b3a6df Bug 1920731: Prevent gBrowser.tabs from returning tab groups r=dwalker,sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D223362
 2024-09-25 17:31:38 +00:00
Dão Gottwald
6331e3d00d Bug 1919790 - Stop returning hidden tabs or tabs from collpased groups in _findTabToBlurTo. r=dwalker,tabbrowser-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D223292
 2024-09-25 05:08:37 +00:00
Kelly Cochrane
e668b13784 Bug 1906888 - Update focus order and move new tab button to the bottom for vertical tabs r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sidebar-reviewers,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D221244
 2024-09-20 11:40:04 +00:00
Butkovits Atila
b99eba59d5 Backed out changeset fb2f7f9f6def (bug 1906888) for causing failures at browser_newtabButton.js. CLOSED TREE 2024-09-19 22:04:46 +03:00
Kelly Cochrane
5f2ec97144 Bug 1906888 - Update focus order and move new tab button to the bottom for vertical tabs r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sidebar-reviewers,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D221244
 2024-09-19 15:54:02 +00:00
Dão Gottwald
ed5c86c8ca Bug 1918676 - Disable tab opening / closing animations and tab size locking in vertical mode, properly set --tab-min-width rather than overriding min-width in vertical mode, and restrict some styles to horizontal mode. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,kcochrane,sclements,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D222202
 2024-09-17 08:21:24 +00:00
Noemi Erli
c7dfc168f3 Backed out 2 changesets (bug 1918676, bug 1918638) for causing browser chrome failures 
Backed out changeset c36ab1469893 (bug 1918638)
Backed out changeset f973faab6674 (bug 1918676)
 2024-09-17 02:34:41 +03:00
Dão Gottwald
aa7d577032 Bug 1918676 - Disable tab opening / closing animations and tab size locking in vertical mode, properly set --tab-min-width rather than overriding min-width in vertical mode, and restrict some styles to horizontal mode. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,kcochrane,sclements,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D222202
 2024-09-16 19:53:42 +00:00
Kelly Cochrane
b4412f7c8c Bug 1911889 - Update tab mute/soundplaying/activemedia-blocked icon styling r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D219495
 2024-09-13 17:51:03 +00:00
Iulian Moraru
056ccbf498 Backed out changeset e6b82ff4e092 (bug 1911889) for causing bc failures on browser_tabIconOverlayPiP.js. CLOSED TREE 2024-09-13 19:14:13 +03:00
Kelly Cochrane
fc47bb913d Bug 1911889 - Update tab mute/soundplaying/activemedia-blocked icon styling r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D219495
 2024-09-13 14:46:04 +00:00
Nikki Sharpley
669717834d Bug 1914438 - Long press on New tab button does not offer to open a new Container tab r=sidebar-reviewers,tabbrowser-reviewers,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D221681
 2024-09-11 22:43:59 +00:00
Nikki Sharpley
d033a176ec Bug 1913971 - Improve drag experience for pinned tabs in expanded vertical tabs r=sidebar-reviewers,sclements,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D221078
 2024-09-11 18:18:36 +00:00
Norisz Fay
4a8bd8efdf Backed out changeset 870b68c06bd7 (bug 1914438) for causing bc failures on browser_newtabButton.js CLOSED TREE 2024-09-11 19:05:37 +03:00
Nikki Sharpley
b37604bebc Bug 1914438 - Long press on New tab button does not offer to open a new Container tab r=sidebar-reviewers,tabbrowser-reviewers,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D221681
 2024-09-11 13:02:32 +00:00
Sarah Clements
adf70151f7 Bug 1913279 - Fix vertical tabs issue with selected tab not scrolling on overflow r=tabbrowser-reviewers,desktop-theme-reviewers,dao 
* Remove condition in tabs.js that prohibited overflow attribute being added for vertical orientation
* Remove redundant overflow-y:auto for #tabbrowser-arrowscrollbox and set a min-height for vertical tabs

Differential Revision: https://phabricator.services.mozilla.com/D221133
 2024-09-09 13:49:26 +00:00
Dão Gottwald
6c204fa4e1 Bug 1916941 - Vertical new tab button cleanup. r=desktop-theme-reviewers,sidebar-reviewers,kcochrane 
Details in the bug.

Differential Revision: https://phabricator.services.mozilla.com/D221117
 2024-09-06 14:04:43 +00:00
Dão Gottwald
149c2d7f96 Bug 1915599 - Consolidate tabbrowser arrowscrollbox initialization and overflow/overflowing attribute checks. r=extension-reviewers,desktop-theme-reviewers,jswinarton,emilio,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D220594
 2024-09-04 08:18:46 +00:00
Dave Townsend
2d92259aee Bug 1915111: Double clicking in the vertical tab strip should open a new tab. r=desktop-theme-reviewers,tabbrowser-reviewers,sclements,dao 
This solves two problems. First we must make the tabbrowser-tabs instance
fill the remaining space in the sidebar while at the moment it is constrained
to the height of the tabs. Then we allow the double click event to be
handled when vertical tabs and tabs in titlebar are enabled.

Differential Revision: https://phabricator.services.mozilla.com/D220269
 2024-08-30 08:20:47 +00:00
Dão Gottwald
de4baf9757 Bug 345399 - Update scroll buttons' disabled state when the scrollbox width changes. r=emilio,dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220153
 2024-08-27 20:19:18 +00:00
DJ
fe364e14ff Bug 1908419 - add method to retrieve list of groups from tabContainer. r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220142
 2024-08-26 16:59:51 +00:00
Dão Gottwald
e62576b18b Bug 1914779 - Clean up getting the last tab in tabs.js. r=jswinarton,dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220076
 2024-08-26 14:39:43 +00:00
Dão Gottwald
3269eaa02e Bug 1914703 - Fix up scrolled to end check. r=emilio 
I first tried to fix the disabled property, but this turned into a rabbit hole that seems a bit too risky at this stage. With some luck, this may be the only place accessing these buttons' disabled property. Medium-term we still need to fix the property, ideally by making the disabled attribute a standard boolean one.

Differential Revision: https://phabricator.services.mozilla.com/D220122
 2024-08-26 13:06:21 +00:00
Dão Gottwald
d90ec3853e Bug 1914519 - Consolidate vertical mode and rtl checks in tab bar code. r=jswinarton,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D219933
 2024-08-23 20:17:39 +00:00
Emilio Cobos Álvarez
a1833e9d5a Bug 1914544 - Make sure we don't open a new tab for doubleclick on the overflow buttons. 
MANUAL PUSH: Fixes browser_overflowScroll.js on Linux CLOSED TREE.
 2024-08-23 18:47:10 +01:00
Emilio Cobos Álvarez
67b36870e4 Bug 1914544 - Fix tab bar doubleclick check. r=dao,tabbrowser-reviewers 
Make sure that we actually hit our arrowscrollbox (not any random
scrollbox).

Differential Revision: https://phabricator.services.mozilla.com/D219972
 2024-08-23 14:55:27 +00:00
Emilio Cobos Álvarez
b586de292c Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers 
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.

Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.

Differential Revision: https://phabricator.services.mozilla.com/D219249
 2024-08-21 12:23:34 +00:00
Cristian Tuns
3447333df4 Backed out changeset 6fb2cecebdd8 (bug 1913322) for causing multiple failures. CLOSED TREE 2024-08-20 21:01:50 -04:00
Emilio Cobos Álvarez
9a8a267f79 Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers 
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.

Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.

Differential Revision: https://phabricator.services.mozilla.com/D219249
 2024-08-20 22:31:22 +00:00
Iulian Moraru
e0e41bf500 Backed out changeset 1658290c1b95 (bug 1913322) for causing overflow related failures. CLOSED TREE 2024-08-20 17:54:54 +03:00
Emilio Cobos Álvarez
47c031614c Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers 
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.

Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.

Differential Revision: https://phabricator.services.mozilla.com/D219249
 2024-08-20 12:58:16 +00:00
Jeremy Swinarton
8c4d173464 Bug 1912275: Collapsing tab group changes selected tab r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D218888
 2024-08-14 13:56:29 +00:00
Jeremy Swinarton
40668a4a02 Bug 1908416: gBrowser.visibleTabs handles tab groups r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D218796
 2024-08-08 16:23:24 +00:00
Sam Foster
5d032fb4be Bug 1899580 - Exclude collapsed vertical tabs from indicator-replaces-favicon behavior. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements 
- Ensure everything that sets .expanded on sidebar-main uses the toggleExpanded method

Differential Revision: https://phabricator.services.mozilla.com/D217507
 2024-08-07 18:51:26 +00:00
Dão Gottwald
542523f78e Bug 1908412 - add API for adding tabs to a group. r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D218204
 2024-08-05 09:25:19 +00:00