Brad Werth
bed36b14d5
Bug 1457288 - Part 2: Clamp shape-margin distance field operands to prevent int multiplication overflow when allocating. r=mats
2018-04-27 18:10:51 -07:00
Brad Werth
914c3f1d6c
Bug 1457288 - Part 1: Clamp EllipseShapeInfo distance field operands to the maximum shape-margin we are willing to compute. r=mats
...
MozReview-Commit-ID: IXAV0uaxB0R
2018-04-27 13:10:08 -07:00
Brad Werth
9b1031c464
Bug 1265342 Part 7: Implement shape-margin for shape-outside: shape-box. r=dholbert
...
MozReview-Commit-ID: 67vq9Gcr8qJ
--HG--
extra : rebase_source : afea3fab0bfd0ad538ddc902f9a8ffedd4a65862
2018-02-26 14:47:31 -08:00
Brad Werth
8511677375
Bug 1265342 Part 6b: Implement shape-margin for shape-outside: inset, for general case of shape-margin > 0. r=dholbert
...
MozReview-Commit-ID: 4pjALPSIBhI
--HG--
extra : rebase_source : b8c065173e04033795baa67c4fcf8222103182cb
2018-04-17 11:39:50 -07:00
Brad Werth
c8f1b46489
Bug 1265342 Part 6a: Implement shape-margin for shape-outside: inset, for some special cases with shape-margin > 0. r=dholbert
...
MozReview-Commit-ID: AEOksiuM0GJ
--HG--
extra : rebase_source : edc6f6040760d3facb3a7f6bcdc39f1d8fa208f0
2018-04-13 11:29:14 -07:00
Brad Werth
b935ad1265
Bug 1265342 Part 5d: Move EllipseShapeInfo class definition ahead of RoundedBoxShapeInfo so it can be referenced by rounded boxes. r=dholbert
...
MozReview-Commit-ID: G8qdPlnh8kY
--HG--
extra : rebase_source : 2917054937f488c601394f1d244151c9c3df7596
2018-04-17 11:59:11 -07:00
Brad Werth
eb8a0661ae
Bug 1265342 Part 5c: Add some asserts to ensure ellipse distance field index values are in-bounds. r=dholbert
...
MozReview-Commit-ID: CpuWWaLh1CX
--HG--
extra : rebase_source : 6db8ba9191f1211d8ea2435b23dc13caae39955c
2018-04-20 13:43:36 -07:00
Brad Werth
6c6be70823
Bug 1265342 Part 5b: Complete the implementation of shape-margin for ellipse (handling shape-margin: > 0). r=dholbert
...
MozReview-Commit-ID: CovCfk5ryEn
--HG--
extra : rebase_source : 4691876fd2afb2833ddf416821988f59abd4c019
2018-04-11 15:18:32 -07:00
Brad Werth
6c5a82a38c
Bug 1265342 Part 5a: Implement shape-margin for shape-outside: circle and ellipse (ellipse only for shape-margin: 0). r=dholbert
...
MozReview-Commit-ID: HeipoUTkqUE
--HG--
extra : rebase_source : 21de8ff25a10ea8007a310e91254cf17346cdd3f
2018-02-26 13:13:03 -08:00
Brad Werth
104fcf3ad7
Bug 1265342 Part 4b: Add some logic and asserts to ensure distance field index values and image index values are in-bounds. r=dholbert
...
MozReview-Commit-ID: 1C9vB14Qhyj
--HG--
extra : rebase_source : 1f5d912deb27c4f1e2a65e609d6ebc825ab34790
2018-04-20 14:04:15 -07:00
Brad Werth
314184fbb8
Bug 1265342 Part 4a: Complete the implementation of shape-margin for shape-outside: image (handling shape-margin: > 0). r=dholbert
...
MozReview-Commit-ID: 4xqfqWB78Oh
--HG--
extra : rebase_source : 5ca9e80eb25b9100f7bcbc5a7936b3ec5ce3f1cd
2018-02-22 11:11:03 -08:00
Brad Werth
e53f7f51ac
Bug 1265342 Part 3: Stub in shape-margin for shape-outside: image, by implementing only for shape-margin: 0. r=dholbert
...
MozReview-Commit-ID: 2gVRyQtd7Io
--HG--
extra : rebase_source : 1e3cd2e71d7dbb89db74c5ce8ac88695c70843a1
2018-03-12 17:04:34 -07:00
Brad Werth
eeb34f4713
Bug 1265342 Part 2b: Refactor interval creation for shape-outside:image. r=dholbert
...
MozReview-Commit-ID: LnzQPsSBVqY
--HG--
extra : rebase_source : 20ff59b099ae7e7f0f3e5207b017f919d5b6f661
2018-02-28 10:43:43 -08:00
Brad Werth
405f362460
Bug 1265342 Part 2a: Move interval binary search method into ShapeInfo. r=dholbert
...
MozReview-Commit-ID: BxJxIU0RVAo
--HG--
extra : rebase_source : c822c3fd56fe8fc11aeb7aab10afa440a2a53931
2018-04-11 14:05:06 -07:00
Narcis Beleuzu
a07765b336
Backed out 20 changesets (bug 1265342) for mochitest-plain-headless failures on layout/style/test/test_first_letter_restrictions.html. CLOSED TREE
...
Backed out changeset 6c80ec2d0398 (bug 1265342)
Backed out changeset 62d571916086 (bug 1265342)
Backed out changeset fd247f38f8a7 (bug 1265342)
Backed out changeset 83aee3dafe4b (bug 1265342)
Backed out changeset 9b200122014e (bug 1265342)
Backed out changeset a90aa063b2fd (bug 1265342)
Backed out changeset 0791ff3d9194 (bug 1265342)
Backed out changeset 7109288f10b3 (bug 1265342)
Backed out changeset 048cce2fb99f (bug 1265342)
Backed out changeset c8e3dbc6c729 (bug 1265342)
Backed out changeset 09da0968333a (bug 1265342)
Backed out changeset d16f7ff85677 (bug 1265342)
Backed out changeset 53eb7f14463d (bug 1265342)
Backed out changeset 64fc631ef122 (bug 1265342)
Backed out changeset 332382c708e1 (bug 1265342)
Backed out changeset a8695981eec0 (bug 1265342)
Backed out changeset ce473fa5f1f4 (bug 1265342)
Backed out changeset 5ee470e75a53 (bug 1265342)
Backed out changeset 802aa95a52d9 (bug 1265342)
Backed out changeset 5da0c34c9600 (bug 1265342)
2018-04-24 22:31:15 +03:00
Brad Werth
9dcd875e5a
Bug 1265342 Part 7: Implement shape-margin for shape-outside: shape-box. r=dholbert
...
MozReview-Commit-ID: 67vq9Gcr8qJ
--HG--
extra : rebase_source : 9bb27215f51bb914b1e9e185419b605b3ae29167
2018-02-26 14:47:31 -08:00
Brad Werth
24f86cb132
Bug 1265342 Part 6b: Implement shape-margin for shape-outside: inset, for general case of shape-margin > 0. r=dholbert
...
MozReview-Commit-ID: 4pjALPSIBhI
--HG--
extra : rebase_source : 017c887e4f8d6f2ca0c2293fcb910b0daec1e06d
2018-04-17 11:39:50 -07:00
Brad Werth
df2128a244
Bug 1265342 Part 6a: Implement shape-margin for shape-outside: inset, for some special cases with shape-margin > 0. r=dholbert
...
MozReview-Commit-ID: AEOksiuM0GJ
--HG--
extra : rebase_source : f12a98ebfc393d97dc2fba352427486f2a75feda
2018-04-13 11:29:14 -07:00
Brad Werth
14845e4b61
Bug 1265342 Part 5d: Move EllipseShapeInfo class definition ahead of RoundedBoxShapeInfo so it can be referenced by rounded boxes. r=dholbert
...
MozReview-Commit-ID: G8qdPlnh8kY
--HG--
extra : rebase_source : 6f955c4f9e6017f86898f88790f434d0af566f2d
2018-04-17 11:59:11 -07:00
Brad Werth
5b973bb3ed
Bug 1265342 Part 5c: Add some asserts to ensure ellipse distance field index values are in-bounds. r=dholbert
...
MozReview-Commit-ID: CpuWWaLh1CX
--HG--
extra : rebase_source : b58257bba2548d2b7e4944c5902ff5e5f7dcd42a
2018-04-20 13:43:36 -07:00
Brad Werth
c3a504881e
Bug 1265342 Part 5b: Complete the implementation of shape-margin for ellipse (handling shape-margin: > 0). r=dholbert
...
MozReview-Commit-ID: CovCfk5ryEn
--HG--
extra : rebase_source : 9a38c1261576a92de9fd75e21f49f787568bec25
2018-04-11 15:18:32 -07:00
Brad Werth
c31ad119a7
Bug 1265342 Part 5a: Implement shape-margin for shape-outside: circle and ellipse (ellipse only for shape-margin: 0). r=dholbert
...
MozReview-Commit-ID: HeipoUTkqUE
--HG--
extra : rebase_source : 7773717856174150c477c222aae50738dab004bb
2018-02-26 13:13:03 -08:00
Brad Werth
c39ecb3117
Bug 1265342 Part 4b: Add some logic and asserts to ensure distance field index values and image index values are in-bounds. r=dholbert
...
MozReview-Commit-ID: 1C9vB14Qhyj
--HG--
extra : rebase_source : 1809d4c2280240d699df434b50c3058d553c8875
2018-04-20 14:04:15 -07:00
Brad Werth
d80b315cb1
Bug 1265342 Part 4a: Complete the implementation of shape-margin for shape-outside: image (handling shape-margin: > 0). r=dholbert
...
MozReview-Commit-ID: 4xqfqWB78Oh
--HG--
extra : rebase_source : 3477ac91bfd4a047a11e1f7853ca5c43572b6795
2018-02-22 11:11:03 -08:00
Brad Werth
2069eb32a1
Bug 1265342 Part 3: Stub in shape-margin for shape-outside: image, by implementing only for shape-margin: 0. r=dholbert
...
MozReview-Commit-ID: 2gVRyQtd7Io
--HG--
extra : rebase_source : 0421d9fd1328a1c3d9b619f2a0467d8e7ac52770
2018-03-12 17:04:34 -07:00
Brad Werth
39c4660609
Bug 1265342 Part 2b: Refactor interval creation for shape-outside:image. r=dholbert
...
MozReview-Commit-ID: LnzQPsSBVqY
--HG--
extra : rebase_source : ee1985749b976833e850d27992d0709c5631d3a9
2018-02-28 10:43:43 -08:00
Brad Werth
357b2601a5
Bug 1265342 Part 2a: Move interval binary search method into ShapeInfo. r=dholbert
...
MozReview-Commit-ID: BxJxIU0RVAo
--HG--
extra : rebase_source : 5ce9a0b8b2ad2d4c513ffaf77d6ad1895a0b84e0
2018-04-11 14:05:06 -07:00
Sebastian Hengst
0819f35e51
Backed out 4 changesets (bug 525063) on request from Andi. a=backout
...
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Tristan Bourvon
a3a77c0312
Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan
2018-04-10 21:11:02 +02:00
Ting-Yu Lin ext:(%2C%20Brad%20Werth%20%3Cbwerth%40mozilla.com%3E)
6c72d34781
Bug 1404222 Part 1: Implement shape-outside: <image>. r=dbaron,dholbert
...
When creating ImageShapeInfo, it's likely that the image is still decoding.
Part 2 will add mechanism to trigger reflow after the image is ready.
2018-01-25 14:55:18 +08:00
Ryan VanderMeulen
e5ec40f40c
Backed out 11 changesets (bug 1404222) for static analysis failures on a CLOSED TREE.
...
Backed out changeset a6a99136300c (bug 1404222)
Backed out changeset 7183b8104399 (bug 1404222)
Backed out changeset a1e4294c1c59 (bug 1404222)
Backed out changeset b79d6e8318db (bug 1404222)
Backed out changeset 0450620fdabd (bug 1404222)
Backed out changeset 026c74a92d04 (bug 1404222)
Backed out changeset 50ac4167f702 (bug 1404222)
Backed out changeset 59038f2db68a (bug 1404222)
Backed out changeset f6b9096da915 (bug 1404222)
Backed out changeset 4e0baffdd79b (bug 1404222)
Backed out changeset 57eeb849ab88 (bug 1404222)
2018-04-02 17:57:27 -04:00
Ting-Yu Lin ext:(%2C%20Brad%20Werth%20%3Cbwerth%40mozilla.com%3E)
8efec59d87
Bug 1404222 Part 1: Implement shape-outside: <image>. r=dbaron,dholbert
...
When creating ImageShapeInfo, it's likely that the image is still decoding.
Part 2 will add mechanism to trigger reflow after the image is ready.
2018-01-25 14:55:18 +08:00
Ting-Yu Lin
278ab9f9a4
Bug 1426065 Part 2 - Drop mozilla prefix in nsFloatManager.cpp. r=dholbert
...
The cpp file already has "using namespace mozilla;".
MozReview-Commit-ID: L2OPyBuvg9q
--HG--
extra : rebase_source : d53b9ab09163a2bb03fc1cebe059aca0f6bb53a1
2017-12-19 15:22:36 +08:00
Ting-Yu Lin
6b9beb409e
Bug 1426065 Part 1 - Move ShapeInfo and its dervied classes from header to cpp. r=dholbert
...
ShapeInfo and its derived classes are private to nsFloatManager, which don't
need to be in the header. Move them to cpp to make compile faster after
changing them.
MozReview-Commit-ID: MRkBGoqcPj
--HG--
extra : rebase_source : bc1de4269629f881e49af0d4faba89e8fbd4e460
2017-12-19 15:06:10 +08:00
Ting-Yu Lin
80fee1a237
Bug 1418224 Part 3 - Add shape-outside: <image> support to style system. r=heycam
...
Some Gecko style system files are modified to prevent assertions and
crashing, and to keep test failures on stylo disabled builds to minimum.
MozReview-Commit-ID: GuxAeCTz0xx
--HG--
extra : rebase_source : 2342085d13a50535836be46d75a731641d0fc49e
2017-11-17 16:34:37 +08:00
Ting-Yu Lin
56d6b694a2
Bug 1418224 Part 2 - Extract ShapeInfo::CreateBasicShape(). r=heycam
...
MozReview-Commit-ID: DZ1O0CzzsyT
--HG--
extra : rebase_source : d5f03aeea3b10810b07fb001b9ff4dbfc7e03c64
2017-11-21 18:24:34 +08:00
dluca
627438bf3c
Backed out 4 changesets (bug 1418224) for build bustages r=backout on a CLOSED TREE
...
Backed out changeset 3ef8715cb8d7 (bug 1418224)
Backed out changeset 0d58d9fed90d (bug 1418224)
Backed out changeset faad7f275749 (bug 1418224)
Backed out changeset 1e86ff6b95ae (bug 1418224)
2017-11-27 07:42:50 +02:00
Ting-Yu Lin
0a432576a1
Bug 1418224 Part 3 - Add shape-outside: <image> support to style system. r=heycam
...
Some Gecko style system files are modified to prevent assertions and
crashing, and to keep test failures on stylo disabled builds to minimum.
MozReview-Commit-ID: GuxAeCTz0xx
--HG--
extra : rebase_source : 97c8b3900e4492ac03158a38aa03f7c044b71e0f
2017-11-17 16:34:37 +08:00
Ting-Yu Lin
fdbb843588
Bug 1418224 Part 2 - Extract ShapeInfo::CreateBasicShape(). r=heycam
...
MozReview-Commit-ID: DZ1O0CzzsyT
--HG--
extra : rebase_source : 41d23db4caef61663003c8ea1453363c90cdeca7
2017-11-21 18:24:34 +08:00
Daniel Holbert
680815cd6e
Bug 1412346 part 5: (automated patch) Switch a bunch of C++ files in layout to use our standard mode lines. r=jfkthame
...
This patch was generated automatically by the "modeline.py" script, available
here: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py
For every file that is modified in this patch, the changes are as follows:
(1) The patch changes the file to use the exact C++ mode lines from the
Mozilla coding style guide, available here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line
(2) The patch deletes any blank lines between the mode line & the MPL
boilerplate comment.
(3) If the file previously had the mode lines and MPL boilerplate in a
single contiguous C++ comment, then the patch splits them into
separate C++ comments, to match the boilerplate in the coding style.
MozReview-Commit-ID: EuRsDue63tK
--HG--
extra : rebase_source : 3356d4b80ff6213935192e87cdbc9103fec6084c
2017-10-27 10:33:53 -07:00
Ting-Yu Lin
d944131798
Bug 1404243 Part 3 - Remove refcount for StyleBasicShape, and use UniquePtr to hold it. r=heycam
...
After StyleBasicShape is set to StyleShapeSource, it's life cycle never go
beyond StyleShapeSource, so I make StyleBasicShape hold by a UniquePtr in
StyleShapeSource.
Also, replace all raw pointers to StyleBasicShape by UniquePtr in all APIs.
MozReview-Commit-ID: 1MfIFjP8TsQ
--HG--
extra : rebase_source : bdbbd47de57e0bc610e37913752ab8413f62588a
2017-09-25 18:50:24 +08:00
Jonathan Kew
a8f81efd8e
Bug 1365982 - Attach frame properties to each frame instead of looking them up in a hashtable on the prescontext. r=mats
...
--HG--
rename : layout/base/FramePropertyTable.cpp => layout/base/FrameProperties.cpp
rename : layout/base/FramePropertyTable.h => layout/base/FrameProperties.h
2017-05-27 12:36:00 +01:00
L. David Baron
a852d0d5ce
Bug 1367190 patch 1 - Convert the 4 objects that use nsPresArena::AllocateBySize to use AllocateByObjectID. r=mats
...
MozReview-Commit-ID: 3LaG8Daon6V
--HG--
extra : transplant_source : %AB%00%3E%F6B%13%B8%84%C7%7B%24%08%8BU%8A%91%7DA%2C%A1
2017-05-24 09:35:26 -04:00
cku
c486e7014c
Bug 1340044 - Part 2. Rename value in StyleGeometryBox. r=heycam
...
This change is to use gecko_enum_prefix in helpers.mako.rs, so that we do not
need to manually write code for nsStyleDisplay::mTransformBox.
MozReview-Commit-ID: 7UAL0iUcSIO
--HG--
extra : rebase_source : e99b7c163991df7ef3e7c0404fcef1832718a150
2017-03-16 15:18:10 +08:00
Ting-Yu Lin
1ab8a867a4
Bug 1326409 Part 6 - Convert aBasicShape to a pointer to a const value. r=dholbert
...
To address reviewer's comments in bug 1326409 comment 13 and comment 14.
MozReview-Commit-ID: FiUXXk4O8N7
2017-03-13 12:03:40 +08:00
Ting-Yu Lin
620f7841b7
Bug 1326409 Part 5 - Implement shape-outside: polygon(). r=dholbert
...
The <fill-rule> in the polygon() syntax is not handled because it doesn't
matter to shape-outside at all.
The reftests are numbered from 018 to avoid conflict with the w3c upstream
ones according to this list.
https://test.csswg.org/harness/results/css-shapes-1_dev/grouped/
Reftest 018 to 025 are under various writing-modes, 026 to 029 are testing
empty float area, 030 to 031 are testing polygon containing horizontal
lines.
MozReview-Commit-ID: FPUbMdZsvu6
2017-03-13 12:03:40 +08:00
Ting-Yu Lin
aa5bf0b087
Bug 1326409 Part 3 - Remove unneeded WritingMode parameter. r=dholbert
...
Remove WritingMode parameter from LineRight() and LineLeft() in both
FloatInfo and ShapeInfo.
Bug 1316549 Part 3 added the parameter to compute the border radii under
writing-modes correctly. However, bug 1326407 Part 6 later made us cache
border radii, so the WritingMode parameter is no longer needed.
MozReview-Commit-ID: DFhm5d51OXJ
2017-03-13 12:03:39 +08:00
cku
cfc6e5755f
Bug 1336905 - Part 1. Remove StyleShapeSource's template argument. r=heycam,TYLin
...
MozReview-Commit-ID: FHTwGyXHsce
--HG--
extra : rebase_source : c043e4790bc2c84e4f3735a95c8ef0d9aa268986
extra : source : fb3c04effbd191767b1ff3e46c3c2d416ac8ee37
2017-02-21 23:26:17 +08:00
Ting-Yu Lin
e5836e823a
Bug 1326407 Part 8 - Implement shape-outside: inset(). r=dbaron
...
The reftests have passed
layout/reftests/w3c-css/submitted/check-for-references.sh.
MozReview-Commit-ID: JZk1fo8SxgV
--HG--
extra : rebase_source : 5010c7e32bfe383c855ea5899f84860c4c747658
2017-02-16 10:51:49 +08:00
Ting-Yu Lin
859109777e
Bug 1326407 Part 7 - Rename BoxShapeInfo to RoundedBoxShapeInfo. r=dbaron
...
The radii has been cached in the BoxShapeInfo in the previous part. Hence
the rename.
This class will be used to implement inset() in the next part, so the rect
stored isn't necessarily the rect of the <shape-box>. It could be the inset
rectangle. Therefore I rename mShapeBoxRect to mRect to avoid any confusion.
MozReview-Commit-ID: J0hpQDsbMyN
--HG--
extra : rebase_source : 76cf50e1819a586199934c29f46d467a1b86a9ec
2017-02-16 10:51:48 +08:00