Commit graph

108 commits

Author SHA1 Message Date
Stephen Thompson
6a9f38a71d Bug 1927540 - drop tab into/out of end of tab groups r=dao,tabbrowser-reviewers
When all tabs are inside of tab groups, this patch allows the user to drag a tab to become a standalone tab at the end of the tab stirp. The user also has the ability to drop the tab into the end of the tab group at the end of the tab strip if the tab is dropped closer to the tab group.

Differential Revision: https://phabricator.services.mozilla.com/D229440
2024-11-19 20:26:31 +00:00
Stephen Thompson
63ba53c55c Bug 1921830 - move active tab left/right into/out of tab groups r=dao
Adds tab group contexts to the functionality behind keyboard shortcuts for moving the active tab left/right in the tab strip

Differential Revision: https://phabricator.services.mozilla.com/D227253
2024-11-19 19:40:21 +00:00
Greg Stoll
f74081cab8 Bug 1926390 part 2 - add telemetry and tests for explicit tab unloading r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D229141
2024-11-18 15:02:41 +00:00
codesuki
571e653b9a Bug 655445 - Add setting to control position of tabs opened from pinned tabs. r=dao,tabbrowser-reviewers
This patch introduces `browser.tabs.insertAfterCurrentExceptPinned`.
Setting it to `true` open links from pinned tabs at the end of the tabbar.

Differential Revision: https://phabricator.services.mozilla.com/D69489
2024-11-15 11:51:17 +00:00
Dão Gottwald
18931973a9 Bug 1928166 - Maintain tab order when ungrouping. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228990
2024-11-14 19:52:58 +00:00
Florian Quèze
070d875bcf Bug 1930163 - Remove support for setting a legacy telemetry scalar when a notification bar is shown, r=mstriemer,tabbrowser-reviewers,reusable-components-reviewers,dao.
Differential Revision: https://phabricator.services.mozilla.com/D228453
2024-11-14 17:25:13 +00:00
Dão Gottwald
c834ce0cb8 Bug 1930654 - Convert _gBrowser to a modern JS class. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D228667
2024-11-14 16:33:19 +00:00
Alexandru Marc
59ccd93292 Backed out changeset 365a4dc7fe2d (bug 1930654) for causing bc failures @ browser_standalone_application_chooser_window_fallback.js . CLOSED TREE 2024-11-14 17:37:47 +02:00
Dão Gottwald
a755a9da97 Bug 1930654 - Convert _gBrowser to a modern JS class. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D228667
2024-11-14 14:02:57 +00:00
Simon Friedberger
ee24230231 Bug 1919544 - Do not HTTPS-First upgrade URLs with http:// scheme r=mak,necko-reviewers,urlbar-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228588
2024-11-13 17:15:57 +00:00
Sandor Molnar
f796cfe131 Backed out changeset c4dfee1f9194 (bug 1919544) for causing bc failures @ browser_UrlbarInput_formatValue.js CLOSED TREE 2024-11-13 15:20:39 +02:00
Simon Friedberger
3f59148693 Bug 1919544 - Do not HTTPS-First upgrade URLs with http:// scheme r=mak,necko-reviewers,urlbar-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228588
2024-11-13 11:44:43 +00:00
Jeremy Swinarton
a5e3795c2b Bug 1908422: Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.

This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.

Differential Revision: https://phabricator.services.mozilla.com/D226397
2024-11-12 16:34:19 +00:00
Dão Gottwald
95e696eb77 Bug 1930608 - Refactor _updateAfterMoveTabTo. r=jswinarton,tabbrowser-reviewers
Also simplify moveTabToStart and moveTabToEnd.

Differential Revision: https://phabricator.services.mozilla.com/D228646
2024-11-12 14:09:52 +00:00
Dão Gottwald
d8ffcc5a06 Bug 1926371 - Make "Remove from group" not move the tab into another group. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D228636
2024-11-12 14:09:52 +00:00
Stephen Thompson
fbc6382c6c Bug 1929384 - do not close window if there are still collapsed tab groups r=dao,tabbrowser-reviewers
When closing the last visible tab, if there are any collapsed tab groups, make one of the tabs in a tab group active. Based on pre-existing behavior, activating a tab in a collapsed tab group causes the tab group to expand.

Currently, if you close the last visible tab while you still have collapsed tab groups present on the tab bar, the browser window will close. This is surprising and sad behavior for users.

Differential Revision: https://phabricator.services.mozilla.com/D228274
2024-11-11 10:39:11 +00:00
Emilio Cobos Álvarez
e078501af2 Bug 1928151 - With vertical tabs, make the sidebar and toolbars match the toolbox. r=sidebar-reviewers,sfoster,desktop-theme-reviewers,sclements
As per discussion with UX, we might want the toolbox background to be
different in (some of) our default themes in this case, but that seems
orthogonal, and this seems somewhat straight-forward.

Differential Revision: https://phabricator.services.mozilla.com/D227494
2024-11-09 00:07:54 +00:00
Butkovits Atila
31d28441e1 Backed out changeset 307c830b0d2b (bug 1908422) for causing failures at browser_tab_groups.js. CLOSED TREE 2024-11-08 21:50:37 +02:00
Jeremy Swinarton
192fcb4ace Bug 1908422: Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.

This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.

Differential Revision: https://phabricator.services.mozilla.com/D226397
2024-11-08 17:29:38 +00:00
Alexandru Marc
01db59aeab Backed out changeset 9e5edf53c876 (bug 1908422) for causing bc failures @ browser_tab_groups_a11y.js 2024-11-08 16:57:36 +02:00
Jeremy Swinarton
976c5c6a23 Bug 1908422: Add closedGroups to SessionRestore for tab groups r=dao,sthompson,sessionstore-reviewers,tabbrowser-reviewers
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.

This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.

Differential Revision: https://phabricator.services.mozilla.com/D226397
2024-11-08 13:53:19 +00:00
Stephen Thompson
dea8bab029 Bug 1922268: inserting tabs behaves with adjacent tab groups r=dao,tabbrowser-reviewers
Fixes a number of edge cases where tabs created/inserted in the tab strip were incorrectly being placed inside of an adjacent tab group or incorrectly being placed outside of the intended tab group

Differential Revision: https://phabricator.services.mozilla.com/D226705
2024-11-05 17:57:09 +00:00
Stephen Thompson
ac726238d7 Bug 1921814 - add keyboard focus for tab group labels r=dao,dwalker,desktop-theme-reviewers,tabbrowser-reviewers
This patch makes tab group labels "focusable" using the keyboard when the tab strip contains both tabs and tab groups.

Differential Revision: https://phabricator.services.mozilla.com/D226154
2024-11-05 16:52:19 +00:00
DJ
a888370569 Bug 1922276 - addTabGroup: add showCreateUI option and don't show post-create UI by default. r=dao,jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226957
2024-11-05 15:59:01 +00:00
Iulian Moraru
9f3814a261 Backed out changeset 068e6a4704bf (bug 1922276) for causing bc failures on browser_tab_groups.js. 2024-11-05 01:45:16 +02:00
DJ
26cee6b52f Bug 1922276 - addTabGroup: add showCreateUI option and don't show post-create UI by default. r=dao,jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226957
2024-11-04 16:31:09 +00:00
Greg Stoll
a010f0e92b Bug 1926055 part 1 - add "Unload Tab" to context menu r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson
Also make sure to select another tab if unloading the currently selected
tab (or Firefox View if unloading all tabs in the window) and handle
multiselect.

Differential Revision: https://phabricator.services.mozilla.com/D226346
2024-11-04 12:20:08 +00:00
DJ
cde6ddebdc Bug 1923651 - implement "move group to new window" in tabgroup edit menu. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226325
2024-10-31 15:01:07 +00:00
Sam Foster
1fb6c6a140 Bug 1922307 - Adjust the height of the auto-hiding menu toolbar when the tabstrip is hidden. r=desktop-theme-reviewers,dao,tabbrowser-reviewers,urlbar-reviewers
* Set the 'tabs-hidden' attribute on the #navigator-toolbox instead of the #nav-bar
* Add a --urlbar-padding-block variable for the padding around the urlbar

Differential Revision: https://phabricator.services.mozilla.com/D226568
2024-10-24 22:54:23 +00:00
Gijs Kruitbosch
acebf6e91c Bug 1926834 - put pid pref getter on tabbrowser and use from both tab hover previews and tabbrowser itself, r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D226767
2024-10-24 15:25:36 +00:00
Sandor Molnar
6ec81d7b1d Backed out 2 changesets (bug 1926055) for causing bc failures @ browser_multiselect_tabs_unload_with_beforeunload.js CLOSED TREE
Backed out changeset 85a555f31920 (bug 1926055)
Backed out changeset db41b497b1be (bug 1926055)
2024-10-22 06:14:17 +03:00
Greg Stoll
afe27c86a4 Bug 1926055 part 1 - add "Unload Tab" to context menu r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson
Also make sure to select another tab if unloading the currently selected
tab (or Firefox View if unloading all tabs in the window) and handle
multiselect.

Differential Revision: https://phabricator.services.mozilla.com/D226346
2024-10-22 01:34:34 +00:00
Dão Gottwald
4750c05946 Bug 1925842 - Rename _numPinnedTabs to pinnedTabCount. r=tabbrowser-reviewers,jswinarton,dwalker
Also move getDuplicateTabsToClose and getAllDuplicateTabsToClose away from essentials at the top, closer to related methods.

Differential Revision: https://phabricator.services.mozilla.com/D226279
2024-10-21 14:35:06 +00:00
Dão Gottwald
d39af4daab Bug 1908438 - Drag and drop support for creating a group. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D225799
2024-10-18 17:59:44 +00:00
Jeremy Swinarton
f469ca9429 Bug 1922655: New tab groups are positioned in the tab strip based on TabContextMenu.contextTab r=dao,sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D225071
2024-10-16 20:04:07 +00:00
Jeremy Swinarton
5a6d7614a0 Bug 1918712: Context menu to remove tab from group r=dao,fluent-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D224480
2024-10-16 15:18:21 +00:00
DJ
907db54691 Bug 1923865 - revise call signature for addTabGroup. r=jswinarton,sessionstore-reviewers,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D225386
2024-10-15 14:10:39 +00:00
Stephen Thompson
b91e1b1686 Bug 1915172 - Restore open tab groups r=dao,jswinarton,sessionstore-reviewers,tabbrowser-reviewers
1908418 added tab groups and their tab relationships to each window. This patch will restore tab groups and the tabs within them.

Differential Revision: https://phabricator.services.mozilla.com/D224955
2024-10-14 15:31:29 +00:00
Dão Gottwald
c3c13fc1ea Bug 1924041 - Stop setting the "hashiddentabs" attribute. r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D225325
2024-10-11 14:25:14 +00:00
Dão Gottwald
5c2c364bdc Bug 1924036 - Remove obsolete showOnlyTheseTabs API and reimplement in BrowserTestUtils. r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D225323
2024-10-11 14:25:13 +00:00
DJ
0b91483f2d Bug 1918687 - addTabGroup: select unused color if no color specified. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D225102
2024-10-10 20:00:23 +00:00
Sam Foster
fc07ffe892 Bug 1922898 - Correct inactive titlebar color in linux; ensure titlebar toolbars get the browser-titlebar class. r=desktop-theme-reviewers,dao,tabbrowser-reviewers
- Remove the titlebar-color class which is now redundant with browser-titlebar
- Fix the specificity in the linux stylesheet ensuring titlebar toolbars show the theme's background images not the falback colors

Differential Revision: https://phabricator.services.mozilla.com/D224862
2024-10-10 17:28:23 +00:00
Jeremy Swinarton
81f22c1b28 Bug 1922262: Tab group context menu chicklet uses correct styling r=dao,desktop-theme-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D224547
2024-10-10 15:00:02 +00:00
Dão Gottwald
3a500158ae Bug 1921860 - Tab counts should include hidden tabs and tabs in collapsed tab groups. r=sthompson
Differential Revision: https://phabricator.services.mozilla.com/D225206
2024-10-10 13:59:46 +00:00
Butkovits Atila
764b685a67 Backed out changeset 51e855a9eb6c (bug 1922262) for causing failures at browser_tab_groups.js. CLOSED TREE 2024-10-09 20:21:39 +03:00
Jeremy Swinarton
b33f5b36a6 Bug 1922262: Tab group context menu chicklet uses correct styling r=dao,desktop-theme-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D224547
2024-10-09 15:26:24 +00:00
Dão Gottwald
827c481bb3 Bug 1923635 - Various MozTabbrowserTabs cleanup. r=dwalker,tabbrowser-reviewers
Did this while working on drag-and-drop code.

Differential Revision: https://phabricator.services.mozilla.com/D225062
2024-10-09 14:46:09 +00:00
Sam Foster
a5ef3ca65d Bug 1899598 - Hide the horizontal tab strip when vertical tabs are enabled. r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,willdurand,sclements
* Remove the #titlebar element, and ensure toolbars that comprise the titlebar get a .browser-titlebar class
* Ensure we call TabBarVisibility.update when initializing with verticalTab=true
* Adjust TabBarVisibility logic so we allow for the vertical tabs case
* Give #navigator-toolbar z-index: var(--browser-area-z-index-toolbox) to ensure the urlbar view doesnt get clipped behind the lower elements

Differential Revision: https://phabricator.services.mozilla.com/D222059
2024-10-02 22:14:13 +00:00
Iulian Moraru
4bc5ac9ba8 Backed out changeset 98b6ddc6deed (bug 1899598) for causing marionette failures on test_initialize_vertical_tabs.py. CLOSED TREE 2024-10-02 07:49:47 +03:00
DJ
2d21263f13 Bug 1908426 - add UI to edit group label / color after creation. r=jswinarton,dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D222017
2024-10-02 00:48:13 +00:00