Commit graph

195 commits

Author SHA1 Message Date
Paul Zuehlcke
3e16fc7823 Bug 1751481 - Enable felt privacy features by default and integrate with Nimbus. r=dao,preferences-reviewers,Gijs
Depends on D155013

Differential Revision: https://phabricator.services.mozilla.com/D155065
2022-08-25 11:17:39 +00:00
Paul Zuehlcke
36c001b7b7 Bug 1783235 - Update about:privatebrowsing logos. r=Gijs,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D153779
2022-08-10 11:44:08 +00:00
Tooru Fujisawa
9fa82cdffe Bug 1780543 - Part 4: Add mozilla/remote-page environment. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D152429
2022-07-26 02:46:30 +00:00
negin
75e3960bd9 Bug 1774070 - Add asset needed for about:privatebrowsing pin promo r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D152107
2022-07-20 16:32:34 +00:00
Marian-Vasile Laza
27ac5b09b5 Backed out changeset bdeb418ce16c (bug 1774070) for causing bc failures on browser_all_files_referenced.js. CLOSED TREE 2022-07-19 00:56:45 +03:00
negin
5f8322d127 Bug 1774070 - Add asset needed for about:privatebrowsing pin promo r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D152107
2022-07-18 20:44:12 +00:00
Barret Rennie
edfd11a38c Bug 1771073 - Correct FxMS features and keep them up to date with tests r=dmose,pdahiya
The Nimbus Features corresponding to FxMS messaging surfaces are actually
intended to map to FxMS message groups, which can accept *any* FxMS message.
The features have been updated with schemas that accept any FxMS message.

As part of this, all FxMS schemas have been updated with an `$id` so that they
can be bundled into feature schemas and have their internal `$ref`s work.
(Otherwise, a `$ref` would be relative to the top-level schema instead of the
sub-schema).

Schemas for individual message types are no longer exposed as resource:// URIs,
except in tests, as indivual schemas are no longer required at runtime.

Additionally, each FxMS schema has had its `template` field become required and
requires a constant value for that schema (e.g., Spotlight requires a template
value of "spotlight").

A test has been added to ensure that if any of the messaging surfaces schemas
change that the feature schemas are also updated. The feature schemas can be
regenerated via:

```
cd ./browser/components/newtab/content-src/asrouter/schemas
../../../../../../mach make-schemas.py
```

Differential Revision: https://phabricator.services.mozilla.com/D147332
2022-06-29 23:01:37 +00:00
Jason Prickett
2e44c5c642 Bug 1770067 - Adding link support to private browsing promo button r=pdahiya,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D149571
2022-06-24 23:09:23 +00:00
Dan Mosedale
6799a67305 Bug 1748214 - Remove private browsing Nimbus feature, r=pdahiya,barret
Differential Revision: https://phabricator.services.mozilla.com/D146474
2022-06-15 16:03:17 +00:00
Punam Dahiya
f6bc444db3 Bug 1770061 - Enhance PBM Promo button to support all SpecialMessageActions r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D146751
2022-05-23 22:35:07 +00:00
Punam Dahiya
58f2a36893 Bug 1765907 - PBM experiment message should override default promo message r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D144871
2022-05-12 18:24:06 +00:00
Cristian Tuns
6c334e2b06 Backed out changeset eb12cdc5d1e8 (bug 1765907) for causing mochitest failures on browser_privatebrowsing_focus_promo.js CLOSED TREE 2022-05-10 14:38:02 -04:00
Punam Dahiya
815ffe3c32 Bug 1765907 - PBM experiment message should override default promo message r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D144871
2022-05-10 17:12:05 +00:00
Itiel
e137f3bbad Bug 1767167 - Style improvements for PBM r=desktop-theme-reviewers,sfoster
This includes:
1. Fix "Download Firefox Focus" button :hover:active state
2. Make the fake caret visible in HCM
3. Fix the branding name to be visible in all HCM modes
4. Make the sections distinguishable from others in HCM
5. Fix the searchbox text to be visible when hovered, in HCM
6. Make the promo's X button look better and work in :hover:active state

Differential Revision: https://phabricator.services.mozilla.com/D145175
2022-05-05 23:02:37 +00:00
Meg Viar
f5f23cdb0a Bug 1766592 - [Experiment] The "Focus Promo" experiment message is wrongly displayed on the fist opened tab after it was dismissed r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D145015
2022-05-04 13:35:28 +00:00
Emily McMinn
1f9a03af0c Bug 1759915 - Add aria-hidden to PBM search box to correct VoiceOver behaviour r=mviar
This should prevent VoiceOver from getting "stuck" between the address bar and the fake search bar in Private Browsing Mode. I'm not sure why PBM is different to the behaviour on the newtab page (the newtab page doesn't have the aria-hidden property and the HTML is essentially the same) but adding "aria-hidden" in this case doesn't seem to break anything.

Differential Revision: https://phabricator.services.mozilla.com/D143784
2022-04-18 19:49:04 +00:00
Meg Viar
8d7ec958ea Bug 1764330 - The QR code from the "PB_FOCUS_PROMO" modal wrongly redirects to the "Firefox Klar" app even if the region is set to "US" and a Firefox en-US locale build is used r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D143724
2022-04-14 16:09:34 +00:00
Emily McMinn
3c39a409d9 Bug 1762431 - Presentation fixes for a11y on PBM Fx100 r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D142893
2022-04-05 16:02:37 +00:00
Emily McMinn
6b3183955e Bug 1761842 - Replace promo CTA link with a button for better a11y r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D142589
2022-04-04 19:32:44 +00:00
Meg Viar
d8fd9d99de Bug 1762242 - Conditionally show Private Browsing page Focus promo r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D142551
2022-04-01 12:36:30 +00:00
Meg Viar
326a597833 Bug 1760588 - The in-content "Search bar" placeholder is no longer displayed if the “about:privatebrowsing” page is refreshed after the “Get Firefox Focus” spotlight modal is triggered r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D141781
2022-03-23 19:56:59 +00:00
Meg Viar
9c23c0a018 Bug 1758028 - Implement PBM modal content as per finalized design r=pdahiya,preferences-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D140739
2022-03-23 14:03:18 +00:00
smolnar
876c137475 Backed out changeset f6577528fc15 (bug 1758028) for causing xpc failures in xpcshell/test_BrowserUtils.js CLOSED TREE 2022-03-22 21:54:22 +02:00
Meg Viar
2ae66744d6 Bug 1758028 - Implement PBM modal content as per finalized design r=pdahiya,preferences-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D140739
2022-03-22 19:19:02 +00:00
Punam Dahiya
a76c013839 Bug 1754832 - Update PBM to support opening spotlight tab modal r=Mardak,mviar,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D140565
2022-03-17 06:41:47 +00:00
Punam Dahiya
c4f92a5d3b Bug 1756860 - Add Firefox Focus promo image r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D140780
2022-03-12 11:15:33 +00:00
Dan Mosedale
dd68ed956f Bug 1754115 - switch pvt browsing promo close string, r=pdahiya,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D140279
2022-03-04 20:09:46 +00:00
Punam Dahiya
f99fc8a551 Bug 1756178 - Open link from the private browsing page in a new tab r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D139900
2022-03-01 18:38:23 +00:00
Dan Mosedale
f319e6a711 Bug 1749775 - Add user telemetry for 98 VPN promo, r=andreio,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D135874
2022-02-11 16:31:06 +00:00
Andrei Oprea
78216df832 Bug 1748240 - Add impressions counting and dismiss functionality to PB messaging r=desktop-theme-reviewers,barret,fluent-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D135058
2022-02-04 02:35:30 +00:00
Cosmin Sabou
c1424ed185 Backed out changeset edbc8f7e808f (bug 1748240) for bc failures on browser_privatebrowsing_about_nimbus.js. CLOSED TREE 2022-02-01 05:40:15 +02:00
Andrei Oprea
5797f87d0b Bug 1748240 - Add impressions counting and dismiss functionality to PB messaging r=desktop-theme-reviewers,barret,fluent-reviewers,Itiel
Depends on D134157

Differential Revision: https://phabricator.services.mozilla.com/D135058
2022-02-01 01:36:28 +00:00
Andrei Oprea
c1807eee8c Bug 1746598 - Route MS messages to PB newtab r=dmose,extension-reviewers,rpl
Differential Revision: https://phabricator.services.mozilla.com/D134157
2022-01-25 13:02:30 +00:00
Sandor Molnar
2387917375 Backed out changeset ea22083f5525 (bug 1746598) for causing bc failures in browser/components/extensions/test/browser/browser_ext_menus_incognito.js CLOSED TREE 2022-01-24 10:53:24 +02:00
Andrei Oprea
628af2aadb Bug 1746598 - Route MS messages to PB newtab r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D134157
2022-01-24 07:49:45 +00:00
Emilio Cobos Alvarez
efe2305b8d Bug 1742696 - Opt-in a bunch of about:pages to dark system colors / form controls. r=Gijs,preferences-reviewers,webcompat-reviewers,twisniewski
Privileged pages do this automatically via:

  https://searchfox.org/mozilla-central/rev/aa8c75b83f636948f708986173965c84cae8c25f/widget/nsXPLookAndFeel.cpp#1179-1183

So this makes everything more consistent. Known exceptions:

 * Pocket panels (as those don't seem to support dark mode)
 * about:reader (because it has its own dark mode handling)

Differential Revision: https://phabricator.services.mozilla.com/D132019
2021-11-25 21:24:43 +00:00
Punam Dahiya
92710b365d Bug 1729766 - Update about:privatebrowsing with VPN promo r=Mardak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D125206
2021-09-16 15:25:47 +00:00
Sebastian Hengst
49f844414e Backed out changeset 13fa4cea337f (Bug 1724019) on request from emcminn because of change of plans. r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D124829

Depends on D124828
2021-09-07 20:41:56 +00:00
Sebastian Hengst
e50b631415 Backed out changeset ad063959d7b7 (Bug 1725977) on request by emcminn for change of plans. r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D124828
2021-09-07 19:32:35 +00:00
Emily McMinn
d6ae3985aa Bug 1725980 - Update strings for about:privatebrowsing r=andreio,flod
Differential Revision: https://phabricator.services.mozilla.com/D123014
2021-08-23 20:34:35 +00:00
Cosmin Sabou
6988079573 Backed out changeset defb6e39eb0b (bug 1725980) for bc failures on browser_privatebrowsing_about_nimbus.js. CLOSED TREE 2021-08-23 20:40:16 +03:00
Emily McMinn
83fe7807da Bug 1725980 - Update strings for about:privatebrowsing r=andreio,flod
Differential Revision: https://phabricator.services.mozilla.com/D123014
2021-08-23 16:58:20 +00:00
Emily McMinn
b1c769c99f Bug 1725977 - Remove the unused markup for the "below search" version of about:privatebrowsing r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D122879
2021-08-17 19:35:36 +00:00
Emily McMinn
0aaae4a863 Bug 1724019 - Update about:privatebrowsing CSS, markup and tests r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D121753
2021-08-16 14:33:31 +00:00
Harry Twyford
1a37803fd6 Bug 1713827 - Hand off to search mode if searching is disabled in the Urlbar. r=amy,Standard8,flod
This patch also addresses bug 1645293. It essentially reverts parts 1 and 3 of bug 1616700 for users with searching disabled. Since we had to introduce branching behaviour, there are some new constructs like a shouldHandOffToSearchMode multi-pref in UrlbarPrefs.

Differential Revision: https://phabricator.services.mozilla.com/D118606
2021-07-22 15:46:30 +00:00
Cosmin Sabou
6b427ca596 Backed out changeset 5a673b05aea0 (bug 1713827) for bc failures on browser_contentSearchUI_default.js. CLOSED TREE 2021-07-21 01:06:27 +03:00
Harry Twyford
cd2b8c89b0 Bug 1713827 - Hand off to search mode if searching is disabled in the Urlbar. r=amy,Standard8,flod
This patch also addresses bug 1645293. It essentially reverts parts 1 and 3 of bug 1616700 for users with searching disabled. Since we had to introduce branching behaviour, there are some new constructs like a shouldHandOffToSearchMode multi-pref in UrlbarPrefs.

Differential Revision: https://phabricator.services.mozilla.com/D118606
2021-07-20 21:25:10 +00:00
Andrei Oprea
392f7dce8e Bug 1715504 - Banner variations for Private Browsing mode experiment r=desktop-theme-reviewers,k88hudson,harry
Differential Revision: https://phabricator.services.mozilla.com/D117281
2021-06-18 11:06:58 +00:00
Sandor Molnar
917badff50 Backed out changeset f4ab27bcac2e (bug 1715504) for causing browser-chrome failures in browser_all_files_referenced. CLOSED TREE 2021-06-18 13:38:10 +03:00
Andrei Oprea
5e63926089 Bug 1715504 - Banner variations for Private Browsing mode experiment r=desktop-theme-reviewers,k88hudson,harry
Differential Revision: https://phabricator.services.mozilla.com/D117281
2021-06-18 09:50:19 +00:00