Commit graph

46 commits

Author SHA1 Message Date
peter chang
483ecd1196 Bug 1090008 Dispatch SelectionStateChanged event for blur, r=roc r=smaug 2014-11-27 18:56:00 +01:00
peter chang
0911a88d6d Bug 1090008 - Part 4 - Rename SelectionChange to SelectionStateChanged, r=smaug 2014-11-27 18:55:00 +01:00
pchang
040f9d3add Bug 1090008 -Part 1 - Refactor the logic to dispatch selectionchange to TextDialog, r=roc 2014-11-28 05:35:00 +01:00
Morris Tseng
c1af02f12b Backed out 5 changesets (bug 1092888) for breaking QA smoketest on b2g.
Backout changeset 8c513f282a9e (bug 1092888)
Backout changeset db37104f6fbd (bug 1092888)
Backout changeset b1a0a7ea1a32 (bug 1092888)
Backout changeset c53a6181a4b2 (bug 1092888)
Backout changeset 54e551c1f2cd (bug 1092888)
2014-11-26 10:11:38 +08:00
Jonathan Kew
9a00763a7b Bug 1077515 - part 3 - Change desiredX (nscoord) to desiredPos (nsPoint) in nsPeekOffsetStruct, to support maintaining either vertical or horizontal position on inter-line moves. r=roc 2014-11-22 14:39:03 +00:00
Ting-Yu Lin
39970eda35 Bug 1100243 - Fix wrong log in SelectionCarets::SetEndFrameVisibility(). r=mtseng 2014-11-17 00:05:00 +01:00
Morris Tseng
2c4935cb1c Bug 1092888 - Part 2: Check pointer of FrameSelection and Selection is valid. r=roc 2014-11-10 02:04:00 +01:00
Morris Tseng
bc63e6b35c Bug 1092888 - Part 1: Remove preference for selection carets with non-editable fields support. r=roc 2014-11-10 02:03:00 +01:00
Ting-Yu Lin
9b3563ea90 Bug 1097094 - Keep a WeakPtr to nsDocShell in SectionCarets. r=roc
When SelectionCarets::Terminate() is called, it's not guaranteed that we
can get nsDocShell from PresContext. It causes that SelectionCarets
cannot remove itself as an observer.

To fix this, we keep a member WeakPtr<nsDocShell> so that we can always
have nsDocShell in SelectionCarets::Terminate().
2014-11-13 08:32:00 -05:00
Morris Tseng
d0e550df52 Bug 1096169 - Handle selection carets overlapping case. r=roc 2014-11-12 23:03:00 -05:00
Morris Tseng
8733cb18e1 Bug 1094056 - Use nsCaret::GetGeometryForFrame to determine position of selection carets. r=roc 2014-11-11 22:54:00 +01:00
Ting-Yu Lin
892f540142 Bug 1073457 - Launch long tap detector when APZ isn't enabled. f=mtseng, r=roc
LaunchLongTapDetector() is used to fire long tap to select word when
async pan zoom is not enabled. We should check if async pan zoom is
enabled rather than check whether it's on main process.

This can also fix selection carets not working on e10s.
2014-11-10 00:29:00 +01:00
Ting-Yu Lin
41fb52c7e0 Bug 1094607 - Move scroll observer logic to SelectionCarets. r=roc 2014-11-05 22:00:00 +01:00
Ting-Yu Lin
189652787e Bug 1094072 - Update selection carets after reflow. r=roc
Let SelectionCarets inherits from nsIReflowObserver so it could refresh
its position after reflow. This fixes the incorrect position of
selection carets after we rotate the device to change the screen from
portrait mode to landscape mode and vice versa.
2014-11-05 21:18:00 +01:00
Morris Tseng
fc246a326d Bug 1088559 - Also dispatch NotifyAsyncPanZoomStarted/NotifyAsyncPanZoomStopped to nsDocShell's child. r=roc 2014-10-29 02:03:00 -04:00
Morris Tseng
d84b5f7745 Bug 1088552 - Change downPoint and movePoint from canvasframe's coordinate to rootframe's coordinate. r=roc 2014-10-28 18:25:00 -04:00
Ting-Yu Lin
59a309404b Bug 1087190 - Add debug log to SelectionCarets. f=mtseng, f=pchang, r=roc 2014-10-29 01:16:00 +01:00
Morris Tseng
d90f8ec248 Bug 1074736 - Consider multiple range selection in selection caret. r=roc 2014-10-23 19:49:00 +02:00
Ryan VanderMeulen
25dcb92582 Backed out changesets 94c5f5317e4b, f43962d6b41e, and 6e0a13090cd8 (bug 1074736) for various carat-related Marionette failures.
--HG--
extra : rebase_source : e26c24158df6cc8198ca57f505028a1f82aa7264
2014-10-27 15:39:44 -04:00
Morris Tseng
15981a5429 Bug 1074736 - Consider multiple range selection in selection caret. r=roc 2014-10-23 19:49:00 +02:00
Carsten "Tomcat" Book
59fffd8c1d Backed out changeset b1ab04e807c3 (bug 1074736) 2014-10-24 14:45:59 +02:00
Morris Tseng
7d092bf950 Bug 1074736 - Consider multiple range selection in selection caret. r=roc 2014-10-23 19:49:00 +02:00
peter chang
79eb0d5c68 Bug 1068461 - Locate the text frames from viewport frame to select word, r=roc 2014-10-15 10:43:29 +08:00
Morris Tseng
42158b0719 Bug 1062735 - Part 4: Support non-editable fields for selection carets. r=roc 2014-10-16 23:17:00 +02:00
Morris Tseng
cadcb883aa Bug 1062735 - Part 3: Change ReduceRectToVerticalEdge to 1 css pixel instead of 1 app unit. r=roc 2014-09-28 23:50:00 +02:00
Morris Tseng
c9fd8dcb1e Bug 1062735 - Part 2: Add a preference to control non-editable fields support. r=roc 2014-09-28 23:49:00 +02:00
Morris Tseng
27ecf9f1b4 Bug 1062735 - Part 1: Remove GetHintForPosition. r=roc 2014-09-28 23:48:00 +02:00
pchang
120fb11ce3 Bug 1067243 - Refine the selection reason matching logic to toggle the visibility of selection carets. r=roc 2014-09-26 15:14:35 +08:00
peter chang
ae05a3086a Bug 1020801 - Notify the ScrollViewChange DOM event when APZ starts/stops to change the transform. r=ehsan 2014-09-23 06:37:00 -04:00
Ting-Yu Lin
e3debbffab Bug 1065244 - Part 2 - Refactor event point on frame logic for SelectionCarets. f=mtseng, r=roc 2014-09-15 02:57:00 +02:00
Ting-Yu Lin
fc63f147e7 Bug 1065244 - Part 1 - Add GetRectRelativeToFrame to nsLayoutUtils. f=mtseng, r=roc 2014-09-15 17:07:00 +02:00
Ting-Yu Lin
3277fc6dc5 Bug 1057256 - Part 2 - Add null pointer check for touch and selection carets. r=roc
TouchCaret::IsDisplayable() contains more null pointer check. It covers
what's original there in TouchCaret::HandleEvent().
2014-08-25 02:50:00 +02:00
Ting-Yu Lin
9a407aec80 Bug 1057256 - Part 1 - Remove NS_ENSURE_TRUE in SelectionCarets.cpp. r=roc
Remove NS_ENSURE_TRUE and NS_ENSURE_TRUE_VOID since they are deprecated,
and we do not need to print log in plain null pointer check.
2014-08-25 02:50:00 +02:00
Morris Tseng
ce44192262 Bug 1056457 - Remove batch changes in selection carets. r=roc 2014-08-20 20:23:00 +02:00
Robert O'Callahan
150ec76871 Bug 1048752. Part 24: Rename and deCOM Set/GetCaretVisible. r=tn
--HG--
extra : rebase_source : 04249e9b22a62b8f2952515fa48f4ba3227e235e
2014-08-06 17:19:29 +12:00
Robert O'Callahan
0a6d04586e Bug 1048752. Part 17: Rename Get/SetCaretDOMSelection to Get/SetSelection. r=tn
The forward declaration of Selection in nsCaret.h will be used in later patches.

--HG--
extra : rebase_source : d1b749adac983c04d3365bb6bfb76a50101beeb5
2014-08-06 17:19:27 +12:00
Robert O'Callahan
2489dc1f01 Bug 1048752. Part 16: Move nsFrameSelection::HINT to CaretAssociationHint.h. r=tn
This patch started an attempt to remove nsFrameSelection.h from nsCaret.h
and metastasized into a rather large refactoring patch that removed it
from some other header files as well, and changed nsFrameSelection::HINT
into a global-scope enum with better names. I also converted bools
into CaretAssociationHint in a few places where that was appropriate,
but there are still some more places (GetChildFrameContainingOffset)
where bools need to be converted. I figured this patch was big enough already.

--HG--
extra : rebase_source : cc618ef60e707e1360644340a2648de389383da0
2014-08-06 17:19:27 +12:00
Robert O'Callahan
b4ed20d441 Bug 1048752. Part 14: Split GetGeometry into a static and a non-static version. r=tn
GetGeometry is used in two different ways. Sometimes it's used to get
information about a particular caret. Sometimes it's used to get
information about a particular selection that's not associated with
a caret. Splitting GetGeometry into a non-static version for the former
and a static version for the latter makes this more clear. Also it saves
code since for the latter version we don't have to get an nsCaret first.

--HG--
extra : rebase_source : b7730dac56b308a82b79b175749234c9a92b6f59
2014-08-06 17:19:26 +12:00
Morris Tseng
f1d2262570 Bug 1050095 - Prevent drag event when calling SelectionCarets::SelectWord(). r=roc 2014-08-06 23:08:00 -04:00
Morris Tseng
f3682709b7 Bug 1046498 - Constrain frame to anchor subtree when dragging selection caret. r=roc 2014-08-06 01:55:00 -04:00
Morris Tseng
e805832aca Bug 1023041 - Part 1: Rename SetMouseDownState to SetDragState. r=roc 2014-08-04 00:26:00 -04:00
Morris Tseng
cc9241e019 Bug 987040 - Part 2: Add a flag indicate whether CollectClientRects should flush layout or not. r=ehsan 2014-07-23 23:06:00 +02:00
Morris Tseng
16565ccd04 Bug 1026431 - Determine tilt mode by next character of startFrame and previous character of endFrame. r=roc 2014-07-15 22:44:00 +02:00
Morris Tseng
e6c58de728 Bug 1024966 - Check mResultContent before using it. r=roc 2014-07-09 02:21:00 +02:00
Morris Tseng
3dd291a28e Bug 864595 - Provide a option which indicate to that offsets outside the frame box are allowed. [r=roc] 2014-06-27 13:58:57 -07:00
Morris Tseng
e0ddfe5e18 Bug 987718 - Part 5: Add SelectionCarets; r=roc 2014-06-04 22:57:00 +02:00