Commit graph

327 commits

Author SHA1 Message Date
Ehsan Akhgari
68e4309bda Bug 585922 - Text cursor doesn't follow character input for passwords (encrypted phrases) r=roc a=blocking-fennec2.0b1+ 2010-08-23 20:49:15 -07:00
Ehsan Akhgari
9b8f299714 Bug 581585 - Cache the frame for caret; r=roc approval2.0=dbaron
--HG--
extra : rebase_source : 3043705ce2689532c40d6e0f1b023b55174e8a88
2010-07-26 20:05:14 -04:00
Masayuki Nakano
f88647e545 Bug 554822 Caret should refer the actual text color instead of the value of CSS color property r=roc 2010-04-01 11:35:48 +09:00
Masayuki Nakano
37b847f135 Bug 554822 backout the previous patch 2010-04-01 02:31:06 +09:00
Masayuki Nakano
f1448bab60 Bug 554822 Caret should refer the actual text color instead of the value of CSS color property r=roc 2010-04-01 02:12:43 +09:00
Craig Topper
afa4c872e5 Bug 253889: DeCOMtaminate nsIPresShell - IsPaintingSuppressed(). r=roc
--HG--
extra : rebase_source : 9ee8283e8bce33402893ae5316f89c9f699a1236
2010-03-31 08:43:49 -04:00
Kyle Huey
5278cfe428 Backed out changeset 4b8936ac4a31 2010-03-30 19:56:44 -04:00
Craig Topper
61dba9a452 Bug 253889: More deCOMtamination of nsIPresShell. r=roc 2010-03-28 19:21:11 -04:00
Mats Palmgren
355d7fd5b3 Bug 544852, part 4: Add nsCaret::GetGeometryForFrame. r=roc 2010-03-14 23:56:26 +01:00
Mats Palmgren
a445269db2 Bug 544852, part 3: Merge UpdateHookRect into UpdateCaretRects. r=roc 2010-03-14 23:54:11 +01:00
Mats Palmgren
06c0d583e4 Bug 544852, part 2: Use nsCaret::GetGeometry. r=roc 2010-03-14 23:52:45 +01:00
Mats Palmgren
e5f8b2f7e8 Bug 544852, part 1: Remove nsCaret::GetCaretCoordinates. r=roc 2010-03-14 23:52:07 +01:00
Robert O'Callahan
aeff873bb5 Bug 539323. Position the caret at the content-edge of its container frame, not the border-edge. r=mats 2010-03-05 11:52:59 +13:00
Mats Palmgren
29c9316331 Null-check the root pres context result. Unregister the plugin frame earlier, at Stop instead of Destroy time. b=521426 r=roc 2010-01-26 14:10:12 +01:00
Robert O'Callahan
bf02bb9929 Bug 526394. Part 24: Create sane nsCaret::GetGeometry API to obsolete nsCaret::GetCaretCoordinates. r=mats 2010-01-12 10:45:16 +13:00
Robert O'Callahan
a1e9364edb Bug 526394. Part 20: Convert more code in caret and docshell. r=mats 2009-09-09 17:40:02 +12:00
Mats Palmgren
032dc23c67 Flag nsCaret::mPendingDraw if the on-cycle draw was suppressed; update the caret when the pres shell tells us that painting is unsuppressed. b=520720 r=roc 2009-10-16 12:55:32 +02:00
Mats Palmgren
d484947c23 Adjust the caret y-position for zero-height inlines. b=503531 r=roc 2009-09-29 23:07:05 +02:00
Mats Palmgren
dea07412a1 Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX. b=512106 r=roc 2009-09-16 17:01:36 +02:00
Robert O'Callahan
2d683e020f Bug 352093. Part 8: Fix view returned for eToplevelWindowCoordinates. r=bzbarsky 2009-07-22 12:45:07 +12:00
Peter Van der Beken
78a793c211 Fix for bug 308736 (Caret is invisible when entering an empty designmode field.). r/sr=roc.
--HG--
extra : rebase_source : ef79a8ef7cb96c0efcdccc967370fcdf8f07eba4
2009-06-19 18:31:49 +02:00
Robert O'Callahan
aa6dce5b49 Bug 406646. Make sure to only search *visible* popups for mouse event targets. r=enndeakin
--HG--
extra : rebase_source : bd0825d6a6469a10dcdd9e4ae9e9c91dcbafbe99
2009-02-24 21:25:25 +13:00
Benjamin Smedberg
3498a5f86e Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
73a6fab34b Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
802d1a10c7 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Simon Montagu
8231106b44 Fix compiler warnings in nsCaret.cpp. Bug 470574, r+sr=dbaron 2008-12-28 04:08:22 -08:00
Simon Montagu
890194181a Make display of the directional hook on the caret dependent on the bidi.browser.ui pref. Bug 418513, r=uriber, sr=roc (for core) r=mano, gavin.sharp (for browser) 2008-12-14 01:05:39 -08:00
Robert O'Callahan
775dd33c74 Bug 450930. Fire a DOM event when painting so that content and chrome can track what's being repainted. r=smaug,sr=dbaron 2008-09-18 21:47:21 +12:00
Arpad Borsos
87878e68eb Bug 454766 - Add suggested parentheses to layout/; r+sr=roc; (with nits by sgautherie) 2008-09-15 17:40:25 +02:00
Oleg Romashin
862b8e5d2b Bug 453826 - MOZ_XUL define required for nsCaret::IsMenuPopupHidingCaret. r+sr=roc 2008-09-08 15:23:38 +03:00
Masayuki Nakano
d504a8c50f Bug 449955 – Remove #ifdef of nsCaret.cpp for IME r+sr=roc 2008-08-13 10:55:39 +09:00
John Daniels
b006229ae6 Bug 419532 – deCOMtaminate nsICaret. r+sr=roc 2008-07-16 12:52:01 +02:00
Karuna (karunasagark@gmail.com)
0eb449dd2a Bug 409331. Instead of QIing to nsBlockFrame in various places, call an nsLayoutUtils method to do it. r+sr=roc 2008-07-14 10:10:23 +12:00
Michael Ventnor
c6a1fd787c Bug 118308, NS_THEME_TEXTFIELD_CARET implementation (GTK), r+sr=roc 2008-06-23 11:50:52 +03:00
Simon Montagu
9faa7d6380 Remove unnecessary argument from SetBidiEnabled. Bug 435856, r+sr=roc 2008-06-16 02:28:17 -07:00
gavin@gavinsharp.com
4707993a0a Bug 430785: Caret not visible with right-clicking on a text input, patch by Martijn Wargers <martijn.martijn@gmail.com>, r+sr=roc, a=damon 2008-04-30 09:54:16 -07:00
roc+@cs.cmu.edu
9fe63cd0b9 Bug 335359. Make the caret thicker when it's at a Kanji character. r+sr=mrbkap,a=damon 2008-04-22 20:13:55 -07:00
roc+@cs.cmu.edu
6eb1cd4a0c Bug 420987. The caret size should be specified in CSS pixels and it should be rounded like borders --- rounding down to the nearest device pixel, but not down to zero. r+sr=mrbkap,a=schrep 2008-04-14 14:09:23 -07:00
reed@reedloden.com
52084d2065 Bug 427163 - "Crash [@ nsContentUtils::ContentIsDescendantOf] with contenteditable, right-clicking and document.write" (add null check) [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a1.9=damons] 2008-04-08 23:16:09 -07:00
reed@reedloden.com
3ada7e2c40 Bug 420499 - "Caret browsing mode wrongly engaged" (Mochitest) [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+] 2008-04-08 11:52:48 -07:00
reed@reedloden.com
e0e0118cf9 Bug 420499 - "Caret browsing mode wrongly engaged" [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+] 2008-04-01 01:35:11 -07:00
roc+@cs.cmu.edu
efc1d5a1dd Bug 400057. Make nsBlockInFlowLineIterator useful for finding the line containing a frame, searching across block continuations and their overflow lines. Use it in various places, especially in textrun construction. r+sr=dbaron 2008-02-27 01:53:48 -08:00
reed@reedloden.com
0ac3599db4 Bug 394473 - "caret/cursor in View Source is invisible since 20070628 {not rendered, seen, can't, cannot, shown, displayed}" [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r=peterv r+sr=roc a1.9=beltzner] 2008-02-26 17:49:46 -08:00
Olli.Pettay@helsinki.fi
a0a74f16e7 Bug 368760, r=mats, sr=roc, a=blocking1.9+ 2007-11-22 12:47:33 -08:00
reed@reedloden.com
1ff7b5c5fd Bug 394473 - "caret/cursor in View Source is invisible since 20070628 {not rendered, seen, can't, cannot, shown, displayed}" [p=cpearce r=peterv sr=roc a1.9=schrep] 2007-11-12 21:42:52 -08:00
roc+@cs.cmu.edu
2992eec22e Bug 403048. Be more careful about looking for the line containing the caret. r+sr=mrbkap 2007-11-08 17:59:20 -08:00
reed@reedloden.com
788e2903bf Bug 336408 - Allow the caret to be positioned at the end of trimmed whitespace, as if the whitespace wasn't trimmed [p=roc r=smontagu sr=mrbkap a=blocking1.9+] 2007-11-07 20:07:00 -08:00
tglek@mozilla.com
8cf3fb1c90 Clean up prbool misuse in layout. bug 398312, r+sr+a=dbaron 2007-10-09 17:00:05 -07:00
joshmoz@gmail.com
f219b51c26 remove XP_MAC usage. b=281889 r=cbarrett sr=roc a=roc 2007-10-01 16:20:37 -07:00
philringnalda@gmail.com
42675246db Bug 390423 - Simplify the signature of nsIFrame::GetPointFromOffset, patch by Ben Karel <web+moz@eschew.org>, r=aaronlev/elif, sr=roc, a1.9=dbaron 2007-08-16 20:43:00 -07:00
mrbkap@gmail.com
f055907b89 Redragging over empty text field doesn't show drag caret, except for the last text field. bug 390228, r+sr=roc a=dbaron 2007-08-13 14:33:25 -07:00
mrbkap@gmail.com
dc890e2df6 Clamp the caret's position so that we always draw within the nearest scrollframe. Not doing this allows the scrollframe to clip the caret, causing it to not show up at all. bug 335560, r+sr=roc 2007-08-13 13:51:16 -07:00
peterv@propagandism.org
f7dd41f11e Fix for bug 387380 (No visible caret when caret browsing). r=smaug, sr=jst, a=dbaron. 2007-08-10 06:19:13 -07:00
sharparrow1@yahoo.com
ddf20f3ad6 Bug 390740: Pass lang-group into GetMetricsFor more consistently (general patch). r+sr=roc, a=dbaron 2007-08-07 12:07:43 -07:00
jwalden@mit.edu
6d7584839a Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
peterv@propagandism.org
6662efd338 Fix for bug 237964 (Allow editable areas in browser (contentEditable)). r/sr=sicking. 2007-06-27 19:48:16 -07:00
peterv@propagandism.org
90c374d7c3 Backing out to fix orange. 2007-06-27 16:21:05 -07:00
peterv@propagandism.org
7bf2741259 Fix for bug 237964 (Allow editable areas in browser (contentEditable)). r/sr=sicking. 2007-06-27 15:29:45 -07:00
sharparrow1%yahoo.com
4862938c93 Bug 370379: Create views less frequently. Stops creating views for -moz-hidden-unscrollable, opacity, fixed backgrounds, and scrollbars, plus removes some unneeded methods from views and view managers. r+sr=roc. 2007-02-24 00:23:42 +00:00
sharparrow1%yahoo.com
76a64e5c22 Bug 177805: Fix the use of units in Gecko. r+sr=roc 2007-02-07 07:46:44 +00:00
cvshook%sicking.cc
a39ff30284 Kill remainders of ns(XBL|HTML|XUL|Layout)Atoms. r/sr=jst b=368128 2007-01-30 00:06:41 +00:00
uriber%gmail.com
3c3be786ad Bug 233348: BiDi marker is hidden when the caret is at the edge of a textarea. Patch by Haamed Gheibi <gheibi@gmail.com>. r=mrbkap sr=roc 2006-11-01 18:31:42 +00:00
uriber%gmail.com
38c1e056e9 Refactor nsIFrame::PeekOfset to use iteration instead of recursion, plus some more related refactoring. bug=300131 r+sr=roc 2006-09-11 20:43:01 +00:00
uriber%gmail.com
0fa608ce5e Backing out bug 300131 until I figure out how to deal with the bustage. 2006-09-11 08:03:28 +00:00
uriber%gmail.com
95b377fc13 Refactor nsIFrame::PeekOfset to use iteration instead of recursion, and some related refactoring. bug=300131 r+sr=roc 2006-09-11 06:39:56 +00:00
uriber%gmail.com
8982c70f78 Moved mCaretBidiLevel and its accessors from nsPresShell to nsFrameSelection. Also added sBidiKeyboard as a static service to nsContentUtils. bug=346891 r+sr=roc 2006-08-08 05:14:52 +00:00
uriber%gmail.com
cee7609648 Enable PeekOffset to find the visual beginning/end of a line, and use use it for bidi caret positioning. bug=302051 r=smontagu sr=roc 2006-08-03 06:24:11 +00:00
sharparrow1%yahoo.com
ca2fdec000 Bug 345371: add null checks for weak pointers in nsCaret. r+sr=roc. 2006-07-20 23:26:05 +00:00
smontagu%smontagu.org
952a1a4a12 Only display a bidirectional caret on platforms that implement nsIBidiKeyboard. Bug 272096, r+sr=roc 2006-07-06 08:29:53 +00:00
mrbkap%gmail.com
9f87463b44 Only recalculate the caret's rect when we're not currently drawn in an attempt to avoid caret turds when we're being notified of the caret movement after the frame has already been marked dirty. bug 335834, r+sr=roc 2006-05-04 00:05:22 +00:00
mrbkap%gmail.com
695809a291 Update the caret position after reflows to avoid turds. bug 334649, r+sr=roc 2006-04-28 04:33:41 +00:00
roc+%cs.cmu.edu
4667a9b409 Bug 330305. Rename nsSelection to nsFrameSelection, and deCOMtaminate it, removing nsIFrameSelection. patch by Marc Liddell, r+sr=roc 2006-04-26 01:57:22 +00:00
mrbkap%gmail.com
8cde2f4313 Make the caret paint in the same color as the foreground so it's not always painted black. bug 334635, r+sr=roc 2006-04-21 19:13:58 +00:00
mrbkap%gmail.com
e27b36efcc Draw the caret in the normal path of frame painting instead of doing it directly to the current view. bug 287813, r+sr=roc 2006-04-17 23:16:46 +00:00
dbaron%dbaron.org
5dcd0b1309 One-line descriptions of files, partly because they show up in LXR. 2006-03-30 05:56:38 +00:00
uriber%gmail.com
ba0d30b880 In nsTextEditRules::CheckBidiLevelForDeletion(), use nsSelection::GetPrevNextBidiLevels to determine bidi levels. bug=330460 r=smontagu sr=roc 2006-03-23 08:20:29 +00:00
smontagu%smontagu.org
d999b33cff Bug 305798: Bidi: After deleting last character of reverse-direction text, arrow keys move caret incorrectly. Patch by Uri Bernstein <uriber@gmail.com, r=smontagu, sr=roc 2005-11-16 09:37:01 +00:00
mark%moxienet.com
045ce7774f Bug 311399, Crash [@ SetOrigin] during rendering context destruction. Remove QD save/restore from rendering context, it was placed there as a workaround for scrollbar functional and aesthetic bugs. Add OS event handler to fix aesthetic problems, and check for bad states to work around functional problems. r=josh sr=smfr 2005-11-10 03:46:52 +00:00
masayuki%d-toybox.com
e7ed3d82a7 Bug 313918 IME candidate list is positioned to wrong position if the caret is positioned non-root view r+sr=roc 2005-10-29 12:43:51 +00:00
roc+%cs.cmu.edu
344b4be95e Bug 311152. Make DOM selection changes repaint the caret in the new position. r=mrbkap,sr=dbaron 2005-10-12 18:40:38 +00:00
aaronleventhal%moonset.net
fd97041e21 Bug 193316. Caret not visible in readonly fields (HTML or XUL). r=mrbkap, sr=smfr 2005-10-04 03:14:03 +00:00
mats.palmgren%bredband.net
f048b80534 Caret drawn at incorrect position after typing a single LTR character in a blank RTL input field (or vice versa) while caret is visible. b=307533 r=uriber sr=bzbarsky 2005-09-10 11:14:48 +00:00
mrbkap%gmail.com
5187e69f5f bug 303399: Bidi: Problems with caret positioning on blank lines. Patch by Uri Bernstein <uriber@gmail.com>. r=mrbkap sr=roc 2005-08-24 17:44:28 +00:00
mats.palmgren%bredband.net
decb76621e Erase caret if needed when content is removed. b=304383 r=mrbkap sr=bzbarsky 2005-08-22 00:25:20 +00:00
mats.palmgren%bredband.net
b3f31d48d4 Don't use a Frame pointer to remember where we last painted the caret, instead use Content+offset+hint. b=296464 r=mrbkap sr=roc a=cbeard 2005-08-11 03:44:16 +00:00
dougt%meer.net
be6760da53 Windows CE build changes. This addresses most of the outstanding Windows
CE compilation issues.

This patch also fixes/removes CheckStackGrowthDirection assertions in
Javscript.  This change is based on bug 242518.  See comment 36.

This patch also removes the unused enum in transformiix .  See bug
292118.

r/sr = dveditz/shaver
b    = 291229
a    = asa
2005-04-29 13:33:49 +00:00
mats.palmgren%bredband.net
a3c9fa1b01 Account for the view's origin not lining up with the widget's. b=190290 r=bzbarsky sr=roc 2005-03-26 14:50:09 +00:00
bzbarsky%mit.edu
f01adb747a Fix crashes in GTK1 builds due to reuse of rendering contexts for the caret.
Bug 254049, patch by Mark Banner <mark@standard8.demon.co.uk>, r=jst, sr=roc
2005-02-01 21:19:05 +00:00
bryner%brianryner.com
f575a675b2 Remove nsIAutoCopy and fold the functionality into nsSelection.cpp (bug 231343). r+sr=roc. 2005-01-31 23:47:26 +00:00
bmlk%gmx.de
d3197a9276 remove unused prescontext argument from GetOffsetFromView bug 276015 r/sr=dbaron 2004-12-26 19:48:54 +00:00
smontagu%smontagu.org
52ff1c323f Prevent the right-to-left directional hook from overlapping the caret and make both directions thinner. Bug 264903, r=mkaply, aaronleventhal, sr=rbs. 2004-11-30 19:28:00 +00:00
neil%parkwaycc.co.uk
a45fb5a046 Don't use QueryInterface to get a scrollable view from a view b=258521 r+sr=roc 2004-11-24 00:19:21 +00:00
scott%scott-macgregor.org
903bd845ea Try landing the fix for infamous Bug #98564 again -->
caret overlaps the last character in textfield (if positioned after the last char)

r=smontagu
sr=sfraser

We think this patch can land again because the regression it introduced was fixed by
Bug #216101 which does a better job of clearing out caret fragments.
2004-11-10 07:14:08 +00:00
aaronleventhal%moonset.net
cd89107e7e Fixing bustage 2004-10-13 02:24:38 +00:00
aaronleventhal%moonset.net
ca0cd1c767 Bug 261054. Make caret consistently the same width throughout Gecko/Mozilla. Configurable through ui.caretWidth. r=glazou, sr=rbs 2004-10-13 01:12:14 +00:00
neil%parkwaycc.co.uk
6a4f37de6b Don't use QueryInterface to get a view from a scrollable view b=258521 r+sr=roc 2004-09-20 22:25:07 +00:00
bryner%brianryner.com
d082d2bf5e More nsIPresShell deCOMtamination:
- Made Get/SetAuthorStyleDisabled and ReconstructStyleData non-virtual when called internally.
- Inlined GetFrameSelection and renamed it to FrameSelection.
- Removed non-inline version of GetViewManager.
- Removed unused EnablePrefStyleRules and ArePrefStyleRulesEnabled.

Bug 253889, r+sr=roc.
2004-08-29 03:08:44 +00:00
bryner%brianryner.com
180b0b7373 Remove refcounting version of nsIPresShell::GetPresContext. Bug 253889, r+sr=roc. 2004-08-20 20:34:37 +00:00
bryner%brianryner.com
5c02a6978c Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc 2004-07-31 23:15:21 +00:00
caillon%redhat.com
8f71882950 Bug 241507
Don't create new rendering contexts for each caret drawn on *nix platforms since there are no known issues with doing so.  If issues crop up, I will undo this change.
r/sr=jst/bryner
2004-06-29 19:12:19 +00:00
neil%parkwaycc.co.uk
ed766b9ccb Bug 216101 Cleaing frame refs can leave caret fragments p=mnyromyr@tprac.de r/sr=roc 2004-06-25 09:57:35 +00:00
bryner%brianryner.com
97a65f9548 Get rid of nsILanguageAtom and deCOMtaminate nsILanguageAtomService (bug 230603). Also, fix a bunch of atom double-addref leaks in nsFontMetricsXlib. r+sr=dbaron. 2004-06-08 23:53:59 +00:00
smontagu%smontagu.org
82d48e1672 DeCOMtaminate nsIFrame Set/GetProperty and merge Set/GetBidiProperty with it. Bug 117751, r+sr=roc 2004-06-01 06:20:16 +00:00
sspitzer%mozilla.org
3862b3557b bullet proofing (wall paper) fix for top crasher bug #243294
now we just assert, instead of crash. see bug #245055 about the real problem.

Crash [@ nsCaret::GetViewForRendering] when printing a schedule from www.matkahuolto.info

r/sr=roc
2004-05-29 19:57:00 +00:00
gerv%gerv.net
708b56cff4 Bug 236613: change to MPL/LGPL/GPL tri-license. 2004-04-18 14:30:37 +00:00
tor%cs.brown.edu
83eb215db9 Bug 240274 - remove PopState() argument. r=blizzard, sr=bryner 2004-04-18 13:13:35 +00:00
bryner%brianryner.com
0af1a79c51 More nsIPresContext deCOMtamination (bug 229371). r+sr=roc. 2004-04-13 00:28:44 +00:00
bryner%brianryner.com
433c389ddf Inline getters and setters for scaling factors on nsIDeviceContext. Bug 233103, r+sr=dbaron. 2004-02-05 01:57:10 +00:00
bryner%brianryner.com
4f69ec2c2e Guarantee that the pres context's device context will be non-null by returning failure from Init() if it's null. Rename inline getter GetDeviceContext() to DeviceContext(), convert all callers to use the inline getter, and remove the virtual/refcounting getter. Bug 229371, r+sr=dbaron. 2004-02-02 22:17:21 +00:00
bryner%brianryner.com
ef5c330583 Continuing nsIPresContext deCOMtamination (bug 229371). Remove GetImageLoadFlags (unused). Make failure to fetch the LookAndFeel service cause Init() to fail, don't null check it after that, and inlined the getter. Move IOService caching to nsImageFrame, the only user of it. r+sr=bzbarsky. 2004-01-21 09:35:59 +00:00
scott%scott-macgregor.org
c2df672e12 Bug #226325 --> Back out the fix for Bug #98564 as this opened us up to a regression where trailing stationary caret remnant left after backspace.
a=asa for 1.6b
2003-12-03 20:32:47 +00:00
scott%scott-macgregor.org
54777f2e4f Bug #98564 --> caret overlaps the last character in textfield (if positioned after the last char).
Patch written by kin.


r=smontagu
sr=sfraser
2003-11-16 07:08:55 +00:00
bryner%brianryner.com
9d11b3c424 Fix build on gcc 3.4 by removing extra semicolons (bug 218551). r/sr=dbaron, a=brendan. 2003-09-07 22:37:27 +00:00
jaggernaut%netscape.com
95899387f6 Bug 213602: Switch some users of NS_GetWeakReference over to do_GetWeakReference. r=bzbarsky, sr=dbaron 2003-07-25 19:06:59 +00:00
jaggernaut%netscape.com
83c571e877 Bug 25886: Get rid of a bunch of unused NS_DEFINE_IID, NS_DEFINE_CID. r=caillon, sr=dbaron 2003-07-20 07:47:59 +00:00
roc+%cs.cmu.edu
e324543a75 Ongoing deCOMtamination. r+sr=dbaron 2003-07-02 10:30:00 +00:00
leon.zhang%sun.com
b1b7ead95d Bug 204005: optimize caret timer usage
r=sfraser sr=brendan
2003-05-26 07:03:29 +00:00
timeless%mozdev.org
22604cfbf6 Bug 206165 Unused variable `PRBool aCanCacheFrameOffset' in nsCaret::GetCaretRectAndInvert
r=sfraser sr=sfraser
2003-05-23 22:24:37 +00:00
dbaron%dbaron.org
75ff60c62f Clean up API (and its callers) for getting style data: remove unneeded null checks and switch to new inline member functions (one for each struct) that return values. b=197205 r+sr=roc a=brendan 2003-05-15 03:42:21 +00:00
leon.zhang%sun.com
526c0515e9 Bug 199412: optimize nsTypedSelection::ScrollIntoView r/sr=sfraser 2003-04-20 01:03:40 +00:00
leon.zhang%sun.com
c5e44e7d6e Patch for bug 35296:SetCaretEnabled() takes too long
r/sr=sfraser
2003-04-13 08:38:57 +00:00
henry.jia%sun.com
a873e7e743 Patch for bug 35296: SetCaretEnabled() takes too long
Patch by Leon.Zhang@sun.com
r=sfraser, sr=kin
2003-04-02 05:48:09 +00:00
sfraser%netscape.com
511b311820 Fix bug 74404: show caret drag feedback. r=brade, sr=kin 2003-02-27 23:09:51 +00:00
kin%netscape.com
86eabf3281 Fix for regression bug 194774 (cursor appears to "jump" to beginning of line after hitting backspace)
Checking in this work around for leon.zhang@sun.com. Comment out the code that sets mCachedOffsetValid to PR_TRUE. This effectively disables the fix for bug 35296.

r=brade@netscape.com  sr=sfraser@netscape.com  a=leaf@mozilla.org
2003-02-25 18:10:35 +00:00
henry.jia%sun.com
1dd5b9dab2 Bug 35296: SetCaretEnabled() takes too long
Patch by Leon.Zhang@sun.com, r/sr=sfraser
2003-02-24 10:26:20 +00:00
jrgm%netscape.com
9f319a79e1 remove '#ifndef REPEATING_TIMERS' code. This was accidentally turned back on in 9/02 after being dead from 12/01, and will now revert to using repeating timers. Affect caret, <blink>, bookmarks & search 'ping'. bug 182141, r+sr=smfr 2003-01-20 04:26:17 +00:00
smontagu%netscape.com
50972ff560 Caret not displayed in empty right-aligned text input fields. Bug 105397, r=kin, sr=sfraser. 2003-01-09 01:01:38 +00:00
dbaron%dbaron.org
3ea0dc57d4 Bug 178643: Remove uses of NS_INIT_ISUPPORTS, since it is no longer needed. r=timeless sr=jag 2003-01-08 21:07:51 +00:00
caillon%returnzero.com
0dffa137af Re-landing these because I don't believe this are responsible for the Txul spike.
Bug 181975 - Convert layout to use nsIPrefService, nsIPrefBranch, and friends.
r/sr=roc+moz
2002-12-11 14:05:41 +00:00
caillon%returnzero.com
22b558c150 Backing out these changes since they appear to have caused a Txul regression on some tinderboxes (not all... weird...) 2002-12-11 05:11:02 +00:00
caillon%returnzero.com
71f8783cae Bug 181975 - Convert layout to use nsIPrefService, nsIPrefBranch, and friends.
r/sr=roc+moz
2002-12-10 23:41:12 +00:00
aaronl%netscape.com
076b6d3c59 Bug 166791. Invisible insertion point after tabbing to text field when typeaheadfind is active. r=mjudge, sr=alecf 2002-09-26 00:07:53 +00:00
dougt%netscape.com
68faeb5241 166917. Clean up xpcom SDK includes. r=rpotts@netscape.com, sr=alecf@netscape.com, a=rjesup@wgate.com 2002-09-07 17:13:19 +00:00
dougt%netscape.com
fae89c4077 Fixes up the timer interface. b157136, r=rpotts@netscape.com, sr=alecf@netscape.com, a=rjesup@wgate.com 2002-09-07 05:38:16 +00:00
mjudge%netscape.com
a07cba5734 4302 r=jfrancis sr=kin. pageup/down bug with navigation. 2002-08-26 20:55:30 +00:00
aaronl%netscape.com
fac59ec279 Bug 158754. Allow type ahead find to change selection color, and show caret with selection. r=akkana, sr=jst 2002-08-10 08:15:30 +00:00
aaronl%netscape.com
2d5ce67f73 Bug 153196. Active Accessibility: support MSAA caret object and events. r=kyle, sr=kin 2002-06-25 22:54:23 +00:00
cbiesinger%web.de
15a321ca78 bug 115473 r=pavlov sr=brendan
Remove timer priorities
2002-06-11 20:47:04 +00:00
shanjian%netscape.com
7f5900aa67 #142562 problem with <td align=right or align=center
We are observing langGroup in some place while ignor it in others. This patch
make all font metrics call consistent. nsIRenderingContext API is change to
make things neat.
r=rbs, sr=waterson
2002-05-24 20:11:14 +00:00
kin%netscape.com
6b835d7397 Fix for bug 135154 (Cursor not appearing in textarea after tabbing into it)
Don't call StopBlinking() if the selection changed notification is
for a selection that is different from the one in mDomSelectionWeak.

r=akkana@netscape.com  sr=attinasi@netscape.com
2002-04-26 13:11:47 +00:00
mjudge%netscape.com
cbca07291c 82151 r=jfrancis sr = kin 2002-04-16 02:42:09 +00:00
hyatt%netscape.com
e0734fa45e Fix for 129893, cocoa changes to gfx/layout/view, r=pink, sr=ben 2002-04-12 02:05:12 +00:00
dbaron%fas.harvard.edu
0c93d110f3 Tweak XP_MACOSX ifdefs to fix keyboard shortcuts (partly), context menus, and hidden window behavior and build the mac classic skin in the Mach-O build. b=109165 r=pinkerton sr=beard 2001-11-10 23:30:13 +00:00
dbaron%fas.harvard.edu
157c017816 Bug 86947:
Make the line list doubly linked and access it through a list class and iterators.
Stop recomputing margins on all of the children of each block in the reflow chain (which causes O(N^2) state recovery during incremental reflow).  Instead, add a second dirty bit to the lines and walk backwards through the line list to recompute vertical margins only when either dirty bit is set and the previous line was not reflowed.  Add nsIFrame::IsEmpty to identify frames through which margins collapse.
Fix O(N^2) propagation of float damage by maintaining a set of intervals damaged by floats (bug 61962) and be sure to damage the correct areas (bug 48138).
Introduce nsCollapsingMargin to do correct collapsing of combinations of positive and negative margins (bug 50142).
Clean up some odds and ends and fix another smaller O(N^2) problem in nsBlockFrame::AddFrames.
r=attinasi, rbs  sr=waterson
2001-10-25 01:08:40 +00:00
mkaply%us.ibm.com
72816bd6d4 #79798
r=ftang, sr=kin@netscape.com
Cursor is an ambigous term - use caret to refer to the text caret in Bidi functions
2001-09-30 20:35:55 +00:00
gerv%gerv.net
4e12e44b2f Relicensing Round 1, Take 2. Most C-like NPL files -> NPL/GPL/LGPL. Bug 98089. 2001-09-28 20:14:13 +00:00
simon%softel.co.il
4a71690e4f Move the IBMBIDI code in nsCaret.cpp to fix a crash when backspacing in a form with dir=rtl. Bug 89964, r=ftang, sr=kin. 2001-07-19 06:56:46 +00:00
dbaron%fas.harvard.edu
aa4fec2b67 Header include dependency cleanup. b=64023 r=jag rs=brendan 2001-07-16 02:40:48 +00:00
ftang%netscape.com
434d9c464f fix 84031. replace sizeof(datatype) to sizeof(variable)
r=nhotta sr=kin a=blizzard
2001-06-21 12:23:56 +00:00
hyatt%netscape.com
b135c5b55a Fix for 78695 (rule matching improvements). r/sr=attinasi, jst, waterson 2001-05-31 22:19:43 +00:00