Commit graph

366 commits

Author SHA1 Message Date
Noemi Erli
cc1f5b44f2 Backed out 4 changesets (bug 1510569) for mass test failures CLOSED TREE
Backed out changeset c5488e2770a6 (bug 1510569)
Backed out changeset df98eef1f640 (bug 1510569)
Backed out changeset db6da7f94a92 (bug 1510569)
Backed out changeset fb696b92c13d (bug 1510569)
2019-05-21 23:41:41 +03:00
Barret Rennie
68cdb08594 Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Previously the `WebNavigationChild` would keep track of when triggering its
`nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods.
It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of
porting `OnStateChange` and `OnLocationChange` events from
`WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this
informations needs to be available from the `BrowserChild`. As it stands, it is
currently an expando property on the `WebProgressChild`.

Instead of introducing yet another XPCOM interface for the WebProgressChild, we
now store this information directly on the `nsDocShell`. Furthermore, instead
of having the `WebNavigationChild` manage this part of the `nsDocShell`'s
state, we can have the `nsDocShell` manage this state itself so it is always
consistent.

Differential Revision: https://phabricator.services.mozilla.com/D28124

--HG--
extra : moz-landing-system : lando
2019-05-21 19:28:39 +00:00
Cosmin Sabou
e565aa827a Backed out 4 changesets (bug 1510569) for causing build bustages on nsIDocShell.idl CLOSED TREE
Backed out changeset 57f49df057be (bug 1510569)
Backed out changeset de97a258fcfd (bug 1510569)
Backed out changeset 4b0ed20ab3bc (bug 1510569)
Backed out changeset 1d8ab383d3e9 (bug 1510569)
2019-05-21 20:30:01 +03:00
Barret Rennie
3ee6a359f7 Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Previously the `WebNavigationChild` would keep track of when triggering its
`nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods.
It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of
porting `OnStateChange` and `OnLocationChange` events from
`WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this
informations needs to be available from the `BrowserChild`. As it stands, it is
currently an expando property on the `WebProgressChild`.

Instead of introducing yet another XPCOM interface for the WebProgressChild, we
now store this information directly on the `nsDocShell`. Furthermore, instead
of having the `WebNavigationChild` manage this part of the `nsDocShell`'s
state, we can have the `nsDocShell` manage this state itself so it is always
consistent.

Differential Revision: https://phabricator.services.mozilla.com/D28124

--HG--
extra : moz-landing-system : lando
2019-05-21 17:08:57 +00:00
Dão Gottwald
d028a9dc3b Bug 1547299 - Implement open-view-on-focus mode. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D31419

--HG--
extra : moz-landing-system : lando
2019-05-17 08:27:08 +00:00
Kyle Machulis
d0cadc6c25 Bug 1540839 - Add Cross Origin Opener Policy case for BC preservation; r=nika
If we're doing a process switch due to the cross origin opener policy
being mismatched, we don't want to preserve the browsing context.

Differential Revision: https://phabricator.services.mozilla.com/D26392
2019-05-14 10:51:05 -07:00
Razvan Maries
1be8bab7d1 Backed out 8 changesets (bug 1540839) for build bustages. CLOSED TREE
Backed out changeset f7e477858ab7 (bug 1540839)
Backed out changeset 55e841a0f005 (bug 1540839)
Backed out changeset b71b58e40426 (bug 1540839)
Backed out changeset 484a54613358 (bug 1540839)
Backed out changeset b34c4d71f202 (bug 1540839)
Backed out changeset 8ff2ff524489 (bug 1540839)
Backed out changeset 27492a30286c (bug 1540839)
Backed out changeset f1c35e8e84f6 (bug 1540839)
2019-05-14 04:23:27 +03:00
Kyle Machulis
679ff7a37e Bug 1540839 - Add Cross Origin Opener Policy case for BC preservation; r=nika
If we're doing a process switch due to the cross origin opener policy
being mismatched, we don't want to preserve the browsing context.

Differential Revision: https://phabricator.services.mozilla.com/D26392
2019-05-13 17:58:45 -07:00
Nika Layzell
6eb2084136 Bug 1544811 - Use web processes on a per-site basis for fission-enabled windows, r=mconley
This patch introduces a new type of content process, which has a dynamic name.
This type of content process is labeled as `webIsolated=${SITE_ORIGIN}` and is
used within fission-enabled windows.

To enable this, additional information about the fission status of the target
window must be passed into E10SUtils. This was done by updating every call site
manually to pass an extra boolean. A better solution perhaps should be used in
the future.

With this patch enabled, we now perform process switches, but only when
navigating to HTTP URIs. If we navigate to a non-HTTP URI in an iframe with
fission enabled, it will not behave correctly. This must be done in a
follow-up.

Differential Revision: https://phabricator.services.mozilla.com/D29570

--HG--
extra : moz-landing-system : lando
2019-05-03 21:31:57 +00:00
Bogdan Tara
a3eab309d8 Backed out 2 changesets (bug 1510569) for crashtests/1419902.html crashes CLOSED TREE
Backed out changeset fc0ae629221a (bug 1510569)
Backed out changeset 97f6ac273b5d (bug 1510569)
2019-05-03 03:48:15 +03:00
Barret Rennie
c28096b98d Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Previously the `WebNavigationChild` would keep track of when triggering its
`nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods.
It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of
porting `OnStateChange` and `OnLocationChange` events from
`WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this
informations needs to be available from the `BrowserChild`. As it stands, it is
currently an expando property on the `WebProgressChild`.

Instead of introducing yet another XPCOM interface for the WebProgressChild, we
now store this information directly on the `nsDocShell`. Furthermore, instead
of having the `WebNavigationChild` manage this part of the `nsDocShell`'s
state, we can have the `nsDocShell` manage this state itself so it is always
consistent.

Differential Revision: https://phabricator.services.mozilla.com/D28124

--HG--
extra : moz-landing-system : lando
2019-05-02 23:35:02 +00:00
Bogdan Tara
86cbef62d0 Backed out 2 changesets (bug 1510569) for crashtests/1419902.html failures CLOSED TREE
Backed out changeset 13c5249d66a7 (bug 1510569)
Backed out changeset a6ad4039d785 (bug 1510569)
2019-05-02 21:30:20 +03:00
Barret Rennie
5474c1f3df Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Previously the `WebNavigationChild` would keep track of when triggering its
`nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods.
It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of
porting `OnStateChange` and `OnLocationChange` events from
`WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this
informations needs to be available from the `BrowserChild`. As it stands, it is
currently an expando property on the `WebProgressChild`.

Instead of introducing yet another XPCOM interface for the WebProgressChild, we
now store this information directly on the `nsDocShell`. Furthermore, instead
of having the `WebNavigationChild` manage this part of the `nsDocShell`'s
state, we can have the `nsDocShell` manage this state itself so it is always
consistent.

Differential Revision: https://phabricator.services.mozilla.com/D28124

--HG--
extra : moz-landing-system : lando
2019-05-02 17:00:51 +00:00
Mike Conley
bff8e0ac63 Bug 1533955 - Show some UI to indicate that a subframe has crashed. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D29238

--HG--
extra : moz-landing-system : lando
2019-05-01 20:05:24 +00:00
Emilio Cobos Álvarez
ccc940508d Bug 1546019 - When a focused browser changes remoteness, make sure to activate the remote browser if needed. r=qdot
Not quite sure what's a good way to add a test for this... Ideas?

Differential Revision: https://phabricator.services.mozilla.com/D29104

--HG--
extra : moz-landing-system : lando
2019-04-29 20:06:22 +00:00
Ryan Hunt
3675f2449b Bug 1534395 - Rename nsITabParent to nsIRemoteTab. r=nika,mconley
nsITabParent is exposed to frontend code and is generally used as a representation of a remote tab. We could just rename the interface to nsIBrowserParent and worry about it later, but I think it's better to rename the interface to nsIRemoteTab so that we can later work on splitting the interface away from the PBrowser protocol.

Note: Some frontend code refers to a TabParentId. This commit renames this to RemoteTabId. We need to figure out the purpose of TabId with fission.

Differential Revision: https://phabricator.services.mozilla.com/D28132

--HG--
rename : dom/interfaces/base/nsITabParent.idl => dom/interfaces/base/nsIRemoteTab.idl
extra : rebase_source : 9d8a1790a7bb10195ad063644d1a93d63b2afb72
2019-04-09 15:59:37 -05:00
Nika Layzell
f7ae25cb52 Bug 1542791 - Part 2: Add a [F] marker to fission-enabled tabs, r=mconley
This should make it easier to tell whether a particular window is
fission-enabled as testing with fission enabled improves.

Differential Revision: https://phabricator.services.mozilla.com/D26561

--HG--
extra : moz-landing-system : lando
2019-04-17 00:53:30 +00:00
Jonathan Kingston
2b27f3c10d Bug 1479433 - Changing icons and colors for containers to be class based. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D24918

--HG--
extra : moz-landing-system : lando
2019-04-10 11:19:00 +00:00
Dão Gottwald
0b822d6214 Bug 1542299 - Remove Array.unshift usage from tabbrowser.js. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D26685

--HG--
extra : moz-landing-system : lando
2019-04-09 10:30:39 +00:00
Dão Gottwald
8e0b6d7a6e Bug 1542298 - Remove Array.filter usage from tabbrowser.js. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D26688

--HG--
extra : moz-landing-system : lando
2019-04-09 10:48:27 +00:00
Dão Gottwald
5e399367b5 Bug 1504775 - Ensure externally provided addTab index is within bounds. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D26296

--HG--
extra : moz-landing-system : lando
2019-04-05 17:23:07 +00:00
Brian
d8eb046cd9 Bug 1523763 - Move tab context menu strings to FTL file loaded on-demand. r=Gijs,flod
Moved tab context menu out of browser.dtd to browser.xul except for sendPageToDevice, sendLinkToDevice, moveTabOptions, moveSelectedTabOptions, undoCloseTab. Not sure if tabbrowser.js and tabbrowser.xul are working as intended.

Differential Revision: https://phabricator.services.mozilla.com/D19312

--HG--
extra : moz-landing-system : lando
2019-03-29 14:55:12 +00:00
sakshaat
d781937a67 Bug 1517483 - Get rid of nsIScriptSecurityManager::IsSystemPrincipal r=bzbarsky
Replaced instances of callers in both C++ and JS files to query the state from the principal directly.

Differential Revision: https://phabricator.services.mozilla.com/D22532

--HG--
extra : moz-landing-system : lando
2019-03-24 20:36:25 +00:00
Gijs Kruitbosch
d185982673 Bug 1530500 - remove obsolete browser swapping flags, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D24114

--HG--
extra : moz-landing-system : lando
2019-03-20 08:49:04 +00:00
Gijs Kruitbosch
44dd6b4718 Bug 1353013 - allow using the preloaded new tab page in private windows, too, r=dthayer
This didn't use to work and was disabled in
https://bugzilla.mozilla.org/show_bug.cgi?id=1195981 . I expect my changes in
https://bugzilla.mozilla.org/show_bug.cgi?id=1427186 fixed the issue. It works
in my testing, anyway.

Differential Revision: https://phabricator.services.mozilla.com/D21127

--HG--
extra : moz-landing-system : lando
2019-03-19 17:29:34 +00:00
Gijs Kruitbosch
5e05f6c9c9 Bug 1353013 - move new tab preload browser tracking into a separate module, r=dthayer
Differential Revision: https://phabricator.services.mozilla.com/D21126

--HG--
extra : moz-landing-system : lando
2019-03-19 17:29:14 +00:00
shindli
a7af1edc71 Backed out 3 changesets (bug 1353013) for a11y failures in accessible/tests/mochitest/relations/test_tabbrowser.xul CLOSED TREE
Backed out changeset af8bce2330e9 (bug 1353013)
Backed out changeset a3d1302b06c0 (bug 1353013)
Backed out changeset 976afd1adf84 (bug 1353013)
2019-03-18 18:21:16 +02:00
Gijs Kruitbosch
6f44e2b43b Bug 1353013 - allow using the preloaded new tab page in private windows, too, r=dthayer
This didn't use to work and was disabled in
https://bugzilla.mozilla.org/show_bug.cgi?id=1195981 . I expect my changes in
https://bugzilla.mozilla.org/show_bug.cgi?id=1427186 fixed the issue. It works
in my testing, anyway.

Differential Revision: https://phabricator.services.mozilla.com/D21127

--HG--
extra : moz-landing-system : lando
2019-03-12 14:34:24 +00:00
Gijs Kruitbosch
b7a741e6cb Bug 1353013 - move new tab preload browser tracking into a separate module, r=dthayer
Differential Revision: https://phabricator.services.mozilla.com/D21126

--HG--
extra : moz-landing-system : lando
2019-03-12 14:34:04 +00:00
Thomas Nguyen
26bd1e060c Bug 1528695 - Part 2 : Use referrerInfo in openWindow, contextmenu and openLinkIn r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D21911

--HG--
extra : moz-landing-system : lando
2019-03-15 05:10:17 +00:00
Kyle Machulis
f1f0e15fa3 Bug 1522713 - Don't change node binding to tree when updating remoteness; r=nika
Since we now have a method on nsFrameLoaderOwner/MozFrameLoaderOwner
that can update remoteness, we should no longer need to unbind and
rebind browser elements to the tree to change their remoteness
attributes. We can just call the method and have the Frameloaders
rebuilt in the backend.

We're still getting some test breakage in Marionette and browser
chrome with this patch. Putting this behind a pref so the fission
team can still work with it while the tests are being fixed.

Depends on D22790

Differential Revision: https://phabricator.services.mozilla.com/D22791

--HG--
extra : moz-landing-system : lando
2019-03-14 00:52:02 +00:00
Kyle Machulis
b1414002ac Bug 1524709 - Remove aShouldBeRemote from updateBrowserRemoteness; r=nika
Just set the RemoteType in the options object argument, instead of
doubling up the information.

Differential Revision: https://phabricator.services.mozilla.com/D23250

--HG--
extra : moz-landing-system : lando
2019-03-14 00:51:30 +00:00
James Willcox
082b6eb1e7 Bug 1524992 - Treat command line URIs as external r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D20890

--HG--
extra : moz-landing-system : lando
2019-03-12 20:20:58 +00:00
Mark Striemer
020a5bff50 Bug 1520068 - Handle more system shortcuts in add-on shortcuts ui r=dao
This centralizes the checks for system shortcuts into ShortcutUtils.jsm, so
they can be checked for in the add-on shortcut assignment UI. It also
introduces a mechanism for skipping the system event handler if it is already
being handled by the shortcuts UI.

Differential Revision: https://phabricator.services.mozilla.com/D17586

--HG--
extra : moz-landing-system : lando
2019-03-08 18:32:20 +00:00
arthur.iakab
85ad02d41a Merge inbound to mozilla-central a=merge 2019-03-07 23:58:42 +02:00
Dão Gottwald
cf91e86d2c Bug 1532719 - Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D22474

--HG--
extra : moz-landing-system : lando
2019-03-07 11:47:26 +00:00
Nikki S
58536c524e Bug 1484071 - Crop large data URLs before displaying them in the status bar r=Felipe
This commit provides a simple fix to reduce the time spent
rendering larger data URLs (such as large screenshots) in
the status panel when the Highlights tab is hovered over.
By limiting the number of characters displayed, this
decreases the time spent in the _showDelayed function.

Differential Revision: https://phabricator.services.mozilla.com/D21593

--HG--
extra : moz-landing-system : lando
2019-03-06 14:09:31 +00:00
Doug Thayer
61cadb5fd3 Bug 1532841 - Don't preopen pinned tabs for private browser window r=Gijs
If we're opening a private browsing window on startup, we won't run the
session restore code, and thus we won't end up cleaning up the preopened
tabs. This raises the question: are there other scenarios where we won't
run restoreWindow at all? Eyeballing the code I think not, but I'm not
sure.

Depends on D22195

Differential Revision: https://phabricator.services.mozilla.com/D22216

--HG--
extra : moz-landing-system : lando
2019-03-06 11:51:55 +00:00
Brindusan Cristian
252f6553c6 Backed out changeset 6890499eb5d1 (bug 1484071) for ESlint failure at tabbrowser.js. CLOSED TREE 2019-03-06 01:42:21 +02:00
Nikki S
30f6fc4eeb Bug 1484071 - Crop large data URLs before displaying them in the status bar r=Felipe
This commit provides a simple fix to reduce the time spent
rendering larger data URLs (such as large screenshots) in
the status panel when the Highlights tab is hovered over.
By limiting the number of characters displayed, this
decreases the time spent in the _showDelayed function.

Differential Revision: https://phabricator.services.mozilla.com/D21593

--HG--
extra : moz-landing-system : lando
2019-03-05 22:11:37 +00:00
Andreea Pavel
be960187e1 Backed out 3 changesets (bug 1524992) for valgrind failures on a CLOSED TREE
Backed out changeset face9d1e8868 (bug 1524992)
Backed out changeset ae1e20a595c4 (bug 1524992)
Backed out changeset b0b9322c7a59 (bug 1524992)
2019-03-05 01:36:59 +02:00
James Willcox
4440844f6a Bug 1524992 - Treat command line URIs as external r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D20890

--HG--
extra : moz-landing-system : lando
2019-03-04 22:06:30 +00:00
Doug Thayer
9790c57933 Bug 1442694 - Preopen pinned tabs before session restore r=Gijs
When we open firefox with pinned tabs, we first paint a window with
one tab open, and then that tab gets displaced after the pinned tabs
come in. This aims to ensure that our first paint contains the
pinned tab, so that we don't have tabs moving around after first
paint.

MozReview-Commit-ID: GC1y6NlgLTd

Differential Revision: https://phabricator.services.mozilla.com/D18742

--HG--
extra : moz-landing-system : lando
2019-03-01 18:28:53 +00:00
Dão Gottwald
fb03a6d522 Backed out changeset 59c8fffe9e41 (bug 1442694) 2019-03-07 11:41:29 +01:00
Johann Hofmann
b4d5efa6f7 Bug 1525267 - Move auth prompt rate limiting to nsIAuthPrompt2.promptAuth. r=MattN
This also changes the name of 'canceledAuthenticationPromptCounter' to account for the
fact that we no longer count up when the prompt was cancelled, but when it was shown.

Differential Revision: https://phabricator.services.mozilla.com/D21680

--HG--
extra : moz-landing-system : lando
2019-03-01 15:24:19 +00:00
Oriol Brufau
c153629d72 Bug 1521923 - Preserve lazyness of the first inactive tab moved into a new window. r=jaws CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D20100

--HG--
extra : source : 51ffa59f14882531251a889b57ed73530c8997ac
extra : histedit_source : 6cf345b42f48b404c9ec2cdef9a7279012e1a0f1
2019-02-28 23:21:40 +00:00
Narcis Beleuzu
1bcc890eb4 Backed out changeset 51ffa59f1488 (bug 1521923) for WR failures on outline-013.html . CLOSED TREE 2019-03-01 06:25:27 +02:00
Oriol Brufau
ceaa13b7b4 Bug 1521923 - Preserve lazyness of the first inactive tab moved into a new window. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D20100

--HG--
extra : moz-landing-system : lando
2019-02-28 23:21:40 +00:00
Gabriele Svelto
0443979a06 Bug 675539 - Make tab discard functionality work on tab objects directly r=mconley
This removes the need to go through the browser-to-tab mapping when discarding
a tab and simplifies the relevant code. Besides being renamed discardBrowser()
was also split so that one can check if a tab can be discarded prior to trying
it.

Differential Revision: https://phabricator.services.mozilla.com/D20475

--HG--
extra : moz-landing-system : lando
2019-02-26 05:35:09 +00:00
Coroiu Cristina
5a9b738453 Backed out 2 changesets (bug 1524992) for multiple failures and timeout on a CLOSED TREE
Backed out changeset fb1d7e57e253 (bug 1524992)
Backed out changeset bd215cd3c8d7 (bug 1524992)
2019-02-27 19:02:03 +02:00