Commit graph

14 commits

Author SHA1 Message Date
Emilio Cobos Álvarez
e05d3b513e Bug 1612427 - Fix flaky browser_947914_button_zoomReset.js. r=Gijs
This is what I see when running the test:

console.log: Changing zoom for browser from 1 to 0.5
	set fullZoom@chrome://global/content/elements/browser-custom-element.js:812:19
	set fullZoom@chrome://browser/content/tabbrowser.js:526:7
	ZoomManager_setZoomForBrowser@chrome://global/content/viewZoomOverlay.js:60:7
	set zoom@chrome://global/content/viewZoomOverlay.js:49:10
	@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_947914_button_zoomReset.js:26:5
	Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1039:34
	Tester_execTest@chrome://mochikit/content/browser-test.js:1074:11
	nextTest/<@chrome://mochikit/content/browser-test.js:904:14
	SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23

"FullZoomChange for browser"

PASS Zoom reset button exists in Panel Menu -

console.log: Changing zoom for browser from 0.5 to 1
	console.log: set fullZoom@chrome://global/content/elements/browser-custom-element.js:817:19
	ZoomManager_setZoomForBrowser@chrome://global/content/viewZoomOverlay.js:60:7
	FullZoom__applyPrefToZoom@chrome://browser/content/browser-fullZoom.js:479:19
	FullZoom_onLocationChange@chrome://browser/content/browser-fullZoom.js:247:14
	XWB_onUpdateCurrentBrowser@chrome://browser/content/browser.js:5419:16
	callListeners@chrome://browser/content/tabbrowser.js:820:31
	_callProgressListeners@chrome://browser/content/tabbrowser.js:834:22
	_callProgressListeners@chrome://browser/content/tabbrowser.js:5776:46
	onStateChange@chrome://browser/content/tabbrowser.js:6039:14
	_callProgressListeners@resource://gre/modules/RemoteWebProgress.jsm:75:31
	onStateChange@resource://gre/modules/RemoteWebProgress.jsm:88:10

Which is pretty broken (the zoom is reset way earlier than clicking the reset
button, by FullZoom.onLocationChange).

This seems to me was mostly passing by chance, but with my Fission changes
which made FullZoomChange events more async (and actually, not notify twice) it
started failing.

Wait to load a page before changing the zoom level so that the browser doesn't
reset it when navigating.

Differential Revision: https://phabricator.services.mozilla.com/D72208
2020-04-24 08:13:37 +00:00
Victor Porof
1f830c96da Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042

--HG--
extra : source : d3afcafdce650a6f36cebbc126ee93b17f13cf52
2019-07-05 09:53:32 +02:00
Gijs Kruitbosch
58d91186ae Bug 1393133 - wait for the overflow button to be visible before activating it in tests, r=jaws
MozReview-Commit-ID: 58GGrPVufZ3

--HG--
extra : rebase_source : 325709623de03b4fd7e1414fff5bb42474194551
2017-08-24 17:25:24 +01:00
Gijs Kruitbosch
8216336ee8 Bug 1354117 - update panel button tests for photon, r=adw
MozReview-Commit-ID: 94mIvlOenCg

--HG--
extra : rebase_source : 165971d09f4bf5129aafcf2d6c1e11c1315cd6a1
2017-08-01 11:33:26 +01:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Gijs
233681e912 Bug 1354082 - part 0: set prefs in all the tests that need it, r=mikedeboer
MozReview-Commit-ID: D1YDY5NvdYJ

--HG--
extra : rebase_source : 06b2b1e31efdf77b9eced71db930b6e291175e3d
extra : histedit_source : 11449e9985fea4b5f0a51fd1c73a1c41a79d66e3
2017-05-10 06:54:44 -04:00
Kris Maglione
13c6073298 Bug 1238310: Follow-up: Fix some timing issues in tests. r=bustage
MozReview-Commit-ID: BjKiNO1T5yN

--HG--
extra : amend_source : ae884bd9cd629853d6d2998ef4e460bc46f67107
2016-04-23 23:56:28 -07:00
Jared Wein
3f6801477a Bug 1242137 - Fix eslint errors in /browser/components/customizableui. r=gijs
--HG--
extra : commitid : CTMv8KOMjRK
extra : rebase_source : 768fb80e4652c1f0e14eea9e32da8eff795f1659
extra : amend_source : bd695a57c00c8004b048ccd4673465d66bea22c6
extra : histedit_source : ca0c6fcb719d0e7f0895de1bd429fa9804833f65
2016-01-23 14:55:27 -05:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Mihaela Velimiroviciu
ec54f075e2 Bug 947914 - Add test for the functionality of Panel Menu buttons in Australis. r=Gijs 2014-09-30 10:12:43 +03:00
Ryan VanderMeulen
8d5596e4bc Backed out changeset cabda6c7f0e9 (bug 947914) for frequent test failures. 2014-04-26 18:12:33 -04:00
Mihaela Velimiroviciu
2f72cbde02 Bug 947914 - Add test for the funtionality of panel menu default buttons. r=Gijs 2014-04-25 14:46:52 +03:00
Ed Morley
3f6c185490 Backed out changeset 1d6730688107 (bug 947914) for browser-chrome failures 2014-03-04 17:25:53 +00:00
Mihaela Velimiroviciu
596e519bf2 Bug 947914 - tests for Australis panel menu default buttons existence and functionality. r=Gijs 2014-03-04 17:30:17 +02:00