Commit graph

410 commits

Author SHA1 Message Date
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Kris Maglione
c9bc5f8a41 Bug 1542415: Part 4 - Always rebuild frameloaders on remoteness change in Fission windows. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D44738

--HG--
extra : moz-landing-system : lando
2019-09-09 12:28:09 +00:00
Andreas Farre
6e42fb98f8 Bug 1563619 - Handle subframe crashes in BrowserParent::ActorDestroy. r=mconley,kmag,peterv
Differential Revision: https://phabricator.services.mozilla.com/D40937

--HG--
extra : moz-landing-system : lando
2019-08-26 13:08:32 +00:00
Paul Zuehlcke
619584035d Bug 1574110 - Updated tabbrowser.js SitePermissions call to use principal. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D42321

--HG--
extra : moz-landing-system : lando
2019-08-20 12:29:26 +00:00
Cameron McCormack
d622a3d445 Bug 1569060 - Add layout debugger command to dump process IDs. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D39437

--HG--
extra : moz-landing-system : lando
2019-08-06 23:31:55 +00:00
Paul Zuehlcke
5a377a3a37 Bug 630614 - Show an indicator when geolocation is in use. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D35428

--HG--
extra : moz-landing-system : lando
2019-07-30 08:28:31 +00:00
Csoregi Natalia
141bcffcc8 Backed out changeset 3855d35999dd (bug 630614) for causing failures on browser_ext_tabs_sharingState.js. CLOSED TREE 2019-07-29 14:32:05 +03:00
Paul Zuehlcke
15afab0390 Bug 630614 - Show an indicator when geolocation is in use. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D35428

--HG--
extra : moz-landing-system : lando
2019-07-29 08:37:55 +00:00
Abdoulaye Oumar Ly
70d817b8d5 Bug 1481055 - Improve the consistency of params of tab multiselection functions in gBrowser. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D36356

--HG--
extra : moz-landing-system : lando
2019-07-22 17:16:40 +00:00
Narcis Beleuzu
a30f010301 Backed out changeset ff49c94ed1d2 (bug 1481055) for bc failures on browser_multiselect_tabs_using_keyboard.js . CLOSED TREE 2019-07-18 23:10:58 +03:00
Abdoulaye O. Ly
edb8d71d8c Bug 1481055 - Improve the consistency of params of tab multiselection functions in gBrowser. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D36356

--HG--
extra : moz-landing-system : lando
2019-07-11 18:43:05 +00:00
James Teh
0faff9a8fe Bug 1410757: Expose the info provided in the tool tip for the focused browser tab as the tab's accessible description. r=Gijs
The tool tip for a browser tab exposes information such as the process ids (on Nightly) and the container tab name.
It appears when a user mouses over the tab, but this isn't really accessible to screen reader users.
Ideally, we'd expose this information as the accessible description for all browser tabs.
However, doing this for all tabs and keeping it up to date is rather difficult and potentially expensive.
Instead, just expose this description for a tab when it gets focus; i.e. the user has to focus the tab bar to access it.

To enable this, XUL tab elements now fire an AriaFocus event on the ARIA focused tab when the ariaFocusedItem property is set.

Differential Revision: https://phabricator.services.mozilla.com/D38027

--HG--
extra : moz-landing-system : lando
2019-07-15 11:21:15 +00:00
Dão Gottwald
da30f0dd76 Bug 1528605 - Remove UrlbarInput::closePopup in favor of UrlbarView::close. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D37550

--HG--
extra : moz-landing-system : lando
2019-07-10 15:25:35 +00:00
Jonathan Kingston
31441f82ea Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D35504

--HG--
extra : moz-landing-system : lando
2019-07-08 16:37:45 +00:00
Victor Porof
f9f5914039 Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041

--HG--
extra : source : 96b3895a3b2aa2fcb064c85ec5857b7216884556
2019-07-05 09:48:57 +02:00
Andrew Swan
7696519cff Bug 1555060 Convert <tabs> to a custom element
The conversion for "regular" <tabs> elements is straightforward, most of
the work here is to support the tab strip (the <tabs> element with the id
"tabbrowser-tabs").  The markup needed for the tab strip moves directly
into browser.xhtml and the construction/teardown logic is now explicitly
driven from gBrowser.  There are many more little tweaks too numerous to
enumerate.

Differential Revision: https://phabricator.services.mozilla.com/D32855

--HG--
rename : browser/base/content/tabbrowser.xml => browser/base/content/tabbrowser-tabs.js
extra : source : c163881a80c9a032b40f7d965fad6a6850fcf8a4
extra : intermediate-source : a5c6deeda8a9475ac0268a4351417c8ff659c962
extra : histedit_source : 5eb8b3d14027f2aeca5c52534096837cd0343104%2Ca23a07ddd5e1fb8bd084644dd6db0ee028b7c4b4
2019-06-20 14:09:37 -07:00
Andrew Swan
f1d137eff5 Bug 1555060 Stop using dom structure for <tabs>/<tab> relationships
A bunch of existing code assumes that <tab> elements are the immediate
and only children of a <tabs> element, and uses dom apis to traverse
relationships between these elements.  To simplify conversion of <tabs>
to a custom element (and hopefully improve readability a bit at the same
time!), introduce new apis:

On <tab>
this.parentNode -> this.container
this.nextElementSibling -> this.container.findNextTab(...)
this.previousElementSibiling -> this.container.findNextTab(...)

On <tabs>
this.children -> this.allTabs

Differential Revision: https://phabricator.services.mozilla.com/D34648

--HG--
extra : source : f4e21e465f384b90fa1e768141c4db708748bf66
extra : histedit_source : 95d8a4242e8e04df9e29c2b647558d37e910b845
2019-06-11 14:49:46 -07:00
Ciure Andrei
c04368fddd Backed out 3 changesets (bug 1555060) for causing test_tabbar.py to perma fail CLOSED TREE
Backed out changeset a5c6deeda8a9 (bug 1555060)
Backed out changeset f4e21e465f38 (bug 1555060)
Backed out changeset c71c45fe3e63 (bug 1555060)

--HG--
rename : browser/base/content/tabbrowser-tabs.js => browser/base/content/tabbrowser.xml
2019-06-28 00:21:50 +03:00
Andrew Swan
e6c0e0f03a Bug 1555060 Convert <tabs> to a custom element
The conversion for "regular" <tabs> elements is straightforward, most of
the work here is to support the tab strip (the <tabs> element with the id
"tabbrowser-tabs").  The markup needed for the tab strip moves directly
into browser.xhtml and the construction/teardown logic is now explicitly
driven from gBrowser.  There are many more little tweaks too numerous to
enumerate.

Differential Revision: https://phabricator.services.mozilla.com/D32855

--HG--
rename : browser/base/content/tabbrowser.xml => browser/base/content/tabbrowser-tabs.js
extra : rebase_source : 6b2b0ed9b01958d1b2db605ab300c4bebcaa461c
extra : source : c163881a80c9a032b40f7d965fad6a6850fcf8a4
2019-06-20 14:09:37 -07:00
Andrew Swan
6fd54d15e6 Bug 1555060 Stop using dom structure for <tabs>/<tab> relationships
A bunch of existing code assumes that <tab> elements are the immediate
and only children of a <tabs> element, and uses dom apis to traverse
relationships between these elements.  To simplify conversion of <tabs>
to a custom element (and hopefully improve readability a bit at the same
time!), introduce new apis:

On <tab>
this.parentNode -> this.container
this.nextElementSibling -> this.container.findNextTab(...)
this.previousElementSibiling -> this.container.findNextTab(...)

On <tabs>
this.children -> this.allTabs

Differential Revision: https://phabricator.services.mozilla.com/D34648

--HG--
extra : rebase_source : affeda0295a5195124709f322de524aea3a28a3f
2019-06-11 14:49:46 -07:00
Geoff Lankow
7df08a4fb1 Bug 1529205 - Remove DateTimePickerParent's dependency on gBrowser; r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D35392

--HG--
extra : moz-landing-system : lando
2019-06-26 18:15:28 +00:00
Nika Layzell
9033668540 Bug 1559409 - Show subframe pids in tab hover text, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D35029

--HG--
extra : moz-landing-system : lando
2019-06-14 15:42:39 +00:00
Dão Gottwald
d3918ecf49 Bug 1559363 - Open-view-on-focus mode should only apply when the user explicitly focuses the address bar, not on autofocus. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D35280

--HG--
extra : moz-landing-system : lando
2019-06-19 01:18:06 +00:00
Ehsan Akhgari
fc40494b9c Bug 1557887 - Part 5: Pass a storage principal argument through the browser loadURI()/addTab() APIs; r=baku,mconley
Differential Revision: https://phabricator.services.mozilla.com/D34459

--HG--
extra : moz-landing-system : lando
2019-06-12 23:05:36 +00:00
Gurzau Raul
227f5329f7 Merge inbound to mozilla-central. a=merge 2019-06-12 00:34:32 +03:00
Neil Deakin
e5fb1d5934 Bug 1533948, change BrowserTabChild to inherit from JSWindowActor, r=mconley
--HG--
extra : rebase_source : 5e88e30ac09c15e6747f6ef1019e9b27a793a898
2019-06-11 09:05:33 -04:00
Boris Zbarsky
9de72a3ac6 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196

--HG--
extra : moz-landing-system : lando
2019-06-11 15:51:51 +00:00
Mike Conley
42b822a5ef Bug 1505909 - Merge remote and non-remote context menu handlers. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D32757

--HG--
extra : moz-landing-system : lando
2019-06-08 01:09:10 +00:00
Noemi Erli
ea35f4b13b Backed out 6 changesets (bug 1505909) for failures in browser_ext_webNavigation_onCreatedNavigationTarget_contextmenu.js CLOSED TREE
Backed out changeset 57336967a6c7 (bug 1505909)
Backed out changeset 8adcacadd689 (bug 1505909)
Backed out changeset bcca6bb913ef (bug 1505909)
Backed out changeset afc11a5ebb6d (bug 1505909)
Backed out changeset 40f0a56ed3af (bug 1505909)
Backed out changeset 3e31f9726798 (bug 1505909)
2019-06-07 19:19:14 +03:00
Mike Conley
cef09f3647 Bug 1505909 - Merge remote and non-remote context menu handlers. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D32757

--HG--
extra : moz-landing-system : lando
2019-06-07 14:28:33 +00:00
Bogdan Tara
4da63aeb53 Backed out 6 changesets (bug 1505909) for bc failures complaining about WebNavigationChild and browser_e10s_about_page_triggeringprincipal.js CLOSED TREE
Backed out changeset 56449fd37aee (bug 1505909)
Backed out changeset 3ff09b79821c (bug 1505909)
Backed out changeset a1a2a9efe22f (bug 1505909)
Backed out changeset 8aeb77291207 (bug 1505909)
Backed out changeset 4aa17e28ee54 (bug 1505909)
Backed out changeset dbe6803d979e (bug 1505909)
2019-06-07 06:15:16 +03:00
Mike Conley
014fa7a924 Bug 1505909 - Merge remote and non-remote context menu handlers. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D32757

--HG--
extra : moz-landing-system : lando
2019-06-06 20:32:11 +00:00
Emilio Cobos Álvarez
b6728cedb7 Bug 1553769 - Have a single way of requesting window focus and switching to a tab. r=NeilDeakin,snorp
Right now there's some duplicated code with the focus manager and the
DOMWindowFocus event.

Android didn't handle the new framefocusrequested event, so the test-cases in
bug 416771 still didn't work there.

I think using the focus manager codepath everywhere is preferable. I confirmed
manually that the stuff that sent DOMWindowFocus events still works as expected
with this patch (i.e., switching to the right tab when you click on a
notification, etc.).

This fixes it so that it works in Fennec, and it sends the focus events right in
GeckoView Example (i.e., we get here[1] properly).

The snippet that Snorp provided on IRC to implement the "bring activity to
front" stuff (`startActivity(getIntent())`) didn't actually work for me, but I
confirmed that the right message is sent when the focus is requested, and that
we get there.

[1]: https://searchfox.org/mozilla-central/rev/952521e6164ddffa3f34bc8cfa5a81afc5b859c4/mobile/android/geckoview_example/src/main/java/org/mozilla/geckoview_example/GeckoViewActivity.java#503

Depends on D32353

Differential Revision: https://phabricator.services.mozilla.com/D32354

--HG--
extra : moz-landing-system : lando
2019-06-03 19:42:28 +00:00
Gijs Kruitbosch
55d70903ed Bug 1555453 - use contextmenu event as backup to ensure we always localize the context menu, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D33328

--HG--
extra : moz-landing-system : lando
2019-05-31 20:01:56 +00:00
Mike Conley
82bd51e393 Bug 1533949 - Make BrowserChild functions Fission-compatible, and move to BrowserElementChild. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D30725

--HG--
rename : toolkit/actors/BrowserChild.jsm => toolkit/actors/BrowserElementChild.jsm
extra : moz-landing-system : lando
2019-05-30 19:01:29 +00:00
Alexander Surkov
452c2f3269 Bug 1519514 - convert tabbrowser-tab binding to a Custom Element, r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D28662

--HG--
extra : source : 8488d800a7856b6dc4a1619592fc776dc1a5e444
2019-05-28 22:00:28 +00:00
Cosmin Sabou
fa7207a14d Backed out 4 changesets (bug 1519514) for causing several browser chrome failures. CLOSED TREE
Backed out changeset 485c2c76fab6 (bug 1519514)
Backed out changeset 8488d800a785 (bug 1519514)
Backed out changeset 858b9456eb3c (bug 1519514)
Backed out changeset 2cd983857de6 (bug 1519514)
2019-05-29 11:01:47 +03:00
Alexander Surkov
0f1bc68db8 Bug 1519514 - convert tabbrowser-tab binding to a Custom Element, r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D28662

--HG--
extra : moz-landing-system : lando
2019-05-28 22:00:28 +00:00
Barret Rennie
0345083532 Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Previously the `WebNavigationChild` would keep track of when triggering its
`nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods.
It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of
porting `OnStateChange` and `OnLocationChange` events from
`WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this
informations needs to be available from the `BrowserChild`. As it stands, it is
currently an expando property on the `WebProgressChild`.

Instead of introducing yet another XPCOM interface for the WebProgressChild, we
now store this information directly on the `nsDocShell`. Furthermore, instead
of having the `WebNavigationChild` manage this part of the `nsDocShell`'s
state, we can have the `nsDocShell` manage this state itself so it is always
consistent.

Differential Revision: https://phabricator.services.mozilla.com/D28124

--HG--
extra : moz-landing-system : lando
2019-05-23 18:48:48 +00:00
Bogdan Tara
a0b69fc936 Backed out 4 changesets (bug 1510569) for 1419902.html failures CLOSED TREE
Backed out changeset 756519a7cf79 (bug 1510569)
Backed out changeset 39c6818fdb12 (bug 1510569)
Backed out changeset 3d9715a5ecd4 (bug 1510569)
Backed out changeset 418a61f5f87b (bug 1510569)
2019-05-23 01:58:51 +03:00
Barret Rennie
f795631269 Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Previously the `WebNavigationChild` would keep track of when triggering its
`nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods.
It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of
porting `OnStateChange` and `OnLocationChange` events from
`WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this
informations needs to be available from the `BrowserChild`. As it stands, it is
currently an expando property on the `WebProgressChild`.

Instead of introducing yet another XPCOM interface for the WebProgressChild, we
now store this information directly on the `nsDocShell`. Furthermore, instead
of having the `WebNavigationChild` manage this part of the `nsDocShell`'s
state, we can have the `nsDocShell` manage this state itself so it is always
consistent.

Differential Revision: https://phabricator.services.mozilla.com/D28124

--HG--
extra : moz-landing-system : lando
2019-05-21 21:34:54 +00:00
Emilio Cobos Álvarez
300ed443b9 Bug 416771 - Allow window.focus() to switch tabs. r=NeilDeakin,dao CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D31643

--HG--
extra : source : 5acccb49a66840b5c2266edfb7a8953878a2a040
extra : histedit_source : 33a19d54114ef5eda00aefb1c997d6dbcfb40501
2019-05-22 17:21:29 +00:00
Bogdan Tara
e34a09a25c Backed out changeset 5acccb49a668 (bug 416771) for gecko decision bustage CLOSED TREE 2019-05-22 20:38:33 +03:00
Emilio Cobos Álvarez
f11ec3db68 Bug 416771 - Allow window.focus() to switch tabs. r=NeilDeakin,dao
Differential Revision: https://phabricator.services.mozilla.com/D31643

--HG--
extra : moz-landing-system : lando
2019-05-22 17:21:29 +00:00
Noemi Erli
cc1f5b44f2 Backed out 4 changesets (bug 1510569) for mass test failures CLOSED TREE
Backed out changeset c5488e2770a6 (bug 1510569)
Backed out changeset df98eef1f640 (bug 1510569)
Backed out changeset db6da7f94a92 (bug 1510569)
Backed out changeset fb696b92c13d (bug 1510569)
2019-05-21 23:41:41 +03:00
Barret Rennie
68cdb08594 Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Previously the `WebNavigationChild` would keep track of when triggering its
`nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods.
It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of
porting `OnStateChange` and `OnLocationChange` events from
`WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this
informations needs to be available from the `BrowserChild`. As it stands, it is
currently an expando property on the `WebProgressChild`.

Instead of introducing yet another XPCOM interface for the WebProgressChild, we
now store this information directly on the `nsDocShell`. Furthermore, instead
of having the `WebNavigationChild` manage this part of the `nsDocShell`'s
state, we can have the `nsDocShell` manage this state itself so it is always
consistent.

Differential Revision: https://phabricator.services.mozilla.com/D28124

--HG--
extra : moz-landing-system : lando
2019-05-21 19:28:39 +00:00
Cosmin Sabou
e565aa827a Backed out 4 changesets (bug 1510569) for causing build bustages on nsIDocShell.idl CLOSED TREE
Backed out changeset 57f49df057be (bug 1510569)
Backed out changeset de97a258fcfd (bug 1510569)
Backed out changeset 4b0ed20ab3bc (bug 1510569)
Backed out changeset 1d8ab383d3e9 (bug 1510569)
2019-05-21 20:30:01 +03:00
Barret Rennie
3ee6a359f7 Bug 1510569 - Keep track of whether we are navigating to a new URI in nsDocShell r=mconley,kmag,qdot
Previously the `WebNavigationChild` would keep track of when triggering its
`nsIWebNavigation`, `goForward`, `goBack`, `gotoIndex`, and `loadURI` methods.
It's `nsIWebNavigation` instance is always an `nsIDocShell` and as part of
porting `OnStateChange` and `OnLocationChange` events from
`WebProgressChild`/`RemoteWebProgress` to `BrowserChild`/`BrowserParent`, this
informations needs to be available from the `BrowserChild`. As it stands, it is
currently an expando property on the `WebProgressChild`.

Instead of introducing yet another XPCOM interface for the WebProgressChild, we
now store this information directly on the `nsDocShell`. Furthermore, instead
of having the `WebNavigationChild` manage this part of the `nsDocShell`'s
state, we can have the `nsDocShell` manage this state itself so it is always
consistent.

Differential Revision: https://phabricator.services.mozilla.com/D28124

--HG--
extra : moz-landing-system : lando
2019-05-21 17:08:57 +00:00
Dão Gottwald
d028a9dc3b Bug 1547299 - Implement open-view-on-focus mode. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D31419

--HG--
extra : moz-landing-system : lando
2019-05-17 08:27:08 +00:00
Kyle Machulis
d0cadc6c25 Bug 1540839 - Add Cross Origin Opener Policy case for BC preservation; r=nika
If we're doing a process switch due to the cross origin opener policy
being mismatched, we don't want to preserve the browsing context.

Differential Revision: https://phabricator.services.mozilla.com/D26392
2019-05-14 10:51:05 -07:00