Commit graph

382 commits

Author SHA1 Message Date
Katie Broida[:ktbee]
07f2d654fe Bug 1171746 - Ensure tab-specific panels close when you switch the tab. r=jaws
--HG--
extra : amend_source : 8c8bd60be44132befa37a50422086d9ffdae3cbe
2016-08-19 07:27:00 -04:00
Wes Kocher
7636e9aaaf Backed out changeset 33fcf83eefe4 (bug 1171746) for browser_visibleFindSelection.js failures a=backout 2016-08-12 19:11:21 -07:00
Katie Broida[:ktbee]
b9d80840e4 Bug 1171746 - ensure tab specific panels close when you switch the tab r=jaws
Adds a tabspecific attribute to the edit bookmarks panel and the Pocket subview panel to signal that these popups should close when the user navigates away from the tab. It also specifies that the localized keyboard short cut for closing a  window should close the edit bookmarks panel and the tab by adding a general function to check whether a certain <key> has been pressed. Adds tests for both closing specific tabs and checking keys.

MozReview-Commit-ID: AxW5uQgDQQB

--HG--
extra : rebase_source : 76f649492e719317a9ef71895e9cb1d600ea67b1
2016-08-11 16:51:45 -04:00
Dão Gottwald
347cc05845 Bug 1289659 - Account for placesContext not existing in non-browser windows on Mac. r=mdeboer 2016-08-10 13:49:20 +02:00
Jared Wein
fd84c776c7 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt

--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00
Pushpankar
c6670d980f Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao
--HG--
extra : rebase_source : 72d50e73baf595840a2aade57ae782e4c40d4c27
2016-07-16 10:20:04 +02:00
Jared Wein
78099b5a1b Bug 1251071 - "New bookmark" popup disappears if I reopen it after creating bookmark. r=mak
MozReview-Commit-ID: DNqcu5vxrBG
* * *


MozReview-Commit-ID: 3KoNVklCK8d
2016-07-06 07:27:00 +02:00
Scott Wu
14183e306e Bug 754623 - Get page title from tab label; r=mak
MozReview-Commit-ID: BOXUKUcA0fZ

--HG--
extra : transplant_source : C%15%EB%C50%A3%E4eK%C7%60%965l%F5u%A3%F3%B9%0F
2016-05-19 12:45:21 +08:00
Dão Gottwald
f0ad31722f Bug 1257087 - Middle mouse click on history item should open it. r=mak 2016-05-25 18:15:15 +02:00
Dão Gottwald
b2ab89a79b Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak 2016-05-24 14:31:33 +02:00
Sebastian Hengst
5a53f34fe3 Backed out changeset 54ebf85e8731 (bug 1219788) for leaks in many mochitests on Linux. r=backout 2016-05-21 09:35:06 +02:00
Dão Gottwald
377084b710 Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak
--HG--
extra : rebase_source : d7fc47340b6655ac5050d5e742dc39565e147e82
2016-05-20 14:41:49 +02:00
Mike de Boer
08e2673c63 Bug 1248267 - allow Recently Bookmarked items to be special root nodes to allow primitive contextual actions. r=mak,dao 2016-05-19 12:37:33 +02:00
Dão Gottwald
ab3bd282d9 Bug 1250203 - Re-populate recent bookmarks when a bookmark gets deleted while the menu is open. r=mak 2016-05-04 16:52:40 +02:00
Carsten "Tomcat" Book
548d98c27e merge mozilla-inbound to mozilla-central a=merge 2016-05-02 11:25:32 +02:00
Matt Brubeck
a17fb5bfed Bug 943888 - Always keep the bookmark star button enabled [r=mak]
MozReview-Commit-ID: 27ee1dbLSM1

--HG--
extra : rebase_source : 2d9a4aa005d585fa6ceafe174bbbd5f8c6b8f5ec
2016-04-25 13:59:00 -07:00
Scott Wu
ca33d182f4 Bug 446171 - Part 1: Get page titles from tab and not depend on history; r=mak
MozReview-Commit-ID: EUQv2p9LxtY

--HG--
extra : rebase_source : 0967a5d7b3fcb6cfd74c00f6252a6cca1a85b77b
extra : histedit_source : 6ee3667d3a79284058e2f9628e0b5d1c365ff7a9
2016-03-21 14:57:18 +08:00
Dão Gottwald
ac879e2e39 Bug 1248268 - Add option for disabling the "Recently Bookmarked" UI. r=mak 2016-04-29 13:43:59 +02:00
Wes Kocher
5b1e4f68c2 Backed out changeset fec92924befb (bug 1250203) for bc leaks
MozReview-Commit-ID: BMq0vBarOQZ
2016-04-15 12:19:44 -07:00
Dão Gottwald
10bc69ffda Bug 1250203 - Re-populate recent bookmarks when a bookmark has been deleted. r=mak 2016-04-15 16:50:20 +02:00
Sebastian Hengst
c515d4ce79 Backed out changeset 81df156cb345 (bug 1250203) for test failures in mochitest-5 test_ext_bookmarks.html, browser-chrome browser_views_liveupdate.js, OS X xpcshell test_browserGlue_migrate.js and maybe more. r=backout on a CLOSED TREE 2016-04-08 18:42:07 +02:00
Dão Gottwald
02c6656bf9 Bug 1250203 - Re-populate recent bookmarks when a bookmark has been deleted. r=mak 2016-04-08 16:33:21 +02:00
malayaleecoder
b3deb181bb Bug 1254496 - Remove gURLBar null-checks. r=dao 2016-03-10 23:15:49 +05:30
Marco Bonardo
6cc886e9f3 Bug 1253930 - Recently bookmarked items have the default favicon instead of the correct one. r=dao
MozReview-Commit-ID: LMTVQetQL9Q

--HG--
extra : rebase_source : 76bc5e0eb24bfd0e6c26e7d577100a566dda94de
2016-03-07 12:06:40 +01:00
Dão Gottwald
d97fcaaba2 Bug 1250806 - Add menuitems for recent bookmarks synchronously so that they show up in the native menubar on OS X. r=mak 2016-03-02 17:16:59 +01:00
Jared Wein
2d2a2f8e9d Bug 1219794 - Show the bookmark popup for new bookmarks and autoclose if no interaction. r=mak
MozReview-Commit-ID: FSx0bB4KqpQ
2016-02-18 15:36:22 -05:00
Dão Gottwald
9249c82407 Bug 1249473 - Right-clicking a recent bookmark shouldn't load it. r=mak 2016-02-19 15:10:17 +01:00
Justin Dolske
d342593533 Backout 44f79bbe2b51 (bug 1219788), not working as intended. 2016-02-18 12:16:52 -08:00
Dão Gottwald
040a3bb826 Bug 1248266 - Make recently added bookmarks keyboard-accessible by not using a vbox container. r=mak
--HG--
extra : rebase_source : 169ad437807eba57a863d582a54ea81e50323e19
2016-02-16 12:05:47 +01:00
Dão Gottwald
060c2c03e3 Bug 1248259 - onMainMenuPopupShowing shouldn't handle the popupshowing event from sub menus. r=mak 2016-02-15 13:16:58 +01:00
Dão Gottwald
486c442ad2 Bug 1248258 - Fix sorting in the query used for 5 most recently added bookmarks. r=mak 2016-02-15 13:15:30 +01:00
Dão Gottwald
52d9a689b0 Bug 1219804 - Show last 5 recent bookmarks in the bookmarks menu. r=mak 2016-02-12 12:21:17 +01:00
Dave Townsend
a9fc7f9380 Bug 1245649: Turn on no-irregular-whitespace and no-mixed-spaces-and-tabs. r=jaws
--HG--
extra : commitid : AHmjTpVmCOP
extra : rebase_source : 0034d884816464bff4677afbe96c52fa9dca9072
2016-02-03 18:09:49 -08:00
Dave Townsend
0a6414b898 Bug 1245649: Turn on no-trailing-spaces. r=Gijs
--HG--
extra : commitid : F2OWKTvXUO4
extra : rebase_source : ec68631342e0edc59d77b6bab1cdc975ad175327
2016-02-03 14:22:33 -08:00
Dão Gottwald
13fb21d300 Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak 2016-01-06 14:29:36 +01:00
Sebastian Hengst
6738c45761 Bug 1236481 - 'Synced Tabs' History menuitem not shown. r=markh 2016-01-05 17:29:39 +01:00
Ryan VanderMeulen
8dbcac5e68 Backed out changeset 4e9389db3a5a (bug 1219788) for causing M(JP) LSAN permaleaks. a=backout 2016-01-01 20:21:59 -05:00
Dão Gottwald
3b0c155b31 Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak 2015-12-31 11:01:09 +01:00
Shane Caraveo
eabb5f6400 Bug 1215694 move pocket to a system addon, r=Gijs, r=glandium
part 1: reorganize file locations, r=Gijs
  part 2: remove built-in pocket code, r=Gijs
  part 3: l10n support, r=glandium
  part 4: move code/functionality from part 2 into the addon, r=Gijs
  part 5: remove dead code, r=Gijs
  part 6: create a simple api for addons to add to reader mode, r=Gijs
  part 7: various test fixes related to cui behaviour and pocket, r=me

--HG--
rename : browser/components/pocket/Pocket.jsm => browser/extensions/pocket/content/Pocket.jsm
rename : browser/components/pocket/main.js => browser/extensions/pocket/content/main.js
rename : browser/components/pocket/panels/css/firasans.css => browser/extensions/pocket/content/panels/css/firasans.css
rename : browser/components/pocket/panels/css/normalize.css => browser/extensions/pocket/content/panels/css/normalize.css
rename : browser/components/pocket/panels/css/saved.css => browser/extensions/pocket/content/panels/css/saved.css
rename : browser/components/pocket/panels/css/signup.css => browser/extensions/pocket/content/panels/css/signup.css
rename : browser/components/pocket/panels/fonts/FiraSans-Regular.woff => browser/extensions/pocket/content/panels/fonts/FiraSans-Regular.woff
rename : toolkit/themes/shared/reader/pocket.svg => browser/extensions/pocket/content/panels/img/pocket.svg
rename : browser/components/pocket/panels/img/pocketerror@1x.png => browser/extensions/pocket/content/panels/img/pocketerror@1x.png
rename : browser/components/pocket/panels/img/pocketerror@2x.png => browser/extensions/pocket/content/panels/img/pocketerror@2x.png
rename : browser/components/pocket/panels/img/pocketlogo@1x.png => browser/extensions/pocket/content/panels/img/pocketlogo@1x.png
rename : browser/components/pocket/panels/img/pocketlogo@2x.png => browser/extensions/pocket/content/panels/img/pocketlogo@2x.png
rename : browser/components/pocket/panels/img/pocketlogosolo@1x.png => browser/extensions/pocket/content/panels/img/pocketlogosolo@1x.png
rename : browser/components/pocket/panels/img/pocketlogosolo@2x.png => browser/extensions/pocket/content/panels/img/pocketlogosolo@2x.png
rename : browser/components/pocket/panels/img/pocketmenuitem16.png => browser/extensions/pocket/content/panels/img/pocketmenuitem16.png
rename : browser/components/pocket/panels/img/pocketmenuitem16@2x.png => browser/extensions/pocket/content/panels/img/pocketmenuitem16@2x.png
rename : browser/components/pocket/panels/img/pocketsignup_button@1x.png => browser/extensions/pocket/content/panels/img/pocketsignup_button@1x.png
rename : browser/components/pocket/panels/img/pocketsignup_button@2x.png => browser/extensions/pocket/content/panels/img/pocketsignup_button@2x.png
rename : browser/components/pocket/panels/img/pocketsignup_devices@1x.png => browser/extensions/pocket/content/panels/img/pocketsignup_devices@1x.png
rename : browser/components/pocket/panels/img/pocketsignup_devices@2x.png => browser/extensions/pocket/content/panels/img/pocketsignup_devices@2x.png
rename : browser/components/pocket/panels/img/pocketsignup_hero@1x.png => browser/extensions/pocket/content/panels/img/pocketsignup_hero@1x.png
rename : browser/components/pocket/panels/img/pocketsignup_hero@2x.png => browser/extensions/pocket/content/panels/img/pocketsignup_hero@2x.png
rename : browser/components/pocket/panels/img/signup_firefoxlogo@1x.png => browser/extensions/pocket/content/panels/img/signup_firefoxlogo@1x.png
rename : browser/components/pocket/panels/img/signup_firefoxlogo@2x.png => browser/extensions/pocket/content/panels/img/signup_firefoxlogo@2x.png
rename : browser/components/pocket/panels/img/signup_help@1x.png => browser/extensions/pocket/content/panels/img/signup_help@1x.png
rename : browser/components/pocket/panels/img/signup_help@2x.png => browser/extensions/pocket/content/panels/img/signup_help@2x.png
rename : browser/components/pocket/panels/img/signup_or@1x.png => browser/extensions/pocket/content/panels/img/signup_or@1x.png
rename : browser/components/pocket/panels/img/signup_or@2x.png => browser/extensions/pocket/content/panels/img/signup_or@2x.png
rename : browser/components/pocket/panels/img/tag_close@1x.png => browser/extensions/pocket/content/panels/img/tag_close@1x.png
rename : browser/components/pocket/panels/img/tag_close@2x.png => browser/extensions/pocket/content/panels/img/tag_close@2x.png
rename : browser/components/pocket/panels/img/tag_closeactive@1x.png => browser/extensions/pocket/content/panels/img/tag_closeactive@1x.png
rename : browser/components/pocket/panels/img/tag_closeactive@2x.png => browser/extensions/pocket/content/panels/img/tag_closeactive@2x.png
rename : browser/components/pocket/panels/js/messages.js => browser/extensions/pocket/content/panels/js/messages.js
rename : browser/components/pocket/panels/js/saved.js => browser/extensions/pocket/content/panels/js/saved.js
rename : browser/components/pocket/panels/js/signup.js => browser/extensions/pocket/content/panels/js/signup.js
rename : browser/components/pocket/panels/js/tmpl.js => browser/extensions/pocket/content/panels/js/tmpl.js
rename : browser/components/pocket/panels/js/vendor/handlebars.runtime.js => browser/extensions/pocket/content/panels/js/vendor/handlebars.runtime.js
rename : browser/components/pocket/panels/js/vendor/jquery-2.1.1.min.js => browser/extensions/pocket/content/panels/js/vendor/jquery-2.1.1.min.js
rename : browser/components/pocket/panels/js/vendor/jquery.tokeninput.min.js => browser/extensions/pocket/content/panels/js/vendor/jquery.tokeninput.min.js
rename : browser/components/pocket/panels/license.txt => browser/extensions/pocket/content/panels/license.txt
rename : browser/components/pocket/panels/saved.html => browser/extensions/pocket/content/panels/saved.html
rename : browser/components/pocket/panels/signup.html => browser/extensions/pocket/content/panels/signup.html
rename : browser/components/pocket/panels/tmpl/saved_premiumextras.handlebars => browser/extensions/pocket/content/panels/tmpl/saved_premiumextras.handlebars
rename : browser/components/pocket/panels/tmpl/saved_premiumshell.handlebars => browser/extensions/pocket/content/panels/tmpl/saved_premiumshell.handlebars
rename : browser/components/pocket/panels/tmpl/saved_shell.handlebars => browser/extensions/pocket/content/panels/tmpl/saved_shell.handlebars
rename : browser/components/pocket/panels/tmpl/signup_shell.handlebars => browser/extensions/pocket/content/panels/tmpl/signup_shell.handlebars
rename : browser/components/pocket/panels/tmpl/signupstoryboard_shell.handlebars => browser/extensions/pocket/content/panels/tmpl/signupstoryboard_shell.handlebars
rename : browser/components/pocket/pktApi.js => browser/extensions/pocket/content/pktApi.jsm
rename : browser/locales/en-US/chrome/browser/browser-pocket.properties => browser/extensions/pocket/locales/en-US/pocket.properties
2015-12-29 15:40:52 -08:00
Felipe Gomes
bddd338cd7 Bug 1231728 - Fixes some code to follow eslint rules. r=mak
--HG--
extra : commitid : 2pB0pOqsHVW
2015-12-10 14:38:30 -05:00
Felipe Gomes
0e0c0d5f18 Bug 1228655 - Remove ifdefs in browser-places.js. r=Gijs 2015-12-01 20:06:11 -02:00
Felipe Gomes
909d49249d Bug 1228627 - Remove #includes from browser.js. r=Gijs 2015-11-30 12:13:57 -02:00
Sebastian Hengst
66ebfb501e Bug 1227361 - Remove checks for MOZ_SERVICES_SYNC from browser/. r=markh 2015-11-24 19:31:16 +01:00
Paolo Amadini
383af26e19 Bug 1206244 - Replace globe with the "i" icon, keep separate lock for secure pages. r=past
--HG--
extra : commitid : FK2Mm4rfvXP
extra : rebase_source : 27b3567bb0db0f8b5dc042f3958a4374b012429e
2015-11-11 15:52:56 +00:00
Hassen ben tanfous
45492f28fb Bug 1074804 - Replace arrays .indexOf with .includes in Places. r=mak 2015-10-11 20:24:32 +02:00
Marco Bonardo
ed553c88ae Bug 1208063 - The name input field on the new bookmark dialog doesn't get focus. r=adw 2015-10-07 15:40:13 +02:00
Tooru Fujisawa
d88225d76e Bug 1207490 - Part 1: Remove use of expression closure from browser/base/. r=dao
--HG--
extra : commitid : GTnFNtx973B
extra : rebase_source : 5bf8bb3d7ddb0234bd533cf6ddc843dd2db9d8f5
2015-09-21 00:29:37 +09:00
Neil Deakin
895856cf29 Bug 1199239, remove cpow usage from bookmark this page, r=mak 2015-09-25 21:14:43 -04:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Dão Gottwald
e0bb5614ac Bug 1182102 - Stop setting the bookmark-item class on the home button or the bookmarks button when moving them to the bookmarks toolbar. r=gijs 2015-08-17 15:51:22 +02:00