L. David Baron
ce547cd6f5
Bug 1566945 - Add a parameter to nsContainerFrame::InsertFrames for aPrevFrame's line box. r=dholbert
...
For now, always pass null, except when passing it through from one
overload to another.
Differential Revision: https://phabricator.services.mozilla.com/D38389
--HG--
extra : moz-landing-system : lando
2019-07-17 23:34:45 +00:00
Matt Woodrow
9f39c7b608
Bug 1409114 - Part 8: Create column and column group background display items as part of the cell's BuildDisplayList. r=dbaron
...
This is the main performance improvement, and means that we no longer have to iterate all the cells for each column.
It has a couple of behaviour changes:
The first is that we no longer apply stacking context effects (like opacity) to column and column group backgrounds.
I believe this is correct as per both CSS2.1 Appendix E, and css-tables-3 (quoted in nsTableColFrame::BuildDisplayList).
This matches the behaviour of blink and WebKit.
We also previously created items in column,row ordering, whereas now they will be in row,column. In cases where two cells
overlap (using rowspan and colspan to extend multiple neighbours in to the same place) this can render backgrounds in a
different order, but the new behaviour matches blink and WebKit.
Differential Revision: https://phabricator.services.mozilla.com/D29280
--HG--
extra : moz-landing-system : lando
2019-05-20 23:16:09 +00:00
Matt Woodrow
8bf47621c6
Bug 1409114 - Part 6: Store column and column group backgrounds separately, and then append then before the rest of the table contents. r=dbaron
...
This also changes behaviour a bit, previously we interleaved column and column group backgrounds. where we now put all the column group backgrounds behind all columns.
I believe this is the correct ordering as per CSS2.2 Appendix E.
Column backgrounds can overlap when using 'span', and we now render this in a different order, but this matches what other browsers do.
Differential Revision: https://phabricator.services.mozilla.com/D29278
--HG--
extra : moz-landing-system : lando
2019-05-20 23:15:39 +00:00
Matt Woodrow
1b955945aa
Bug 1409114 - Part 2: Get rid of generic table painting code, and handle each class separately. r=dbaron
...
Most of the code in DisplayGenericTablePart was all within a per-class if statement, so it doesn't add much value, and makes the control flow harder to understand.
Differential Revision: https://phabricator.services.mozilla.com/D29273
--HG--
extra : moz-landing-system : lando
2019-05-20 23:14:45 +00:00
Masayuki Nakano
2f9688c14e
Bug 1544343 - part 2: Make factory methods take mozilla::PresShell instead of nsIPresShell r=emilio
...
Additionally, this patch makes `nsFrame.h` stop including `nsIPresShell.h`
and makes each users include `mozilla/PresShell.h` instead. So, this improves
rebuild performance of `nsIPresShell.h` (and `mozilla/PresShell.h` in the
future).
Note that due to `nsIFrame::PresShell()`, `mozilla::` prefix is necessary for
`PresShell` in a lot of classes which are derived from `nsIFrame` even in
`.cpp` files.
Differential Revision: https://phabricator.services.mozilla.com/D27476
--HG--
extra : moz-landing-system : lando
2019-04-16 07:24:49 +00:00
Emilio Cobos Álvarez
12867b1a3f
Bug 1525371 - Kill ComputedStyle::mPresContext, move the pointer to the frame instead. r=jwatt
...
Differential Revision: https://phabricator.services.mozilla.com/D18734
2019-02-07 11:15:36 +01:00
Sylvestre Ledru ext:(%20and%20Karl%20Tomlinson%20%3Ckarlt%2B%40karlt.net%3E)
c7b59395f2
Bug 1515556 comment fix-ups for the tree reformat (layout/) r=Ehsan,heycam
...
Differential Revision: https://phabricator.services.mozilla.com/D13125
--HG--
extra : moz-landing-system : lando
2018-12-21 03:07:05 +00:00
Cameron McCormack
a9c935c355
Bug 1511854 - Part 1: Fix some formatting oddities in layout/ after the clang-format. r=TYLin
...
Differential Revision: https://phabricator.services.mozilla.com/D13686
--HG--
extra : moz-landing-system : lando
2018-12-05 18:44:03 +00:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Cosmin Sabou
0afa5aa670
Backed out 2 changesets (bug 1508472) for causing build bustages on JobScheduler_posix.cpp. CLOSED TREE
...
Backed out changeset af951294cf96 (bug 1508472)
Backed out changeset 2320933cb7bc (bug 1508472)
2018-11-28 00:08:11 +02:00
Sylvestre Ledru
9ea4a3d5c0
Bug 1508472 - Part 3: Third batch of comment fix-ups in preparation for the tree reformat (layout/) r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D13125
--HG--
extra : moz-landing-system : lando
2018-11-27 21:39:24 +00:00
L. David Baron
aad8d26078
Bug 1479859 patch 3 - Add an nsIFrame::IsFrameOfType bit to say whether frames support contain:layout and contain:paint. r=dholbert
...
This is needed for patch 4.
This is based both on the wording in the spec and the discussion in
https://github.com/w3c/csswg-drafts/issues/2987 , and also doesn't
support them for nsMathMLContainerFrame, which is similar to inlines and
ruby.
Differential Revision: https://phabricator.services.mozilla.com/D2815
--HG--
extra : rebase_source : b7e23fb248fa34957ca2d539134e872f5a03f5a8
2018-08-07 15:02:07 -07:00
Matt Woodrow
8eb6516c62
Bug 1443380 - Don't mark all descendant frames modified for display list building when invalidating a frame subtree since marking just the root is sufficient. r=miko
2018-04-04 16:15:49 +12:00
Emilio Cobos Álvarez
e341b20ec4
Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt on a CLOSED TREE
...
MozReview-Commit-ID: JPopq0LudD
2018-03-22 20:06:24 +01:00
Emilio Cobos Álvarez
5dd797f154
Back out changeset b683bb3f22a1 (Bug 1447483) for not landing with all the files. r=me on a CLOSED TREE
...
This reverts commit 1808914126bb9f9e4a82d2c3d7ac961885fe7d62.
MozReview-Commit-ID: 5skESBseEvo
2018-03-22 20:05:22 +01:00
Emilio Cobos Álvarez
ca5ac79cca
Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt
...
MozReview-Commit-ID: JPopq0LudD
2018-03-22 19:48:42 +01:00
Mats Palmgren
25cd0c37f7
Bug 1400618 part 1 - Collect NAC / generated content and call DestroyAnonymousContent / UnbindFromTree on those after the frames are destroyed. r=bz
...
MozReview-Commit-ID: 2trDgeJPw25
2017-11-07 01:20:33 +01:00
Nicholas Nethercote
d225f7151b
Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.
...
(Path is actually r=froydnj.)
Bug 1400459 devirtualized nsIAtom so that it is no longer a subclass of
nsISupports. This means that nsAtom is now a better name for it than nsIAtom.
MozReview-Commit-ID: 91U22X2NydP
--HG--
rename : xpcom/ds/nsIAtom.h => xpcom/ds/nsAtom.h
extra : rebase_source : ac3e904a21b8b48e74534fff964f1623ee937c67
2017-10-03 09:05:19 +11:00
Ya-Chieh Wu
ce1be4b4eb
Bug 895096 - Part 1: Round border-collapsed table borders to device pixels rather than CSS pixels, as for other borders, and store them (as BCPixelSize) as device pixels rather than CSS pixels. r=dbaron
...
MozReview-Commit-ID: 3yqj8gAAGYv
2017-09-12 19:48:00 -04:00
Matt Woodrow
40f5b92e3b
Bug 1388161 - Store the dirty rect on the display list builder rather than passing it as a parameter to BuildDisplayList. r=mstange
2017-08-07 14:23:35 +12:00
Sebastian Hengst
8257b2d113
Backed out changeset 8f2dd8f13b53 (bug 1388161) for failing chrome's test_animation_performance_warning.html | preserve-3d transform. r=backout
2017-08-10 14:40:21 +02:00
Matt Woodrow
a3a130b6ff
Bug 1388161 - Store the dirty rect on the display list builder rather than passing it as a parameter to BuildDisplayList. r=mstange
2017-08-07 14:23:35 +12:00
Mats Palmgren
ec6b1ef065
Bug 1364805 part 1 - Make every concrete frame class be a NS_DECL_QUERYFRAME_TARGET. r=jfkthame
...
MozReview-Commit-ID: Gy9gcEYupeY
2017-05-26 12:11:11 +02:00
Morris Tseng
c09ed5d520
Bug 929484 - Remove nsTableBorderBackground displayitem and nsTablePainter. r=mstange
...
MozReview-Commit-ID: 1HmfGyBqWnf
2017-05-05 14:30:15 +08:00
Carsten "Tomcat" Book
44f55ecb9b
Backed out changeset 3dc8c2aea9bf (bug 929484)
2017-05-04 16:59:59 +02:00
Morris Tseng
087ad6539a
Bug 929484 - Remove nsTableBorderBackground displayitem and nsTablePainter. r=mstange
...
MozReview-Commit-ID: 1HmfGyBqWnf
2017-05-04 17:32:08 +08:00
Emilio Cobos Álvarez
e44543aad4
Bug 1360241: Devirtualize nsIFrame::GetType. r=heycam
...
MozReview-Commit-ID: 5Nzhyta5Hle
--HG--
extra : rebase_source : c2e9d4bfb9239f5e851d110cd7dff98c1e1a8d8b
2017-04-30 17:30:08 +02:00
Neerja Pancholi
ee17cb9c09
Bug 1285874 - Maintain a map of removed table-rows and use it to lazily recalculate row indices. r=dbaron
...
MozReview-Commit-ID: Jt6QJTp0YGe
2017-03-02 15:09:30 -08:00
Mats Palmgren
e8c6fd3388
Bug 1342801 - Store the 'writing-mode' used value on nsIFrame and make GetWritingMode non-virtual. r=jfkthame
...
MozReview-Commit-ID: HPhuxjDbOdh
2017-02-28 18:58:30 +01:00
Mats Palmgren
562b840a02
Bug 1312379 part 3 - [css-align][css-tables] Add methods for CSS Alignment first/last baseline of the table container. r=dholbert
2016-12-20 23:56:35 +01:00
Ting-Yu Lin
40fcd21b9a
Bug 1277129 Part 7b - Rename various ReflowState variables to ReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -r "s/$1/$2/g" "{}" \;
}
rename "([[:alpha:]]*)([rR])eflowState(s?)" "\1\2eflowInput\3"
MozReview-Commit-ID: ITFO7uMTkSb
--HG--
extra : rebase_source : c91a2e174a0baec60c1b0111ac7636295004ab35
2016-07-21 18:36:39 +08:00
Ting-Yu Lin
4053c4c028
Bug 1277129 Part 5c - Rename nsHTMLReflowMetrics to ReflowOutput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename "nsHTMLReflowMetrics" "ReflowOutput"
MozReview-Commit-ID: 2HBb7DkooH5
--HG--
extra : rebase_source : acfa442a6483772fcb5748dc6f5e7072e599032a
2016-07-21 18:36:38 +08:00
Ting-Yu Lin
5246b4bf71
Bug 1277129 Part 3b - Rename nsTableReflowState, nsRowGroupReflowState, and nsTableCellReflowState. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename nsTableReflowState TableReflowInput
rename nsRowGroupReflowState TableRowGroupReflowInput
rename nsTableCellReflowState TableCellReflowInput
MozReview-Commit-ID: HN2E6utaxL8
--HG--
extra : rebase_source : 19767e6f88125f008f857116c607b3fc4faebda7
2016-07-21 18:36:36 +08:00
Ting-Yu Lin
0945a386ae
Bug 1277129 Part 3a - Move nsTableReflowState, nsRowGroupReflowState, and nsTableCellReflowState into mozilla namespace. r=dbaron
...
Also move the definition of nsRowGroupReflowState from .h into .cpp as
other two classes did since forward declaration in header is enough.
MozReview-Commit-ID: 9p1vIk1Ewji
--HG--
extra : rebase_source : add4f9a78a7299306f1f4a8aafb70525063ccbf2
2016-07-21 18:36:36 +08:00
Ting-Yu Lin
820f88de49
Bug 1277129 Part 1c - Rename nsHTMLReflowState to ReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename nsHTMLReflowState ReflowInput
MozReview-Commit-ID: 9r9vdVv1pXc
--HG--
extra : rebase_source : 623ec822996ba0ea0058dd137acf5a658cdea04a
2016-07-21 18:36:35 +08:00
Ting-Yu Lin
39dffbe21b
Bug 1277129 Part 1a - Move nsHTMLReflowState and nsCSSOffsetState into mozilla namespace. r=dbaron
...
MozReview-Commit-ID: DJfEQRCgNo3
--HG--
extra : rebase_source : add4c7a843f956114b2b9dfe20fba1048139ca5f
2016-07-21 18:36:34 +08:00
Matt Woodrow
47cde44daf
Bug 1243610 - Refactor UpdateOverflow to separate out local overflow from that contributed by descendants. r=dbaron
2016-05-04 12:27:43 +12:00
Nicholas Nethercote
16cd9db041
Bug 1230863 - Remove unused nsPresContext args from many functions. r=roc.
2015-12-06 17:15:53 -08:00
Jonathan Kew
4e6c40d7ea
Bug 1131451 part 1 - Replace containerWidth with containerSize in logical-coordinate classes and APIs, frame classes, etc. r=dholbert
2015-07-16 10:07:57 +01:00
Jonathan Kew
6c2cc390da
Bug 1177600 - Properly adjust table row and cell positions when their containing block-size changes in vertical-rl writing mode. r=dholbert
2015-06-26 16:50:21 -07:00
Jonathan Kew
d1f05cc84f
Bug 1176555 - Replace explicit bit-twiddling of frame state flags by human-readable nsIFrame state-manipulation methods in table layout code. r=dholbert
2015-06-23 13:41:29 -07:00
Jonathan Kew
2d252085be
Bug 1174711 - patch 3 - Rename a couple more frame-state bits from physical to logical. r=dholbert
2015-06-22 10:33:34 +01:00
Jonathan Kew
2c538d45a5
Bug 1174711 - patch 2 - Convert nsTableFrame to work with logical coordinates. r=dholbert
2015-06-22 10:33:34 +01:00
Jonathan Kew
31469f3572
Bug 1174700 - patch 1 - Convert nsTableRowFrame and nsTableRowGroupFrame to work with logical coordinates. r=dholbert
2015-06-20 21:00:26 +01:00
L. David Baron
2c5c24868e
Back out changesets ed293fc9596c and f18cb4c41578 (bug 1174700) for fatal assertions in all Windows debug reftest runs.
...
CLOSED TREE
Assertion failure: origKidNormalPosition.B(wm) == 0, at c:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/src/layout/tables/nsTableRowFrame.cpp:861
TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/writing-mode/ua-style-sheet-size-1.html | application terminated with exit code 1
2015-06-20 22:41:07 -07:00
Jonathan Kew
daf28cd1e7
Bug 1174700 - patch 1 - Convert nsTableRowFrame and nsTableRowGroupFrame to work with logical coordinates. r=dholbert
2015-06-20 21:00:26 +01:00
Xidorn Quan
79661faf79
Bug 1157569 part 9 - Rename methods and fields in nsTableRowFrame from physicals to logicals. r=roc
...
--HG--
extra : source : ce0fb2e11506e7aafffd88ee628bf8485648de24
2015-05-04 19:09:25 +12:00
Xidorn Quan
48d1d4f3e5
bug 1157569 part 1 - Rename BC_BORDER_{TOP,RIGHT,BOTTOM,LEFT}_HALF* to BC_BORDER_{START,END}_HALF*. r=roc
...
--HG--
extra : source : 5a1c4c8f584b89b2d65c43f325ffa4a070a4f7b6
2015-05-04 19:09:25 +12:00
Xidorn Quan
b67d865b08
Bug 1159101 part 4 - Override GetWritingMode() in nsTable{{Col,Row}{,Group},Cell}Frame. r=roc
...
--HG--
extra : source : 4b8d51cfa3331c052ede29b56bb7172088e47873
2015-04-30 16:24:59 +12:00
Xidorn Quan
e30901b6a0
Bug 1159101 part 2 - Add GetTableFrame() for table inner frames. r=roc
...
--HG--
extra : source : c470aa2508be969b203ec686f8375383a5de6959
2015-04-30 16:24:59 +12:00