Commit graph

19 commits

Author SHA1 Message Date
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Paolo Amadini
ea3963afc9 Bug 1444392 - Part 1 - Add test-only helpers to open and close the main menu. r=Gijs
MozReview-Commit-ID: 9kvUdw2TeHB

--HG--
extra : rebase_source : 0b0a007ad517c0256fe67256391d87065bf645ef
extra : amend_source : c2c56528f12e38852e913e42e9e7f9e78e8623d9
extra : source : ec2f47133979d085739d383cc50358d6e9417979
2018-04-04 11:34:16 +01:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Paolo Amadini
1714b3aba4 Bug 1425736 - Don't show the attention badge for download failures on the application menu button. r=Gijs
MozReview-Commit-ID: A882hXl5o0

--HG--
extra : rebase_source : 1584f1141c3e8bc1aeb62559a7136dc9f0745899
2018-01-09 15:51:19 +00:00
Doug Thayer
646edb5fab Bug 1359733 - Move menu notification state to jsm r=Gijs
Right now, app menu doorhangers/badges have their state managed
directly inside panelUI.js. This is problematic because these
doorhangers and badges usually have to do with Firefox itself,
and not the specific window that's showing them. Accordingly, the
simplest solution was to move panelUI.js's notification state out
into a jsm file, which will fire notifications that all panelUI
instances can listen to.

MozReview-Commit-ID: 7b8w1WsQ29p

--HG--
extra : rebase_source : 23575df8176b862ec0e6a039173b105c45c76de9
2017-05-18 13:22:27 -07:00
Florian Quèze
16530fa1e3 Bug 1353542 - smaller script-generated patch converting remaining generators that are likely tasks (actual generators were identified by hand and whitelisted), r=Mossop. 2017-05-12 14:45:01 +02:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Doug Thayer
5361205f4d Bug 1358363 - Show PanelUI notifications when window focused r=rstrong
Right now notifications displayed in non-focused windows are
causing that window to be focused. This is annoying. We could work
to make the doorhangers not focus the other windows, but a simpler
solution is to just not show the doorhanger until the window is
focused. This has the added benefit of ensuring that the doorhangers
entry animation is seen by the user, increasing the likelihood that
they will notice it.

Additionally, some existing tests involving extra windows were
refactored. I stripped the old tests of their extra windows and
created new tests specifically to test the behavior of background
windows. These tests were modeled off of the background window
tests of PopupNotifications.jsm, which create a new window knowing
that this will cause the existing window to be the background,
rather than explicitly manipulating the focus of the two windows.

MozReview-Commit-ID: 1fjrDOhEKCw

--HG--
extra : rebase_source : 954ace7e43da90fcee3da2d70c4bdbcda8456d77
2017-04-21 08:57:28 -07:00
Gijs Kruitbosch
1c3d0e4047 Bug 1355020 - part 1: disentangle update notifications from 'PanelUI' and hardcoded IDs, r=dthayer
MozReview-Commit-ID: EqLtDuRC8EH

--HG--
extra : rebase_source : 4508af1a155193ae556c0b9261aeb13a71afb0e9
2017-05-04 12:56:11 +01:00
Doug Thayer
6c660b95af Bug 1348396 - Only show a badge on PanelUI while in fullscreen r=enndeakin+6102,rstrong
Previously we were showing a doorhanger when the user moused to the
top of the screen while in fullscreen mode. However, the doorhanger
would disappear before the user had a chance to interact with it.
We decided it's best anyway to simply display a badge when the user
is in fullscreen, and to reshow the doorhanger when the user exits
fullscreen.

MozReview-Commit-ID: ENRtXC4wqvZ

--HG--
extra : rebase_source : 4609fbc2d0bd38fe16a23151d94d265761cd57b0
2017-04-10 11:11:45 -07:00
Iris Hsiao
9493a7eab5 Backed out changeset a9fb56b87d01 (bug 1348396) for frequent customizableui browser_panelUINotifications.js failures 2017-04-12 18:07:29 +08:00
Doug Thayer
b8c7cfa79c Bug 1348396 - Only show a badge on PanelUI while in fullscreen r=enndeakin+6102
Previously we were showing a doorhanger when the user moused to the
top of the screen while in fullscreen mode. However, the doorhanger
would disappear before the user had a chance to interact with it.
We decided it's best anyway to simply display a badge when the user
is in fullscreen, and to reshow the doorhanger when the user exits
fullscreen.

MozReview-Commit-ID: ENRtXC4wqvZ

--HG--
extra : rebase_source : 4d7f0880b2b4e8bd9424302bca16ef706e2fca25
2017-04-10 11:11:45 -07:00
Sebastian Hengst
12bbf7f45f Backed out changeset d6d5806e5695 (bug 1348396) for frequently failing modified test. r=backout 2017-04-11 21:31:41 +02:00
Doug Thayer
7810cd0dda Bug 1348396 - Only show a badge on PanelUI while in fullscreen r=enndeakin+6102
Previously we were showing a doorhanger when the user moused to the
top of the screen while in fullscreen mode. However, the doorhanger
would disappear before the user had a chance to interact with it.
We decided it's best anyway to simply display a badge when the user
is in fullscreen, and to reshow the doorhanger when the user exits
fullscreen.

MozReview-Commit-ID: ENRtXC4wqvZ

--HG--
extra : rebase_source : d0ddc7395115287620ed4c9532297e825996be1d
2017-04-10 11:11:45 -07:00
Doug Thayer
f463069928 Bug 893505 - Simplify the application update UI r=chmanchester,enndeakin+6102,Gijs,rstrong
There's quite a few changes in here. At a high level, all we're trying to do
is to replace the old update popup with a less intrusive and more modern
doorhanger (set of doorhangers) for various update failure conditions.

MozReview-Commit-ID: 24sESMTosNX

--HG--
extra : rebase_source : ee0c1e00fe3f99e16388f0de17274ff97a3b9fcf
2017-03-21 13:50:09 -07:00