mirrors/gecko-dev
1
0
Fork 1
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-11-02 17:28:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
987101 commits 621 branches 98 tags 6.6 GiB
Commit graph

203 commits

Author SHA1 Message Date
Meg Viar
4b1e713247 Bug 1903416 - Add a pref to control the display of set default guidance notification a=dmeehan 
Add a pref and nimbus variable to control whether users see set to default guidance notifications when one-click set to default is disabled. Windows only.

This patch supports the [[ https://experimenter.services.mozilla.com/nimbus/one-click-set-to-default-new-users/summary | one-click set to default guidance experiment ]].

Original Revision: https://phabricator.services.mozilla.com/D214700

Differential Revision: https://phabricator.services.mozilla.com/D214758
 2024-06-25 17:20:07 +00:00
Barret Rennie
9ef1c3a9cb Bug 1829412 - Simplify NimbusTestUtils.enrollmentHelper r=chumphreys,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,omc-reviewers,home-newtab-reviewers,thecount,issammani,aminomancer,mconley 
The enrollmentHelper was much more complicated than it needed to be. The
internal asynchrony that required awaiting an additional promise was fixed in
bug 1773583.

The returned cleanup function is no longer async, so unnecessary awaits have
been removed. This also applies to enrollWithFeatureConfig, as it is a wrapper
around enrollmentHelper.

Differential Revision: https://phabricator.services.mozilla.com/D212318
 2024-06-06 14:42:00 +00:00
Joel Maher
15a6a58ab8 Bug 1898801 - Fix tests on mac which use python2 to use python3 on macosx 14.x+. r=gbrown 
Differential Revision: https://phabricator.services.mozilla.com/D211604
 2024-05-24 19:45:19 +00:00
Nicholas Rishel
72e1b66f1a Bug 1894865 - Concat nsStrings to avoid issues converting wide characters to char and back again. r=bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D210247
 2024-05-21 02:37:10 +00:00
Sandor Molnar
e2f6710763 Backed out changeset 6c952a8ea651 (bug 1894865) for causing build bustages @ browser/components/shell/nsWindowsShellServiceInternal.h CLOSED TREE 2024-05-20 22:06:06 +03:00
Nicholas Rishel
a90458d752 Bug 1894865 - Concat nsStrings to avoid issues converting wide characters to char and back again. r=bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D210247
 2024-05-20 18:49:11 +00:00
Barret Rennie
972e870f9a Bug 1790428 - Remove ExperimentFakes.enrollWithRollout r=chumphreys 
enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.

Differential Revision: https://phabricator.services.mozilla.com/D209936
 2024-05-16 17:15:58 +00:00
Sandor Molnar
592ca16351 Backed out changeset c9a936171ae4 (bug 1790428) for causing bc failures @ browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about_nimbus_impressions.js CLOSED TREE 2024-05-16 01:29:10 +03:00
Barret Rennie
d7ad02fc32 Bug 1790428 - Remove ExperimentFakes.enrollWithRollout r=chumphreys 
enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.

Differential Revision: https://phabricator.services.mozilla.com/D209936
 2024-05-15 19:19:29 +00:00
Cristian Tuns
dad1423a62 Backed out changeset 9db188aa6dac (bug 1790428) for causing bc failures in browser_remotesettingsexperimentloader_remote_defaults.js CLOSED TREE 2024-05-14 18:00:11 -04:00
Barret Rennie
f22c00c889 Bug 1790428 - Remove ExperimentFakes.enrollWithRollout r=chumphreys 
enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.

Differential Revision: https://phabricator.services.mozilla.com/D209936
 2024-05-14 16:18:01 +00:00
Dave Townsend
a9a51bf046 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203005
 2024-03-19 09:36:35 +00:00
Michael Hughes
82527350b3 Bug 1863636 - mochi tests for filename validation to prevent callers of new functions from creating bad file paths r=nshukla,gstoll 
Added in mochi tests to validate that the C++ filename validation for taskbar tab shortcut paths works.

Differential Revision: https://phabricator.services.mozilla.com/D199689
 2024-01-29 22:26:21 +00:00
Joel Maher
3ad5072cf1 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao 
Differential Revision: https://phabricator.services.mozilla.com/D198082
 2024-01-25 00:27:05 +00:00
Stanca Serban
221d7acc5b Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures. 2024-01-24 21:08:19 +02:00
Gijs Kruitbosch
96fbfbdfb0 Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D198974
 2024-01-24 17:03:13 +00:00
Joel Maher
807575f8e1 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao 
Differential Revision: https://phabricator.services.mozilla.com/D198082
 2024-01-24 16:35:54 +00:00
Michael Hughes
be184998f5 Bug 1863980 - [msix] Make ShellService.setDefaultBrowser async. r=nalexander,mconley,dmose,omc-reviewers 
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.

While here, we add more logging to this interaction to allow easier
debugging with QA.

Differential Revision: https://phabricator.services.mozilla.com/D194949
 2023-12-01 20:07:08 +00:00
Joel Maher
2cae29b76e Bug 1859869 - batch 12 - browser/* xpcshell .ini manifests to .toml. r=aryx,extension-reviewers,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,issammani,Standard8,robwu,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D193996
 2023-11-21 17:35:23 +00:00
Masatoshi Kimura
bcd7d268c4 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D189696
 2023-10-02 19:00:07 +00:00
Noemi Erli
26e0b0be0a Backed out 3 changesets (bug 1856187, bug 1856100, bug 1856104) for causing newtab failures 
Backed out changeset db28784a1734 (bug 1856187)
Backed out changeset bd11e14dca63 (bug 1856104)
Backed out changeset 2741311b6055 (bug 1856100)
 2023-10-02 21:16:25 +03:00
Masatoshi Kimura
7ad48d61dd Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D189696
 2023-10-02 17:36:27 +00:00
Masatoshi Kimura
3e8c44dd66 Bug 1845057 - Remove aClaimAllTypes from setDefaultBrowser. r=nrishel,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D189678
 2023-10-02 16:56:42 +00:00
Tom Marble
d596ebea8e Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D188427
 2023-09-21 22:47:07 +00:00
Masatoshi Kimura
f65b99f594 Bug 1852881 - Stop using MockRegistrar in browser_setDefaultPDFHandler.js. r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D188075
 2023-09-13 18:22:24 +00:00
Masatoshi Kimura
1cbf60617c Bug 1850631 - Call nsIDefaultAgent directly to set default. r=nrishel,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D187853
 2023-09-13 03:18:46 +00:00
Masatoshi Kimura
702a789097 Bug 1851596 - await _handleWDBAResult. r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D187845
 2023-09-10 06:44:06 +00:00
Norisz Fay
0453721e9c Backed out changeset df18c9cb1487 (bug 1851596) for causing mochitest failure on browser_setDefaultBrowser.js CLOSED TREE 2023-09-10 03:04:19 +03:00
Masatoshi Kimura
a5e528b625 Bug 1851596 - await _handleWDBAResult. r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D187845
 2023-09-09 23:15:51 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
anwar
1dbd9bffb3 Bug 1829673 - Put all mochitest test manifest files under browser/components into alphabetical order. r=mconley,extension-reviewers,credential-management-reviewers,dimi,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D176459
 2023-05-02 16:13:24 +00:00
Barret Rennie
a85bf46599 Bug 1788954 - Convert toolkit/components/nimbus to ES modules r=Standard8,pip-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D172850
 2023-03-30 20:51:58 +00:00
CanadaHonk
91709586ba Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu 
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
 2023-03-29 07:34:10 +00:00
Barret Rennie
174da7f10d Bug 1820642 - Fix intermittent in browser_setDefaultPDFHandler.js r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D171794
 2023-03-08 18:38:46 +00:00
Barret Rennie
9a989eba44 Bug 1805509 - Add ShellService.setAsDefaultPDFHandler r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D169817
 2023-03-06 20:10:56 +00:00
Sandor Molnar
bf87798f51 Backed out 4 changesets (bug 1805511, bug 1805509) for causing bc and xpc failures. CLOSED TREE 
Backed out changeset 31a8dcad0d88 (bug 1805509)
Backed out changeset 3dd1735b85fa (bug 1805509)
Backed out changeset 87641a6eee2b (bug 1805509)
Backed out changeset e5bd4ad558f2 (bug 1805511)
 2023-03-02 23:26:06 +02:00
Barret Rennie
eec9f6d959 Bug 1805509 - Add ShellService.setAsDefaultPDFHandler r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D169817
 2023-03-02 20:33:22 +00:00
Sandor Molnar
dcf64fc565 Backed out 4 changesets (bug 1805509, bug 1805511) for causing node newtab failures. CLOSED TREE 
Backed out changeset 1c1d335d4ef5 (bug 1805509)
Backed out changeset 0bf2579bccd7 (bug 1805509)
Backed out changeset a87f459f2caa (bug 1805509)
Backed out changeset ae16a9890f22 (bug 1805511)
 2023-03-02 21:03:45 +02:00
Barret Rennie
c87b42b8c1 Bug 1805509 - Add ShellService.setAsDefaultPDFHandler r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D169817
 2023-03-02 18:27:14 +00:00
Gijs Kruitbosch
efef52fc92 Bug 1795255 - autofix duplicate imports in tests under browser/, r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D166179
 2023-01-31 11:48:41 +00:00
Marco Castelluccio
f69e697461 Bug 1801836 - Remove no longer necessary 'from __future__' imports. r=linter-reviewers,glandium,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jld,ahal,owlish,afinder DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D165395
 2022-12-23 22:45:46 +00:00
Emilio Cobos Álvarez
a14c746228 Bug 1805415 - Use activateItem() rather than click() to activate menuitems. r=Gijs,extension-reviewers,pip-reviewers,search-reviewers 
Bug 1805414 will move menu event handling to the DOM.

With that change the current synthetic click behavior of XUL menuitems
breaks. On current central, we rely on nsMenuFrame::HandleEvent not
getting called at all for synthetic clicks, and instead we just fire a
command event synchronously here:

  https://searchfox.org/mozilla-central/rev/a0d4f8f112c5c792ae272bf6ce50763ddd23ffa2/dom/xul/nsXULElement.cpp#1071

After my patch the command event is fired properly (potentially
asynchronously too) by the regular menu activation machinery, which is
preferable.

 * They fire a command event synchronously (even though on some
   platforms like macOS activating a context menu item is async).

 * They use a totally different codepath from what a user does.

 * They don't deal with native menus, etc.

We have a proper API for this (activateItem) which takes a much more
closer codepath to what users do, requires that the menu is shown, etc.
Use that API instead for testing.

As a benefit, tests now do not need to close the context menu manually
when clicking on a menu item (because we trigger the same code path as
users clicking the menu).

Differential Revision: https://phabricator.services.mozilla.com/D164567
 2022-12-15 03:11:55 +00:00
Cristian Tuns
b638ccfac9 Backed out 2 changesets (bug 1805415) for causing dt failures on browser_net_telemetry_throttle_changed.js CLOSED TREE 
Backed out changeset 5056d7df9f1e (bug 1805415)
Backed out changeset e13513500184 (bug 1805415)
 2022-12-14 08:52:21 -05:00
Emilio Cobos Álvarez
be1f057109 Bug 1805415 - Use activateItem() rather than click() to activate menuitems. r=Gijs,extension-reviewers,pip-reviewers,search-reviewers 
Bug 1805414 will move menu event handling to the DOM.

With that change the current synthetic click behavior of XUL menuitems
breaks. On current central, we rely on nsMenuFrame::HandleEvent not
getting called at all for synthetic clicks, and instead we just fire a
command event synchronously here:

  https://searchfox.org/mozilla-central/rev/a0d4f8f112c5c792ae272bf6ce50763ddd23ffa2/dom/xul/nsXULElement.cpp#1071

After my patch the command event is fired properly (potentially
asynchronously too) by the regular menu activation machinery, which is
preferable.

 * They fire a command event synchronously (even though on some
   platforms like macOS activating a context menu item is async).

 * They use a totally different codepath from what a user does.

 * They don't deal with native menus, etc.

We have a proper API for this (activateItem) which takes a much more
closer codepath to what users do, requires that the menu is shown, etc.
Use that API instead for testing.

As a benefit, tests now do not need to close the context menu manually
when clicking on a menu item (because we trigger the same code path as
users clicking the menu).

Differential Revision: https://phabricator.services.mozilla.com/D164567
 2022-12-14 10:25:17 +00:00
Marco Castelluccio
6d04d33abd Bug 1790816 - Reformat browser/ with isort. r=linter-reviewers,search-reviewers,Standard8 DONTBUILD 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D162667
 2022-11-22 11:09:34 +00:00
Mark Banner
640cf06c1b Bug 1797686 - Convert subprocess import consumers to import ES modules directly. r=kmag,application-update-reviewers,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D160489
 2022-10-27 20:17:39 +00:00
Olli Pettay
cd1e2f6198 Bug 1644658 - Remove usages of <img> loadend events in screenshots code, r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D159929
 2022-10-25 08:27:01 +00:00
Norisz Fay
81c86f9a79 Backed out 3 changesets (bug 1644658, bug 1574487, bug 1644656) for causing mochitest failures on browser_staticPartition_saveAs.js CLOSED TREE 
Backed out changeset ccd076f67748 (bug 1574487)
Backed out changeset 2235323f0cf9 (bug 1644656)
Backed out changeset 7fe2c7526246 (bug 1644658)
 2022-10-25 02:22:37 +03:00
Olli Pettay
a0dfa0ffbe Bug 1644658 - Remove usages of <img> loadend events in screenshots code, r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D159929
 2022-10-24 20:33:03 +00:00
Mark Banner
8d1ebcb9d6 Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00