The enrollmentHelper was much more complicated than it needed to be. The
internal asynchrony that required awaiting an additional promise was fixed in
bug 1773583.
The returned cleanup function is no longer async, so unnecessary awaits have
been removed. This also applies to enrollWithFeatureConfig, as it is a wrapper
around enrollmentHelper.
Differential Revision: https://phabricator.services.mozilla.com/D212318
These tests would fail if we automatically add a HTTPS-First exception. So this
patch either removes those exceptions again throughout the tests, or disables
the adding of automatic exceptions via a pref.
Differential Revision: https://phabricator.services.mozilla.com/D204757
This also avoids sending an engine-update Glean event for the default engine by not handling the engine-icon-update
notification in the update tracking code.
Differential Revision: https://phabricator.services.mozilla.com/D210838
Right now, these only works because of the JSON serialization fallback, but
the background() function is getting dropped. This slightly changes the
test results, but hopefully the new behavior is valid.
Differential Revision: https://phabricator.services.mozilla.com/D210961
While working on D210972, I found that browser_blobIcons.js intermittently fails
because AppProvidedSearchEngine.sys.mjs also creates blob URLs. The failure
happened locally when I was running browser_blobIcons.js by itself, so it might
only be a problem in that scenario, shortly after browser startup.
Regardless, the test shouldn't assume that the only part of the app that creates
blob URLs is the part being tested. This patch makes these changes:
* Use a particular test blob (instead of an empty blob)
* Filter out `createObjectURL()` calls that don't pass the test blob
* Filter out `revokeObjectURL()` calls that don't pass the expected blob URL
* Reset the spies after each part to make the test a little easier to follow.
Right now the call counts accumulate since the spies are never reset, which
makes the test harder to understand and modify.
Differential Revision: https://phabricator.services.mozilla.com/D210981
I want the initialization function that I'm going to add later in the patch stack to be asynchronous, so the update entry points should be asynchronous functions.
Differential Revision: https://phabricator.services.mozilla.com/D209109
enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.
Differential Revision: https://phabricator.services.mozilla.com/D209936
enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.
Differential Revision: https://phabricator.services.mozilla.com/D209936
I want the initialization function that I'm going to add later in the patch stack to be asynchronous, so the update entry points should be asynchronous functions.
Differential Revision: https://phabricator.services.mozilla.com/D209109
enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.
Differential Revision: https://phabricator.services.mozilla.com/D209936
onboardingNext is visibility: hidden and thus not focusable. Before my
patch, the focus wasn't fixed-up properly, but now it is.
MANUAL PUSH: Test only orange fix CLOSED TREE
