Commit graph

23987 commits

Author SHA1 Message Date
Dorel Luca
fafb51f01d Backed out changeset 7f353853da83 (bug 1588793) as requsted by the dev. CLOSED TREE 2019-10-15 18:43:25 +03:00
Edouard Oger
8b32e670f0 Bug 1588793 - Load Sync Now string at startup. r=flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D49296

--HG--
extra : moz-landing-system : lando
2019-10-15 15:26:24 +00:00
Mike de Boer
7cf173a0ec Bug 1587804 - Add an Enterprise Policy that allows to set the default search engine used in Private Browsing mode. r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D49268

--HG--
extra : moz-landing-system : lando
2019-10-15 14:31:05 +00:00
Dorel Luca
37a8d618cb Backed out changeset d7a217f1ebee (bug 1588199) for Browser-chrome failures in rowser/components/newtab/test/browser/browser_asrouter_cfr.js. CLOSED TREE 2019-10-15 15:15:46 +03:00
Nan Jiang
b892f9c356 Bug 1588199 - Load local fluent file for ASRouter as fallback r=Pike,Mardak
This changes the either-or semantics to one-after between the local and remote fluent files for ASRouter.

Differential Revision: https://phabricator.services.mozilla.com/D49068

--HG--
extra : moz-landing-system : lando
2019-10-15 11:12:45 +00:00
Ms2ger
30b4e2a534 Bug 1194860 - Remove dom/imptests; r=jgraham
This leaves the testharness files, because they are used in various mochitests.

Differential Revision: https://phabricator.services.mozilla.com/D49132

--HG--
extra : moz-landing-system : lando
2019-10-15 08:22:15 +00:00
Jared Wein
267f2d146d Bug 1581506 - Hide the extra text for the Firefox Accounts button if the text wrapping stretches across more than three lines. r=sfoster
I used three lines instead of two because in my testing the space above and below the Sign In button allowed for some extra text to be shown without strecthing out of the container. I would prefer to err on the side of showing the full text instead of just the elided text since we cannot add a tooltip (title attribute) without changing the FTL key.

Differential Revision: https://phabricator.services.mozilla.com/D49014

--HG--
extra : moz-landing-system : lando
2019-10-15 00:02:23 +00:00
Emma Malysz
efcbc0d09d Bug 1588135, replace .xul test files in browser/ to .xhtml r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D48986

--HG--
rename : browser/base/content/test/chrome/test_aboutCrashed.xul => browser/base/content/test/chrome/test_aboutCrashed.xhtml
rename : browser/base/content/test/chrome/test_aboutRestartRequired.xul => browser/base/content/test/chrome/test_aboutRestartRequired.xhtml
rename : browser/base/content/test/contextMenu/subtst_contextmenu_xul.xul => browser/base/content/test/contextMenu/subtst_contextmenu_xul.xhtml
rename : browser/base/content/test/general/browser_tab_dragdrop2_frame1.xul => browser/base/content/test/general/browser_tab_dragdrop2_frame1.xhtml
rename : browser/components/places/tests/chrome/test_0_bug510634.xul => browser/components/places/tests/chrome/test_0_bug510634.xhtml
rename : browser/components/places/tests/chrome/test_bug1163447_selectItems_through_shortcut.xul => browser/components/places/tests/chrome/test_bug1163447_selectItems_through_shortcut.xhtml
rename : browser/components/places/tests/chrome/test_bug549192.xul => browser/components/places/tests/chrome/test_bug549192.xhtml
rename : browser/components/places/tests/chrome/test_bug549491.xul => browser/components/places/tests/chrome/test_bug549491.xhtml
rename : browser/components/places/tests/chrome/test_selectItems_on_nested_tree.xul => browser/components/places/tests/chrome/test_selectItems_on_nested_tree.xhtml
rename : browser/components/places/tests/chrome/test_treeview_date.xul => browser/components/places/tests/chrome/test_treeview_date.xhtml
rename : browser/components/preferences/in-content/tests/browser_bug1184989_prevent_scrolling_when_preferences_flipped.xul => browser/components/preferences/in-content/tests/browser_bug1184989_prevent_scrolling_when_preferences_flipped.xhtml
rename : browser/components/preferences/in-content/tests/subdialog.xul => browser/components/preferences/in-content/tests/subdialog.xhtml
rename : browser/components/preferences/in-content/tests/subdialog2.xul => browser/components/preferences/in-content/tests/subdialog2.xhtml
rename : browser/extensions/formautofill/test/browser/focus-leak/doc_iframe_typecontent_input_focus.xul => browser/extensions/formautofill/test/browser/focus-leak/doc_iframe_typecontent_input_focus.xhtml
extra : source : 9de4958b65f183a452937f1e7e6b526df36e02f1
2019-10-14 22:24:12 +00:00
Cosmin Sabou
372660d92d Backed out changeset 9de4958b65f1 (bug 1588135) for browser chrome failures on test_aboutRestartRequired.xhtml
--HG--
rename : browser/base/content/test/chrome/test_aboutCrashed.xhtml => browser/base/content/test/chrome/test_aboutCrashed.xul
rename : browser/base/content/test/chrome/test_aboutRestartRequired.xhtml => browser/base/content/test/chrome/test_aboutRestartRequired.xul
rename : browser/base/content/test/contextMenu/subtst_contextmenu_xul.xhtml => browser/base/content/test/contextMenu/subtst_contextmenu_xul.xul
rename : browser/base/content/test/general/browser_tab_dragdrop2_frame1.xhtml => browser/base/content/test/general/browser_tab_dragdrop2_frame1.xul
rename : browser/components/places/tests/chrome/test_0_bug510634.xhtml => browser/components/places/tests/chrome/test_0_bug510634.xul
rename : browser/components/places/tests/chrome/test_bug1163447_selectItems_through_shortcut.xhtml => browser/components/places/tests/chrome/test_bug1163447_selectItems_through_shortcut.xul
rename : browser/components/places/tests/chrome/test_bug549192.xhtml => browser/components/places/tests/chrome/test_bug549192.xul
rename : browser/components/places/tests/chrome/test_bug549491.xhtml => browser/components/places/tests/chrome/test_bug549491.xul
rename : browser/components/places/tests/chrome/test_selectItems_on_nested_tree.xhtml => browser/components/places/tests/chrome/test_selectItems_on_nested_tree.xul
rename : browser/components/places/tests/chrome/test_treeview_date.xhtml => browser/components/places/tests/chrome/test_treeview_date.xul
rename : browser/components/preferences/in-content/tests/browser_bug1184989_prevent_scrolling_when_preferences_flipped.xhtml => browser/components/preferences/in-content/tests/browser_bug1184989_prevent_scrolling_when_preferences_flipped.xul
rename : browser/components/preferences/in-content/tests/subdialog.xhtml => browser/components/preferences/in-content/tests/subdialog.xul
rename : browser/components/preferences/in-content/tests/subdialog2.xhtml => browser/components/preferences/in-content/tests/subdialog2.xul
rename : browser/extensions/formautofill/test/browser/focus-leak/doc_iframe_typecontent_input_focus.xhtml => browser/extensions/formautofill/test/browser/focus-leak/doc_iframe_typecontent_input_focus.xul
extra : rebase_source : 95271ab213263da82a35c1fc52e1dedc3bfc4789
2019-10-15 03:06:38 +03:00
Emma Malysz
62c9920956 Bug 1588135, replace .xul test files in browser/ to .xhtml r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D48986

--HG--
rename : browser/base/content/test/chrome/test_aboutCrashed.xul => browser/base/content/test/chrome/test_aboutCrashed.xhtml
rename : browser/base/content/test/chrome/test_aboutRestartRequired.xul => browser/base/content/test/chrome/test_aboutRestartRequired.xhtml
rename : browser/base/content/test/contextMenu/subtst_contextmenu_xul.xul => browser/base/content/test/contextMenu/subtst_contextmenu_xul.xhtml
rename : browser/base/content/test/general/browser_tab_dragdrop2_frame1.xul => browser/base/content/test/general/browser_tab_dragdrop2_frame1.xhtml
rename : browser/components/places/tests/chrome/test_0_bug510634.xul => browser/components/places/tests/chrome/test_0_bug510634.xhtml
rename : browser/components/places/tests/chrome/test_bug1163447_selectItems_through_shortcut.xul => browser/components/places/tests/chrome/test_bug1163447_selectItems_through_shortcut.xhtml
rename : browser/components/places/tests/chrome/test_bug549192.xul => browser/components/places/tests/chrome/test_bug549192.xhtml
rename : browser/components/places/tests/chrome/test_bug549491.xul => browser/components/places/tests/chrome/test_bug549491.xhtml
rename : browser/components/places/tests/chrome/test_selectItems_on_nested_tree.xul => browser/components/places/tests/chrome/test_selectItems_on_nested_tree.xhtml
rename : browser/components/places/tests/chrome/test_treeview_date.xul => browser/components/places/tests/chrome/test_treeview_date.xhtml
rename : browser/components/preferences/in-content/tests/browser_bug1184989_prevent_scrolling_when_preferences_flipped.xul => browser/components/preferences/in-content/tests/browser_bug1184989_prevent_scrolling_when_preferences_flipped.xhtml
rename : browser/components/preferences/in-content/tests/subdialog.xul => browser/components/preferences/in-content/tests/subdialog.xhtml
rename : browser/components/preferences/in-content/tests/subdialog2.xul => browser/components/preferences/in-content/tests/subdialog2.xhtml
rename : browser/extensions/formautofill/test/browser/focus-leak/doc_iframe_typecontent_input_focus.xul => browser/extensions/formautofill/test/browser/focus-leak/doc_iframe_typecontent_input_focus.xhtml
extra : moz-landing-system : lando
2019-10-14 22:24:12 +00:00
Cosmin Sabou
5d6e6dc693 Backed out changeset adbcc583862c (bug 1579974) for browser chrome failures on browser_asrouter_trigger_listeners.js 2019-10-15 00:12:26 +03:00
Erica Wright
994cf2a525 Bug 1579974 - Add celebrating milestone toast when certain numbers of trackers are blocked. r=k88hudson,johannh,fluent-reviewers,flod
test with:
`./mach run --temp-profile --setpref browser.newtabpage.activity-stream.asrouter.providers.cfr="{\"id\":\"cfr\",\"enabled\":true,\"type\":\"local\",\"localProvider\":\"CFRMessageProvider\",\"frequency\":{\"custom\":[{\"period\":\"daily\",\"cap\":10}]},\"categories\":[\"cfrAddons\",\"cfrFeatures\"],\"updateCycleInMs\":3600000}"`

for testing: Change `browser/components/newtab/lib/CFRPageActions.jsm` line 136, to `if (false)` instead of `if (resource)` or comment out that block. This is to force using the local ftl file.


  - you can use the newtab devtools, set `browser.newtabpage.activity-stream.asrouter.devtoolsEnabled=true`
 - change the pref `privacy.trackingprotection.cfr-milestone.milestone-achieved=1` and `privacy.trackingprotection.cfr-milestone.milestones="1, 5000, 10000, 25000, 50000, 100000, 500000"`
 - ensure at least one tracker has been saved in the database by visiting a tracking page and refreshing (this is so we can get the date it was saved from the database).
- open a new tab and click the wrench to the top right.
- change provider to "cfr" scroll down to find the milestone_message and click "show"
- I've now added a 24 hour timeout in `toolkit/components/antitracking/TrackingDBService.jsm` line 270 - you'll want to comment this out in order to see the popup.

Differential Revision: https://phabricator.services.mozilla.com/D47512

--HG--
extra : moz-landing-system : lando
2019-10-14 20:06:41 +00:00
Matthew Noorenberghe
87888ef235 Bug 1527828 - Remove insecure password field detection code for the address bar. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D48975

--HG--
extra : moz-landing-system : lando
2019-10-14 20:03:19 +00:00
mcrawford@mozilla.com
0fbeeb4d57 Bug 1579166 - Buttons should be wider to match the spec r=jaws
Note - This was added in such a way so that any other buttons within login-item who have min-width declared are not overwritten.

Differential Revision: https://phabricator.services.mozilla.com/D49182

--HG--
extra : moz-landing-system : lando
2019-10-14 18:17:08 +00:00
Jared Wein
a1f3063d98 Bug 1588046 - Flex the login-item so the form can grow to consume the remaining space and push the footer to the bottom of the grid area. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D48990

--HG--
extra : moz-landing-system : lando
2019-10-14 16:32:36 +00:00
Paolo Amadini
ee00161634 Bug 1532703 - Redirect "about:config" to the HTML version on all channels for browser builds. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D48960

--HG--
extra : moz-landing-system : lando
2019-10-14 15:58:42 +00:00
shindli
56880b8b3b Backed out changeset 8fb923925923 (bug 1194860) for causing perma mda3 failures in dom/media/webaudio/test/test_convolverNodeChannelInterpretationChanges.html CLOSED TREE
--HG--
extra : histedit_source : f6827f0392c7d385c8a78cb2ec2458cf679afa4a
2019-10-14 19:27:08 +03:00
Ms2ger
6d1c58e46c Bug 1194860 - Remove dom/imptests; r=jgraham
This leaves the testharness files, because they are used in mochitest-chrome
tests in dom/animation/test.

Differential Revision: https://phabricator.services.mozilla.com/D49132

--HG--
extra : moz-landing-system : lando
2019-10-14 15:13:32 +00:00
James Teh
76247694a7 Bug 1588416: Reinstate the label for the search one-offs container. r=Standard8
The previous code relied on the header label having a value property.
However, after the conversion to Fluent in bug 1563026, this is no longer the case.
Instead, use aria-labelledby, which avoids label duplication and will work irrespective of the label's implementation.

Differential Revision: https://phabricator.services.mozilla.com/D49125

--HG--
extra : moz-landing-system : lando
2019-10-14 12:27:49 +00:00
shindli
8aa10c0b78 Backed out changeset 73cbc0f61053 (bug 1194860) for causing lint failure in /builds/worker/checkouts/gecko/dom/imptests/testharness.js CLOSED TREE 2019-10-14 16:43:11 +03:00
Ms2ger
ea25c9e00d Bug 1194860 - Remove dom/imptests; r=jgraham
This leaves the testharness files, because they are used in mochitest-chrome
tests in dom/animation/test.

Differential Revision: https://phabricator.services.mozilla.com/D49132

--HG--
extra : moz-landing-system : lando
2019-10-14 12:59:10 +00:00
Tim Huang
5f19bcd57a Bug 1586722 - Making the test 'browser/components/originattributes/test/browser/browser_firstPartyIsolation_about_newtab.js' working in Fission. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D48844

--HG--
extra : moz-landing-system : lando
2019-10-11 15:51:43 +00:00
Tim Nguyen
79c7f01c56 Bug 1588066 - Remove remaining references to textbox. r=surkov,emilio,webdriver-reviewers,bgrins,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D48958

--HG--
extra : moz-landing-system : lando
2019-10-14 07:41:35 +00:00
Marco Bonardo
cff612c7b4 Bug 1586681 - Ensure URIFIxup uses the right engine when there's a separate PB engine. r=Standard8,Gijs
Add a new FIXUP_FLAG_PRIVATE_CONTEXT to nsIURIFixup, make it use the default
private search engine when it's set.
Update consumers to pass the new flag when necessary.

Differential Revision: https://phabricator.services.mozilla.com/D48741

--HG--
extra : moz-landing-system : lando
2019-10-12 12:37:51 +00:00
Punam Dahiya
d16004d6cb Bug 1588215 - Add modal-less welcome, send-tab recipes and bug fixes to New Tab Page r=Mardak,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D49020

--HG--
extra : moz-landing-system : lando
2019-10-12 07:01:16 +00:00
Jared Wein
891886fa91 Bug 1587439 - Ignore messages about missing profile in old XULStore.jsm. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D48750

--HG--
extra : moz-landing-system : lando
2019-10-11 20:15:41 +00:00
Nan Jiang
d4893635c3 Bug 1585434 - Add a pref to control ASRouter remote l10n r=Mardak
By flipping this pref, we can force ASRouter to load the local flient files for l10n. Note I will make another change for ASRouter to decide which fluent source to use.

Differential Revision: https://phabricator.services.mozilla.com/D49010

--HG--
extra : moz-landing-system : lando
2019-10-11 21:01:20 +00:00
Jared Wein
ebdbdbee8f Bug 1583795 - Select the first breached login when breaches are set initially. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D48764

--HG--
extra : moz-landing-system : lando
2019-10-11 17:35:54 +00:00
Edouard Oger
25eb2d60df Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D48410

--HG--
extra : moz-landing-system : lando
2019-10-11 17:06:57 +00:00
Mark Banner
0f977493e1 Bug 1576160 - Turn on the display of default private search engine feature for nightly/early beta users. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D47223

--HG--
extra : moz-landing-system : lando
2019-10-11 07:22:23 +00:00
Tim Nguyen
8e222cab72 Bug 1586997 - Fix focusing the first input of edit bookmark dialogs. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D48955

--HG--
extra : moz-landing-system : lando
2019-10-11 14:16:42 +00:00
Mark Banner
bbdd994f71 Bug 1583162 - Add an option in preferences to allow search suggestions in private windows. r=mak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D48972

--HG--
extra : moz-landing-system : lando
2019-10-11 14:57:44 +00:00
Mark Banner
50b98750a5 Bug 1583162 - Remove 'Show Suggestions' from the search bar context menu as it doesn't work correctly, and using prefs UI is better. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D48971

--HG--
extra : moz-landing-system : lando
2019-10-11 14:57:27 +00:00
Abdoulaye Oumar Ly
a0898dc653 Bug 1505916 - [Fission] Part 1: Make the fullscreen code work with JSWindowActors. r=NeilDeakin,dao,smaug
At this point, fullscreen is not regressed but it doesn't work with oop iframes yet.

Differential Revision: https://phabricator.services.mozilla.com/D35026

--HG--
extra : moz-landing-system : lando
2019-10-11 14:30:28 +00:00
Dão Gottwald
f49de631fa Bug 1587800 - Remove the hidden-focus class. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D48845

--HG--
extra : moz-landing-system : lando
2019-10-11 13:35:52 +00:00
harry
9b2a6d81ce Bug 1588084 - Add null-checking to isUrlbarFocused to avoid crashes on window shutdown. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D48966

--HG--
extra : moz-landing-system : lando
2019-10-11 13:35:04 +00:00
Noemi Erli
9bb4859279 Backed out changeset 41fb463d4a8c (bug 1587800) for failures in test_about_private_browsing.py 2019-10-11 13:49:51 +03:00
Dão Gottwald
ea4ddcd840 Bug 1587800 - Remove the hidden-focus class. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D48845

--HG--
extra : moz-landing-system : lando
2019-10-11 09:58:13 +00:00
Sebastian Hengst
0af4fd28ee Bug 1587836 - update permissions related Bugzilla components stored in moz.build files. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D48869

--HG--
extra : moz-landing-system : lando
2019-10-11 08:44:00 +00:00
Kashav Madan
409851d51d Bug 1583240 - Update fission annotations, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D47648

--HG--
extra : moz-landing-system : lando
2019-10-08 15:29:06 +00:00
Kashav Madan
8dc620b8bc Bug 1583240 - Make BrowserTestUtils.waitForDocLoadAndStopIt Fission-compatible, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D47649

--HG--
extra : moz-landing-system : lando
2019-10-10 23:21:22 +00:00
Mike de Boer
7d3c7d45d1 Bug 1563024 - Adapt unit tests to include coverage for the new Search in Private Window context menu option. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D48673

--HG--
rename : browser/base/content/test/general/browser_bug970746.js => browser/components/search/test/browser/browser_contentContextMenu.js
rename : browser/base/content/test/general/browser_bug970746.xhtml => browser/components/search/test/browser/browser_contentContextMenu.xhtml
extra : moz-landing-system : lando
2019-10-10 22:49:18 +00:00
Tomislav Jovanovic
8b347e672a Bug 1587914 - Fix browser_ext_tabs_readerMode.js with Fission r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D48896

--HG--
extra : moz-landing-system : lando
2019-10-10 22:42:41 +00:00
Andreea Pavel
eb350d4f6b Backed out changeset 4695136f7e82 (bug 1549049) for assertion failures at ErrorResult.h on a CLOSED TREE 2019-10-11 00:53:42 +03:00
harry
bb242e5b57 Bug 1563351 - Insert search shortcuts into the Urlbar with Touch Bar buttons. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D38892

--HG--
extra : moz-landing-system : lando
2019-10-09 10:45:33 +00:00
harry
b4a08851a2 Bug 1563350 - Add popover to the Touch Bar that displays when the Urlbar has focus. r=mikedeboer,spohl,fluent-reviewers,Pike,flod
Differential Revision: https://phabricator.services.mozilla.com/D38563

--HG--
extra : moz-landing-system : lando
2019-10-10 19:57:32 +00:00
harry
63d2c3fa56 Bug 1563349 - Part 1 - JS changes to support TouchBarInput children. r=mikedeboer
Depends on D34926

Differential Revision: https://phabricator.services.mozilla.com/D47618

--HG--
extra : moz-landing-system : lando
2019-10-09 15:25:43 +00:00
Edouard Oger
136a86deed Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D48410

--HG--
extra : moz-landing-system : lando
2019-10-10 21:08:01 +00:00
Andrei Oprea
5716f36a6c Bug 1587705 - The CFR Recommendation button is not displayed in the minimized form on urlbar focus r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D48876

--HG--
extra : moz-landing-system : lando
2019-10-10 19:30:32 +00:00
Mark Banner
818208e565 Bug 1580830 - Add a display to the private browsing page to inform of the new setting for search engines in private mode. r=mikedeboer,fluent-reviewers,flod
This implements the introduction display for the new search engine preference.

The decision for whether or not to display the introduction is handled in AboutPrivateBrowsingHandler.jsm, as we need
to limit it to being displayed once per session.

Differential Revision: https://phabricator.services.mozilla.com/D48722

--HG--
extra : moz-landing-system : lando
2019-10-10 20:00:51 +00:00