mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-08 12:19:05 +02:00
6c3c9b5bf3
Prior to this patch, PDF.js tracks both its own 'disabled' pref (which is used by enterprise policy) and whether it is the default handler per the handler service - but it tracks both in one bool, which determines whether its streamconverter registers. Really, what we want is to never use PDF.js if it's preffed off. However, if there is some other default, it should be acceptable to use PDF.js in some circumstances, like for <embed> or <object>s where otherwise we would show no content at all. Even for toplevel PDFs, if the user has configured Firefox to open PDFs in an external helper app which is Firefox (which is currently an easy mistake to make in the unknownContentType dialog), or has it set to the OS default, but has changed their OS default to Firefox, we really still want to open those PDFs with PDF.js. This patch fixes all of this by splitting out the pref tracking from the handler state tracking. Only the pref will completely disable PDF.js. Then, in the streamconverter code, we check whether PDF.js should be used for PDFs, and if there's a misconfiguration that we can correct. This code is invoked from the parent process when we load PDFs in frames or toplevel documents, and will prevent us from invoking PDF.js in the child if the user would prefer that not to happen. As a driveby, this cleans up how we track the pref inside PDF.js, and how we get notified of changes to the handler - we were missing changes made in the unknown content type dialog, so it seemed worth making it generic. Differential Revision: https://phabricator.services.mozilla.com/D73510
34 lines
1.1 KiB
JavaScript
34 lines
1.1 KiB
JavaScript
/* Copyright 2018 Mozilla Foundation
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
const { Services } = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
|
|
ChromeUtils.defineModuleGetter(
|
|
this,
|
|
"PdfStreamConverter",
|
|
"resource://pdf.js/PdfStreamConverter.jsm"
|
|
);
|
|
|
|
// Register/unregister a constructor as a factory.
|
|
function StreamConverterFactory() {
|
|
if (!Services.prefs.getBoolPref("pdfjs.disabled", false)) {
|
|
return new PdfStreamConverter();
|
|
}
|
|
throw Components.Exception("", Cr.NS_ERROR_FACTORY_NOT_REGISTERED);
|
|
}
|
|
|
|
var EXPORTED_SYMBOLS = ["StreamConverterFactory"];
|