gecko-dev/testing/web-platform/tests/css/css-grid
Blink WPT Bot 6ed9c6e8d6 Bug 1632282 [wpt PR 23184] - [wpt] enhanceents to check-layout-th.js, a=testonly
Automatic update from web-platform-tests
[wpt] enhanceents to check-layout-th.js (#23184)

There are 3 enhancements that I've found useful.

1. Warn if there are any unexpected  data-* attributes

A common error is to have a typo in data-* attribute name.
When this happens, test will pass, because attribute is never read.
This enhancement prints a warning if unexpected attribute is found.

Running this over the entire test suite, I've found several errors:

css/css-grid/grid-definition/grid-auto-repeat-intrinsic-001.html
css/css-grid/grid-items/grid-items-percentage-margins-vertical-rl-001.html
css/css-grid/grid-items/grid-items-percentage-margins-vertical-rl-002.html
css/css-grid/grid-items/grid-items-relative-offsets-001.html
css/css-grid/grid-items/grid-items-relative-offsets-002.html
have data-expected-x, data-expected-y
Tried replacing some of these with data-offset-x, and tests fail.

css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002
has data-offset-top

2. highlight error on failure flag. Defaults to false.

If set, this flag will draw an outline around failed Element.
Useful when debugging pages with many elements.

3. toggle printing dom on error.

Sometimes, it is useful not to print dom on error for clarity.

Change-Id: I8424aa2dc002f63fde18d0fc54bdfe77666ce951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161379
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763069}

Co-authored-by: Aleks Totic <atotic@chromium.org>
--

wpt-commits: a5a3b7353c884ebcca0230818632a42ad2fbd9b2
wpt-pr: 23184
2020-04-28 11:47:43 +00:00
..
abspos
alignment Bug 1631030 [wpt PR 23066] - [css-grid] Migrate grid-self-baseline-* tests to WPT, a=testonly 2020-04-28 11:30:53 +00:00
animation
grid-definition Bug 1632282 [wpt PR 23184] - [wpt] enhanceents to check-layout-th.js, a=testonly 2020-04-28 11:47:43 +00:00
grid-items Bug 1632282 [wpt PR 23184] - [wpt] enhanceents to check-layout-th.js, a=testonly 2020-04-28 11:47:43 +00:00
grid-model Bug 1632282 [wpt PR 23184] - [wpt] enhanceents to check-layout-th.js, a=testonly 2020-04-28 11:47:43 +00:00
implicit-grids
layout-algorithm Bug 1630931 [wpt PR 23054] - [css-grid] Migrate grid-automatic-minimum-for-auto-rows to WPT, a=testonly 2020-04-28 11:31:13 +00:00
masonry.tentative
parsing
placement
reference Bug 1630846 [wpt PR 23045] - [css-grid] Migrate grid-container-width-should-include-scroll-bar-width.html to WPT, a=testonly 2020-04-28 11:31:03 +00:00
subgrid
support
test-plan
anonymous-grid-items-001.html
chrome-bug-001.html
chrome-crash-001.html
grid-child-percent-basis-resize-1-ref.html
grid-child-percent-basis-resize-1.html
grid-item-non-auto-height-stretch-001.html
grid-item-non-auto-height-stretch-002.html
grid-item-non-auto-height-stretch-003.html
grid-item-non-auto-height-stretch-004.html
grid-item-non-auto-height-stretch-ref.html
grid-layout-properties.html
grid-tracks-stretched-with-different-flex-factors-sum.html
inheritance.html
META.yml
README.md
table-grid-item-dynamic-001-ref.html
table-grid-item-dynamic-001.html

CSS Grid Layout Module Level 1 Test Suite

Directory containing the CSS Grid Layout spec test suite.

This suite is structured in different folders for each section of the spec (the name of the folders corresponds to the "id" of each section):

Links: