mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-10 05:08:36 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
47 lines
2.1 KiB
JavaScript
47 lines
2.1 KiB
JavaScript
"use strict";
|
|
|
|
const {ChromeMigrationUtils} = ChromeUtils.import("resource:///modules/ChromeMigrationUtils.jsm");
|
|
|
|
// Setup chrome user data path for all platforms.
|
|
ChromeMigrationUtils.getDataPath = () => {
|
|
return do_get_file("Library/Application Support/Google/Chrome/").path;
|
|
};
|
|
|
|
add_task(async function test_getExtensionList_function() {
|
|
let extensionList = await ChromeMigrationUtils.getExtensionList("Default");
|
|
Assert.equal(extensionList.length, 2, "There should be 2 extensions installed.");
|
|
Assert.deepEqual(extensionList.find(extension => extension.id == "fake-extension-1"), {
|
|
id: "fake-extension-1",
|
|
name: "Fake Extension 1",
|
|
description: "It is the description of fake extension 1.",
|
|
}, "First extension should match expectations.");
|
|
Assert.deepEqual(extensionList.find(extension => extension.id == "fake-extension-2"), {
|
|
id: "fake-extension-2",
|
|
name: "Fake Extension 2",
|
|
description: "It is the description of fake extension 2.",
|
|
}, "Second extension should match expectations.");
|
|
});
|
|
|
|
add_task(async function test_getExtensionInformation_function() {
|
|
let extension = await ChromeMigrationUtils.getExtensionInformation("fake-extension-1", "Default");
|
|
Assert.deepEqual(extension, {
|
|
id: "fake-extension-1",
|
|
name: "Fake Extension 1",
|
|
description: "It is the description of fake extension 1.",
|
|
}, "Should get the extension information correctly.");
|
|
});
|
|
|
|
add_task(async function test_getLocaleString_function() {
|
|
let name = await ChromeMigrationUtils._getLocaleString("__MSG_name__", "en_US", "fake-extension-1", "Default");
|
|
Assert.deepEqual(name, "Fake Extension 1", "The value of __MSG_name__ locale key is Fake Extension 1.");
|
|
});
|
|
|
|
add_task(async function test_isExtensionInstalled_function() {
|
|
let isInstalled = await ChromeMigrationUtils.isExtensionInstalled("fake-extension-1", "Default");
|
|
Assert.ok(isInstalled, "The fake-extension-1 extension should be installed.");
|
|
});
|
|
|
|
add_task(async function test_getLastUsedProfileId_function() {
|
|
let profileId = await ChromeMigrationUtils.getLastUsedProfileId();
|
|
Assert.equal(profileId, "Default", "The last used profile ID should be Default.");
|
|
});
|