mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-10 05:08:36 +02:00
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
153 lines
4.9 KiB
JavaScript
153 lines
4.9 KiB
JavaScript
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
const {XPCOMUtils} = ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
|
|
XPCOMUtils.defineLazyGlobalGetters(this, ["URL"]);
|
|
|
|
const {actionTypes: at} = ChromeUtils.import("resource://activity-stream/common/Actions.jsm");
|
|
|
|
XPCOMUtils.defineLazyModuleGetters(this, {
|
|
DownloadsCommon: "resource:///modules/DownloadsCommon.jsm",
|
|
DownloadsViewUI: "resource:///modules/DownloadsViewUI.jsm",
|
|
FileUtils: "resource://gre/modules/FileUtils.jsm",
|
|
});
|
|
|
|
const DOWNLOAD_CHANGED_DELAY_TIME = 1000; // time in ms to delay timer for downloads changed events
|
|
|
|
this.DownloadsManager = class DownloadsManager {
|
|
constructor(store) {
|
|
this._downloadData = null;
|
|
this._store = null;
|
|
this._downloadItems = new Map();
|
|
this._downloadTimer = null;
|
|
}
|
|
|
|
setTimeout(callback, delay) {
|
|
let timer = Cc["@mozilla.org/timer;1"].createInstance(Ci.nsITimer);
|
|
timer.initWithCallback(callback, delay, Ci.nsITimer.TYPE_ONE_SHOT);
|
|
return timer;
|
|
}
|
|
|
|
formatDownload(download) {
|
|
return {
|
|
hostname: new URL(download.source.url).hostname,
|
|
url: download.source.url,
|
|
path: download.target.path,
|
|
title: DownloadsViewUI.getDisplayName(download),
|
|
description: DownloadsViewUI.getSizeWithUnits(download) ||
|
|
DownloadsCommon.strings.sizeUnknown,
|
|
referrer: download.source.referrer,
|
|
date_added: download.endTime,
|
|
};
|
|
}
|
|
|
|
init(store) {
|
|
this._store = store;
|
|
this._browser = Services.appShell.hiddenDOMWindow;
|
|
this._downloadData = DownloadsCommon.getData(this._browser.ownerGlobal, true, false, true);
|
|
this._downloadData.addView(this);
|
|
}
|
|
|
|
onDownloadAdded(download) {
|
|
if (!this._downloadItems.has(download.source.url)) {
|
|
this._downloadItems.set(download.source.url, download);
|
|
|
|
// On startup, all existing downloads fire this notification, so debounce them
|
|
if (this._downloadTimer) {
|
|
this._downloadTimer.delay = DOWNLOAD_CHANGED_DELAY_TIME;
|
|
} else {
|
|
this._downloadTimer = this.setTimeout(() => {
|
|
this._downloadTimer = null;
|
|
this._store.dispatch({type: at.DOWNLOAD_CHANGED});
|
|
}, DOWNLOAD_CHANGED_DELAY_TIME);
|
|
}
|
|
}
|
|
}
|
|
|
|
onDownloadRemoved(download) {
|
|
if (this._downloadItems.has(download.source.url)) {
|
|
this._downloadItems.delete(download.source.url);
|
|
this._store.dispatch({type: at.DOWNLOAD_CHANGED});
|
|
}
|
|
}
|
|
|
|
async getDownloads(threshold, {numItems = this._downloadItems.size, onlySucceeded = false, onlyExists = false}) {
|
|
if (!threshold) {
|
|
return [];
|
|
}
|
|
let results = [];
|
|
|
|
// Only get downloads within the time threshold specified and sort by recency
|
|
const downloadThreshold = Date.now() - threshold;
|
|
let downloads = [...this._downloadItems.values()]
|
|
.filter(download => download.endTime > downloadThreshold)
|
|
.sort((download1, download2) => download1.endTime < download2.endTime);
|
|
|
|
for (const download of downloads) {
|
|
// Only include downloads where the file still exists
|
|
if (onlyExists) {
|
|
// Refresh download to ensure the 'exists' attribute is up to date
|
|
await download.refresh();
|
|
if (!download.target.exists) { continue; }
|
|
}
|
|
// Only include downloads that were completed successfully
|
|
if (onlySucceeded) {
|
|
if (!download.succeeded) { continue; }
|
|
}
|
|
const formattedDownloadForHighlights = this.formatDownload(download);
|
|
results.push(formattedDownloadForHighlights);
|
|
if (results.length === numItems) {
|
|
break;
|
|
}
|
|
}
|
|
return results;
|
|
}
|
|
|
|
uninit() {
|
|
if (this._downloadData) {
|
|
this._downloadData.removeView(this);
|
|
this._downloadData = null;
|
|
}
|
|
if (this._downloadTimer) {
|
|
this._downloadTimer.cancel();
|
|
this._downloadTimer = null;
|
|
}
|
|
}
|
|
|
|
onAction(action) {
|
|
let doDownloadAction = callback => {
|
|
let download = this._downloadItems.get(action.data.url);
|
|
if (download) {
|
|
callback(download);
|
|
}
|
|
};
|
|
|
|
switch (action.type) {
|
|
case at.COPY_DOWNLOAD_LINK:
|
|
doDownloadAction(download => {
|
|
DownloadsCommon.copyDownloadLink(download);
|
|
});
|
|
break;
|
|
case at.REMOVE_DOWNLOAD_FILE:
|
|
doDownloadAction(download => {
|
|
DownloadsCommon.deleteDownload(download).catch(Cu.reportError);
|
|
});
|
|
break;
|
|
case at.SHOW_DOWNLOAD_FILE:
|
|
doDownloadAction(download => {
|
|
DownloadsCommon.showDownloadedFile(
|
|
new FileUtils.File(download.target.path));
|
|
});
|
|
break;
|
|
case at.OPEN_DOWNLOAD_FILE:
|
|
doDownloadAction(download => {
|
|
DownloadsCommon.openDownloadedFile(
|
|
new FileUtils.File(download.target.path), null,
|
|
this._browser.ownerGlobal);
|
|
});
|
|
break;
|
|
case at.UNINIT:
|
|
this.uninit();
|
|
break;
|
|
}
|
|
}
|
|
};
|
|
this.EXPORTED_SYMBOLS = ["DownloadsManager"];
|