mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-10 21:28:04 +02:00
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
190 lines
4.8 KiB
JavaScript
190 lines
4.8 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
/* exported EditAddressDialog, EditCreditCardDialog */
|
|
/* eslint-disable mozilla/balanced-listeners */ // Not relevant since the document gets unloaded.
|
|
|
|
"use strict";
|
|
|
|
// eslint-disable-next-line no-unused-vars
|
|
const {FormAutofill} = ChromeUtils.import("resource://formautofill/FormAutofill.jsm");
|
|
|
|
ChromeUtils.defineModuleGetter(this, "formAutofillStorage",
|
|
"resource://formautofill/FormAutofillStorage.jsm");
|
|
|
|
class AutofillEditDialog {
|
|
constructor(subStorageName, elements, record) {
|
|
this._storageInitPromise = formAutofillStorage.initialize();
|
|
this._subStorageName = subStorageName;
|
|
this._elements = elements;
|
|
this._record = record;
|
|
this.localizeDocument();
|
|
window.addEventListener("DOMContentLoaded", this, {once: true});
|
|
}
|
|
|
|
async init() {
|
|
this.updateSaveButtonState();
|
|
this.attachEventListeners();
|
|
// For testing only: signal to tests that the dialog is ready for testing.
|
|
// This is likely no longer needed since retrieving from storage is fully
|
|
// handled in manageDialog.js now.
|
|
window.dispatchEvent(new CustomEvent("FormReady"));
|
|
}
|
|
|
|
/**
|
|
* Get storage and ensure it has been initialized.
|
|
* @returns {object}
|
|
*/
|
|
async getStorage() {
|
|
await this._storageInitPromise;
|
|
return formAutofillStorage[this._subStorageName];
|
|
}
|
|
|
|
/**
|
|
* Asks FormAutofillParent to save or update an record.
|
|
* @param {object} record
|
|
* @param {string} guid [optional]
|
|
*/
|
|
async saveRecord(record, guid) {
|
|
let storage = await this.getStorage();
|
|
if (guid) {
|
|
await storage.update(guid, record);
|
|
} else {
|
|
await storage.add(record);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Handle events
|
|
*
|
|
* @param {DOMEvent} event
|
|
*/
|
|
handleEvent(event) {
|
|
switch (event.type) {
|
|
case "DOMContentLoaded": {
|
|
this.init();
|
|
break;
|
|
}
|
|
case "click": {
|
|
this.handleClick(event);
|
|
break;
|
|
}
|
|
case "input": {
|
|
this.handleInput(event);
|
|
break;
|
|
}
|
|
case "keypress": {
|
|
this.handleKeyPress(event);
|
|
break;
|
|
}
|
|
case "contextmenu": {
|
|
if (!(event.target instanceof HTMLInputElement) &&
|
|
!(event.target instanceof HTMLTextAreaElement)) {
|
|
event.preventDefault();
|
|
}
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Handle click events
|
|
*
|
|
* @param {DOMEvent} event
|
|
*/
|
|
handleClick(event) {
|
|
if (event.target == this._elements.cancel) {
|
|
window.close();
|
|
}
|
|
if (event.target == this._elements.save) {
|
|
this.handleSubmit();
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Handle input events
|
|
*
|
|
* @param {DOMEvent} event
|
|
*/
|
|
handleInput(event) {
|
|
this.updateSaveButtonState();
|
|
}
|
|
|
|
/**
|
|
* Handle key press events
|
|
*
|
|
* @param {DOMEvent} event
|
|
*/
|
|
handleKeyPress(event) {
|
|
if (event.keyCode == KeyEvent.DOM_VK_ESCAPE) {
|
|
window.close();
|
|
}
|
|
}
|
|
|
|
updateSaveButtonState() {
|
|
// Toggle disabled attribute on the save button based on
|
|
// whether the form is filled or empty.
|
|
if (Object.keys(this._elements.fieldContainer.buildFormObject()).length == 0) {
|
|
this._elements.save.setAttribute("disabled", true);
|
|
} else {
|
|
this._elements.save.removeAttribute("disabled");
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Attach event listener
|
|
*/
|
|
attachEventListeners() {
|
|
window.addEventListener("keypress", this);
|
|
window.addEventListener("contextmenu", this);
|
|
this._elements.controlsContainer.addEventListener("click", this);
|
|
document.addEventListener("input", this);
|
|
}
|
|
|
|
// An interface to be inherited.
|
|
localizeDocument() {}
|
|
}
|
|
|
|
class EditAddressDialog extends AutofillEditDialog {
|
|
constructor(elements, record) {
|
|
super("addresses", elements, record);
|
|
}
|
|
|
|
localizeDocument() {
|
|
if (this._record) {
|
|
this._elements.title.dataset.localization = "editAddressTitle";
|
|
}
|
|
}
|
|
|
|
async handleSubmit() {
|
|
await this.saveRecord(this._elements.fieldContainer.buildFormObject(), this._record ? this._record.guid : null);
|
|
window.close();
|
|
}
|
|
}
|
|
|
|
class EditCreditCardDialog extends AutofillEditDialog {
|
|
constructor(elements, record) {
|
|
super("creditCards", elements, record);
|
|
}
|
|
|
|
localizeDocument() {
|
|
if (this._record) {
|
|
this._elements.title.dataset.localization = "editCreditCardTitle";
|
|
}
|
|
}
|
|
|
|
async handleSubmit() {
|
|
let creditCard = this._elements.fieldContainer.buildFormObject();
|
|
if (!this._elements.fieldContainer._elements.form.reportValidity()) {
|
|
return;
|
|
}
|
|
|
|
try {
|
|
await this.saveRecord(creditCard, this._record ? this._record.guid : null);
|
|
window.close();
|
|
} catch (ex) {
|
|
Cu.reportError(ex);
|
|
}
|
|
}
|
|
}
|