mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-10 21:28:04 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
68 lines
2.3 KiB
JavaScript
68 lines
2.3 KiB
JavaScript
/* Copyright 2013 Mozilla Foundation
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
/* eslint max-len: ["error", 100] */
|
|
|
|
"use strict";
|
|
|
|
var EXPORTED_SYMBOLS = ["PdfJsTelemetry"];
|
|
|
|
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
|
|
var PdfJsTelemetry = {
|
|
onViewerIsUsed() {
|
|
let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_USED");
|
|
histogram.add(true);
|
|
},
|
|
onFallback() {
|
|
let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_FALLBACK_SHOWN");
|
|
histogram.add(true);
|
|
},
|
|
onDocumentSize(size) {
|
|
let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_DOCUMENT_SIZE_KB");
|
|
histogram.add(size / 1024);
|
|
},
|
|
onDocumentVersion(versionId) {
|
|
let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_DOCUMENT_VERSION");
|
|
histogram.add(versionId);
|
|
},
|
|
onDocumentGenerator(generatorId) {
|
|
let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_DOCUMENT_GENERATOR");
|
|
histogram.add(generatorId);
|
|
},
|
|
onEmbed(isObject) {
|
|
let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_EMBED");
|
|
histogram.add(isObject);
|
|
},
|
|
onFontType(fontTypeId) {
|
|
let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_FONT_TYPES");
|
|
histogram.add(fontTypeId);
|
|
},
|
|
onForm(isAcroform) {
|
|
let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_FORM");
|
|
histogram.add(isAcroform);
|
|
},
|
|
onPrint() {
|
|
let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_PRINT");
|
|
histogram.add(true);
|
|
},
|
|
onStreamType(streamTypeId) {
|
|
let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_STREAM_TYPES");
|
|
histogram.add(streamTypeId);
|
|
},
|
|
onTimeToView(ms) {
|
|
let histogram = Services.telemetry.getHistogramById("PDF_VIEWER_TIME_TO_VIEW_MS");
|
|
histogram.add(ms);
|
|
},
|
|
};
|