mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-10 05:08:36 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
44 lines
1.4 KiB
JavaScript
44 lines
1.4 KiB
JavaScript
/* eslint-env mozilla/frame-script */
|
|
// eslint-disable-next-line mozilla/reject-importGlobalProperties
|
|
Cu.importGlobalProperties(["File", "Directory"]);
|
|
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
var tmpFile, tmpDir;
|
|
|
|
addMessageListener("entries.open", function(e) {
|
|
tmpFile = Services.dirsvc.QueryInterface(Ci.nsIProperties).get("TmpD", Ci.nsIFile);
|
|
tmpFile.append("file.txt");
|
|
tmpFile.createUnique(Ci.nsIFile.NORMAL_FILE_TYPE, 0o600);
|
|
|
|
tmpDir = Services.dirsvc.QueryInterface(Ci.nsIProperties).get("TmpD", Ci.nsIFile);
|
|
|
|
tmpDir.append("dir-test");
|
|
tmpDir.createUnique(Ci.nsIFile.DIRECTORY_TYPE, 0o700);
|
|
|
|
var file1 = tmpDir.clone();
|
|
file1.append("foo.txt");
|
|
file1.create(Ci.nsIFile.NORMAL_FILE_TYPE, 0o600);
|
|
|
|
var dir1 = tmpDir.clone();
|
|
dir1.append("subdir");
|
|
dir1.create(Ci.nsIFile.DIRECTORY_TYPE, 0o700);
|
|
|
|
var file2 = dir1.clone();
|
|
file2.append("bar..txt"); // Note the double ..
|
|
file2.create(Ci.nsIFile.NORMAL_FILE_TYPE, 0o600);
|
|
|
|
var dir2 = dir1.clone();
|
|
dir2.append("subsubdir");
|
|
dir2.create(Ci.nsIFile.DIRECTORY_TYPE, 0o700);
|
|
|
|
File.createFromNsIFile(tmpFile).then(function(file) {
|
|
sendAsyncMessage("entries.opened", {
|
|
data: [ new Directory(tmpDir.path), file ],
|
|
});
|
|
});
|
|
});
|
|
|
|
addMessageListener("entries.delete", function(e) {
|
|
tmpFile.remove(true);
|
|
tmpDir.remove(true);
|
|
sendAsyncMessage("entries.deleted");
|
|
});
|