gecko-dev/toolkit/components/extensions/ExtensionChildDevToolsUtils.jsm
Kris Maglione e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00

112 lines
3.3 KiB
JavaScript

/* -*- Mode: indent-tabs-mode: nil; js-indent-level: 2 -*- */
/* vim: set sts=2 sw=2 et tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
"use strict";
/**
* @fileOverview
* This module contains utilities for interacting with DevTools
* from the child process.
*/
var EXPORTED_SYMBOLS = ["ExtensionChildDevToolsUtils"];
const {EventEmitter} = ChromeUtils.import("resource://gre/modules/EventEmitter.jsm");
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
// Create a variable to hold the cached ThemeChangeObserver which does not
// get created until a devtools context has been created.
let themeChangeObserver;
/**
* An observer that watches for changes to the devtools theme and provides
* that information to the devtools.panels.themeName API property, as well as
* emits events for the devtools.panels.onThemeChanged event. It also caches
* the current value of devtools.themeName.
*/
class ThemeChangeObserver extends EventEmitter {
constructor(themeName, onDestroyed) {
super();
this.themeName = themeName;
this.onDestroyed = onDestroyed;
this.contexts = new Set();
Services.cpmm.addMessageListener("Extension:DevToolsThemeChanged", this);
}
addContext(context) {
if (this.contexts.has(context)) {
throw new Error(
"addContext on the ThemeChangeObserver was called more than once" +
" for the context.");
}
context.callOnClose({
close: () => this.onContextClosed(context),
});
this.contexts.add(context);
}
onContextClosed(context) {
this.contexts.delete(context);
if (this.contexts.size === 0) {
this.destroy();
}
}
onThemeChanged(themeName) {
// Update the cached themeName and emit an event for the API.
this.themeName = themeName;
this.emit("themeChanged", themeName);
}
receiveMessage({name, data}) {
if (name === "Extension:DevToolsThemeChanged") {
this.onThemeChanged(data.themeName);
}
}
destroy() {
Services.cpmm.removeMessageListener("Extension:DevToolsThemeChanged", this);
this.onDestroyed();
this.onDestroyed = null;
this.contexts.clear();
this.contexts = null;
}
}
var ExtensionChildDevToolsUtils = {
/**
* Creates an cached instance of the ThemeChangeObserver class and
* initializes it with the current themeName. This cached instance is
* destroyed when all of the contexts added to it are closed.
*
* @param {string} themeName The name of the current devtools theme.
* @param {DevToolsContextChild} context The newly created devtools page context.
*/
initThemeChangeObserver(themeName, context) {
if (!themeChangeObserver) {
themeChangeObserver = new ThemeChangeObserver(
themeName,
function() { themeChangeObserver = null; }
);
}
themeChangeObserver.addContext(context);
},
/**
* Returns the cached instance of ThemeChangeObserver.
*
* @returns {ThemeChangeObserver} The cached instance of ThemeChangeObserver.
*/
getThemeChangeObserver() {
if (!themeChangeObserver) {
throw new Error("A ThemeChangeObserver must be created before being retrieved.");
}
return themeChangeObserver;
},
};