mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-10 21:28:04 +02:00
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
98 lines
3.1 KiB
JavaScript
98 lines
3.1 KiB
JavaScript
/* Any copyright is dedicated to the Public Domain.
|
|
* http://creativecommons.org/publicdomain/zero/1.0/ */
|
|
|
|
"use strict";
|
|
|
|
const {OS} = ChromeUtils.import("resource://gre/modules/osfile.jsm");
|
|
|
|
function run_test() {
|
|
do_test_pending();
|
|
run_next_test();
|
|
}
|
|
|
|
add_task(async function test_compress_lz4() {
|
|
let path = OS.Path.join(OS.Constants.Path.tmpDir, "compression.lz");
|
|
let length = 1024;
|
|
let array = new Uint8Array(length);
|
|
for (let i = 0; i < array.byteLength; ++i) {
|
|
array[i] = i;
|
|
}
|
|
let arrayAsString = Array.prototype.join.call(array);
|
|
|
|
info("Writing data with lz4 compression");
|
|
let bytes = await OS.File.writeAtomic(path, array, { compression: "lz4" });
|
|
info("Compressed " + length + " bytes into " + bytes);
|
|
|
|
info("Reading back with lz4 decompression");
|
|
let decompressed = await OS.File.read(path, { compression: "lz4" });
|
|
info("Decompressed into " + decompressed.byteLength + " bytes");
|
|
Assert.equal(arrayAsString, Array.prototype.join.call(decompressed));
|
|
});
|
|
|
|
add_task(async function test_uncompressed() {
|
|
info("Writing data without compression");
|
|
let path = OS.Path.join(OS.Constants.Path.tmpDir, "no_compression.tmp");
|
|
let array = new Uint8Array(1024);
|
|
for (let i = 0; i < array.byteLength; ++i) {
|
|
array[i] = i;
|
|
}
|
|
await OS.File.writeAtomic(path, array); // No compression
|
|
|
|
let exn;
|
|
// Force decompression, reading should fail
|
|
try {
|
|
await OS.File.read(path, { compression: "lz4" });
|
|
} catch (ex) {
|
|
exn = ex;
|
|
}
|
|
Assert.ok(!!exn);
|
|
// Check the exception message (and that it contains the file name)
|
|
Assert.ok(exn.message.includes(`Invalid header (no magic number) - Data: ${ path }`));
|
|
});
|
|
|
|
add_task(async function test_no_header() {
|
|
let path = OS.Path.join(OS.Constants.Path.tmpDir, "no_header.tmp");
|
|
let array = new Uint8Array(8).fill(0, 0); // Small array with no header
|
|
|
|
info("Writing data with no header");
|
|
|
|
await OS.File.writeAtomic(path, array); // No compression
|
|
let exn;
|
|
// Force decompression, reading should fail
|
|
try {
|
|
await OS.File.read(path, { compression: "lz4" });
|
|
} catch (ex) {
|
|
exn = ex;
|
|
}
|
|
Assert.ok(!!exn);
|
|
// Check the exception message (and that it contains the file name)
|
|
Assert.ok(exn.message.includes(`Buffer is too short (no header) - Data: ${ path }`));
|
|
});
|
|
|
|
add_task(async function test_invalid_content() {
|
|
let path = OS.Path.join(OS.Constants.Path.tmpDir, "invalid_content.tmp");
|
|
let arr1 = new Uint8Array([109, 111, 122, 76, 122, 52, 48, 0]);
|
|
let arr2 = new Uint8Array(248).fill(1, 0);
|
|
|
|
let array = new Uint8Array(arr1.length + arr2.length);
|
|
array.set(arr1);
|
|
array.set(arr2, arr1.length);
|
|
|
|
info("Writing invalid data (with a valid header and only ones after that)");
|
|
|
|
await OS.File.writeAtomic(path, array); // No compression
|
|
let exn;
|
|
// Force decompression, reading should fail
|
|
try {
|
|
await OS.File.read(path, { compression: "lz4" });
|
|
} catch (ex) {
|
|
exn = ex;
|
|
}
|
|
Assert.ok(!!exn);
|
|
// Check the exception message (and that it contains the file name)
|
|
Assert.ok(exn.message.includes(`Invalid content: Decompression stopped at 0 - Data: ${ path }`));
|
|
});
|
|
|
|
add_task(function() {
|
|
do_test_finished();
|
|
});
|