mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-10 21:28:04 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
57 lines
2.1 KiB
JavaScript
57 lines
2.1 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
"use strict";
|
|
|
|
const {OS} = ChromeUtils.import("resource://gre/modules/osfile.jsm");
|
|
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
|
|
registerCleanupFunction(function() {
|
|
Services.prefs.setBoolPref("toolkit.osfile.log", false);
|
|
});
|
|
|
|
function run_test() {
|
|
Services.prefs.setBoolPref("toolkit.osfile.log", true);
|
|
run_next_test();
|
|
}
|
|
|
|
add_task(async function test_ignoreAbsent() {
|
|
let absent_file_name = "test_osfile_front_absent.tmp";
|
|
|
|
// Removing absent files should throw if "ignoreAbsent" is true.
|
|
await Assert.rejects(OS.File.remove(absent_file_name, {ignoreAbsent: false}),
|
|
err => err.operation == "remove",
|
|
"OS.File.remove throws if there is no such file.");
|
|
|
|
// Removing absent files should not throw if "ignoreAbsent" is true or not
|
|
// defined.
|
|
let exception = null;
|
|
try {
|
|
await OS.File.remove(absent_file_name, {ignoreAbsent: true});
|
|
await OS.File.remove(absent_file_name);
|
|
} catch (ex) {
|
|
exception = ex;
|
|
}
|
|
Assert.ok(!exception, "OS.File.remove should not throw when not requested.");
|
|
});
|
|
|
|
add_task(async function test_ignoreAbsent_directory_missing() {
|
|
let absent_file_name = OS.Path.join("absent_parent", "test.tmp");
|
|
|
|
// Removing absent files should throw if "ignoreAbsent" is true.
|
|
await Assert.rejects(OS.File.remove(absent_file_name, {ignoreAbsent: false}),
|
|
err => err.operation == "remove",
|
|
"OS.File.remove throws if there is no such file.");
|
|
|
|
// Removing files from absent directories should not throw if "ignoreAbsent"
|
|
// is true or not defined.
|
|
let exception = null;
|
|
try {
|
|
await OS.File.remove(absent_file_name, {ignoreAbsent: true});
|
|
await OS.File.remove(absent_file_name);
|
|
} catch (ex) {
|
|
exception = ex;
|
|
}
|
|
Assert.ok(!exception, "OS.File.remove should not throw when not requested.");
|
|
});
|