mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-10 21:28:04 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
59 lines
1.8 KiB
JavaScript
59 lines
1.8 KiB
JavaScript
"use strict";
|
|
|
|
var {OS: {File, Path, Constants}} = ChromeUtils.import("resource://gre/modules/osfile.jsm");
|
|
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
|
|
// Ensure that we have a profile but that the OS.File worker is not launched
|
|
add_task(async function init() {
|
|
do_get_profile();
|
|
await File.resetWorker();
|
|
});
|
|
|
|
function getCount(histogram) {
|
|
if (histogram == null) {
|
|
return 0;
|
|
}
|
|
|
|
let total = 0;
|
|
for (let i of Object.values(histogram.values)) {
|
|
total += i;
|
|
}
|
|
return total;
|
|
}
|
|
|
|
// Ensure that launching the OS.File worker adds data to the relevant
|
|
// histograms
|
|
add_task(async function test_startup() {
|
|
let LAUNCH = "OSFILE_WORKER_LAUNCH_MS";
|
|
let READY = "OSFILE_WORKER_READY_MS";
|
|
|
|
let before = Services.telemetry.getSnapshotForHistograms("main", false).parent;
|
|
|
|
// Launch the OS.File worker
|
|
await File.getCurrentDirectory();
|
|
|
|
let after = Services.telemetry.getSnapshotForHistograms("main", false).parent;
|
|
|
|
|
|
info("Ensuring that we have recorded measures for histograms");
|
|
Assert.equal(getCount(after[LAUNCH]), getCount(before[LAUNCH]) + 1);
|
|
Assert.equal(getCount(after[READY]), getCount(before[READY]) + 1);
|
|
|
|
info("Ensuring that launh <= ready");
|
|
Assert.ok(after[LAUNCH].sum <= after[READY].sum);
|
|
});
|
|
|
|
// Ensure that calling writeAtomic adds data to the relevant histograms
|
|
add_task(async function test_writeAtomic() {
|
|
let LABEL = "OSFILE_WRITEATOMIC_JANK_MS";
|
|
|
|
let before = Services.telemetry.getSnapshotForHistograms("main", false).parent;
|
|
|
|
// Perform a write.
|
|
let path = Path.join(Constants.Path.profileDir, "test_osfile_telemetry.tmp");
|
|
await File.writeAtomic(path, LABEL, { tmpPath: path + ".tmp" } );
|
|
|
|
let after = Services.telemetry.getSnapshotForHistograms("main", false).parent;
|
|
|
|
Assert.equal(getCount(after[LABEL]), getCount(before[LABEL]) + 1);
|
|
});
|