mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-10 21:28:04 +02:00
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
87 lines
2.9 KiB
JavaScript
87 lines
2.9 KiB
JavaScript
"use strict";
|
|
|
|
const {OS} = ChromeUtils.import("resource://gre/modules/osfile.jsm");
|
|
|
|
function run_test() {
|
|
do_get_profile();
|
|
run_next_test();
|
|
}
|
|
|
|
function testFiles(filename) {
|
|
return (async function() {
|
|
const MAX_TRIES = 10;
|
|
let profileDir = OS.Constants.Path.profileDir;
|
|
let path = OS.Path.join(profileDir, filename);
|
|
|
|
// Ensure that openUnique() uses the file name if there is no file with that name already.
|
|
let openedFile = await OS.File.openUnique(path);
|
|
info("\nCreate new file: " + openedFile.path);
|
|
await openedFile.file.close();
|
|
let exists = await OS.File.exists(openedFile.path);
|
|
Assert.ok(exists);
|
|
Assert.equal(path, openedFile.path);
|
|
let fileInfo = await OS.File.stat(openedFile.path);
|
|
Assert.ok(fileInfo.size == 0);
|
|
|
|
// Ensure that openUnique() creates a new file name using a HEX number, as the original name is already taken.
|
|
openedFile = await OS.File.openUnique(path);
|
|
info("\nCreate unique HEX file: " + openedFile.path);
|
|
await openedFile.file.close();
|
|
exists = await OS.File.exists(openedFile.path);
|
|
Assert.ok(exists);
|
|
fileInfo = await OS.File.stat(openedFile.path);
|
|
Assert.ok(fileInfo.size == 0);
|
|
|
|
// Ensure that openUnique() generates different file names each time, using the HEX number algorithm
|
|
let filenames = new Set();
|
|
for (let i = 0; i < MAX_TRIES; i++) {
|
|
openedFile = await OS.File.openUnique(path);
|
|
await openedFile.file.close();
|
|
filenames.add(openedFile.path);
|
|
}
|
|
|
|
Assert.equal(filenames.size, MAX_TRIES);
|
|
|
|
// Ensure that openUnique() creates a new human readable file name using, as the original name is already taken.
|
|
openedFile = await OS.File.openUnique(path, {humanReadable: true});
|
|
info("\nCreate unique Human Readable file: " + openedFile.path);
|
|
await openedFile.file.close();
|
|
exists = await OS.File.exists(openedFile.path);
|
|
Assert.ok(exists);
|
|
fileInfo = await OS.File.stat(openedFile.path);
|
|
Assert.ok(fileInfo.size == 0);
|
|
|
|
// Ensure that openUnique() generates different human readable file names each time
|
|
filenames = new Set();
|
|
for (let i = 0; i < MAX_TRIES; i++) {
|
|
openedFile = await OS.File.openUnique(path, {humanReadable: true});
|
|
await openedFile.file.close();
|
|
filenames.add(openedFile.path);
|
|
}
|
|
|
|
Assert.equal(filenames.size, MAX_TRIES);
|
|
|
|
let exn;
|
|
try {
|
|
for (let i = 0; i < 100; i++) {
|
|
openedFile = await OS.File.openUnique(path, {humanReadable: true});
|
|
await openedFile.file.close();
|
|
}
|
|
} catch (ex) {
|
|
exn = ex;
|
|
}
|
|
|
|
info("Ensure that this raises the correct error");
|
|
Assert.ok(!!exn);
|
|
Assert.ok(exn instanceof OS.File.Error);
|
|
Assert.ok(exn.becauseExists);
|
|
})();
|
|
}
|
|
|
|
add_task(async function test_unique() {
|
|
OS.Shared.DEBUG = true;
|
|
// Tests files with extension
|
|
await testFiles("dummy_unique_file.txt");
|
|
// Tests files with no extension
|
|
await testFiles("dummy_unique_file_no_ext");
|
|
});
|