mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-12 22:28:59 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
92 lines
3.3 KiB
JavaScript
92 lines
3.3 KiB
JavaScript
/**
|
|
* Provides infrastructure for automated login components tests.
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
// Globals
|
|
|
|
var {XPCOMUtils} = ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
|
|
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
var {LoginRecipesContent, LoginRecipesParent} = ChromeUtils.import("resource://gre/modules/LoginRecipes.jsm");
|
|
var {LoginHelper} = ChromeUtils.import("resource://gre/modules/LoginHelper.jsm");
|
|
var {FileTestUtils} = ChromeUtils.import("resource://testing-common/FileTestUtils.jsm");
|
|
var {LoginTestUtils} = ChromeUtils.import("resource://testing-common/LoginTestUtils.jsm");
|
|
var {MockDocument} = ChromeUtils.import("resource://testing-common/MockDocument.jsm");
|
|
|
|
ChromeUtils.defineModuleGetter(this, "DownloadPaths",
|
|
"resource://gre/modules/DownloadPaths.jsm");
|
|
ChromeUtils.defineModuleGetter(this, "FileUtils",
|
|
"resource://gre/modules/FileUtils.jsm");
|
|
ChromeUtils.defineModuleGetter(this, "OS",
|
|
"resource://gre/modules/osfile.jsm");
|
|
|
|
const LoginInfo =
|
|
Components.Constructor("@mozilla.org/login-manager/loginInfo;1",
|
|
"nsILoginInfo", "init");
|
|
|
|
const TestData = LoginTestUtils.testData;
|
|
const newPropertyBag = LoginHelper.newPropertyBag;
|
|
|
|
/**
|
|
* All the tests are implemented with add_task, this starts them automatically.
|
|
*/
|
|
function run_test() {
|
|
do_get_profile();
|
|
run_next_test();
|
|
}
|
|
|
|
// Global helpers
|
|
|
|
/**
|
|
* Returns a reference to a temporary file that is guaranteed not to exist and
|
|
* is cleaned up later. See FileTestUtils.getTempFile for details.
|
|
*/
|
|
function getTempFile(leafName) {
|
|
return FileTestUtils.getTempFile(leafName);
|
|
}
|
|
|
|
const RecipeHelpers = {
|
|
initNewParent() {
|
|
return (new LoginRecipesParent({ defaults: null })).initializationPromise;
|
|
},
|
|
};
|
|
|
|
// Initialization functions common to all tests
|
|
|
|
add_task(async function test_common_initialize() {
|
|
// Before initializing the service for the first time, we should copy the key
|
|
// file required to decrypt the logins contained in the SQLite databases used
|
|
// by migration tests. This file is not required for the other tests.
|
|
await OS.File.copy(do_get_file("data/key3.db").path,
|
|
OS.Path.join(OS.Constants.Path.profileDir, "key3.db"));
|
|
|
|
// Ensure that the service and the storage module are initialized.
|
|
await Services.logins.initializationPromise;
|
|
|
|
// Ensure that every test file starts with an empty database.
|
|
LoginTestUtils.clearData();
|
|
|
|
// Clean up after every test.
|
|
registerCleanupFunction(() => LoginTestUtils.clearData());
|
|
});
|
|
|
|
/**
|
|
* Compare two FormLike to see if they represent the same information. Elements
|
|
* are compared using their @id attribute.
|
|
*/
|
|
function formLikeEqual(a, b) {
|
|
Assert.strictEqual(Object.keys(a).length, Object.keys(b).length,
|
|
"Check the formLikes have the same number of properties");
|
|
|
|
for (let propName of Object.keys(a)) {
|
|
if (propName == "elements") {
|
|
Assert.strictEqual(a.elements.length, b.elements.length, "Check element count");
|
|
for (let i = 0; i < a.elements.length; i++) {
|
|
Assert.strictEqual(a.elements[i].id, b.elements[i].id, "Check element " + i + " id");
|
|
}
|
|
continue;
|
|
}
|
|
Assert.strictEqual(a[propName], b[propName], "Compare formLike " + propName + " property");
|
|
}
|
|
}
|