mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-11 05:39:41 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
54 lines
2 KiB
JavaScript
54 lines
2 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
const {CommonDialog} = ChromeUtils.import("resource://gre/modules/CommonDialog.jsm");
|
|
|
|
var propBag, args, Dialog;
|
|
|
|
function commonDialogOnLoad() {
|
|
propBag = window.arguments[0].QueryInterface(Ci.nsIWritablePropertyBag2)
|
|
.QueryInterface(Ci.nsIWritablePropertyBag);
|
|
// Convert to a JS object
|
|
args = {};
|
|
for (let prop of propBag.enumerator) {
|
|
args[prop.name] = prop.value;
|
|
}
|
|
|
|
let dialog = document.documentElement;
|
|
|
|
let ui = {
|
|
prompt: window,
|
|
loginContainer: document.getElementById("loginContainer"),
|
|
loginTextbox: document.getElementById("loginTextbox"),
|
|
loginLabel: document.getElementById("loginLabel"),
|
|
password1Container: document.getElementById("password1Container"),
|
|
password1Textbox: document.getElementById("password1Textbox"),
|
|
password1Label: document.getElementById("password1Label"),
|
|
infoBody: document.getElementById("infoBody"),
|
|
infoTitle: document.getElementById("infoTitle"),
|
|
infoIcon: document.getElementById("infoIcon"),
|
|
checkbox: document.getElementById("checkbox"),
|
|
checkboxContainer: document.getElementById("checkboxContainer"),
|
|
button3: dialog.getButton("extra2"),
|
|
button2: dialog.getButton("extra1"),
|
|
button1: dialog.getButton("cancel"),
|
|
button0: dialog.getButton("accept"),
|
|
focusTarget: window,
|
|
};
|
|
|
|
// limit the dialog to the screen width
|
|
document.getElementById("filler").maxWidth = screen.availWidth;
|
|
|
|
Dialog = new CommonDialog(args, ui);
|
|
Dialog.onLoad(dialog);
|
|
// resize the window to the content
|
|
window.sizeToContent();
|
|
window.getAttention();
|
|
}
|
|
|
|
function commonDialogOnUnload() {
|
|
// Convert args back into property bag
|
|
for (let propName in args)
|
|
propBag.setProperty(propName, args[propName]);
|
|
}
|