mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-11 05:39:41 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
59 lines
1.9 KiB
JavaScript
59 lines
1.9 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
const {FormHistory} = ChromeUtils.import("resource://gre/modules/FormHistory.jsm");
|
|
|
|
add_task(async function test() {
|
|
const url = `data:text/html,<input type="text" name="field1">`;
|
|
|
|
// Open a dummy tab.
|
|
await BrowserTestUtils.withNewTab({gBrowser, url}, async function(browser) {});
|
|
|
|
await BrowserTestUtils.withNewTab({gBrowser, url}, async function(browser) {
|
|
const {autoCompletePopup} = browser;
|
|
const mockHistory = [
|
|
{op: "add", fieldname: "field1", value: "value1"},
|
|
];
|
|
|
|
await new Promise(resolve =>
|
|
FormHistory.update([{op: "remove"}, ...mockHistory],
|
|
{handleCompletion: resolve})
|
|
);
|
|
await ContentTask.spawn(browser, {}, async function() {
|
|
const input = content.document.querySelector("input");
|
|
|
|
input.focus();
|
|
});
|
|
|
|
// show popup
|
|
await BrowserTestUtils.synthesizeKey("VK_DOWN", {}, browser);
|
|
await TestUtils.waitForCondition(() => {
|
|
return autoCompletePopup.popupOpen;
|
|
});
|
|
|
|
let listener;
|
|
let errorLogPromise = new Promise(resolve => {
|
|
listener = ({message}) => {
|
|
const ERROR_MSG = "AutoCompletePopup: No messageManager for " +
|
|
"message \"FormAutoComplete:PopupClosed\"";
|
|
if (message.includes(ERROR_MSG)) {
|
|
Assert.ok(true, "Got the error message for inexistent messageManager.");
|
|
Services.console.unregisterListener(listener);
|
|
resolve();
|
|
}
|
|
};
|
|
});
|
|
Services.console.registerListener(listener);
|
|
|
|
gBrowser.removeCurrentTab();
|
|
|
|
await TestUtils.waitForCondition(() => {
|
|
return !autoCompletePopup.popupOpen;
|
|
});
|
|
|
|
Assert.ok(!autoCompletePopup.popupOpen, "Ensure the popup is closed.");
|
|
|
|
await errorLogPromise;
|
|
});
|
|
});
|