mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-11 13:48:23 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
59 lines
2.2 KiB
JavaScript
59 lines
2.2 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
var {FormHistory} = (ChromeUtils.import("resource://gre/modules/FormHistory.jsm"));
|
|
|
|
/** Test for Bug 472396 **/
|
|
add_task(async function test() {
|
|
// initialization
|
|
let windowsToClose = [];
|
|
let testURI =
|
|
"http://example.com/tests/toolkit/components/satchel/test/subtst_privbrowsing.html";
|
|
|
|
async function doTest(aShouldValueExist, aWindow) {
|
|
let browser = aWindow.gBrowser.selectedBrowser;
|
|
BrowserTestUtils.loadURI(browser, testURI);
|
|
await BrowserTestUtils.browserLoaded(browser);
|
|
|
|
// Wait for the page to reload itself.
|
|
await BrowserTestUtils.browserLoaded(browser);
|
|
|
|
let count = 0;
|
|
let doneCounting = {};
|
|
doneCounting.promise = new Promise(resolve => doneCounting.resolve = resolve);
|
|
FormHistory.count({ fieldname: "field", value: "value" },
|
|
{
|
|
handleResult(result) {
|
|
count = result;
|
|
},
|
|
handleError(error) {
|
|
Assert.ok(false, "Error occurred searching form history: " + error);
|
|
},
|
|
handleCompletion(num) {
|
|
if (aShouldValueExist) {
|
|
is(count, 1, "In non-PB mode, we add a single entry");
|
|
} else {
|
|
is(count, 0, "In PB mode, we don't add any entries");
|
|
}
|
|
|
|
doneCounting.resolve();
|
|
},
|
|
});
|
|
await doneCounting.promise;
|
|
}
|
|
|
|
function testOnWindow(aOptions, aCallback) {
|
|
return BrowserTestUtils.openNewBrowserWindow(aOptions)
|
|
.then(win => { windowsToClose.push(win); return win; });
|
|
}
|
|
|
|
|
|
await testOnWindow({private: true}).then(aWin => doTest(false, aWin));
|
|
|
|
// Test when not on private mode after visiting a site on private
|
|
// mode. The form history should not exist.
|
|
await testOnWindow({}).then(aWin => doTest(true, aWin));
|
|
|
|
await Promise.all(windowsToClose.map(win => BrowserTestUtils.closeWindow(win)));
|
|
});
|