mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-10 21:28:04 +02:00
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
72 lines
2.4 KiB
JavaScript
72 lines
2.4 KiB
JavaScript
/* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
|
|
function loadUtilsScript() {
|
|
/* import-globals-from ../../contentAreaUtils.js */
|
|
Services.scriptloader.loadSubScript("chrome://global/content/contentAreaUtils.js");
|
|
}
|
|
|
|
function test_urlSecurityCheck() {
|
|
var nullPrincipal = Services.scriptSecurityManager.createNullPrincipal({});
|
|
|
|
const HTTP_URI = "http://www.mozilla.org/";
|
|
const CHROME_URI = "chrome://browser/content/browser.xul";
|
|
const DISALLOW_INHERIT_PRINCIPAL =
|
|
Ci.nsIScriptSecurityManager.DISALLOW_INHERIT_PRINCIPAL;
|
|
|
|
try {
|
|
urlSecurityCheck(makeURI(HTTP_URI), nullPrincipal,
|
|
DISALLOW_INHERIT_PRINCIPAL);
|
|
} catch (ex) {
|
|
do_throw("urlSecurityCheck should not throw when linking to a http uri with a null principal");
|
|
}
|
|
|
|
// urlSecurityCheck also supports passing the url as a string
|
|
try {
|
|
urlSecurityCheck(HTTP_URI, nullPrincipal,
|
|
DISALLOW_INHERIT_PRINCIPAL);
|
|
} catch (ex) {
|
|
do_throw("urlSecurityCheck failed to handle the http URI as a string (uri spec)");
|
|
}
|
|
|
|
let shouldThrow = true;
|
|
try {
|
|
urlSecurityCheck(CHROME_URI, nullPrincipal,
|
|
DISALLOW_INHERIT_PRINCIPAL);
|
|
} catch (ex) {
|
|
shouldThrow = false;
|
|
}
|
|
if (shouldThrow)
|
|
do_throw("urlSecurityCheck should throw when linking to a chrome uri with a null principal");
|
|
}
|
|
|
|
function test_stringBundle() {
|
|
// This test verifies that the elements that can be used as file picker title
|
|
// keys in the save* functions are actually present in the string bundle.
|
|
// These keys are part of the contentAreaUtils.js public API.
|
|
var validFilePickerTitleKeys = [
|
|
"SaveImageTitle",
|
|
"SaveVideoTitle",
|
|
"SaveAudioTitle",
|
|
"SaveLinkTitle",
|
|
];
|
|
|
|
for (let filePickerTitleKey of validFilePickerTitleKeys) {
|
|
// Just check that the string exists
|
|
try {
|
|
ContentAreaUtils.stringBundle.GetStringFromName(filePickerTitleKey);
|
|
} catch (e) {
|
|
do_throw("Error accessing file picker title key: " + filePickerTitleKey);
|
|
}
|
|
}
|
|
}
|
|
|
|
function run_test() {
|
|
loadUtilsScript();
|
|
test_urlSecurityCheck();
|
|
test_stringBundle();
|
|
}
|