mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-10 05:08:36 +02:00
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
180 lines
5.3 KiB
JavaScript
180 lines
5.3 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
* You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
"use strict";
|
|
|
|
var EXPORTED_SYMBOLS = ["AppMenuNotifications"];
|
|
|
|
const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
|
|
|
|
function AppMenuNotification(id, mainAction, secondaryAction, options = {}) {
|
|
this.id = id;
|
|
this.mainAction = mainAction;
|
|
this.secondaryAction = secondaryAction;
|
|
this.options = options;
|
|
this.dismissed = this.options.dismissed || false;
|
|
}
|
|
|
|
var AppMenuNotifications = {
|
|
_notifications: [],
|
|
_hasInitialized: false,
|
|
|
|
get notifications() {
|
|
return Array.from(this._notifications);
|
|
},
|
|
|
|
_lazyInit() {
|
|
if (!this._hasInitialized) {
|
|
Services.obs.addObserver(this, "xpcom-shutdown");
|
|
Services.obs.addObserver(this, "appMenu-notifications-request");
|
|
}
|
|
},
|
|
|
|
uninit() {
|
|
Services.obs.removeObserver(this, "xpcom-shutdown");
|
|
Services.obs.removeObserver(this, "appMenu-notifications-request");
|
|
},
|
|
|
|
observe(subject, topic, status) {
|
|
switch (topic) {
|
|
case "xpcom-shutdown":
|
|
this.uninit();
|
|
break;
|
|
case "appMenu-notifications-request":
|
|
if (this._notifications.length != 0) {
|
|
Services.obs.notifyObservers(null, "appMenu-notifications", "init");
|
|
}
|
|
break;
|
|
}
|
|
},
|
|
|
|
get activeNotification() {
|
|
if (this._notifications.length > 0) {
|
|
const doorhanger =
|
|
this._notifications.find(n => !n.dismissed && !n.options.badgeOnly);
|
|
return doorhanger || this._notifications[0];
|
|
}
|
|
|
|
return null;
|
|
},
|
|
|
|
showNotification(id, mainAction, secondaryAction, options = {}) {
|
|
let notification = new AppMenuNotification(id, mainAction, secondaryAction, options);
|
|
let existingIndex = this._notifications.findIndex(n => n.id == id);
|
|
if (existingIndex != -1) {
|
|
this._notifications.splice(existingIndex, 1);
|
|
}
|
|
|
|
// We don't want to clobber doorhanger notifications just to show a badge,
|
|
// so don't dismiss any of them and the badge will show once the doorhanger
|
|
// gets resolved.
|
|
if (!options.badgeOnly && !options.dismissed) {
|
|
this._notifications.forEach(n => { n.dismissed = true; });
|
|
}
|
|
|
|
// Since notifications are generally somewhat pressing, the ideal case is that
|
|
// we never have two notifications at once. However, in the event that we do,
|
|
// it's more likely that the older notification has been sitting around for a
|
|
// bit, and so we don't want to hide the new notification behind it. Thus,
|
|
// we want our notifications to behave like a stack instead of a queue.
|
|
this._notifications.unshift(notification);
|
|
|
|
this._lazyInit();
|
|
this._updateNotifications();
|
|
return notification;
|
|
},
|
|
|
|
showBadgeOnlyNotification(id) {
|
|
return this.showNotification(id, null, null, { badgeOnly: true });
|
|
},
|
|
|
|
removeNotification(id) {
|
|
let notifications;
|
|
if (typeof id == "string") {
|
|
notifications = this._notifications.filter(n => n.id == id);
|
|
} else {
|
|
// If it's not a string, assume RegExp
|
|
notifications = this._notifications.filter(n => id.test(n.id));
|
|
}
|
|
// _updateNotifications can be expensive if it forces attachment of XBL
|
|
// bindings that haven't been used yet, so return early if we haven't found
|
|
// any notification to remove, as callers may expect this removeNotification
|
|
// method to be a no-op for non-existent notifications.
|
|
if (!notifications.length) {
|
|
return;
|
|
}
|
|
|
|
notifications.forEach(n => {
|
|
this._removeNotification(n);
|
|
});
|
|
this._updateNotifications();
|
|
},
|
|
|
|
dismissNotification(id) {
|
|
let notifications;
|
|
if (typeof id == "string") {
|
|
notifications = this._notifications.filter(n => n.id == id);
|
|
} else {
|
|
// If it's not a string, assume RegExp
|
|
notifications = this._notifications.filter(n => id.test(n.id));
|
|
}
|
|
|
|
notifications.forEach(n => {
|
|
n.dismissed = true;
|
|
if (n.options.onDismissed) {
|
|
n.options.onDismissed();
|
|
}
|
|
});
|
|
this._updateNotifications();
|
|
},
|
|
|
|
callMainAction(win, notification, fromDoorhanger) {
|
|
let action = notification.mainAction;
|
|
this._callAction(win, notification, action, fromDoorhanger);
|
|
},
|
|
|
|
callSecondaryAction(win, notification) {
|
|
let action = notification.secondaryAction;
|
|
this._callAction(win, notification, action, true);
|
|
},
|
|
|
|
_callAction(win, notification, action, fromDoorhanger) {
|
|
let dismiss = true;
|
|
if (action) {
|
|
try {
|
|
action.callback(win, fromDoorhanger);
|
|
} catch (error) {
|
|
Cu.reportError(error);
|
|
}
|
|
|
|
dismiss = action.dismiss;
|
|
}
|
|
|
|
if (dismiss) {
|
|
notification.dismissed = true;
|
|
} else {
|
|
this._removeNotification(notification);
|
|
}
|
|
|
|
this._updateNotifications();
|
|
},
|
|
|
|
_removeNotification(notification) {
|
|
// This notification may already be removed, in which case let's just ignore.
|
|
let notifications = this._notifications;
|
|
if (!notifications)
|
|
return;
|
|
|
|
var index = notifications.indexOf(notification);
|
|
if (index == -1)
|
|
return;
|
|
|
|
// Remove the notification
|
|
notifications.splice(index, 1);
|
|
},
|
|
|
|
_updateNotifications() {
|
|
Services.obs.notifyObservers(null, "appMenu-notifications", "update");
|
|
},
|
|
};
|