mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-09 21:00:42 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
51 lines
1.8 KiB
JavaScript
51 lines
1.8 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
"use strict";
|
|
var {GetBattery, Debugging} = ChromeUtils.import("resource://gre/modules/Battery.jsm", null);
|
|
ChromeUtils.import("resource://gre/modules/Services.jsm", this);
|
|
|
|
function test() {
|
|
waitForExplicitFinish();
|
|
|
|
is(Debugging.fake, false, "Battery spoofing is initially false");
|
|
|
|
GetBattery().then(function(battery) {
|
|
for (let k of ["charging", "chargingTime", "dischargingTime", "level"]) {
|
|
let backup = battery[k];
|
|
try {
|
|
battery[k] = "__magic__";
|
|
} catch (e) {
|
|
// We are testing that we cannot set battery to new values
|
|
// when "use strict" is enabled, this throws a TypeError
|
|
if (e.name != "TypeError")
|
|
throw e;
|
|
}
|
|
is(battery[k], backup, "Setting battery " + k + " preference without spoofing enabled should fail");
|
|
}
|
|
|
|
Debugging.fake = true;
|
|
|
|
// reload again to get the fake one
|
|
GetBattery().then(function(battery) {
|
|
battery.charging = true;
|
|
battery.chargingTime = 100;
|
|
battery.level = 0.5;
|
|
ok(battery.charging, "Test for charging setter");
|
|
is(battery.chargingTime, 100, "Test for chargingTime setter");
|
|
is(battery.level, 0.5, "Test for level setter");
|
|
|
|
battery.charging = false;
|
|
battery.dischargingTime = 50;
|
|
battery.level = 0.7;
|
|
ok(!battery.charging, "Test for charging setter");
|
|
is(battery.dischargingTime, 50, "Test for dischargingTime setter");
|
|
is(battery.level, 0.7, "Test for level setter");
|
|
|
|
// Resetting the value to make the test run successful
|
|
// for multiple runs in same browser session.
|
|
Debugging.fake = false;
|
|
finish();
|
|
});
|
|
});
|
|
}
|