mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-11-10 05:08:36 +02:00
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
49 lines
1.8 KiB
JavaScript
49 lines
1.8 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
const {BrowserUtils} = ChromeUtils.import("resource://gre/modules/BrowserUtils.jsm");
|
|
|
|
add_task(async function test_getSelectionDetails_input() {
|
|
// Mostly a regression test for bug 1420560
|
|
const url = kFixtureBaseURL + "file_getSelectionDetails_inputs.html";
|
|
await BrowserTestUtils.withNewTab({ gBrowser, url }, async browser => {
|
|
await ContentTask.spawn(browser, null, () => {
|
|
function checkSelection({ id, text, linkURL }) {
|
|
content.document.getElementById(id).select();
|
|
// It seems that when running as a test, the previous line will set
|
|
// the both the window's selection and the input's selection to contain
|
|
// the input's text. Outside of tests, only the input's selection seems
|
|
// to be updated, so we explicitly clear the window's selection to
|
|
// ensure we're doing the right thing in the case that only the input's
|
|
// selection is present.
|
|
content.getSelection().removeAllRanges();
|
|
let info = BrowserUtils.getSelectionDetails(content);
|
|
Assert.equal(text, info.text);
|
|
Assert.ok(!info.collapsed);
|
|
Assert.equal(linkURL, info.linkURL);
|
|
}
|
|
|
|
checkSelection({
|
|
id: "url-no-scheme",
|
|
text: "test.example.com",
|
|
linkURL: "http://test.example.com/",
|
|
});
|
|
checkSelection({
|
|
id: "url-with-scheme",
|
|
text: "https://test.example.com",
|
|
linkURL: "https://test.example.com/",
|
|
});
|
|
checkSelection({
|
|
id: "not-url",
|
|
text: "foo. bar",
|
|
linkURL: null,
|
|
});
|
|
checkSelection({
|
|
id: "not-url-number",
|
|
text: "3.5",
|
|
linkURL: null,
|
|
});
|
|
});
|
|
});
|
|
});
|